)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"58eaae34f98b78e86ad7baa597060101b815248f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mechanism driver requires an agent in the compute nodes. This change makes the"},{"line_number":11,"context_line":"SR-IOV mechanism driver to inherit from SimpleAgentMechanismDriverBase, like"},{"line_number":12,"context_line":"all the other agent based ML2 drivers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icffc097a42dd71546b97bb7b43edd1e205c9dd15"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_0ccc34ba","line":13,"updated":"2016-05-04 06:13:38.000000000","message":"while not mandatory, it\u0027s useful to have launchpad bug to trace this efort","commit_id":"2aa1d93940baa49332bb418332a0aa3518914937"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"844a0d8705654533b58b2f5ccbb8f0a101f34732","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mechanism driver requires an agent in the compute nodes. This change makes the"},{"line_number":11,"context_line":"SR-IOV mechanism driver to inherit from SimpleAgentMechanismDriverBase, like"},{"line_number":12,"context_line":"all the other agent based ML2 drivers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icffc097a42dd71546b97bb7b43edd1e205c9dd15"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_60303208","line":13,"in_reply_to":"1a122d0e_0ccc34ba","updated":"2016-05-04 15:57:01.000000000","message":"Done","commit_id":"2aa1d93940baa49332bb418332a0aa3518914937"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c27309270577aa9747396e631ecfdb25f1775183","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SR-IOV driver and SimpleAgentMechanismDriverBase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since commit 83c9578fcc5d06b634d48e0e186bebd60a60322e was merged, the SR-IOV"},{"line_number":10,"context_line":"mechanism driver requires an agent in the compute nodes. This change makes the"},{"line_number":11,"context_line":"SR-IOV mechanism driver to inherit from SimpleAgentMechanismDriverBase, like"},{"line_number":12,"context_line":"all the other agent based ML2 drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_43137665","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"updated":"2016-05-04 19:36:33.000000000","message":"nit:  I think the standard for line wrapping in commit messages is something like 70 characters.  That\u0027s what I used.","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"98f774d8af15bccf5aef48ab40dc3f6d405e0cbf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SR-IOV driver and SimpleAgentMechanismDriverBase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since commit 83c9578fcc5d06b634d48e0e186bebd60a60322e was merged, the SR-IOV"},{"line_number":10,"context_line":"mechanism driver requires an agent in the compute nodes. This change makes the"},{"line_number":11,"context_line":"SR-IOV mechanism driver to inherit from SimpleAgentMechanismDriverBase, like"},{"line_number":12,"context_line":"all the other agent based ML2 drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab17558_3d92f69e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"in_reply_to":"1a122d0e_43137665","updated":"2016-05-09 18:16:55.000000000","message":"Done","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"}],"neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"58eaae34f98b78e86ad7baa597060101b815248f","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def try_to_bind_segment_for_agent(self, context, segment, agent):"},{"line_number":141,"context_line":"        vnic_type \u003d context.current.get(portbindings.VNIC_TYPE,"},{"line_number":142,"context_line":"                                        portbindings.VNIC_NORMAL)"},{"line_number":143,"context_line":"        vif_type \u003d self.vnic_type_for_vif_type.get(vnic_type,"},{"line_number":144,"context_line":"                                                   VIF_TYPE_HW_VEB)"},{"line_number":145,"context_line":"        if self.check_segment_for_agent(segment, agent):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8cc20452","line":142,"range":{"start_line":142,"start_character":40,"end_line":142,"end_character":64},"updated":"2016-05-04 06:13:38.000000000","message":"vnic_normal is not supported by this ml2 driver, maybe worth to default to one of the supported, i.e. DIRECT?","commit_id":"2aa1d93940baa49332bb418332a0aa3518914937"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"844a0d8705654533b58b2f5ccbb8f0a101f34732","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def try_to_bind_segment_for_agent(self, context, segment, agent):"},{"line_number":141,"context_line":"        vnic_type \u003d context.current.get(portbindings.VNIC_TYPE,"},{"line_number":142,"context_line":"                                        portbindings.VNIC_NORMAL)"},{"line_number":143,"context_line":"        vif_type \u003d self.vnic_type_for_vif_type.get(vnic_type,"},{"line_number":144,"context_line":"                                                   VIF_TYPE_HW_VEB)"},{"line_number":145,"context_line":"        if self.check_segment_for_agent(segment, agent):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_60edd28d","line":142,"range":{"start_line":142,"start_character":40,"end_line":142,"end_character":64},"in_reply_to":"1a122d0e_8cc20452","updated":"2016-05-04 15:57:01.000000000","message":"Done","commit_id":"2aa1d93940baa49332bb418332a0aa3518914937"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c27309270577aa9747396e631ecfdb25f1775183","unresolved":false,"context_lines":[{"line_number":83,"context_line":"             for vtype in self.supported_vnic_types})"},{"line_number":84,"context_line":"        self.vif_details \u003d vif_details"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def get_allowed_network_types(self, agent\u003dNone):"},{"line_number":87,"context_line":"        return [p_const.TYPE_FLAT, p_const.TYPE_VLAN]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_mappings(self, agent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_e668d08a","line":86,"range":{"start_line":86,"start_character":45,"end_line":86,"end_character":50},"updated":"2016-05-04 19:36:33.000000000","message":"nit:  Don\u0027t need \"\u003dNone\" here.","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"98f774d8af15bccf5aef48ab40dc3f6d405e0cbf","unresolved":false,"context_lines":[{"line_number":83,"context_line":"             for vtype in self.supported_vnic_types})"},{"line_number":84,"context_line":"        self.vif_details \u003d vif_details"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def get_allowed_network_types(self, agent\u003dNone):"},{"line_number":87,"context_line":"        return [p_const.TYPE_FLAT, p_const.TYPE_VLAN]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_mappings(self, agent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_a25c03ee","line":86,"range":{"start_line":86,"start_character":45,"end_line":86,"end_character":50},"in_reply_to":"1a122d0e_e668d08a","updated":"2016-05-09 18:16:55.000000000","message":"Done","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2777af7a971b6cb84e88f27e558a7458b88abd22","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.vif_details \u003d vif_details"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def get_allowed_network_types(self, agent\u003dNone):"},{"line_number":87,"context_line":"        return [p_const.TYPE_FLAT, p_const.TYPE_VLAN]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_mappings(self, agent):"},{"line_number":90,"context_line":"        return agent[\u0027configurations\u0027].get(\u0027device_mappings\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_480aba22","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":53},"updated":"2016-05-08 15:07:46.000000000","message":"why return list and not tuple?","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"98f774d8af15bccf5aef48ab40dc3f6d405e0cbf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.vif_details \u003d vif_details"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def get_allowed_network_types(self, agent\u003dNone):"},{"line_number":87,"context_line":"        return [p_const.TYPE_FLAT, p_const.TYPE_VLAN]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_mappings(self, agent):"},{"line_number":90,"context_line":"        return agent[\u0027configurations\u0027].get(\u0027device_mappings\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_a22a432a","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":53},"in_reply_to":"dab17558_480aba22","updated":"2016-05-09 18:16:55.000000000","message":"Done","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c27309270577aa9747396e631ecfdb25f1775183","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # functions can use device mapping checks and the plugin can"},{"line_number":123,"context_line":"            # get port status updates."},{"line_number":124,"context_line":"            for segment in context.segments_to_bind:"},{"line_number":125,"context_line":"                if self.try_to_bind_segment_for_agent(context, segment, None):"},{"line_number":126,"context_line":"                    break"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c6895471","line":125,"range":{"start_line":125,"start_character":72,"end_line":125,"end_character":76},"updated":"2016-05-04 19:36:33.000000000","message":"nit:  If you need another spin, could you pass \"agent\u003dNone\" here just to give a little more context?","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"98f774d8af15bccf5aef48ab40dc3f6d405e0cbf","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # functions can use device mapping checks and the plugin can"},{"line_number":123,"context_line":"            # get port status updates."},{"line_number":124,"context_line":"            for segment in context.segments_to_bind:"},{"line_number":125,"context_line":"                if self.try_to_bind_segment_for_agent(context, segment, None):"},{"line_number":126,"context_line":"                    break"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_628cdb35","line":125,"range":{"start_line":125,"start_character":72,"end_line":125,"end_character":76},"in_reply_to":"1a122d0e_c6895471","updated":"2016-05-09 18:16:55.000000000","message":"Done","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c27309270577aa9747396e631ecfdb25f1775183","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                        portbindings.VNIC_DIRECT)"},{"line_number":143,"context_line":"        vif_type \u003d self.vnic_type_for_vif_type.get(vnic_type,"},{"line_number":144,"context_line":"                                                   VIF_TYPE_HW_VEB)"},{"line_number":145,"context_line":"        if self.check_segment_for_agent(segment, agent):"},{"line_number":146,"context_line":"            port_status \u003d (constants.PORT_STATUS_ACTIVE if agent is None"},{"line_number":147,"context_line":"                           else constants.PORT_STATUS_DOWN)"},{"line_number":148,"context_line":"            context.set_binding(segment[api.ID],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c62dd490","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":56},"updated":"2016-05-04 19:36:33.000000000","message":"nit:  You might consider:\n\n  if not self.check...:\n      return False\n\n  port_status \u003d ...","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"98f774d8af15bccf5aef48ab40dc3f6d405e0cbf","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                        portbindings.VNIC_DIRECT)"},{"line_number":143,"context_line":"        vif_type \u003d self.vnic_type_for_vif_type.get(vnic_type,"},{"line_number":144,"context_line":"                                                   VIF_TYPE_HW_VEB)"},{"line_number":145,"context_line":"        if self.check_segment_for_agent(segment, agent):"},{"line_number":146,"context_line":"            port_status \u003d (constants.PORT_STATUS_ACTIVE if agent is None"},{"line_number":147,"context_line":"                           else constants.PORT_STATUS_DOWN)"},{"line_number":148,"context_line":"            context.set_binding(segment[api.ID],"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_82b73fd7","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":56},"in_reply_to":"1a122d0e_c62dd490","updated":"2016-05-09 18:16:55.000000000","message":"Done","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2777af7a971b6cb84e88f27e558a7458b88abd22","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            return True"},{"line_number":154,"context_line":"        return False"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def filter_hosts_with_segment_access("},{"line_number":157,"context_line":"            self, context, segments, candidate_hosts, agent_getter):"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        hosts \u003d set()"},{"line_number":160,"context_line":"        filters \u003d {\u0027host\u0027: candidate_hosts, \u0027agent_type\u0027: [self.agent_type]}"},{"line_number":161,"context_line":"        for agent in agent_getter(context, filters\u003dfilters):"},{"line_number":162,"context_line":"            if any(self.check_segment_for_agent(s, agent) for s in segments):"},{"line_number":163,"context_line":"                hosts.add(agent[\u0027host\u0027])"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        return hosts"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def check_segment_for_agent(self, segment, agent\u003dNone):"},{"line_number":168,"context_line":"        \"\"\"Check if segment can be bound."}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_f5342bfc","line":165,"range":{"start_line":156,"start_character":0,"end_line":165,"end_character":20},"updated":"2016-05-08 15:07:46.000000000","message":"this can be removed because it is already implemented like this in SimpleAgentMechanismDriverBase see \nhttps://github.com/openstack/neutron/blob/42c6f05f2904cd4c01bcd3f79b1966489f5ad3c1/neutron/plugins/ml2/drivers/mech_agent.py#L169-L178","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"98f774d8af15bccf5aef48ab40dc3f6d405e0cbf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            return True"},{"line_number":154,"context_line":"        return False"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def filter_hosts_with_segment_access("},{"line_number":157,"context_line":"            self, context, segments, candidate_hosts, agent_getter):"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        hosts \u003d set()"},{"line_number":160,"context_line":"        filters \u003d {\u0027host\u0027: candidate_hosts, \u0027agent_type\u0027: [self.agent_type]}"},{"line_number":161,"context_line":"        for agent in agent_getter(context, filters\u003dfilters):"},{"line_number":162,"context_line":"            if any(self.check_segment_for_agent(s, agent) for s in segments):"},{"line_number":163,"context_line":"                hosts.add(agent[\u0027host\u0027])"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        return hosts"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def check_segment_for_agent(self, segment, agent\u003dNone):"},{"line_number":168,"context_line":"        \"\"\"Check if segment can be bound."}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_e2f44b88","line":165,"range":{"start_line":156,"start_character":0,"end_line":165,"end_character":20},"in_reply_to":"dab17558_f5342bfc","updated":"2016-05-09 18:16:55.000000000","message":"Done","commit_id":"395a4c6ad4adb14aeece008780d16477c0f4cf19"}]}
