)]}'
{"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8414b4cfe7df2342414b067936f63162fdb75561","unresolved":false,"context_lines":[{"line_number":34,"context_line":"FIP_RT_TBL \u003d 16"},{"line_number":35,"context_line":"# Rule priority range for FIPs"},{"line_number":36,"context_line":"FIP_PR_START \u003d 32768"},{"line_number":37,"context_line":"FIP_PR_END \u003d FIP_PR_START + 40000"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class FipNamespace(namespaces.Namespace):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_523984a3","line":37,"updated":"2016-07-29 17:10:09.000000000","message":"Not sure these are used anymore ?","commit_id":"15b0ed0eb22277a6fdc4b1cd719930e498dba124"}],"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e8c09c7a9832385f6dcc320ce6d11ef53043309f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # update internal structures"},{"line_number":107,"context_line":"        self.dist_fip_count \u003d self.dist_fip_count + 1"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _add_floating_ip_rule(self, floating_ip, fixed_ip):"},{"line_number":110,"context_line":"        rule_pr \u003d 32768  # use same priority for all rules"},{"line_number":111,"context_line":"        ip_rule \u003d ip_lib.IPRule(namespace\u003dself.ns_name)"},{"line_number":112,"context_line":"        ip_rule.rule.add(ip\u003dfixed_ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_8d6be1f0","line":109,"updated":"2016-07-29 17:56:59.000000000","message":"No longer using floating_ip in this method.","commit_id":"15b0ed0eb22277a6fdc4b1cd719930e498dba124"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8414b4cfe7df2342414b067936f63162fdb75561","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.dist_fip_count \u003d self.dist_fip_count + 1"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _add_floating_ip_rule(self, floating_ip, fixed_ip):"},{"line_number":110,"context_line":"        rule_pr \u003d 32768  # use same priority for all rules"},{"line_number":111,"context_line":"        ip_rule \u003d ip_lib.IPRule(namespace\u003dself.ns_name)"},{"line_number":112,"context_line":"        ip_rule.rule.add(ip\u003dfixed_ip,"},{"line_number":113,"context_line":"                         table\u003ddvr_fip_ns.FIP_RT_TBL,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d2745469","line":110,"updated":"2016-07-29 17:10:09.000000000","message":"nit: can you define this above like was done in dvr_fip_ns.py ?","commit_id":"15b0ed0eb22277a6fdc4b1cd719930e498dba124"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e8c09c7a9832385f6dcc320ce6d11ef53043309f","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _remove_floating_ip_rule(self, floating_ip):"},{"line_number":117,"context_line":"        ip_rule \u003d ip_lib.IPRule(namespace\u003dself.ns_name)"},{"line_number":118,"context_line":"        ip_rule.rule.delete(ip\u003dfloating_ip,"},{"line_number":119,"context_line":"                            table\u003ddvr_fip_ns.FIP_RT_TBL)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def floating_ip_removed_dist(self, fip_cidr):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4d65691c","line":118,"updated":"2016-07-29 17:56:59.000000000","message":"We actually need to used the fixed_ip here, but since the IPRule code wasn\u0027t ever passing it things worked because it was matching the priority.  Let me see if I can tweak this.","commit_id":"15b0ed0eb22277a6fdc4b1cd719930e498dba124"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"98dc757a996e26f7de382fbd49ac28ad77729178","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _remove_floating_ip_rule(self, floating_ip):"},{"line_number":117,"context_line":"        ip_rule \u003d ip_lib.IPRule(namespace\u003dself.ns_name)"},{"line_number":118,"context_line":"        ip_rule.rule.delete(ip\u003dfloating_ip,"},{"line_number":119,"context_line":"                            table\u003ddvr_fip_ns.FIP_RT_TBL)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def floating_ip_removed_dist(self, fip_cidr):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_bd887772","line":118,"in_reply_to":"bacf61ea_4d65691c","updated":"2016-07-30 23:47:03.000000000","message":"Yeah, it finally occurred to me why the allocation was necessary. It\u0027s because we need to be able to delete rules associated with a given floating IP that may have had it\u0027s fixed_ip disassociated. We have no map between old fixed_ips and floating IPs so we use the priority as a way to tag all fixed IPs associated with a particular floating IP.\n\nUnless we figure out a different way to know which fixed_ips don\u0027t belong, it would seem we need to keep this around...","commit_id":"15b0ed0eb22277a6fdc4b1cd719930e498dba124"}]}
