)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"015e950285f623087528d4eca7876e3f71aa1709","unresolved":false,"context_lines":[{"line_number":10,"context_line":"operations (create/update/delete). These are leveraged by the"},{"line_number":11,"context_line":"dependent patch for flavor and provider processing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: bp/multi-l3-backends"},{"line_number":14,"context_line":"Change-Id: I0479f0054f9c22f8021531c54b138179f9688de5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_c2cae7a0","line":13,"updated":"2016-05-13 23:33:31.000000000","message":"this doesn\u0027t seem to work","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"}],"neutron/callbacks/registry.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fe3c564d1a4e1bd0a91c79aadafe13eae008dfcd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    try:"},{"line_number":56,"context_line":"        yield"},{"line_number":57,"context_line":"    except manager.exceptions.CallbackFailure as e:"},{"line_number":58,"context_line":"        raise e.errors[0].error"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_4fddf2de","line":58,"updated":"2016-05-17 21:40:55.000000000","message":"talked with Kevin offline about this and returning the first exception like so may lead to nondeterministic responses in situations where there are multiple subscribers to the event triggered.","commit_id":"20e5d80849b9ef097f16c59c1e2683e6ac36ccc3"}],"neutron/db/l3_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"66f5700180d9251a4c3c62eee9169f49cf1041cb","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router_db \u003d Router(id\u003d(router.get(\u0027id\u0027) or"},{"line_number":210,"context_line":"                                   uuidutils.generate_uuid()),"},{"line_number":211,"context_line":"                               tenant_id\u003dtenant_id,"},{"line_number":212,"context_line":"                               name\u003drouter[\u0027name\u0027],"},{"line_number":213,"context_line":"                               admin_state_up\u003drouter[\u0027admin_state_up\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_2851090f","side":"PARENT","line":210,"updated":"2016-05-09 22:54:18.000000000","message":"11.95 microseconds for a call to generate a UUID. I think we should be okay: http://paste.openstack.org/show/496523/","commit_id":"0e53e8f913be34b152918a410c412385e9ec5cbe"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ecd62b6f84cba0002a5c62b2d3e0648fcfa1022f","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router_db \u003d Router(id\u003d(router.get(\u0027id\u0027) or"},{"line_number":210,"context_line":"                                   uuidutils.generate_uuid()),"},{"line_number":211,"context_line":"                               tenant_id\u003dtenant_id,"},{"line_number":212,"context_line":"                               name\u003drouter[\u0027name\u0027],"},{"line_number":213,"context_line":"                               admin_state_up\u003drouter[\u0027admin_state_up\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_189e9706","side":"PARENT","line":210,"updated":"2016-05-12 00:47:48.000000000","message":"Another plugin calling this could possibly provide it.","commit_id":"0e53e8f913be34b152918a410c412385e9ec5cbe"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b7f89813bb7e98c228ac4fa3783ea97924996670","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router_db \u003d Router(id\u003d(router.get(\u0027id\u0027) or"},{"line_number":210,"context_line":"                                   uuidutils.generate_uuid()),"},{"line_number":211,"context_line":"                               tenant_id\u003dtenant_id,"},{"line_number":212,"context_line":"                               name\u003drouter[\u0027name\u0027],"},{"line_number":213,"context_line":"                               admin_state_up\u003drouter[\u0027admin_state_up\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_63b07344","side":"PARENT","line":210,"updated":"2016-05-09 10:52:21.000000000","message":"i think the original coding is intended to avoid generate_uuid call unless necessary.\ni guess it doesn\u0027t matter much though.","commit_id":"0e53e8f913be34b152918a410c412385e9ec5cbe"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1e0e276156780e5292dc2f95de4edc6e65ef6199","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router_db \u003d Router(id\u003d(router.get(\u0027id\u0027) or"},{"line_number":210,"context_line":"                                   uuidutils.generate_uuid()),"},{"line_number":211,"context_line":"                               tenant_id\u003dtenant_id,"},{"line_number":212,"context_line":"                               name\u003drouter[\u0027name\u0027],"},{"line_number":213,"context_line":"                               admin_state_up\u003drouter[\u0027admin_state_up\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_42e8b710","side":"PARENT","line":210,"in_reply_to":"dab17558_189e9706","updated":"2016-05-13 23:32:44.000000000","message":"that\u0027s bonkers! :)","commit_id":"0e53e8f913be34b152918a410c412385e9ec5cbe"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4dd761d1d60458cc113ca7887c82684e6d47d2b7","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router_db \u003d Router(id\u003d(router.get(\u0027id\u0027) or"},{"line_number":210,"context_line":"                                   uuidutils.generate_uuid()),"},{"line_number":211,"context_line":"                               tenant_id\u003dtenant_id,"},{"line_number":212,"context_line":"                               name\u003drouter[\u0027name\u0027],"},{"line_number":213,"context_line":"                               admin_state_up\u003drouter[\u0027admin_state_up\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ea95f432","side":"PARENT","line":210,"in_reply_to":"dab17558_63b07344","updated":"2016-05-10 23:33:02.000000000","message":"I don\u0027t see how id will ever be pre populated when reaching this code, at least not anywhere I could see.","commit_id":"0e53e8f913be34b152918a410c412385e9ec5cbe"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"53edf70ab84b97ae4d4374352f8486e9e1d72da8","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router.setdefault(\u0027id\u0027, uuidutils.generate_uuid())"},{"line_number":210,"context_line":"            router[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":211,"context_line":"            router_db \u003d Router(id\u003drouter[\u0027id\u0027],"},{"line_number":212,"context_line":"                               tenant_id\u003drouter[\u0027tenant_id\u0027],"},{"line_number":213,"context_line":"                               name\u003drouter[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_548639b9","line":210,"updated":"2016-05-17 16:26:55.000000000","message":"Ah, I think we should probably do that in a separate patch since it would be a function signature change and I\u0027m worried about some out of tree l3 plugin that might be using it.","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"66f5700180d9251a4c3c62eee9169f49cf1041cb","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router.setdefault(\u0027id\u0027, uuidutils.generate_uuid())"},{"line_number":210,"context_line":"            router[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":211,"context_line":"            router_db \u003d Router(id\u003drouter[\u0027id\u0027],"},{"line_number":212,"context_line":"                               tenant_id\u003drouter[\u0027tenant_id\u0027],"},{"line_number":213,"context_line":"                               name\u003drouter[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_8858f533","line":210,"updated":"2016-05-09 22:54:18.000000000","message":"What do you mean by cleaning it up, making the caller put the tenant id in the router?","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b7f89813bb7e98c228ac4fa3783ea97924996670","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router.setdefault(\u0027id\u0027, uuidutils.generate_uuid())"},{"line_number":210,"context_line":"            router[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":211,"context_line":"            router_db \u003d Router(id\u003drouter[\u0027id\u0027],"},{"line_number":212,"context_line":"                               tenant_id\u003drouter[\u0027tenant_id\u0027],"},{"line_number":213,"context_line":"                               name\u003drouter[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_03e1a7fe","line":210,"updated":"2016-05-09 10:52:21.000000000","message":"i think you can clean up \"tenant_id\" argument of this method.\nit doesn\u0027t make much sense after _get_tenant_id_for_create has gone.","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fb527ffbcdd659a2fdcac602d6d9bf1a7af795e2","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # configuring external gw port"},{"line_number":208,"context_line":"            status \u003d router.get(\u0027status\u0027, n_const.ROUTER_STATUS_ACTIVE)"},{"line_number":209,"context_line":"            router.setdefault(\u0027id\u0027, uuidutils.generate_uuid())"},{"line_number":210,"context_line":"            router[\u0027tenant_id\u0027] \u003d tenant_id"},{"line_number":211,"context_line":"            router_db \u003d Router(id\u003drouter[\u0027id\u0027],"},{"line_number":212,"context_line":"                               tenant_id\u003drouter[\u0027tenant_id\u0027],"},{"line_number":213,"context_line":"                               name\u003drouter[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_3fc1dce4","line":210,"in_reply_to":"dab17558_8858f533","updated":"2016-05-17 13:13:27.000000000","message":"yes.  actually all callers seem to have it populated already.","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b7f89813bb7e98c228ac4fa3783ea97924996670","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            context.session.add(router_db)"},{"line_number":218,"context_line":"            registry.notify(resources.ROUTER, events.PRECOMMIT_CREATE, self,"},{"line_number":219,"context_line":"                            context\u003dcontext, router\u003drouter,"},{"line_number":220,"context_line":"                            router_db\u003drouter_db)"},{"line_number":221,"context_line":"            return router_db"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def create_router(self, context, router):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_63cb5354","line":220,"updated":"2016-05-09 10:52:21.000000000","message":"don\u0027t you want to catch CallbackFailure?","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"66f5700180d9251a4c3c62eee9169f49cf1041cb","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            context.session.add(router_db)"},{"line_number":218,"context_line":"            registry.notify(resources.ROUTER, events.PRECOMMIT_CREATE, self,"},{"line_number":219,"context_line":"                            context\u003dcontext, router\u003drouter,"},{"line_number":220,"context_line":"                            router_db\u003drouter_db)"},{"line_number":221,"context_line":"            return router_db"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def create_router(self, context, router):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_685b112f","line":220,"updated":"2016-05-09 22:54:18.000000000","message":"yes, i will need to do that.","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fa270b32dc22814e1c37e45da482a06d504f545d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            old_state \u003d self._make_router_dict(router_db)"},{"line_number":243,"context_line":"            if data:"},{"line_number":244,"context_line":"                router_db.update(data)"},{"line_number":245,"context_line":"            registry.notify(resources.ROUTER, events.PRECOMMIT_UPDATE, self,"},{"line_number":246,"context_line":"                            context\u003dcontext, router_id\u003drouter_id, router\u003ddata,"},{"line_number":247,"context_line":"                            router_db\u003drouter_db, old_state\u003dold_state)"},{"line_number":248,"context_line":"            return router_db"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9263fb19","line":245,"updated":"2016-05-05 11:03:31.000000000","message":"Do we want this notification sent even if no update is performed?","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"66f5700180d9251a4c3c62eee9169f49cf1041cb","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            old_state \u003d self._make_router_dict(router_db)"},{"line_number":243,"context_line":"            if data:"},{"line_number":244,"context_line":"                router_db.update(data)"},{"line_number":245,"context_line":"            registry.notify(resources.ROUTER, events.PRECOMMIT_UPDATE, self,"},{"line_number":246,"context_line":"                            context\u003dcontext, router_id\u003drouter_id, router\u003ddata,"},{"line_number":247,"context_line":"                            router_db\u003drouter_db, old_state\u003dold_state)"},{"line_number":248,"context_line":"            return router_db"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c842fd3d","line":245,"updated":"2016-05-09 22:54:18.000000000","message":"I think so, this method ends up getting called when the router is updated in other cases that don\u0027t update the model itself (e.g. adding a router interface).","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"66f5700180d9251a4c3c62eee9169f49cf1041cb","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                router_db.update(data)"},{"line_number":245,"context_line":"            registry.notify(resources.ROUTER, events.PRECOMMIT_UPDATE, self,"},{"line_number":246,"context_line":"                            context\u003dcontext, router_id\u003drouter_id, router\u003ddata,"},{"line_number":247,"context_line":"                            router_db\u003drouter_db, old_state\u003dold_state)"},{"line_number":248,"context_line":"            return router_db"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def update_router(self, context, id, router):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a83df9bc","line":247,"updated":"2016-05-09 22:54:18.000000000","message":"Sure","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b7f89813bb7e98c228ac4fa3783ea97924996670","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                router_db.update(data)"},{"line_number":245,"context_line":"            registry.notify(resources.ROUTER, events.PRECOMMIT_UPDATE, self,"},{"line_number":246,"context_line":"                            context\u003dcontext, router_id\u003drouter_id, router\u003ddata,"},{"line_number":247,"context_line":"                            router_db\u003drouter_db, old_state\u003dold_state)"},{"line_number":248,"context_line":"            return router_db"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def update_router(self, context, id, router):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_961e7761","line":247,"range":{"start_line":247,"start_character":49,"end_line":247,"end_character":58},"updated":"2016-05-09 10:52:21.000000000","message":"how about calling it \"old_router\"?","commit_id":"5613a6c748dc1ccd6e4d08f3ebad17b1cfb208da"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"46c56106434ef3c47cd6235d31bc4a255542606f","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                               admin_state_up\u003drouter[\u0027admin_state_up\u0027],"},{"line_number":215,"context_line":"                               status\u003dstatus,"},{"line_number":216,"context_line":"                               description\u003drouter.get(\u0027description\u0027))"},{"line_number":217,"context_line":"            context.session.add(router_db)"},{"line_number":218,"context_line":"            with registry.raise_first_callback_exception():"},{"line_number":219,"context_line":"                registry.notify(resources.ROUTER, events.PRECOMMIT_CREATE,"},{"line_number":220,"context_line":"                                self, context\u003dcontext, router\u003drouter,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_f7b64687","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":42},"updated":"2016-05-17 19:58:58.000000000","message":"Newbie question: I assume since we notify after add(), that the actual commit does not happen until we exit the with transaction block?","commit_id":"20e5d80849b9ef097f16c59c1e2683e6ac36ccc3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"be8ea80bb1123bfdfad2bc224189d0361db274b2","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                               admin_state_up\u003drouter[\u0027admin_state_up\u0027],"},{"line_number":215,"context_line":"                               status\u003dstatus,"},{"line_number":216,"context_line":"                               description\u003drouter.get(\u0027description\u0027))"},{"line_number":217,"context_line":"            context.session.add(router_db)"},{"line_number":218,"context_line":"            with registry.raise_first_callback_exception():"},{"line_number":219,"context_line":"                registry.notify(resources.ROUTER, events.PRECOMMIT_CREATE,"},{"line_number":220,"context_line":"                                self, context\u003dcontext, router\u003drouter,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_45d0331f","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":42},"in_reply_to":"dab17558_f7b64687","updated":"2016-05-17 22:33:53.000000000","message":"yep.","commit_id":"20e5d80849b9ef097f16c59c1e2683e6ac36ccc3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"46c56106434ef3c47cd6235d31bc4a255542606f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            context.session.add(router_db)"},{"line_number":218,"context_line":"            with registry.raise_first_callback_exception():"},{"line_number":219,"context_line":"                registry.notify(resources.ROUTER, events.PRECOMMIT_CREATE,"},{"line_number":220,"context_line":"                                self, context\u003dcontext, router\u003drouter,"},{"line_number":221,"context_line":"                                router_db\u003drouter_db)"},{"line_number":222,"context_line":"            return router_db"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_77f5364f","line":220,"range":{"start_line":220,"start_character":54,"end_line":220,"end_character":55},"updated":"2016-05-17 19:58:58.000000000","message":"Should we pass the router_id here as well? That would make the notification args more consistent.","commit_id":"20e5d80849b9ef097f16c59c1e2683e6ac36ccc3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"be8ea80bb1123bfdfad2bc224189d0361db274b2","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            context.session.add(router_db)"},{"line_number":218,"context_line":"            with registry.raise_first_callback_exception():"},{"line_number":219,"context_line":"                registry.notify(resources.ROUTER, events.PRECOMMIT_CREATE,"},{"line_number":220,"context_line":"                                self, context\u003dcontext, router\u003drouter,"},{"line_number":221,"context_line":"                                router_db\u003drouter_db)"},{"line_number":222,"context_line":"            return router_db"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_25cb6f73","line":220,"range":{"start_line":220,"start_character":54,"end_line":220,"end_character":55},"in_reply_to":"dab17558_77f5364f","updated":"2016-05-17 22:33:53.000000000","message":"sure","commit_id":"20e5d80849b9ef097f16c59c1e2683e6ac36ccc3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"46c56106434ef3c47cd6235d31bc4a255542606f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            old_router \u003d self._make_router_dict(router_db)"},{"line_number":244,"context_line":"            if data:"},{"line_number":245,"context_line":"                router_db.update(data)"},{"line_number":246,"context_line":"            with registry.raise_first_callback_exception():"},{"line_number":247,"context_line":"                registry.notify(resources.ROUTER, events.PRECOMMIT_UPDATE,"},{"line_number":248,"context_line":"                                self, context\u003dcontext, router_id\u003drouter_id,"},{"line_number":249,"context_line":"                                router\u003ddata, router_db\u003drouter_db,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_170aea78","line":246,"range":{"start_line":246,"start_character":12,"end_line":246,"end_character":59},"updated":"2016-05-17 19:58:58.000000000","message":"This appears to notify regardless of if an update was done or not. Does it make more sense to only notify on update (e.g. move into if data: clause)?","commit_id":"20e5d80849b9ef097f16c59c1e2683e6ac36ccc3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"be8ea80bb1123bfdfad2bc224189d0361db274b2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            old_router \u003d self._make_router_dict(router_db)"},{"line_number":244,"context_line":"            if data:"},{"line_number":245,"context_line":"                router_db.update(data)"},{"line_number":246,"context_line":"            with registry.raise_first_callback_exception():"},{"line_number":247,"context_line":"                registry.notify(resources.ROUTER, events.PRECOMMIT_UPDATE,"},{"line_number":248,"context_line":"                                self, context\u003dcontext, router_id\u003drouter_id,"},{"line_number":249,"context_line":"                                router\u003ddata, router_db\u003drouter_db,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c589c327","line":246,"range":{"start_line":246,"start_character":12,"end_line":246,"end_character":59},"in_reply_to":"dab17558_170aea78","updated":"2016-05-17 22:33:53.000000000","message":"_update_router_db gets called on other operations (e.g. interface changes IIRC). I think it\u0027s still worth emitting the notification in case a subscribe needs to act on those events (at least until we have separate notifications for them). A subscriber can always see what changed by comparing old_router and router_db.","commit_id":"20e5d80849b9ef097f16c59c1e2683e6ac36ccc3"}]}
