)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7a7281563fe0f26dcde25391eea15ae92af44c94","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The fix is to convert port id list to \u0027device\u0027 list."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] https://goo.gl/aII65t"},{"line_number":24,"context_line":"[2] https://goo.gl/ghhrit"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Idf9bd7942ef2063cfbc5e9eeead8d49d09883ea8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_8d29578c","line":23,"updated":"2016-08-16 09:26:57.000000000","message":"please don\u0027t include URL shorteners if these are links to locations in a file. It\u0027s better to have the full git.openstack.org link so people can tell where it goes without trying to visit it in their browser.","commit_id":"c264c2414cffb84b880d26e3f838af138a7eac45"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"15acdc74ae74cc5221dfa0a69f97077c6c047acf","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The fix is to convert port id list to \u0027device\u0027 list."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] https://goo.gl/aII65t"},{"line_number":24,"context_line":"[2] https://goo.gl/ghhrit"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Idf9bd7942ef2063cfbc5e9eeead8d49d09883ea8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_627ec5e5","line":23,"in_reply_to":"3ac371cc_8d29578c","updated":"2016-08-20 12:10:32.000000000","message":"Done","commit_id":"c264c2414cffb84b880d26e3f838af138a7eac45"}],"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"6ac60633c358f0adcade09cb95a345377b5e1072","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            else:"},{"line_number":214,"context_line":"                self.refresh_firewall(devices)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def security_groups_provider_updated(self, devices_to_update):"},{"line_number":217,"context_line":"        LOG.info(_LI(\"Provider rule updated\"))"},{"line_number":218,"context_line":"        if devices_to_update is None:"},{"line_number":219,"context_line":"            # Update all devices"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a4ea26aa","line":216,"updated":"2016-05-10 12:09:08.000000000","message":"if port_ids are passed in, can we rename this to deivce_ids_to_update or so? (like line 236)","commit_id":"34c091fea631e5ccb0c8f45937beb55367faa2ec"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0e66cada0d9d65da3971e166e5d4a5f851c0a779","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            else:"},{"line_number":214,"context_line":"                self.refresh_firewall(devices)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def security_groups_provider_updated(self, devices_to_update):"},{"line_number":217,"context_line":"        LOG.info(_LI(\"Provider rule updated\"))"},{"line_number":218,"context_line":"        if devices_to_update is None:"},{"line_number":219,"context_line":"            # Update all devices"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_33c0cb7c","line":216,"in_reply_to":"dab17558_a4ea26aa","updated":"2016-05-12 10:11:33.000000000","message":"Thanks for the suggestion. Will update to \"port_ids_to_update\". Actually, device_ids in line 236 is a collection of \"device\" attribute. The name here is annoying :(\n\n[1] https://github.com/openstack/neutron/blob/0e53e8f913be34b152918a410c412385e9ec5cbe/neutron/agent/linux/iptables_firewall.py#L149-L154","commit_id":"34c091fea631e5ccb0c8f45937beb55367faa2ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"6ac60633c358f0adcade09cb95a345377b5e1072","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                self.refresh_firewall()"},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            devices \u003d []"},{"line_number":226,"context_line":"            for device in self.firewall.ports.values():"},{"line_number":227,"context_line":"                # neutron server will give port id for updated, change it to"},{"line_number":228,"context_line":"                # device name in firewall, so that the L2 agent can consume it"},{"line_number":229,"context_line":"                if device[\u0027id\u0027] in devices_to_update:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e4942e44","line":226,"updated":"2016-05-10 12:09:08.000000000","message":"not sure how many devices this map contains - but we\u0027re iterating over all of them - can\u0027t we just pass in the a list of devices instead of a list of port_ids? So [1] would needs to be changed\n\n[1] https://goo.gl/aII65t","commit_id":"34c091fea631e5ccb0c8f45937beb55367faa2ec"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0e66cada0d9d65da3971e166e5d4a5f851c0a779","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                self.refresh_firewall()"},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            devices \u003d []"},{"line_number":226,"context_line":"            for device in self.firewall.ports.values():"},{"line_number":227,"context_line":"                # neutron server will give port id for updated, change it to"},{"line_number":228,"context_line":"                # device name in firewall, so that the L2 agent can consume it"},{"line_number":229,"context_line":"                if device[\u0027id\u0027] in devices_to_update:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f0e0f9fc","line":226,"in_reply_to":"dab17558_e4942e44","updated":"2016-05-12 10:11:33.000000000","message":"I think attribute \"device\" is an agent specified attribute. However, [1] runs in the server. So, it is not able to pass in a list of devices.","commit_id":"34c091fea631e5ccb0c8f45937beb55367faa2ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"bf189765d02d09d653c988a0ddf863274b32f3bb","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                self.refresh_firewall()"},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            devices \u003d []"},{"line_number":226,"context_line":"            for device in self.firewall.ports.values():"},{"line_number":227,"context_line":"                # neutron server will give port id for updated, change it to"},{"line_number":228,"context_line":"                # device name in firewall, so that the L2 agent can consume it"},{"line_number":229,"context_line":"                if device[\u0027id\u0027] in devices_to_update:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_0e2471ad","line":226,"in_reply_to":"dab17558_f0e0f9fc","updated":"2016-05-12 12:44:35.000000000","message":"yeah you\u0027re right. Today the server only knows the device when the agent passes this value via rpc. The server is able to transform this into a port-id, but not the way back...","commit_id":"34c091fea631e5ccb0c8f45937beb55367faa2ec"},{"author":{"_account_id":17589,"name":"Darla Ahlert","email":"da741q@att.com","username":"darla.ahlert"},"change_message_id":"1f712342ffd91e0f126ec2f6e8844b89d3ba9aca","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                self.refresh_firewall()"},{"line_number":215,"context_line":"        else:"},{"line_number":216,"context_line":"            devices \u003d []"},{"line_number":217,"context_line":"            for device in self.firewall.ports.values():"},{"line_number":218,"context_line":"                # neutron server will give port id for updated, change it to"},{"line_number":219,"context_line":"                # device name in firewall, so that the L2 agent can consume it"},{"line_number":220,"context_line":"                if device[\u0027id\u0027] in port_ids_to_update:"},{"line_number":221,"context_line":"                    devices.append(device[\u0027device\u0027])"},{"line_number":222,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":223,"context_line":"                self.devices_to_refilter |\u003d set(devices)"},{"line_number":224,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_fe9cf66b","line":221,"range":{"start_line":217,"start_character":0,"end_line":221,"end_character":52},"updated":"2016-09-01 21:39:02.000000000","message":"Would it be better to use filter() rather than a for loop here because of the unknown amount of ports?","commit_id":"a6d30686ca63e62db2049740c4265437c68161b7"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3b30c943f1beab4fb995f6d26dd29389b496784e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                self.refresh_firewall()"},{"line_number":215,"context_line":"        else:"},{"line_number":216,"context_line":"            devices \u003d []"},{"line_number":217,"context_line":"            for device in self.firewall.ports.values():"},{"line_number":218,"context_line":"                # neutron server will give port id for updated, change it to"},{"line_number":219,"context_line":"                # device name in firewall, so that the L2 agent can consume it"},{"line_number":220,"context_line":"                if device[\u0027id\u0027] in port_ids_to_update:"},{"line_number":221,"context_line":"                    devices.append(device[\u0027device\u0027])"},{"line_number":222,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":223,"context_line":"                self.devices_to_refilter |\u003d set(devices)"},{"line_number":224,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_6fb1e78e","line":221,"range":{"start_line":217,"start_character":0,"end_line":221,"end_character":52},"in_reply_to":"fa7ab95a_fe9cf66b","updated":"2016-09-22 02:06:19.000000000","message":"I would like use for or a list comprehension here, as the recent check_python3_no_filter seems not like filter...","commit_id":"a6d30686ca63e62db2049740c4265437c68161b7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"84261c649b6783440597e5ce32b5015c19783106","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def security_groups_provider_updated(self, port_ids_to_update):"},{"line_number":208,"context_line":"        LOG.info(_LI(\"Provider rule updated\"))"},{"line_number":209,"context_line":"        if port_ids_to_update is None:"},{"line_number":210,"context_line":"            # Update all devices"},{"line_number":211,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":212,"context_line":"                self.global_refresh_firewall \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_8246f478","line":209,"updated":"2016-11-03 06:41:25.000000000","message":"could this ever be []?","commit_id":"0c3417f983a0ea534dd4711ed5adf137c96eb677"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"376f5583a1b74b873a54e7b1b90c19336bcfd412","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        else:"},{"line_number":216,"context_line":"            devices \u003d []"},{"line_number":217,"context_line":"            for device in self.firewall.ports.values():"},{"line_number":218,"context_line":"                # neutron server will give port ids for update, However, L2"},{"line_number":219,"context_line":"                # agent will use device name in firewall. Here change port id"},{"line_number":220,"context_line":"                # to device name, so that the L2 agent can consume it"},{"line_number":221,"context_line":"                if device[\u0027id\u0027] in port_ids_to_update:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_028e64cf","line":218,"range":{"start_line":218,"start_character":64,"end_line":218,"end_character":71},"updated":"2016-11-03 06:40:18.000000000","message":"however","commit_id":"0c3417f983a0ea534dd4711ed5adf137c96eb677"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"376f5583a1b74b873a54e7b1b90c19336bcfd412","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                # agent will use device name in firewall. Here change port id"},{"line_number":220,"context_line":"                # to device name, so that the L2 agent can consume it"},{"line_number":221,"context_line":"                if device[\u0027id\u0027] in port_ids_to_update:"},{"line_number":222,"context_line":"                    devices.append(device[\u0027device\u0027])"},{"line_number":223,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":224,"context_line":"                self.devices_to_refilter |\u003d set(devices)"},{"line_number":225,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_2266082a","line":222,"updated":"2016-11-03 06:40:18.000000000","message":"can we write this as :\ndevices \u003d [device[\u0027id\u0027] in port_ids_to_update for device in self.firewall.ports.values()]","commit_id":"0c3417f983a0ea534dd4711ed5adf137c96eb677"}]}
