)]}'
{"neutron/services/externaldns/drivers/designate/driver.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d3fc80faf1f7c8098ff26b20b0eb23b1a9a1eebc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.auth.identity.generic import password"},{"line_number":21,"context_line":"from keystoneclient.auth import token_endpoint"},{"line_number":22,"context_line":"from keystoneclient import session"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_fe040d7f","line":23,"updated":"2016-05-08 09:47:54.000000000","message":"Suggest to rename the import as lib_constants to indicate we are importing from neutron_lib","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"dab281a3c6a5e29eba1203ba667ce4b0081c0576","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.auth.identity.generic import password"},{"line_number":21,"context_line":"from keystoneclient.auth import token_endpoint"},{"line_number":22,"context_line":"from keystoneclient import session"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_dd7d186e","line":23,"in_reply_to":"bab6814e_3a5588c1","updated":"2016-06-02 06:28:15.000000000","message":"I am fine with Henry\u0027s suggestion!","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"9b6dee22615a7609a390372bdeb70e462fdbba1d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.auth.identity.generic import password"},{"line_number":21,"context_line":"from keystoneclient.auth import token_endpoint"},{"line_number":22,"context_line":"from keystoneclient import session"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_9f1466e9","line":23,"in_reply_to":"bab6814e_59e72ce4","updated":"2016-05-26 19:52:07.000000000","message":"I think renaming the neutron_lib constants imports across the codebase is a out of scope of this change and will cause a lot of needless conflicts:\n```\n$ grep -rh \u0027neutron_lib import constants\u0027 neutron | sort | uniq -c | sort -n\n      1 from neutron_lib import constants as consts\n      1 from neutron_lib import constants as l3_const\n      1 from neutron_lib import constants as n_constants\n      2 from neutron_lib import constants as lib_constants\n      3 from neutron_lib import constants as lib_const\n      5 from neutron_lib import constants as n_consts\n     16 from neutron_lib import constants as l3_constants\n     18 from neutron_lib import constants as const\n     25 from neutron_lib import constants as n_const\n    132 from neutron_lib import constants\n```","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"65d0108a7f7e00bab443c1f72e7fa9b307424946","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.auth.identity.generic import password"},{"line_number":21,"context_line":"from keystoneclient.auth import token_endpoint"},{"line_number":22,"context_line":"from keystoneclient import session"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_3a5588c1","line":23,"in_reply_to":"bab6814e_9f1466e9","updated":"2016-05-26 20:18:02.000000000","message":"As Dustin pointed out, there is currently no consistency, and I don\u0027t this this patch is right place to fix that.\n\nI would suggest opening a wishlist bug to achieve consistency, where the desired naming can be discussed.","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"de1aa2f8fda820554dbdac6393581cfb98ce45e0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.auth.identity.generic import password"},{"line_number":21,"context_line":"from keystoneclient.auth import token_endpoint"},{"line_number":22,"context_line":"from keystoneclient import session"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_59e72ce4","line":23,"in_reply_to":"dab17558_019fbbb4","updated":"2016-05-25 03:35:17.000000000","message":"I agree with Vikram about renaming import, but do not agree about calling it as ``nlib``.\n\nIf you\u0027ll look at file, that you changed, you have explicit import[1] of constants module from neutron_lib. Please make consistent modification across the codebase and update imports.\n\n  from neutron_lib import constants as n_const\n\nhttps://github.com/openstack/neutron/blob/master/neutron/objects/common_types.py#L15","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f9a8f22c3656b43dfa15629070c5a0103986dabb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.auth.identity.generic import password"},{"line_number":21,"context_line":"from keystoneclient.auth import token_endpoint"},{"line_number":22,"context_line":"from keystoneclient import session"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_019fbbb4","line":23,"in_reply_to":"dab17558_64bd0b68","updated":"2016-05-10 04:40:10.000000000","message":"I would suggest prefixing \u0027nlib_\u0027 to the the alias name for any modules imported from neutron-lib. This is not at all uniform.. We use \u0027n_x\u0027 / \u0027lib_x\u0027 / \u0027x\u0027. This makes the code really difficult to understand as both neutron and neutron-lib has modules with same names..","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"0482751512415781b9457a307dc5ec353107b52c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient.auth.identity.generic import password"},{"line_number":21,"context_line":"from keystoneclient.auth import token_endpoint"},{"line_number":22,"context_line":"from keystoneclient import session"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_64bd0b68","line":23,"in_reply_to":"dab17558_fe040d7f","updated":"2016-05-09 17:08:25.000000000","message":"My understanding is that the preferred convention is:\n  constants \u003d\u003d neutron_lib.constants\n  n_const \u003d\u003d neutron.common.constants","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"}],"neutron/tests/tempest/api/test_network_ip_availability.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d3fc80faf1f7c8098ff26b20b0eb23b1a9a1eebc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":100,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":101,"context_line":"    if ip_version \u003d\u003d lib_constants.IP_VERSION_4:"},{"line_number":102,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv4_BITS"},{"line_number":103,"context_line":"                          - prefix) - DEFAULT_IP4_RESERVED"},{"line_number":104,"context_line":"    elif ip_version \u003d\u003d lib_constants.IP_VERSION_6:"},{"line_number":105,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv6_BITS"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5ef43986","line":102,"updated":"2016-05-08 09:47:54.000000000","message":"Can you please update the commit msg that you are replacing the numeric constants [32/128] as well?","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f9a8f22c3656b43dfa15629070c5a0103986dabb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":100,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":101,"context_line":"    if ip_version \u003d\u003d lib_constants.IP_VERSION_4:"},{"line_number":102,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv4_BITS"},{"line_number":103,"context_line":"                          - prefix) - DEFAULT_IP4_RESERVED"},{"line_number":104,"context_line":"    elif ip_version \u003d\u003d lib_constants.IP_VERSION_6:"},{"line_number":105,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv6_BITS"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a1698fc0","line":102,"in_reply_to":"dab17558_44672725","updated":"2016-05-10 04:40:10.000000000","message":"Ohh, I didn\u0027t noticed that.. Can we put (32/128) beside integer literals...","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"0482751512415781b9457a307dc5ec353107b52c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":100,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":101,"context_line":"    if ip_version \u003d\u003d lib_constants.IP_VERSION_4:"},{"line_number":102,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv4_BITS"},{"line_number":103,"context_line":"                          - prefix) - DEFAULT_IP4_RESERVED"},{"line_number":104,"context_line":"    elif ip_version \u003d\u003d lib_constants.IP_VERSION_6:"},{"line_number":105,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv6_BITS"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_44672725","line":102,"in_reply_to":"dab17558_5ef43986","updated":"2016-05-09 17:08:25.000000000","message":"Second sentence in first paragraph indicates replacing integer literals, how can I make this more clear?","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"65d0108a7f7e00bab443c1f72e7fa9b307424946","unresolved":false,"context_lines":[{"line_number":99,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":100,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":101,"context_line":"    if ip_version \u003d\u003d lib_constants.IP_VERSION_4:"},{"line_number":102,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv4_BITS"},{"line_number":103,"context_line":"                          - prefix) - DEFAULT_IP4_RESERVED"},{"line_number":104,"context_line":"    elif ip_version \u003d\u003d lib_constants.IP_VERSION_6:"},{"line_number":105,"context_line":"        total_ips \u003d 2 ** (lib_constants.IPv6_BITS"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_fad30036","line":102,"in_reply_to":"dab17558_a1698fc0","updated":"2016-05-26 20:18:02.000000000","message":"That seems like overkill, TBH.","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"}],"neutron/tests/tools.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d3fc80faf1f7c8098ff26b20b0eb23b1a9a1eebc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import fixtures"},{"line_number":26,"context_line":"import mock"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"from neutron_lib import constants"},{"line_number":29,"context_line":"import six"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import neutron"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_bef3a59d","line":28,"updated":"2016-05-08 09:47:54.000000000","message":"Let import it as lib_constants for better readability.","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"}],"neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d3fc80faf1f7c8098ff26b20b0eb23b1a9a1eebc","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron import context"},{"line_number":21,"context_line":"from neutron.db import dns_db"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_de2e69f9","line":18,"updated":"2016-05-08 09:47:54.000000000","message":"Suggest to rename the import as lib_constants to indicate we are importing from neutron_lib","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d3fc80faf1f7c8098ff26b20b0eb23b1a9a1eebc","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    def _get_bytes_or_nybles_to_skip(self, in_addr_name):"},{"line_number":220,"context_line":"        if \u0027in-addr.arpa\u0027 in in_addr_name:"},{"line_number":221,"context_line":"            return (("},{"line_number":222,"context_line":"                constants.IPv4_BITS -"},{"line_number":223,"context_line":"                config.cfg.CONF.designate.ipv4_ptr_zone_prefix_size) / 8)"},{"line_number":224,"context_line":"        return (constants.IPv6_BITS -"},{"line_number":225,"context_line":"                config.cfg.CONF.designate.ipv6_ptr_zone_prefix_size) / 4"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_fe2b6de9","line":222,"updated":"2016-05-08 09:47:54.000000000","message":"Can you please update the commit msg that you are replacing the numeric constants [32/128] as well?","commit_id":"faefe26cfb9830d3e3c83b1081e2c0a779b2e63c"}]}