)]}'
{"neutron/extensions/rbac.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f831d286315c1495682fb27c827aeca78e1edfdf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":64,"context_line":"                      \u0027enforce_policy\u0027: True},"},{"line_number":65,"context_line":"        \u0027target_tenant\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":66,"context_line":"                          \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":67,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":68,"context_line":"                      \u0027required_by_policy\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e92bbde9","line":66,"updated":"2016-05-07 13:33:52.000000000","message":"Do we really need to mandate this parameter? How about initializing the default to \u0027*\u0027 which implies all the tenants? Any thoughts?","commit_id":"544730fe1dd3a8c33419f673d83a008e2a93ffdf"},{"author":{"_account_id":20128,"name":"Han Chao","email":"hanchao7@lenovo.com","username":"HanChao"},"change_message_id":"97a0fdff3d0ddf0e293c742cb699ad2d8129ad6b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":64,"context_line":"                      \u0027enforce_policy\u0027: True},"},{"line_number":65,"context_line":"        \u0027target_tenant\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":66,"context_line":"                          \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":67,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":68,"context_line":"                      \u0027required_by_policy\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_57b1b7e0","line":66,"in_reply_to":"dab17558_7c914052","updated":"2016-05-09 03:51:04.000000000","message":"Once the network is created, the owner of it has been already the tenant itself. If a RBAC target_tenant by default indicates the same tenant, this operation is redundant. Therefore, I propose to add the target_tenant as a mandatory argument.\n\nAnd you are right. An update for the python-nuetronclient and neutron-specs should be updated relatively.","commit_id":"544730fe1dd3a8c33419f673d83a008e2a93ffdf"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"dae633f4845ae7d4573e5003350c172d4f8ea278","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":64,"context_line":"                      \u0027enforce_policy\u0027: True},"},{"line_number":65,"context_line":"        \u0027target_tenant\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":66,"context_line":"                          \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":67,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":68,"context_line":"                      \u0027required_by_policy\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_7c914052","line":66,"in_reply_to":"dab17558_a1d261fe","updated":"2016-05-09 02:30:15.000000000","message":"+1, I\u0027m agree with Han Chao on not to initialize the default to \u0027*\u0027. It\u0027s dangerous and I don\u0027t consider that behavior is RBAC intention.\n\nBeside removal, setting current tenant as target tenant could be an optional way, when target tenant is missing.\n\nBut if you choose current solution, I think you should also update python-neutronclient for prompt, and add a new exception for missing target-tenant if necessary. Since it has no more default value, we need tell user to add one, when it forgets that.","commit_id":"544730fe1dd3a8c33419f673d83a008e2a93ffdf"},{"author":{"_account_id":20128,"name":"Han Chao","email":"hanchao7@lenovo.com","username":"HanChao"},"change_message_id":"69a5f376871a77c5b192987309c8c32f7107da3a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":64,"context_line":"                      \u0027enforce_policy\u0027: True},"},{"line_number":65,"context_line":"        \u0027target_tenant\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":66,"context_line":"                          \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":67,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":68,"context_line":"                      \u0027required_by_policy\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a1d261fe","line":66,"in_reply_to":"dab17558_e92bbde9","updated":"2016-05-09 01:31:12.000000000","message":"From my perspective, the default would be the most common used cases. However, to share the network to all tenants is not that common compared to the case that share it within a group. Besides, if someone created a RBAC by forgetting to provide a target_tenant, but someone else has created resources based on the RBAC. This would be troublesome.","commit_id":"544730fe1dd3a8c33419f673d83a008e2a93ffdf"}]}
