)]}'
{"neutron/tests/base.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6e0be41417f4f962c69652cb8c90debc8972daf5","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        with eventlet.timeout.Timeout(max_execution_time, False):"},{"line_number":207,"context_line":"            yield"},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        self.fail(\u0027Execution of this test timed out\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def assertOrderedEqual(self, expected, actual):"},{"line_number":212,"context_line":"        expect_val \u003d self.sort_dict_lists(expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_f4a79fba","side":"PARENT","line":209,"range":{"start_line":209,"start_character":13,"end_line":209,"end_character":17},"updated":"2016-05-10 22:08:45.000000000","message":"This isn\u0027t unreachable.","commit_id":"065e5d66b650e336965b5ca425427c5d8e763d52"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"13c1dd96c0948ae1570463a4c981da1952a3396f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        with eventlet.timeout.Timeout(max_execution_time, False):"},{"line_number":207,"context_line":"            yield"},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        self.fail(\u0027Execution of this test timed out\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def assertOrderedEqual(self, expected, actual):"},{"line_number":212,"context_line":"        expect_val \u003d self.sort_dict_lists(expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_8966bfb8","side":"PARENT","line":209,"range":{"start_line":209,"start_character":13,"end_line":209,"end_character":17},"in_reply_to":"dab17558_bf11675f","updated":"2016-05-11 21:20:35.000000000","message":"I believe it is correct as written.  If there is a timeout, an exception will be raised which will cause the \"return\" statement to not be executed at all.  Execution will resume with L209 because it comes after the \"with\" statement.  See the equivalent try / except statement in the link I provided.","commit_id":"065e5d66b650e336965b5ca425427c5d8e763d52"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ab6f5217f0ec37bfbc1e7fe52f35eabce2b0b3a7","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        with eventlet.timeout.Timeout(max_execution_time, False):"},{"line_number":207,"context_line":"            yield"},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        self.fail(\u0027Execution of this test timed out\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def assertOrderedEqual(self, expected, actual):"},{"line_number":212,"context_line":"        expect_val \u003d self.sort_dict_lists(expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_bf11675f","side":"PARENT","line":209,"range":{"start_line":209,"start_character":13,"end_line":209,"end_character":17},"in_reply_to":"dab17558_d4c25b33","updated":"2016-05-11 05:51:30.000000000","message":"In that case also, we should remove \u0027return\u0027 statement instead of removing self.fail(\u0027Execution of this test timed out\u0027) .\n\nAs in presence of return statement, self.fail call will never execute.","commit_id":"065e5d66b650e336965b5ca425427c5d8e763d52"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c695fe1a4d4a48c132e93ec9101294c04ee9b2f1","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        with eventlet.timeout.Timeout(max_execution_time, False):"},{"line_number":207,"context_line":"            yield"},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        self.fail(\u0027Execution of this test timed out\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def assertOrderedEqual(self, expected, actual):"},{"line_number":212,"context_line":"        expect_val \u003d self.sort_dict_lists(expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_d4c25b33","side":"PARENT","line":209,"range":{"start_line":209,"start_character":13,"end_line":209,"end_character":17},"in_reply_to":"dab17558_f4a79fba","updated":"2016-05-10 22:11:41.000000000","message":"http://eventlet.net/doc/modules/timeout.html","commit_id":"065e5d66b650e336965b5ca425427c5d8e763d52"}]}
