)]}'
{"neutron/db/flooding_vteps_db.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b9fc8d496c2be12e30c199403e11e02135c73487","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    and VXLAN port number."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    __tablename__ \u003d \u0027provider_flooding_vtep\u0027"},{"line_number":29,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":30,"context_line":"                           sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":31,"context_line":"                           ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_04efdfb0","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":43},"updated":"2016-05-19 15:59:41.000000000","message":"The table name should match the class name to make browsing the code less confusing. Also, table names are typically plurals since a table holds multiple records. I would suggest naming the class to ProviderFloodingVTEP and not override the __tablename__ here. That will give you the default table name of \u0027providerfloodingvteps\u0027.","commit_id":"9bc7ca01dc3c992ccde41d09abe16e7207d1d94d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d0424bc0d42f03e4b8501eecb9f0f4e4c4c1e7a6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    and VXLAN port number."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    __tablename__ \u003d \u0027provider_flooding_vtep\u0027"},{"line_number":29,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":30,"context_line":"                           sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":31,"context_line":"                           ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_1d1f14b8","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":43},"in_reply_to":"bab6814e_04efdfb0","updated":"2016-05-20 05:12:30.000000000","message":"ok, thanks.","commit_id":"9bc7ca01dc3c992ccde41d09abe16e7207d1d94d"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/64fdb58c02b6_add_vtep_ip_to_segment.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e5c17293d6c0c23a83950634c25c2aeb6f50b396","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        sa.Column(\u0027dst_port\u0027, sa.Integer, nullable\u003dFalse,"},{"line_number":39,"context_line":"                  autoincrement\u003dFalse),"},{"line_number":40,"context_line":"        sa.ForeignKeyConstraint([\u0027segment_id\u0027],"},{"line_number":41,"context_line":"                                [\u0027networksegments.id\u0027],"},{"line_number":42,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":43,"context_line":"        sa.PrimaryKeyConstraint(\u0027remote_vtep_ip\u0027, \u0027segment_id\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_e375f4f9","line":41,"range":{"start_line":41,"start_character":34,"end_line":41,"end_character":49},"updated":"2016-06-14 16:45:23.000000000","message":"Because you are depending on a table that was renamed in the contract branch, you will need to put this migration in the contract branch too. You will need to provide a contract_creation_exceptions() hook, like https://review.openstack.org/285548","commit_id":"10fadf317c7bfc1cee0f1124ed4fa82716a564e0"},{"author":{"_account_id":17609,"name":"steve","email":"ruansx@cn.ibm.com","username":"steve.ruan"},"change_message_id":"920f370a03d508176dcc88745128c520466653da","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        sa.Column(\u0027dst_port\u0027, sa.Integer, nullable\u003dFalse,"},{"line_number":39,"context_line":"                  autoincrement\u003dFalse),"},{"line_number":40,"context_line":"        sa.ForeignKeyConstraint([\u0027segment_id\u0027],"},{"line_number":41,"context_line":"                                [\u0027networksegments.id\u0027],"},{"line_number":42,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":43,"context_line":"        sa.PrimaryKeyConstraint(\u0027remote_vtep_ip\u0027, \u0027segment_id\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_c476963d","line":41,"range":{"start_line":41,"start_character":34,"end_line":41,"end_character":49},"in_reply_to":"7aa08908_e375f4f9","updated":"2016-08-03 13:24:11.000000000","message":"Thanks. Will fix it.","commit_id":"10fadf317c7bfc1cee0f1124ed4fa82716a564e0"}],"neutron/db/segments_db.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b9fc8d496c2be12e30c199403e11e02135c73487","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class SegmentFloodingVTEP(model_base.BASEV2):"},{"line_number":34,"context_line":"    \"\"\"Represent VXLAN network remote VTEP ip addresses"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":"    __tablename__ \u003d \u0027segment_flooding_vtep\u0027"},{"line_number":38,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":39,"context_line":"                        sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":40,"context_line":"                            ondelete\u003d\"CASCADE\"),"},{"line_number":41,"context_line":"                        nullable\u003dFalse,"},{"line_number":42,"context_line":"                        primary_key\u003dTrue)"},{"line_number":43,"context_line":"    remote_vtep_ip \u003d sa.Column(sa.String(64),"},{"line_number":44,"context_line":"                        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NetworkSegment(model_base.BASEV2, model_base.HasId):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_44c0c7e0","line":44,"range":{"start_line":33,"start_character":0,"end_line":44,"end_character":57},"updated":"2016-05-19 15:59:41.000000000","message":"Delete this, I believe.","commit_id":"9bc7ca01dc3c992ccde41d09abe16e7207d1d94d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d0424bc0d42f03e4b8501eecb9f0f4e4c4c1e7a6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class SegmentFloodingVTEP(model_base.BASEV2):"},{"line_number":34,"context_line":"    \"\"\"Represent VXLAN network remote VTEP ip addresses"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":"    __tablename__ \u003d \u0027segment_flooding_vtep\u0027"},{"line_number":38,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":39,"context_line":"                        sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":40,"context_line":"                            ondelete\u003d\"CASCADE\"),"},{"line_number":41,"context_line":"                        nullable\u003dFalse,"},{"line_number":42,"context_line":"                        primary_key\u003dTrue)"},{"line_number":43,"context_line":"    remote_vtep_ip \u003d sa.Column(sa.String(64),"},{"line_number":44,"context_line":"                        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NetworkSegment(model_base.BASEV2, model_base.HasId):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_fd721010","line":44,"range":{"start_line":33,"start_character":0,"end_line":44,"end_character":57},"in_reply_to":"bab6814e_44c0c7e0","updated":"2016-05-20 05:12:30.000000000","message":"yes, you are right, thanks.","commit_id":"9bc7ca01dc3c992ccde41d09abe16e7207d1d94d"}],"neutron/extensions/multiprovidernet.py":[{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"422fadf9c0273eaa7e5e7cca5dfe73cea3eb7925","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    if is_partial_func is not None:"},{"line_number":73,"context_line":"        segments \u003d [s for s in segments if not is_partial_func(s)]"},{"line_number":74,"context_line":"    fully_specifieds \u003d [tuple(sorted(s.items())) for s in segments]"},{"line_number":75,"context_line":"    if len(set(fully_specifieds)) !\u003d len(fully_specifieds):"},{"line_number":76,"context_line":"        raise SegmentsContainDuplicateEntry()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"validators.add_validator(\u0027convert_segments\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa6399be_84a72a0a","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":59},"updated":"2016-10-20 09:28:22.000000000","message":"If multiple segments are specified when creating network, this function will be called, then set(fully_specifieds) will raise exception since \"flooding_vtep\" field in \"fully_specifieds\", which is a list, is not hashable.","commit_id":"2d9cabe20829d76adf8271154c3640a1765a42de"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"422fadf9c0273eaa7e5e7cca5dfe73cea3eb7925","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        flooding_vteps \u003d self._get_attribute(segment, vteps.FLOODING_VTEP)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if validators.is_attr_set(network_type):"},{"line_number":100,"context_line":"            if validators.is_attr_set(flooding_vteps):"},{"line_number":101,"context_line":"                # If set flooding_vteps, the network type must be VXLAN"},{"line_number":102,"context_line":"                if (network_type !\u003d p_const.TYPE_VXLAN):"},{"line_number":103,"context_line":"                    msg \u003d _(\"%s is only supported for VXLAN network \""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa6399be_e473864c","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":53},"updated":"2016-10-20 09:28:22.000000000","message":"Do we need to restrict that if multiple segments are specified, only one vxlan segment contains flooding vteps? Otherwise if later we plan to support update of flooding vteps, it\u0027s hard for users to specify which segment they would like to change.","commit_id":"2d9cabe20829d76adf8271154c3640a1765a42de"}]}
