)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ebba1d80b8674fd7b4328c35fd71a5ff650d32e1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This is correct when deleting a v6 router centralized snat port, because"},{"line_number":13,"context_line":"multiple v6 subnets share one router port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"But it is not correct when deleteing a v4 router centralized snat port,"},{"line_number":16,"context_line":"because v4 subnet doesn\u0027t share router port with v6 subnet. Deleteing a"},{"line_number":17,"context_line":"v4 router centralized snat port should be allowed no matter if there is"},{"line_number":18,"context_line":"v6 subnet attached to DVR."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_d2ef1585","line":15,"range":{"start_line":15,"start_character":27,"end_line":15,"end_character":36},"updated":"2016-05-20 17:26:16.000000000","message":"nit: deleting","commit_id":"084173338e5e21ff37f042f69718237b94843665"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ebba1d80b8674fd7b4328c35fd71a5ff650d32e1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"multiple v6 subnets share one router port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"But it is not correct when deleteing a v4 router centralized snat port,"},{"line_number":16,"context_line":"because v4 subnet doesn\u0027t share router port with v6 subnet. Deleteing a"},{"line_number":17,"context_line":"v4 router centralized snat port should be allowed no matter if there is"},{"line_number":18,"context_line":"v6 subnet attached to DVR."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_5204c548","line":16,"range":{"start_line":16,"start_character":60,"end_line":16,"end_character":69},"updated":"2016-05-20 17:26:16.000000000","message":"nit: Deleting","commit_id":"084173338e5e21ff37f042f69718237b94843665"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ad01842c070e2fe74c61ce4c055050bd6319d97d","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            p \u003d port[\u0027port\u0027]"},{"line_number":336,"context_line":"            if (p[\u0027network_id\u0027] \u003d\u003d net_id and"},{"line_number":337,"context_line":"                p[\u0027device_owner\u0027] \u003d\u003d device_owner and"},{"line_number":338,"context_line":"                self._port_has_ipv6_address(p, csnat_port_check\u003dFalse)):"},{"line_number":339,"context_line":"                return port"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def _check_for_multiprefix_csnat_port_and_update("}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_8412af07","line":338,"range":{"start_line":338,"start_character":16,"end_line":338,"end_character":44},"updated":"2016-05-13 22:18:17.000000000","message":"This returns the port with ipv6 addresses ignoring all the other ports!  That was a surprise to me having read the name of the method.  This code is making my head spin.  I wish I could just refactor the whole thing.","commit_id":"54a2e48c108a6161f26d94426490df3223e5b90a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ad01842c070e2fe74c61ce4c055050bd6319d97d","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"            # If router has a gateway port, check if it has IPV6 subnet"},{"line_number":359,"context_line":"            cs_port \u003d ("},{"line_number":360,"context_line":"                self._find_router_port_by_network_and_device_owner("},{"line_number":361,"context_line":"                    router, network_id, const.DEVICE_OWNER_ROUTER_SNAT))"},{"line_number":362,"context_line":"            if cs_port:"},{"line_number":363,"context_line":"                fixed_ips \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e4c45b93","line":360,"range":{"start_line":360,"start_character":21,"end_line":360,"end_character":66},"updated":"2016-05-13 22:18:17.000000000","message":"This call here makes it seems like there is only one ROUTER_SNAT port per network/router.  But, look at L338, it returns the port with ipv6 address on it!  Shouldn\u0027t it be looking for the port that has a fixed_ip on the given subnet_id?\n\nThis makes me think that the code you added on L352 is just a band-aid.  I tend to think that this call here is just plain wrong.  Shouldn\u0027t we fix this by looking getting the csnat port here that matches the subnet we passed in?","commit_id":"54a2e48c108a6161f26d94426490df3223e5b90a"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e228e29364b2b48d462cc95021353979e1ebc37c","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"            # If router has a gateway port, check if it has IPV6 subnet"},{"line_number":359,"context_line":"            cs_port \u003d ("},{"line_number":360,"context_line":"                self._find_router_port_by_network_and_device_owner("},{"line_number":361,"context_line":"                    router, network_id, const.DEVICE_OWNER_ROUTER_SNAT))"},{"line_number":362,"context_line":"            if cs_port:"},{"line_number":363,"context_line":"                fixed_ips \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_3f82e052","line":360,"range":{"start_line":360,"start_character":21,"end_line":360,"end_character":66},"in_reply_to":"dab17558_e4c45b93","updated":"2016-05-15 04:06:52.000000000","message":"Thanks. This make sense to me. I will rename the method and apply the fix in next patch.","commit_id":"54a2e48c108a6161f26d94426490df3223e5b90a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5189175555497a1c36487d0e6fcfc45f7c599aa6","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                # Add new prefix to an existing ipv6 csnat port with the"},{"line_number":291,"context_line":"                # same network id if one exists"},{"line_number":292,"context_line":"                cs_port \u003d ("},{"line_number":293,"context_line":"                    self._find_v6_router_port_by_network_and_device_owner("},{"line_number":294,"context_line":"                        router, subnet[\u0027network_id\u0027],"},{"line_number":295,"context_line":"                        const.DEVICE_OWNER_ROUTER_SNAT))"},{"line_number":296,"context_line":"                if cs_port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_79ce4db5","line":293,"range":{"start_line":293,"start_character":25,"end_line":293,"end_character":73},"updated":"2016-05-19 17:24:47.000000000","message":"Do we really need to rename this in this patch.","commit_id":"040337150a24a85c06faa5355eeab276c8686061"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"fecf295835f93268082e2faa33d88bcceae12799","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                # Add new prefix to an existing ipv6 csnat port with the"},{"line_number":291,"context_line":"                # same network id if one exists"},{"line_number":292,"context_line":"                cs_port \u003d ("},{"line_number":293,"context_line":"                    self._find_v6_router_port_by_network_and_device_owner("},{"line_number":294,"context_line":"                        router, subnet[\u0027network_id\u0027],"},{"line_number":295,"context_line":"                        const.DEVICE_OWNER_ROUTER_SNAT))"},{"line_number":296,"context_line":"                if cs_port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f47cf0b6","line":293,"range":{"start_line":293,"start_character":25,"end_line":293,"end_character":73},"in_reply_to":"bab6814e_79ce4db5","updated":"2016-05-20 01:23:03.000000000","message":"Yeah, split rename to another patch might be easy for potential cherry-pick, will do that in the following PS.","commit_id":"040337150a24a85c06faa5355eeab276c8686061"}]}
