)]}'
{"neutron/pecan_wsgi/controllers/utils.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"fa57735c51aaa1f952230969ef3b2b90a02d07b6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        if not isinstance(subresource_controller, cls):"},{"line_number":63,"context_line":"            raise TypeError(\"%s is not a valid resource controller\" %"},{"line_number":64,"context_line":"                            str(subresource_controller))"},{"line_number":65,"context_line":"        setattr(self, subresource_controller.resource,"},{"line_number":66,"context_line":"                subresource_controller)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_336186a9","line":64,"updated":"2016-05-14 04:45:13.000000000","message":"you should use .format just to anger kevin :)","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"}],"neutron/pecan_wsgi/startup.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"181e7e4f8c45bad9f437c956d5278bdb547125d6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    for ext_res in resources:"},{"line_number":54,"context_line":"        resource_controller \u003d ext_res.controller"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # some legacy controller does not have controller attribute"},{"line_number":57,"context_line":"        if hasattr(resource_controller, \"controller\"):"},{"line_number":58,"context_line":"            legacy_controller \u003d ext_res.controller.controller"},{"line_number":59,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_3377c6a0","line":56,"updated":"2016-05-14 04:42:16.000000000","message":"do you have an example of one of these?","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"3b2d8fd2462acece45c403013e6b020ca18e638f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    for ext_res in resources:"},{"line_number":54,"context_line":"        resource_controller \u003d ext_res.controller"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # some legacy controller does not have controller attribute"},{"line_number":57,"context_line":"        if hasattr(resource_controller, \"controller\"):"},{"line_number":58,"context_line":"            legacy_controller \u003d ext_res.controller.controller"},{"line_number":59,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c386e863","line":56,"in_reply_to":"dab17558_3377c6a0","updated":"2016-05-17 18:19:00.000000000","message":"This is when I try to run neutron with quark plugin:\n\n2016-05-17 14:15:46.710 29059 ERROR neutron     resource_controller \u003d ext_res.controller.controller\n2016-05-17 14:15:46.710 29059 ERROR neutron AttributeError: \u0027MacAddressRangesController\u0027 object has no attribute \u0027controller\u0027\n\nLooks like MacAddressRangesController is an example","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0db6a8293d392ac02fdc08e0f6f78fe5818414f0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    for ext_res in resources:"},{"line_number":54,"context_line":"        resource_controller \u003d ext_res.controller"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # some legacy controller does not have controller attribute"},{"line_number":57,"context_line":"        if hasattr(resource_controller, \"controller\"):"},{"line_number":58,"context_line":"            legacy_controller \u003d ext_res.controller.controller"},{"line_number":59,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_8c988d76","line":56,"in_reply_to":"dab17558_c386e863","updated":"2016-05-17 19:19:00.000000000","message":"hmm that particular controller is an instance of wsgi.Controller, I may need to look at that again see if its doing what I expect.","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"181e7e4f8c45bad9f437c956d5278bdb547125d6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            legacy_controller \u003d resource_controller"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        resource_parent \u003d getattr(ext_res, \"parent\", None)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        new_controller \u003d None"},{"line_number":65,"context_line":"        if isinstance(legacy_controller, base.Controller):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f35d3e16","line":62,"updated":"2016-05-14 04:42:16.000000000","message":"you should be guaranteed the a ResourceExtension has a parent, so just doing ext_res.parent should be enough.  If an extension is not returning a list of ResourceExtensions then its wrong.","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"3b2d8fd2462acece45c403013e6b020ca18e638f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            legacy_controller \u003d resource_controller"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        resource_parent \u003d getattr(ext_res, \"parent\", None)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        new_controller \u003d None"},{"line_number":65,"context_line":"        if isinstance(legacy_controller, base.Controller):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_237a5477","line":62,"in_reply_to":"dab17558_f35d3e16","updated":"2016-05-17 18:19:00.000000000","message":"Done","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"181e7e4f8c45bad9f437c956d5278bdb547125d6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if resource_parent is not None:"},{"line_number":95,"context_line":"            # Question: How do we know whether if it is added to item"},{"line_number":96,"context_line":"            # controller or collection controller though ?"},{"line_number":97,"context_line":"            # Right now I assume it\u0027s collection_name"},{"line_number":98,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":99,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":100,"context_line":"            parent_controller.add_subresource(new_controller)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_937cb273","line":97,"updated":"2016-05-14 04:42:16.000000000","message":"i believe its a rule that if there is a parent set then it will be a collection.  there is another type in the legacy controllers called action_map that we will need to handle that would be similar to an ItemController though.  We can fix that in a follow up review though.","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"3b2d8fd2462acece45c403013e6b020ca18e638f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if resource_parent is not None:"},{"line_number":95,"context_line":"            # Question: How do we know whether if it is added to item"},{"line_number":96,"context_line":"            # controller or collection controller though ?"},{"line_number":97,"context_line":"            # Right now I assume it\u0027s collection_name"},{"line_number":98,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":99,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":100,"context_line":"            parent_controller.add_subresource(new_controller)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e3d16c58","line":97,"in_reply_to":"dab17558_937cb273","updated":"2016-05-17 18:19:00.000000000","message":"Done","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"181e7e4f8c45bad9f437c956d5278bdb547125d6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            # Question: How do we know whether if it is added to item"},{"line_number":96,"context_line":"            # controller or collection controller though ?"},{"line_number":97,"context_line":"            # Right now I assume it\u0027s collection_name"},{"line_number":98,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":99,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":100,"context_line":"            parent_controller.add_subresource(new_controller)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f38b7e66","line":98,"range":{"start_line":98,"start_character":55,"end_line":98,"end_character":56},"updated":"2016-05-14 04:42:16.000000000","message":"there\u0027s only two cases of a \\  being acceptable, this isn\u0027t one :) newline on a ( or [ opening.","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"3b2d8fd2462acece45c403013e6b020ca18e638f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            # Question: How do we know whether if it is added to item"},{"line_number":96,"context_line":"            # controller or collection controller though ?"},{"line_number":97,"context_line":"            # Right now I assume it\u0027s collection_name"},{"line_number":98,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":99,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":100,"context_line":"            parent_controller.add_subresource(new_controller)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_63c61c9b","line":98,"range":{"start_line":98,"start_character":55,"end_line":98,"end_character":56},"in_reply_to":"dab17558_f38b7e66","updated":"2016-05-17 18:19:00.000000000","message":"Done","commit_id":"6abd702421f4403b945b4dde1a4a385d40c1e1f8"}]}
