)]}'
{"etc/quantum/plugins/bigswitch/restproxy.ini":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Timeout in seconds before idle sql connections are reaped"},{"line_number":24,"context_line":"# sql_idle_timeout \u003d 3600"},{"line_number":25,"context_line":"# Maximum number of SQL connections to keep open in a QueuePool in SQLAlchemy"},{"line_number":26,"context_line":"# Example sqlalchemy_pool_size \u003d 5"},{"line_number":27,"context_line":"# Maximum number of overflow connections in a QueuePool in SQLAlchemy"},{"line_number":28,"context_line":"# Example sqlalchemy_max_overflow \u003d 10"},{"line_number":29,"context_line":"# Timeout of the open connections QueuePool in SQLAlchemy"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAPX%2F%2F8zg%3D","line":26,"updated":"2013-06-05 14:33:35.000000000","message":"Is initial \"Example\" really needed? I don\u0027t see it in other options","commit_id":"c8536983021ebfcbe8034c0a2ea24d1d4243b84f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Timeout in seconds before idle sql connections are reaped"},{"line_number":24,"context_line":"# sql_idle_timeout \u003d 3600"},{"line_number":25,"context_line":"# Maximum number of SQL connections to keep open in a QueuePool in SQLAlchemy"},{"line_number":26,"context_line":"# Example sqlalchemy_pool_size \u003d 5"},{"line_number":27,"context_line":"# Maximum number of overflow connections in a QueuePool in SQLAlchemy"},{"line_number":28,"context_line":"# Example sqlalchemy_max_overflow \u003d 10"},{"line_number":29,"context_line":"# Timeout of the open connections QueuePool in SQLAlchemy"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAPX%2F%2F70I%3D","line":26,"in_reply_to":"AAAAPX%2F%2F8zg%3D","updated":"2013-06-05 18:49:08.000000000","message":"In general we put the default values. In this case it is a little different. The QueuePool has its own default values. My take here was that these may change with SQLAlchemy versions and I did not want to have to change these accordingly.\nMaybe I should have stated that we use the default values.","commit_id":"c8536983021ebfcbe8034c0a2ea24d1d4243b84f"}],"etc/quantum/plugins/ml2/ml2_conf.ini":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"# (IntOpt) Maximum number of SQL connections to keep open in a"},{"line_number":44,"context_line":"# QueuePool in SQLAlchemy."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# Example: sqlalchemy_pool_size \u003d 10"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Timeout in seconds before idle sql connections are reaped"},{"line_number":49,"context_line":"# Example sql_idle_timeout \u003d 3600"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAPX%2F%2F8o0%3D","line":46,"updated":"2013-06-05 14:33:35.000000000","message":"should be deleted I believe","commit_id":"c8536983021ebfcbe8034c0a2ea24d1d4243b84f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"# (IntOpt) Maximum number of SQL connections to keep open in a"},{"line_number":44,"context_line":"# QueuePool in SQLAlchemy."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# Example: sqlalchemy_pool_size \u003d 10"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Timeout in seconds before idle sql connections are reaped"},{"line_number":49,"context_line":"# Example sql_idle_timeout \u003d 3600"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAPX%2F%2F70A%3D","line":46,"in_reply_to":"AAAAPX%2F%2F8o0%3D","updated":"2013-06-05 18:49:08.000000000","message":"Correct.","commit_id":"c8536983021ebfcbe8034c0a2ea24d1d4243b84f"}],"quantum/db/api.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"6d588509ddde723bbc6b34ea70bb44e000f30130","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if \u0027mysql\u0027 in connection_dict.drivername:"},{"line_number":132,"context_line":"            engine_args[\u0027listeners\u0027] \u003d [MySQLPingListener()]"},{"line_number":133,"context_line":"            engine_args[\u0027poolclass\u0027] \u003d NullPool"},{"line_number":134,"context_line":"            if (MySQLdb is not None and"},{"line_number":135,"context_line":"                cfg.CONF.DATABASE.sql_dbpool_enable):"},{"line_number":136,"context_line":"                pool_args \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F%2B90%3D","line":133,"updated":"2013-06-04 15:32:31.000000000","message":"Why are we disabling db connection pooling?","commit_id":"1685507b06ee7ef7165f1760683594a98c8ec607"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if \u0027mysql\u0027 in connection_dict.drivername:"},{"line_number":132,"context_line":"            engine_args[\u0027listeners\u0027] \u003d [MySQLPingListener()]"},{"line_number":133,"context_line":"            engine_args[\u0027poolclass\u0027] \u003d NullPool"},{"line_number":134,"context_line":"            if (MySQLdb is not None and"},{"line_number":135,"context_line":"                cfg.CONF.DATABASE.sql_dbpool_enable):"},{"line_number":136,"context_line":"                pool_args \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F%2B5o%3D","line":133,"in_reply_to":"AAAAPX%2F%2F%2B90%3D","updated":"2013-06-04 16:08:41.000000000","message":"This does not disable the connection pooling. It just ensures that connections are closed.\nThis is something that is used in the generic db code which we are waiting to integrate - https://review.openstack.org/#/c/27265/","commit_id":"1685507b06ee7ef7165f1760683594a98c8ec607"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if \u0027mysql\u0027 in connection_dict.drivername:"},{"line_number":149,"context_line":"            engine_args[\u0027listeners\u0027] \u003d [MySQLPingListener()]"},{"line_number":150,"context_line":"            engine_args[\u0027poolclass\u0027] \u003d NullPool"},{"line_number":151,"context_line":"            if (MySQLdb is not None and"},{"line_number":152,"context_line":"                cfg.CONF.DATABASE.sql_dbpool_enable):"},{"line_number":153,"context_line":"                pool_args \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2F6Po%3D","line":150,"updated":"2013-06-06 08:06:00.000000000","message":"I am a little confused. max_overflow, pool_size and pool_timeout above are parameters for QueuePool. NullPool does not support these parameter. If NullPool is specified here, parameters exposed by this patch seem to have no effect.","commit_id":"14d2cd0da84ef4c4d8b109c7fa452433b9764cef"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if \u0027mysql\u0027 in connection_dict.drivername:"},{"line_number":149,"context_line":"            engine_args[\u0027listeners\u0027] \u003d [MySQLPingListener()]"},{"line_number":150,"context_line":"            engine_args[\u0027poolclass\u0027] \u003d NullPool"},{"line_number":151,"context_line":"            if (MySQLdb is not None and"},{"line_number":152,"context_line":"                cfg.CONF.DATABASE.sql_dbpool_enable):"},{"line_number":153,"context_line":"                pool_args \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2F55c%3D","line":150,"in_reply_to":"AAAAPX%2F%2F6Po%3D","updated":"2013-06-06 11:11:21.000000000","message":"Sorry this is my bad and should have been removed.","commit_id":"14d2cd0da84ef4c4d8b109c7fa452433b9764cef"}]}
