)]}'
{"neutron/services/metering/drivers/iptables/iptables_driver.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ae084d30d9c5c816a2ef414fef9db56be6a58b85","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def __exit__(self, type, value, traceback):"},{"line_number":57,"context_line":"        transaction \u003d self.__transactions.get(self.im)"},{"line_number":58,"context_line":"        if transaction \u003d\u003d 1:"},{"line_number":59,"context_line":"            if self.im.namespace in ip_lib.IPWrapper.get_namespaces():"},{"line_number":60,"context_line":"                self.im.apply()"},{"line_number":61,"context_line":"            del self.__transactions[self.im]"},{"line_number":62,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_12be8164","line":59,"updated":"2016-05-17 17:24:00.000000000","message":"It seems to me, the IP Tables Manager should handle the missing namespace case in its own apply() logic. Otherwise future consumers must know about this \"behavior\" we are coding around here.","commit_id":"3d041737e33d58e882a687ed4894a6a459a4dd32"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ae084d30d9c5c816a2ef414fef9db56be6a58b85","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                                                            label_id,"},{"line_number":359,"context_line":"                                                            wrap\u003dFalse)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"                    if rm.ns_name in ip_lib.IPWrapper.get_namespaces():"},{"line_number":362,"context_line":"                        chain_acc \u003d rm.iptables_manager.get_traffic_counters("},{"line_number":363,"context_line":"                            chain, wrap\u003dFalse, zero\u003dTrue)"},{"line_number":364,"context_line":"                except RuntimeError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_6d3e0cb9","line":361,"updated":"2016-05-17 17:24:00.000000000","message":"So if the ns is missing, this is a valid condition and we just don\u0027t get the counters? How do we know the ns is missing for a \"good reason\"? Should we log something here?","commit_id":"3d041737e33d58e882a687ed4894a6a459a4dd32"}]}
