)]}'
{"neutron/extensions/segment.py":[{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b38adc545d322d6a6572255e797514557ed8ce31","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        notify(request.context, \u0027dhcp_agent.segment.add\u0027, segment_id, agent_id)"},{"line_number":115,"context_line":"        return result"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def delete(self, request, id, **kwargs):"},{"line_number":118,"context_line":"        policy.enforce(request.context,"},{"line_number":119,"context_line":"                       \"delete_%s\" % DHCP_SEGMENT,"},{"line_number":120,"context_line":"                       {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_967dbe70","line":117,"updated":"2016-05-19 17:09:11.000000000","message":"id is a python built-in func, should use segement_id","commit_id":"a404bc18237566a99a6a4106724a036888dbc699"}],"neutron/services/segments/db.py":[{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"6c9c6542139df6adfdb73c2b5c17aa31c84e3928","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def _core_plugin(self):"},{"line_number":46,"context_line":"        return manager.NeutronManager.get_plugin()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _make_segment_dict(self, segment_db, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6698eac0","line":45,"updated":"2016-05-17 18:44:53.000000000","message":"Just curious, why makes this a underscore property ?","commit_id":"a404bc18237566a99a6a4106724a036888dbc699"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"59eca67ab6d47c41cdfbdbead4bfee6090b12a1a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def _core_plugin(self):"},{"line_number":46,"context_line":"        return manager.NeutronManager.get_plugin()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _make_segment_dict(self, segment_db, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a94c63c8","line":45,"in_reply_to":"dab17558_6698eac0","updated":"2016-05-17 19:08:06.000000000","message":"I want it to be a private property so it shouldn\u0027t be used outside the instancing class","commit_id":"a404bc18237566a99a6a4106724a036888dbc699"}],"neutron/services/segments/exceptions.py":[{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"6c9c6542139df6adfdb73c2b5c17aa31c84e3928","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"the network_id of segment \u0027%(segment_id)s\u0027\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class InvalidDHCPAgent(agent.AgentNotFound):"},{"line_number":44,"context_line":"    message \u003d _(\"Agent %(id)s is not a valid DHCP Agent or has been disabled\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e6897a27","line":43,"updated":"2016-05-17 18:44:53.000000000","message":"Would a exception.NotFound be a better base class ?","commit_id":"a404bc18237566a99a6a4106724a036888dbc699"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"59eca67ab6d47c41cdfbdbead4bfee6090b12a1a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"the network_id of segment \u0027%(segment_id)s\u0027\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class InvalidDHCPAgent(agent.AgentNotFound):"},{"line_number":44,"context_line":"    message \u003d _(\"Agent %(id)s is not a valid DHCP Agent or has been disabled\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_4974d7cd","line":43,"in_reply_to":"dab17558_e6897a27","updated":"2016-05-17 19:08:06.000000000","message":"i\u0027m basically just using the same exceptions as the network scheduling one.  I\u0027d rather not deviate from that.  However, this exception could probably be imported from that if thats a concern.","commit_id":"a404bc18237566a99a6a4106724a036888dbc699"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"6c9c6542139df6adfdb73c2b5c17aa31c84e3928","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \" by the DHCP Agent %(agent_id)s.\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class SegmentNotHostedByDhcpAgent(exceptions.Conflict):"},{"line_number":53,"context_line":"    message \u003d _(\"The segment %(segment_id)s is not hosted\""},{"line_number":54,"context_line":"                \" by the DHCP agent %(agent_id)s.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e62dfa46","line":52,"updated":"2016-05-17 18:44:53.000000000","message":"Could it be better to use exception.NotFound  as base class ?","commit_id":"a404bc18237566a99a6a4106724a036888dbc699"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"59eca67ab6d47c41cdfbdbead4bfee6090b12a1a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \" by the DHCP Agent %(agent_id)s.\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class SegmentNotHostedByDhcpAgent(exceptions.Conflict):"},{"line_number":53,"context_line":"    message \u003d _(\"The segment %(segment_id)s is not hosted\""},{"line_number":54,"context_line":"                \" by the DHCP agent %(agent_id)s.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_89519f32","line":52,"in_reply_to":"dab17558_e62dfa46","updated":"2016-05-17 19:08:06.000000000","message":"Same as above, althought 404 might make more sense.  I think keeping consistency with the network scheduling is more important at this point.","commit_id":"a404bc18237566a99a6a4106724a036888dbc699"}]}