)]}'
{"neutron/tests/functional/db/test_migrations.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a3b2be5e090449e224e8218c7b06b64517adade8","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                    hasattr(clauseelement, \u0027element\u0027)):"},{"line_number":188,"context_line":"                return"},{"line_number":189,"context_line":"            # Skip tables that were created by mistake in contract branch"},{"line_number":190,"context_line":"            element \u003d clauseelement.element"},{"line_number":191,"context_line":"            element_name \u003d element.name"},{"line_number":192,"context_line":"            if isinstance(element, sqlalchemy.Index):"},{"line_number":193,"context_line":"                element_name \u003d element.table.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_e104a9c7","line":190,"updated":"2016-05-18 09:04:31.000000000","message":"What about making a separate method for this exceptions and call it in expand branch as well? Just in case that something will be messed up there as well.","commit_id":"739f6e9eca1633ff92137baa620e0fb551949fc1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"855eae67e5c4e46600ce7037e5dd30ed6e40fe7f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                    hasattr(clauseelement, \u0027element\u0027)):"},{"line_number":188,"context_line":"                return"},{"line_number":189,"context_line":"            # Skip tables that were created by mistake in contract branch"},{"line_number":190,"context_line":"            element \u003d clauseelement.element"},{"line_number":191,"context_line":"            element_name \u003d element.name"},{"line_number":192,"context_line":"            if isinstance(element, sqlalchemy.Index):"},{"line_number":193,"context_line":"                element_name \u003d element.table.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_df4e92c0","line":190,"in_reply_to":"bab6814e_e104a9c7","updated":"2016-05-18 12:02:41.000000000","message":"Yes, probably a good idea.","commit_id":"739f6e9eca1633ff92137baa620e0fb551949fc1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8f817de229f30850da64a27faf051c36f7f8871d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            script \u003d alembic_script.ScriptDirectory.from_config("},{"line_number":193,"context_line":"                self.alembic_config)"},{"line_number":194,"context_line":"            for m in list(script.walk_revisions(base\u003d\u0027base\u0027, head\u003d\u0027heads\u0027)):"},{"line_number":195,"context_line":"                branches \u003d m.branch_labels or [None]"},{"line_number":196,"context_line":"                if migration.CONTRACT_BRANCH in branches:"},{"line_number":197,"context_line":"                    method_name \u003d \u0027contract_creation_exceptions\u0027"},{"line_number":198,"context_line":"                    exceptions_dict \u003d creation_exceptions"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_cb267bcd","line":195,"range":{"start_line":195,"start_character":47,"end_line":195,"end_character":51},"updated":"2016-05-19 20:24:02.000000000","message":"I\u0027m curious, why None here?  I could just as well be an empty list or tuple, right?","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7bbdf556203ba3a0b871817faae8ee68cfe87ba2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            script \u003d alembic_script.ScriptDirectory.from_config("},{"line_number":193,"context_line":"                self.alembic_config)"},{"line_number":194,"context_line":"            for m in list(script.walk_revisions(base\u003d\u0027base\u0027, head\u003d\u0027heads\u0027)):"},{"line_number":195,"context_line":"                branches \u003d m.branch_labels or [None]"},{"line_number":196,"context_line":"                if migration.CONTRACT_BRANCH in branches:"},{"line_number":197,"context_line":"                    method_name \u003d \u0027contract_creation_exceptions\u0027"},{"line_number":198,"context_line":"                    exceptions_dict \u003d creation_exceptions"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_9ab4ad82","line":195,"range":{"start_line":195,"start_character":47,"end_line":195,"end_character":51},"in_reply_to":"bab6814e_cb267bcd","updated":"2016-05-20 02:19:17.000000000","message":"Brain fart? I have no idea why I did this.","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8f817de229f30850da64a27faf051c36f7f8871d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            for m in list(script.walk_revisions(base\u003d\u0027base\u0027, head\u003d\u0027heads\u0027)):"},{"line_number":195,"context_line":"                branches \u003d m.branch_labels or [None]"},{"line_number":196,"context_line":"                if migration.CONTRACT_BRANCH in branches:"},{"line_number":197,"context_line":"                    method_name \u003d \u0027contract_creation_exceptions\u0027"},{"line_number":198,"context_line":"                    exceptions_dict \u003d creation_exceptions"},{"line_number":199,"context_line":"                elif migration.EXPAND_BRANCH in branches:"},{"line_number":200,"context_line":"                    method_name \u003d \u0027expand_drop_exceptions\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_3dd14a58","line":197,"range":{"start_line":197,"start_character":20,"end_line":197,"end_character":31},"updated":"2016-05-19 20:24:02.000000000","message":"nit:  why not just set get_excepted_elements here?  I know, this is really getting nit-picky.","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7bbdf556203ba3a0b871817faae8ee68cfe87ba2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            for m in list(script.walk_revisions(base\u003d\u0027base\u0027, head\u003d\u0027heads\u0027)):"},{"line_number":195,"context_line":"                branches \u003d m.branch_labels or [None]"},{"line_number":196,"context_line":"                if migration.CONTRACT_BRANCH in branches:"},{"line_number":197,"context_line":"                    method_name \u003d \u0027contract_creation_exceptions\u0027"},{"line_number":198,"context_line":"                    exceptions_dict \u003d creation_exceptions"},{"line_number":199,"context_line":"                elif migration.EXPAND_BRANCH in branches:"},{"line_number":200,"context_line":"                    method_name \u003d \u0027expand_drop_exceptions\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_baaff128","line":197,"range":{"start_line":197,"start_character":20,"end_line":197,"end_character":31},"in_reply_to":"bab6814e_3dd14a58","updated":"2016-05-20 02:19:17.000000000","message":"I thought this made line 204 clearer.","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8f817de229f30850da64a27faf051c36f7f8871d","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                        return True"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        def check_expand_branch(conn, clauseelement, multiparams, params):"},{"line_number":227,"context_line":"            if not (isinstance(clauseelement,"},{"line_number":228,"context_line":"                               migration_help.DROP_OPERATIONS) and"},{"line_number":229,"context_line":"                    hasattr(clauseelement, \u0027element\u0027)):"},{"line_number":230,"context_line":"                return"},{"line_number":231,"context_line":"            # Skip drops that have been explicitly excepted"},{"line_number":232,"context_line":"            if is_excepted(clauseelement, drop_exceptions):"},{"line_number":233,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_ebe1bf9b","line":230,"range":{"start_line":227,"start_character":12,"end_line":230,"end_character":21},"updated":"2016-05-19 20:24:02.000000000","message":"You might consider working this in to \"is_excepted\" since it is essentially duplicated in the next method.  But, since it is only a small amount of duplication, it doesn\u0027t hit my threshold for \"must be refactored.\"","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7bbdf556203ba3a0b871817faae8ee68cfe87ba2","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                        return True"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        def check_expand_branch(conn, clauseelement, multiparams, params):"},{"line_number":227,"context_line":"            if not (isinstance(clauseelement,"},{"line_number":228,"context_line":"                               migration_help.DROP_OPERATIONS) and"},{"line_number":229,"context_line":"                    hasattr(clauseelement, \u0027element\u0027)):"},{"line_number":230,"context_line":"                return"},{"line_number":231,"context_line":"            # Skip drops that have been explicitly excepted"},{"line_number":232,"context_line":"            if is_excepted(clauseelement, drop_exceptions):"},{"line_number":233,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_7a70e9dc","line":230,"range":{"start_line":227,"start_character":12,"end_line":230,"end_character":21},"in_reply_to":"bab6814e_ebe1bf9b","updated":"2016-05-20 02:19:17.000000000","message":"I should have done that.","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8f817de229f30850da64a27faf051c36f7f8871d","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                    hasattr(clauseelement, \u0027element\u0027)):"},{"line_number":230,"context_line":"                return"},{"line_number":231,"context_line":"            # Skip drops that have been explicitly excepted"},{"line_number":232,"context_line":"            if is_excepted(clauseelement, drop_exceptions):"},{"line_number":233,"context_line":"                return"},{"line_number":234,"context_line":"            self.fail(\"Migration in expand branch contains drop command\")"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        def check_contract_branch(conn, clauseelement, multiparams, params):"},{"line_number":237,"context_line":"            if not (isinstance(clauseelement,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_4bbd6b67","line":234,"range":{"start_line":232,"start_character":12,"end_line":234,"end_character":73},"updated":"2016-05-19 20:24:02.000000000","message":"nit:  The following seems a little simpler.  Keep it simple!   :)\n\n  if not is_excepted(clauseelement, drop_exceptions):\n      self.fail(\"Migration in expand branch contains drop command\")","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7bbdf556203ba3a0b871817faae8ee68cfe87ba2","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                    hasattr(clauseelement, \u0027element\u0027)):"},{"line_number":230,"context_line":"                return"},{"line_number":231,"context_line":"            # Skip drops that have been explicitly excepted"},{"line_number":232,"context_line":"            if is_excepted(clauseelement, drop_exceptions):"},{"line_number":233,"context_line":"                return"},{"line_number":234,"context_line":"            self.fail(\"Migration in expand branch contains drop command\")"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        def check_contract_branch(conn, clauseelement, multiparams, params):"},{"line_number":237,"context_line":"            if not (isinstance(clauseelement,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_9a42ed66","line":234,"range":{"start_line":232,"start_character":12,"end_line":234,"end_character":73},"in_reply_to":"bab6814e_4bbd6b67","updated":"2016-05-20 02:19:17.000000000","message":"Ack. Perhaps I will post a follow-up patch to address these nits.","commit_id":"9b13eed46b27c7cfd8320659d23cc56f7a178a1d"}]}
