)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"0082c6bf59610546e952944426dd1f9a46e4f52f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch allows to get metainfo of a specific ServiceProfile"},{"line_number":12,"context_line":"by supplying the flavor id and the FQN of the driver."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The intension is to get the metainfo from a service provider code"},{"line_number":15,"context_line":"once the provider was choosen to serve the loadbalancer."},{"line_number":16,"context_line":"Service plugins will use this function when service provider"},{"line_number":17,"context_line":"requests the loadbalancer metainfo."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_c552bc12","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":13},"updated":"2016-05-26 12:12:24.000000000","message":"Interestingly, intension is a real word, but I think what you mean here is intention.","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"}],"neutron/db/flavors_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"09328af469ce4ee64c41b86f35bd0defc68ecef9","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    def get_service_profile_metainfo(self, context, flavor_id, driver):"},{"line_number":297,"context_line":"        \"\"\"Get service profile metainfo for flavor and provider driver .\"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        metainfo \u003d None"},{"line_number":300,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":301,"context_line":"            srv_prof \u003d context.session.query(FlavorServiceProfileBinding,"},{"line_number":302,"context_line":"                                             ServiceProfile).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_d162293d","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":23},"updated":"2016-06-02 04:31:57.000000000","message":"It seems this is unnecessary.","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"e86b14b4a343702889878a5d47906390b9c6e66c","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    def get_service_profile_metainfo(self, context, flavor_id, driver):"},{"line_number":297,"context_line":"        \"\"\"Get service profile metainfo for flavor and provider driver .\"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        metainfo \u003d None"},{"line_number":300,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":301,"context_line":"            srv_prof \u003d context.session.query(FlavorServiceProfileBinding,"},{"line_number":302,"context_line":"                                             ServiceProfile).\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_47d94983","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":23},"in_reply_to":"9abb7d3a_d162293d","updated":"2016-06-02 13:35:31.000000000","message":"Done","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"09328af469ce4ee64c41b86f35bd0defc68ecef9","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                filter(FlavorServiceProfileBinding.flavor_id \u003d\u003d flavor_id).\\"},{"line_number":305,"context_line":"                filter(ServiceProfile.driver \u003d\u003d driver).first()"},{"line_number":306,"context_line":"            if not srv_prof:"},{"line_number":307,"context_line":"                raise ext_flavors.ServiceProfileDriverNotFound("},{"line_number":308,"context_line":"                    driver\u003ddriver)"},{"line_number":309,"context_line":"            metainfo \u003d srv_prof[1].metainfo"},{"line_number":310,"context_line":"        return metainfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_b14fa590","line":308,"range":{"start_line":307,"start_character":22,"end_line":308,"end_character":34},"updated":"2016-06-02 04:31:57.000000000","message":"Are we sure it\u0027s ServiceProfileDriverNotFound? Is there other case. for instance, FlavorServiceProfileBindingNotFound?","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"e86b14b4a343702889878a5d47906390b9c6e66c","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                filter(FlavorServiceProfileBinding.flavor_id \u003d\u003d flavor_id).\\"},{"line_number":305,"context_line":"                filter(ServiceProfile.driver \u003d\u003d driver).first()"},{"line_number":306,"context_line":"            if not srv_prof:"},{"line_number":307,"context_line":"                raise ext_flavors.ServiceProfileDriverNotFound("},{"line_number":308,"context_line":"                    driver\u003ddriver)"},{"line_number":309,"context_line":"            metainfo \u003d srv_prof[1].metainfo"},{"line_number":310,"context_line":"        return metainfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_2711a55e","line":308,"range":{"start_line":307,"start_character":22,"end_line":308,"end_character":34},"in_reply_to":"9abb7d3a_b14fa590","updated":"2016-06-02 13:35:31.000000000","message":"Actually, there is no suitable exception for this.\nI choose this one because it has the driver parameter. The other one needs a service_profile id.\n\nHowever, if this exception will be thrown, it\u0027s because of a bug. If provider was chosen for a flavor - it implies the service profile and flavor are bound. So it\u0027s not expected to get that exception because of a wrong usage.","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"09328af469ce4ee64c41b86f35bd0defc68ecef9","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            if not srv_prof:"},{"line_number":307,"context_line":"                raise ext_flavors.ServiceProfileDriverNotFound("},{"line_number":308,"context_line":"                    driver\u003ddriver)"},{"line_number":309,"context_line":"            metainfo \u003d srv_prof[1].metainfo"},{"line_number":310,"context_line":"        return metainfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_f15bed83","line":309,"range":{"start_line":309,"start_character":12,"end_line":309,"end_character":43},"updated":"2016-06-02 04:31:57.000000000","message":"return srv_prof[1].metainfo","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"e86b14b4a343702889878a5d47906390b9c6e66c","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            if not srv_prof:"},{"line_number":307,"context_line":"                raise ext_flavors.ServiceProfileDriverNotFound("},{"line_number":308,"context_line":"                    driver\u003ddriver)"},{"line_number":309,"context_line":"            metainfo \u003d srv_prof[1].metainfo"},{"line_number":310,"context_line":"        return metainfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_67c3ad8b","line":309,"range":{"start_line":309,"start_character":12,"end_line":309,"end_character":43},"in_reply_to":"9abb7d3a_f15bed83","updated":"2016-06-02 13:35:31.000000000","message":"Done","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"09328af469ce4ee64c41b86f35bd0defc68ecef9","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                raise ext_flavors.ServiceProfileDriverNotFound("},{"line_number":308,"context_line":"                    driver\u003ddriver)"},{"line_number":309,"context_line":"            metainfo \u003d srv_prof[1].metainfo"},{"line_number":310,"context_line":"        return metainfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_d1c98927","line":310,"range":{"start_line":310,"start_character":8,"end_line":310,"end_character":23},"updated":"2016-06-02 04:31:57.000000000","message":"We can remove this return or using \"return None\". They are no difference but I like the latter.","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"e86b14b4a343702889878a5d47906390b9c6e66c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                raise ext_flavors.ServiceProfileDriverNotFound("},{"line_number":308,"context_line":"                    driver\u003ddriver)"},{"line_number":309,"context_line":"            metainfo \u003d srv_prof[1].metainfo"},{"line_number":310,"context_line":"        return metainfo"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_87e33133","line":310,"range":{"start_line":310,"start_character":8,"end_line":310,"end_character":23},"in_reply_to":"9abb7d3a_d1c98927","updated":"2016-06-02 13:35:31.000000000","message":"Done","commit_id":"9422aee3655001d9aed43931e81c180e613acb5a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"bb43eabd955d9441b8d6e7d649fc247ed29286a4","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                raise ext_flavors.ServiceProfileDriverNotFound("},{"line_number":307,"context_line":"                    driver\u003ddriver)"},{"line_number":308,"context_line":"            return srv_prof[1].metainfo"},{"line_number":309,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_16b488cf","line":309,"range":{"start_line":309,"start_character":8,"end_line":309,"end_character":19},"updated":"2016-06-02 14:15:08.000000000","message":"I\u0027m sorry. My suggestion was bad. This \"return\" is never called so we should remove it.","commit_id":"e0359e3ae54eaaaa8b219d9533b8fc8a5ac2e568"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1a70d82d895ecaf7c54ce91aece4f14ea5b5188d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        return [self._fields(res, fields)]"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    # TODO(evgenyf) This func should be deleted once flavor templating lands"},{"line_number":296,"context_line":"    def get_service_profile_metainfo(self, context, flavor_id, driver):"},{"line_number":297,"context_line":"        \"\"\"Get service profile metainfo for flavor and provider driver .\"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_17b65b8a","line":296,"updated":"2016-08-13 08:54:21.000000000","message":"how is it used? can you point to a code where it\u0027s needed?","commit_id":"bac48957ed24934db1df356ee0f4a89301a47716"}]}
