)]}'
{"neutron/tests/fullstack/resources/config.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6acf1f4367e8efe1c85c7562c9d27479ef8d4ddf","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            }"},{"line_number":159,"context_line":"        })"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        if env_desc.dvr:"},{"line_number":162,"context_line":"            self.config[\u0027agent\u0027][\u0027enable_distributed_routing\u0027] \u003d \u0027True\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if self.tunneling_enabled:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_a17be1bc","line":161,"updated":"2016-06-01 22:29:36.000000000","message":"Nit: This can be simplified to remove the conditional:\n\nself.config[\u0027agent\u0027][\u0027enable_distributed_routing\u0027] \u003d str(env_desc.dvr)","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"cdd6460ee03854d6655688ede9d1c9ab1895461a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            }"},{"line_number":159,"context_line":"        })"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        if env_desc.dvr:"},{"line_number":162,"context_line":"            self.config[\u0027agent\u0027][\u0027enable_distributed_routing\u0027] \u003d \u0027True\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if self.tunneling_enabled:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_ad2f01a0","line":161,"in_reply_to":"9abb7d3a_a17be1bc","updated":"2016-06-03 06:55:02.000000000","message":"done","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6acf1f4367e8efe1c85c7562c9d27479ef8d4ddf","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            \u0027verbose\u0027: \u0027True\u0027,"},{"line_number":266,"context_line":"            \u0027test_namespace_suffix\u0027: self._generate_namespace_suffix(),"},{"line_number":267,"context_line":"        })"},{"line_number":268,"context_line":"        if host_desc.dvr_agent_mode:"},{"line_number":269,"context_line":"            self.config[\u0027DEFAULT\u0027][\u0027agent_mode\u0027] \u003d host_desc.dvr_agent_mode"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def _prepare_config_with_ovs_agent(self, integration_bridge):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_e14fa98f","line":268,"updated":"2016-06-01 22:29:36.000000000","message":"Same comment as above.","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"cdd6460ee03854d6655688ede9d1c9ab1895461a","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            \u0027verbose\u0027: \u0027True\u0027,"},{"line_number":266,"context_line":"            \u0027test_namespace_suffix\u0027: self._generate_namespace_suffix(),"},{"line_number":267,"context_line":"        })"},{"line_number":268,"context_line":"        if host_desc.dvr_agent_mode:"},{"line_number":269,"context_line":"            self.config[\u0027DEFAULT\u0027][\u0027agent_mode\u0027] \u003d host_desc.dvr_agent_mode"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def _prepare_config_with_ovs_agent(self, integration_bridge):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_ed174952","line":268,"in_reply_to":"9abb7d3a_e14fa98f","updated":"2016-06-03 06:55:02.000000000","message":"done","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"}],"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6acf1f4367e8efe1c85c7562c9d27479ef8d4ddf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def __init__(self, l3_agent\u003dFalse, of_interface\u003d\u0027ovs-ofctl\u0027,"},{"line_number":58,"context_line":"                 ovsdb_interface\u003d\u0027vsctl\u0027,"},{"line_number":59,"context_line":"                 l2_agent_type\u003dconstants.AGENT_TYPE_OVS,"},{"line_number":60,"context_line":"                 dvr_agent_mode\u003dNone):"},{"line_number":61,"context_line":"        self.l2_agent_type \u003d l2_agent_type"},{"line_number":62,"context_line":"        self.l3_agent \u003d l3_agent"},{"line_number":63,"context_line":"        self.of_interface \u003d of_interface"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_c1570524","line":60,"updated":"2016-06-01 22:29:36.000000000","message":"You can default this to \u0027legacy\u0027 to slightly simplify other code bits.","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"cdd6460ee03854d6655688ede9d1c9ab1895461a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def __init__(self, l3_agent\u003dFalse, of_interface\u003d\u0027ovs-ofctl\u0027,"},{"line_number":58,"context_line":"                 ovsdb_interface\u003d\u0027vsctl\u0027,"},{"line_number":59,"context_line":"                 l2_agent_type\u003dconstants.AGENT_TYPE_OVS,"},{"line_number":60,"context_line":"                 dvr_agent_mode\u003dNone):"},{"line_number":61,"context_line":"        self.l2_agent_type \u003d l2_agent_type"},{"line_number":62,"context_line":"        self.l3_agent \u003d l3_agent"},{"line_number":63,"context_line":"        self.of_interface \u003d of_interface"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_8d2afd8e","line":60,"in_reply_to":"9abb7d3a_c1570524","updated":"2016-06-03 06:55:02.000000000","message":"done","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"}],"neutron/tests/fullstack/resources/machine.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6acf1f4367e8efe1c85c7562c9d27479ef8d4ddf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                network_id\u003dself.network_id,"},{"line_number":45,"context_line":"                tenant_id\u003dself.tenant_id,"},{"line_number":46,"context_line":"                hostname\u003dself.host.hostname,"},{"line_number":47,"context_line":"                device_owner\u003dDEVICE_OWNER_COMPUTE)"},{"line_number":48,"context_line":"        mac_address \u003d self.neutron_port[\u0027mac_address\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.port \u003d self.useFixture("}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_8517c843","line":47,"updated":"2016-06-01 22:29:36.000000000","message":"Can you explain why this is needed?","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"cdd6460ee03854d6655688ede9d1c9ab1895461a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                network_id\u003dself.network_id,"},{"line_number":45,"context_line":"                tenant_id\u003dself.tenant_id,"},{"line_number":46,"context_line":"                hostname\u003dself.host.hostname,"},{"line_number":47,"context_line":"                device_owner\u003dDEVICE_OWNER_COMPUTE)"},{"line_number":48,"context_line":"        mac_address \u003d self.neutron_port[\u0027mac_address\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.port \u003d self.useFixture("}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_f0255eae","line":47,"in_reply_to":"9abb7d3a_8517c843","updated":"2016-06-03 06:55:02.000000000","message":"DVR scheduler will schedule the router on agent only if the agent is hosting a port with prefix DEVICE_OWNER_COMPUTE_PREFIX.\n\nWithout this, though I am booting vm on agent, router namespace is not created on that agent.","commit_id":"e7d0532e14683553dcc254d989a388b5f377113c"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"e9e657c7763d9cc4592250f4d73613f83f8c7ee1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import constants"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import constants"},{"line_number":20,"context_line":"from neutron.common import utils"},{"line_number":21,"context_line":"from neutron.extensions import portbindings as pbs"},{"line_number":22,"context_line":"from neutron.tests.common import machine_fixtures"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_dc39f8f3","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":36},"updated":"2016-08-17 12:17:10.000000000","message":"this should be removed to make pep8 happy","commit_id":"002aea7f140bcf4047e19f0f10de226e098ea5b9"}],"neutron/tests/fullstack/test_l3_agent.py":[{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"12062a92a71129e5b46d59a282cb22bcd905679e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        vm2 \u003d self._create_net_subnet_and_vm("},{"line_number":82,"context_line":"            tenant_id, [\u002721.0.0.0/24\u0027, \u00272001:db8:bbbb::/64\u0027],"},{"line_number":83,"context_line":"            self.environment.hosts[1], router)"},{"line_number":84,"context_line":"        if dvr:"},{"line_number":85,"context_line":"            vm1.block_until_ping(vm2.ip, timeout\u003d180)"},{"line_number":86,"context_line":"            # Verify ping6 from vm2 to vm1 IPv6 Address"},{"line_number":87,"context_line":"            vm2.block_until_ping(vm1.ipv6, timeout\u003d180)"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            vm1.block_until_ping(vm2.ip)"},{"line_number":90,"context_line":"            # Verify ping6 from vm2 to vm1 IPv6 Address"},{"line_number":91,"context_line":"            vm2.block_until_ping(vm1.ipv6)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _test_snat_and_floatingip(self, dvr\u003dFalse):"},{"line_number":94,"context_line":"        # This function creates external network and boots an extrenal vm"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_bcf83b4b","line":91,"range":{"start_line":84,"start_character":8,"end_line":91,"end_character":42},"updated":"2016-10-17 21:31:19.000000000","message":"Did you consider introducing timeout variable and rewriting this as:\n\ntimeout \u003d 60 if dvr else 180\nvm1.block_until_ping(vm2.ip, timeout\u003dtimeout)\nvm2.block_until_ping(vm1.ip, timeout\u003dtimeout)\n\nThis will reduce code duplication a bit. What do you think?","commit_id":"e2ca6ce89babfe876166be591e9e0ca839f428c3"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"42f79510012d34d9649a35c52be73be27af4a947","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        vm2 \u003d self._create_net_subnet_and_vm("},{"line_number":82,"context_line":"            tenant_id, [\u002721.0.0.0/24\u0027, \u00272001:db8:bbbb::/64\u0027],"},{"line_number":83,"context_line":"            self.environment.hosts[1], router)"},{"line_number":84,"context_line":"        if dvr:"},{"line_number":85,"context_line":"            vm1.block_until_ping(vm2.ip, timeout\u003d180)"},{"line_number":86,"context_line":"            # Verify ping6 from vm2 to vm1 IPv6 Address"},{"line_number":87,"context_line":"            vm2.block_until_ping(vm1.ipv6, timeout\u003d180)"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            vm1.block_until_ping(vm2.ip)"},{"line_number":90,"context_line":"            # Verify ping6 from vm2 to vm1 IPv6 Address"},{"line_number":91,"context_line":"            vm2.block_until_ping(vm1.ipv6)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _test_snat_and_floatingip(self, dvr\u003dFalse):"},{"line_number":94,"context_line":"        # This function creates external network and boots an extrenal vm"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_3ccfbdb4","line":91,"range":{"start_line":84,"start_character":8,"end_line":91,"end_character":42},"in_reply_to":"fa6399be_bcf83b4b","updated":"2016-10-18 08:21:14.000000000","message":"sure","commit_id":"e2ca6ce89babfe876166be591e9e0ca839f428c3"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"12062a92a71129e5b46d59a282cb22bcd905679e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            self.environment.hosts[1], router)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # ping external vm to test snat"},{"line_number":113,"context_line":"        if dvr:"},{"line_number":114,"context_line":"            vm.block_until_ping(external_vm.ip, timeout\u003d180)"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            vm.block_until_ping(external_vm.ip)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        fip \u003d self.safe_client.create_floatingip("},{"line_number":119,"context_line":"            tenant_id, ext_net[\u0027id\u0027], vm.ip, vm.neutron_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_3ca34b51","line":116,"range":{"start_line":113,"start_character":8,"end_line":116,"end_character":47},"updated":"2016-10-17 21:31:19.000000000","message":"same thing here","commit_id":"e2ca6ce89babfe876166be591e9e0ca839f428c3"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"12062a92a71129e5b46d59a282cb22bcd905679e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            tenant_id, ext_net[\u0027id\u0027], vm.ip, vm.neutron_port[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # ping floating ip from external vm"},{"line_number":122,"context_line":"        if dvr:"},{"line_number":123,"context_line":"            external_vm.block_until_ping(fip[\u0027floating_ip_address\u0027],"},{"line_number":124,"context_line":"                                         timeout\u003d180)"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            external_vm.block_until_ping(fip[\u0027floating_ip_address\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class TestLegacyL3Agent(TestL3Agent):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_5c88ffc6","line":126,"range":{"start_line":122,"start_character":8,"end_line":126,"end_character":68},"updated":"2016-10-17 21:31:19.000000000","message":"and here","commit_id":"e2ca6ce89babfe876166be591e9e0ca839f428c3"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"16011ab0b2218e4e421d46da6ebce184619ed799","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def setUp(self):"},{"line_number":187,"context_line":"        host_descriptions \u003d ["},{"line_number":188,"context_line":"            environment.HostDescription(l3_agent\u003dTrue, dvr_agent_mode\u003d\u0027dvr\u0027),"},{"line_number":189,"context_line":"            environment.HostDescription("},{"line_number":190,"context_line":"                l3_agent\u003dTrue, dvr_agent_mode\u003d\u0027dvr_snat\u0027)]"},{"line_number":191,"context_line":"        env \u003d environment.Environment("},{"line_number":192,"context_line":"            environment.EnvironmentDescription("},{"line_number":193,"context_line":"                network_type\u003d\u0027vxlan\u0027, l2_pop\u003dTrue, dvr\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_a3901897","line":190,"range":{"start_line":188,"start_character":12,"end_line":190,"end_character":58},"updated":"2016-11-07 16:03:52.000000000","message":"just wondering why did you change the order \u003d)","commit_id":"e6bbf55b3daa70964631f52b5eb3f72222bbca36"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"f9e80e3f148c615f197aba56cae36c663b8e19d6","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def setUp(self):"},{"line_number":187,"context_line":"        host_descriptions \u003d ["},{"line_number":188,"context_line":"            environment.HostDescription(l3_agent\u003dTrue, dvr_agent_mode\u003d\u0027dvr\u0027),"},{"line_number":189,"context_line":"            environment.HostDescription("},{"line_number":190,"context_line":"                l3_agent\u003dTrue, dvr_agent_mode\u003d\u0027dvr_snat\u0027)]"},{"line_number":191,"context_line":"        env \u003d environment.Environment("},{"line_number":192,"context_line":"            environment.EnvironmentDescription("},{"line_number":193,"context_line":"                network_type\u003d\u0027vxlan\u0027, l2_pop\u003dTrue, dvr\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_06c29b33","line":190,"range":{"start_line":188,"start_character":12,"end_line":190,"end_character":58},"in_reply_to":"9a629dbe_a3901897","updated":"2016-11-08 06:00:06.000000000","message":"For debugging test failures.\n\nWith this sequence, compute node will have enough time to create router resources.\n1) first boot vm on compute node\n2) then vm on controller. Cmpute node can create router namespace and interfaces in parallel during this time.","commit_id":"e6bbf55b3daa70964631f52b5eb3f72222bbca36"}]}
