)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"30068ba80f82f5207f6e4b8cd5e99ff7cc237e7b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The __init__() routine of NeutronDbPluginV2 is missing the call to"},{"line_number":10,"context_line":"super(xxx, self).__init__() which is preventing other __init__()"},{"line_number":11,"context_line":"rotuines from being run.  This is causing an exception in networking-ovn"},{"line_number":12,"context_line":"when attempting to use QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I369e8399f213fc300e70c4cce7ca0ff5c9f1e078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_5173bce7","line":11,"updated":"2016-05-24 07:46:55.000000000","message":"typo: routines","commit_id":"6d477d0e99c43b1ae5d4baaee9fd5ecaafe9fff3"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"7210f383c56f1725858f43189eddec797392654c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The __init__() routine of NeutronDbPluginV2 is missing the call to"},{"line_number":10,"context_line":"super(xxx, self).__init__() which is preventing other __init__()"},{"line_number":11,"context_line":"rotuines from being run.  This is causing an exception in networking-ovn"},{"line_number":12,"context_line":"when attempting to use QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I369e8399f213fc300e70c4cce7ca0ff5c9f1e078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_d3d79feb","line":11,"in_reply_to":"bab6814e_5173bce7","updated":"2016-05-24 12:59:37.000000000","message":"Done","commit_id":"6d477d0e99c43b1ae5d4baaee9fd5ecaafe9fff3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e5df5838bc0aaa092914a0ffe54c204ddca079be","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The __init__() routine of NeutronDbPluginV2 is missing the call to"},{"line_number":10,"context_line":"super(xxx, self).__init__() which is preventing other __init__()"},{"line_number":11,"context_line":"rotuines from being run.  This is causing an exception in networking-ovn"},{"line_number":12,"context_line":"when attempting to use QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I369e8399f213fc300e70c4cce7ca0ff5c9f1e078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_1b902395","line":11,"in_reply_to":"bab6814e_5173bce7","updated":"2016-05-24 12:06:21.000000000","message":"Is this typo in the commit message really worth a -1? While I could understand a -1 for typo that mislead the reader, it seems a bit overkill in this case. Just my $0.02.","commit_id":"6d477d0e99c43b1ae5d4baaee9fd5ecaafe9fff3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c59cec4c99ccfaf80ac977e86c6a7c0f2b298e61","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The __init__() routine of NeutronDbPluginV2 is missing the call to"},{"line_number":10,"context_line":"super(xxx, self).__init__() which is preventing other __init__()"},{"line_number":11,"context_line":"routines from being run.  This is causing an exception in networking-ovn"},{"line_number":12,"context_line":"when attempting to use QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I369e8399f213fc300e70c4cce7ca0ff5c9f1e078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_c3fd82b2","line":11,"updated":"2016-05-26 17:13:56.000000000","message":"you said this applies to OVS and LB, so should the commit/bug report be adjusted to reflect this? Then we should definitely tap into test coverage","commit_id":"f51115e0cea4acf0792f57540841f0b9ebc71fd5"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f34f738717246f037388bf97383a7c1bc19d5cc6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    __native_sorting_support \u003d True"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def __init__(self):"},{"line_number":106,"context_line":"        super(NeutronDbPluginV2, self).__init__()"},{"line_number":107,"context_line":"        self.set_ipam_backend()"},{"line_number":108,"context_line":"        if cfg.CONF.notify_nova_on_port_status_changes:"},{"line_number":109,"context_line":"            # NOTE(arosen) These event listeners are here to hook into when"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_e817c5eb","line":106,"updated":"2016-05-26 17:01:41.000000000","message":"I am thinking that if the agent_db is the only mixin with an init method, we should probably backtrack and address the issue introduced by patch [1]. Then we should document this somewhere, maybe in the effective guide.\n\n[1] https://review.openstack.org/#/c/268040/","commit_id":"f51115e0cea4acf0792f57540841f0b9ebc71fd5"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"87c8eb07c2164c541db2648f40be0669ffe08658","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    __native_sorting_support \u003d True"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def __init__(self):"},{"line_number":106,"context_line":"        super(NeutronDbPluginV2, self).__init__()"},{"line_number":107,"context_line":"        self.set_ipam_backend()"},{"line_number":108,"context_line":"        if cfg.CONF.notify_nova_on_port_status_changes:"},{"line_number":109,"context_line":"            # NOTE(arosen) These event listeners are here to hook into when"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_c87061df","line":106,"in_reply_to":"bab6814e_e817c5eb","updated":"2016-05-30 11:43:55.000000000","message":"Ack, Ihar warned me about this, I\u0027m sending another patch to refactor this a bit, and remove __init__ from agent\u0027s db.\n\n[12:41]  \u003cihrachys\u003e the only problem I see is that current agent calculation callback is part of AgentMixin class, so we would need to have a plugin to call it on.\n[12:47]  \u003cihrachys\u003e ajo_: that said, we could assume it from core_plugin if they decide to use rpc callbacks mechanism (which they should probably not if they don\u0027t use agents)\n[12:48]  \u003cajo_\u003e ihrachys, or document how should they declare their rpc-consuming \"stuff\" versions,\n[12:48]  \u003cihrachys\u003e so then whenever we need to call the callback, we do get_core_plugin().\u003ccallback-name\u003e()\n[12:48]  \u003cajo_\u003e aha\n[12:48]  \u003cajo_\u003e that could be reasonable, if we cut the multiple sources thing\n[12:49]  \u003cajo_\u003e which, is a YAGNI now\n[12:49]  \u003cihrachys\u003e yes. and I don\u0027t think that latter thing is something we should really care right now. in the future, we may get back to it.\n[12:49]  \u003cajo_\u003e ok ihrachys, I\u0027ll remake it that way, and let\u0027s see how it looks\n[12:50]  \u003cihrachys\u003e ajo_: ok cool. @armax wanted to get to a quick resolution on that one.\n[12:50]  \u003cajo_\u003e ihrachys, ack\n[12:50]  \u003cihrachys\u003e ajo_: see the discussion around https://review.openstack.org/#/c/319444/","commit_id":"f51115e0cea4acf0792f57540841f0b9ebc71fd5"}]}
