)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"98e2e4b2e046a6c1a45a603b1fa20f1bde97c900","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add subresources support for PECAN"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements adding a subresource (of extensions) to its parents"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I43ce22ff0ab2ddcb2a1cc8965f423761f41d08c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3aaa91ec_0fc76946","line":9,"updated":"2016-06-21 16:27:46.000000000","message":"Commit message needs a bit more information.  What exactly is a subresource.  Generally, how does this patch fix the issue, etc.  Just so anyone looking through the history has an idea of exactly what happened in this patch.","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"b5ac1a976bae3d6dd747bbeac971f1d967bb4b83","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add subresources support for PECAN"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements adding a subresource (of extensions) to its parents"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I43ce22ff0ab2ddcb2a1cc8965f423761f41d08c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3aaa91ec_aaaec382","line":9,"in_reply_to":"3aaa91ec_0fc76946","updated":"2016-06-22 15:04:34.000000000","message":"Done","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"}],"neutron/extensions/qos.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a6489795799cc02d1b146547387b0d72d42da096","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                        proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027, \u0027\u0027)"},{"line_number":232,"context_line":"                    else:"},{"line_number":233,"context_line":"                        proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027,"},{"line_number":234,"context_line":"                                                      \u0027policy\u0027 + \u0027_\u0027)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"                    rule_obj \u003d self.rule_objects[rule_type]"},{"line_number":237,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_ef593d90","line":234,"updated":"2016-06-21 16:32:29.000000000","message":"i feel like none of the code in this module shouldn\u0027t have to change just to get pecan to work.  I don\u0027t know the extent of what this code does though, I\u0027d need to spend some time with it.  It just has me concerned.","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"acae81a23c20c8a17a08ff99f2cf9c79ad3a9956","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                        proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027, \u0027\u0027)"},{"line_number":232,"context_line":"                    else:"},{"line_number":233,"context_line":"                        proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027,"},{"line_number":234,"context_line":"                                                      \u0027policy\u0027 + \u0027_\u0027)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"                    rule_obj \u003d self.rule_objects[rule_type]"},{"line_number":237,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_d33cad31","line":234,"in_reply_to":"3aaa91ec_ef593d90","updated":"2016-06-22 14:29:03.000000000","message":"This is because routing mechanism like: \nhttps://github.com/openstack/neutron/blob/master/neutron/pecan_wsgi/controllers/resource.py#L114\nAnd\nhttps://github.com/openstack/neutron/blob/master/neutron/pecan_wsgi/controllers/resource.py#L140\nwill generate something like \"get_rules\" and \"create_rules\" proxy method, where existing method on rules extension are like: get_policy_rulels and create_policy_rules.  This will make it work with the old methods.\nRefer to: https://github.com/openstack/neutron/blob/master/neutron/extensions/qos.py#L313~L335\nFor the definition of resource methods.","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"}],"neutron/pecan_wsgi/controllers/resource.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"2da1210e6b593b0cdcf87060e03042b80b8386ff","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        creator_args \u003d [neutron_context, data]"},{"line_number":163,"context_line":"        if \u0027parent_id\u0027 in request.context:"},{"line_number":164,"context_line":"            creator_args.append(request.context[\u0027parent_id\u0027])"},{"line_number":165,"context_line":"        return {key: creator(*creator_args)}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_022e37fa","line":165,"updated":"2016-06-26 21:05:39.000000000","message":"the problem with this and other methods is that you now need to change all the other plugins that do subresources to also accept the parent_id (this includes lbaas, and possible fwaas and vpnaas).  who knows what other out of tree extensions there are that do subresources.","commit_id":"187bcbbc5283919e43fd2078417b3bab0763e06e"}],"neutron/pecan_wsgi/controllers/utils.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d0ec5d33b5b32fc2a398b8f4d68e78cb831ddef6","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def add_subresource(cls, subresource_controller):"},{"line_number":107,"context_line":"        \"\"\"Add a sub resource to the current extension"},{"line_number":108,"context_line":"        :param subresource_controller"},{"line_number":109,"context_line":"        :raises TypeError"},{"line_number":110,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_1c75e4c9","line":107,"updated":"2016-05-23 18:25:57.000000000","message":"i think there needs to be a blank line after the first line.","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"9f3c88397b6dc4d6b197130f25dd5340a090214b","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def add_subresource(cls, subresource_controller):"},{"line_number":107,"context_line":"        \"\"\"Add a sub resource to the current extension"},{"line_number":108,"context_line":"        :param subresource_controller"},{"line_number":109,"context_line":"        :raises TypeError"},{"line_number":110,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_eac9f25b","line":107,"in_reply_to":"bab6814e_1c75e4c9","updated":"2016-06-01 00:25:17.000000000","message":"Done","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d0ec5d33b5b32fc2a398b8f4d68e78cb831ddef6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            str(subresource_controller))"},{"line_number":114,"context_line":"        setattr(cls, subresource_controller.resource,"},{"line_number":115,"context_line":"                subresource_controller)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class ShimRequest(object):"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_373d61c4","line":116,"updated":"2016-05-23 18:25:57.000000000","message":"I\u0027m not sure how I feel about having a method to add a subresource.  It\u0027s not consistent with how everything else has been done, but it\u0027s also pretty flexible.  I was thinking of doing something more in the _lookup method of the ItemController class in utils.  It wouldn\u0027t link directly to a parent though, which may not matter.  This does link directly to a parent.  Need to think about it more and I\u0027d like to get others\u0027 feedback as well on it.","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"9f3c88397b6dc4d6b197130f25dd5340a090214b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            str(subresource_controller))"},{"line_number":114,"context_line":"        setattr(cls, subresource_controller.resource,"},{"line_number":115,"context_line":"                subresource_controller)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class ShimRequest(object):"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_8aeb06b0","line":116,"in_reply_to":"bab6814e_373d61c4","updated":"2016-06-01 00:25:17.000000000","message":"This gives a programmatic interface to add a sub-controller to a controller though.","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"}],"neutron/pecan_wsgi/hooks/policy_enforcement.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"2da1210e6b593b0cdcf87060e03042b80b8386ff","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource)"},{"line_number":53,"context_line":"    if plugin:"},{"line_number":54,"context_line":"        getter \u003d getattr(plugin, \u0027get_%s\u0027 % resource)"},{"line_number":55,"context_line":"        # TODO(kevinbenton): the parent_id logic currently in base.py"},{"line_number":56,"context_line":"        getter_args \u003d [neutron_context, resource_id]"},{"line_number":57,"context_line":"        if parent_id is not None:"},{"line_number":58,"context_line":"            getter_args.append(parent_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_e2bb2bc2","line":55,"range":{"start_line":55,"start_character":7,"end_line":55,"end_character":69},"updated":"2016-06-26 21:05:39.000000000","message":"you should remove this TODO","commit_id":"187bcbbc5283919e43fd2078417b3bab0763e06e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"2da1210e6b593b0cdcf87060e03042b80b8386ff","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        getter \u003d getattr(plugin, \u0027get_%s\u0027 % resource)"},{"line_number":55,"context_line":"        # TODO(kevinbenton): the parent_id logic currently in base.py"},{"line_number":56,"context_line":"        getter_args \u003d [neutron_context, resource_id]"},{"line_number":57,"context_line":"        if parent_id is not None:"},{"line_number":58,"context_line":"            getter_args.append(parent_id)"},{"line_number":59,"context_line":"        return getter(*getter_args, fields\u003dfield_list)"},{"line_number":60,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_22b253e5","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":32},"updated":"2016-06-26 21:05:39.000000000","message":"if not parent_id","commit_id":"187bcbbc5283919e43fd2078417b3bab0763e06e"}],"neutron/pecan_wsgi/startup.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d0ec5d33b5b32fc2a398b8f4d68e78cb831ddef6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            collection, new_controller)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if resource_parent is not None:"},{"line_number":88,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":89,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":90,"context_line":"            parent_controller.add_subresource(new_controller)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_d76fb5c1","line":88,"updated":"2016-05-23 18:25:57.000000000","message":"you\u0027ll probably have to wrap the statement after the \u003d with parentheses to avoid using the \\","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"9f3c88397b6dc4d6b197130f25dd5340a090214b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            collection, new_controller)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if resource_parent is not None:"},{"line_number":88,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":89,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":90,"context_line":"            parent_controller.add_subresource(new_controller)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0a4b96b1","line":88,"in_reply_to":"bab6814e_d76fb5c1","updated":"2016-06-01 00:25:17.000000000","message":"Done","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d0ec5d33b5b32fc2a398b8f4d68e78cb831ddef6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if resource_parent is not None:"},{"line_number":88,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":89,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":90,"context_line":"            parent_controller.add_subresource(new_controller)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Certain policy checks require that the extensions are loaded"},{"line_number":93,"context_line":"    # and the RESOURCE_ATTRIBUTE_MAP populated before they can be"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_77e6c944","line":90,"updated":"2016-05-23 18:25:57.000000000","message":"are we guaranteed that the parent will already have a controller defined by this point? there might be a case where the parent is defined in another extension, I\u0027m not sure though.  If that is the case, you may have to let this loop run but collect all the subresources and their parents then loop through the subresources after this loop finishes.","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"9f3c88397b6dc4d6b197130f25dd5340a090214b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if resource_parent is not None:"},{"line_number":88,"context_line":"            parent_controller \u003d manager.NeutronManager.\\"},{"line_number":89,"context_line":"                get_controller_for_resource(resource_parent[\u0027collection_name\u0027])"},{"line_number":90,"context_line":"            parent_controller.add_subresource(new_controller)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Certain policy checks require that the extensions are loaded"},{"line_number":93,"context_line":"    # and the RESOURCE_ATTRIBUTE_MAP populated before they can be"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_6a94e2e7","line":90,"in_reply_to":"bab6814e_77e6c944","updated":"2016-06-01 00:25:17.000000000","message":"I think I can find another way of doing this. Caching the extension_resource to parent in a dictionary, and moving this logic outside of this loop","commit_id":"3e149fcd80dcc4558d5ce166357d8a5ac293cd19"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a732deb72fbbe18953ce47c87c756dbfe6034459","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        ext_res_parent_mapping[new_controller] \u003d resource_parent"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    for new_controller in ext_res_parent_mapping.keys():"},{"line_number":92,"context_line":"        resource_parent \u003d ext_res_parent_mapping[new_controller]"},{"line_number":93,"context_line":"        if resource_parent is not None:"},{"line_number":94,"context_line":"            parent_controller \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_c2bc19de","line":91,"range":{"start_line":91,"start_character":4,"end_line":91,"end_character":55},"updated":"2016-06-02 06:08:18.000000000","message":"for new_controller, resource_parent in ext_res_parent_mapping.items()\n\nalso I\u0027d add a comment above this loop explaining what it\u0027s doing","commit_id":"a8aac1b14bb1845b73422df0cc49df63c906cb41"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"dd2e7b08264bcf2e46f538bcfea3c8dfe09c64fb","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        ext_res_parent_mapping[new_controller] \u003d resource_parent"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    for new_controller in ext_res_parent_mapping.keys():"},{"line_number":92,"context_line":"        resource_parent \u003d ext_res_parent_mapping[new_controller]"},{"line_number":93,"context_line":"        if resource_parent is not None:"},{"line_number":94,"context_line":"            parent_controller \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_9b716aab","line":91,"range":{"start_line":91,"start_character":4,"end_line":91,"end_character":55},"in_reply_to":"9abb7d3a_c2bc19de","updated":"2016-06-03 19:59:30.000000000","message":"Done","commit_id":"a8aac1b14bb1845b73422df0cc49df63c906cb41"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a6489795799cc02d1b146547387b0d72d42da096","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return rule_type_object.QosRuleType.get_objects(**filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":147,"context_line":"    def create_policy_rule(self, context, rule_obj, rule_data, policy_id):"},{"line_number":148,"context_line":"        \"\"\"Create a QoS policy rule."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_afed7590","line":147,"updated":"2016-06-21 16:32:29.000000000","message":"why is this being switched around?","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"acae81a23c20c8a17a08ff99f2cf9c79ad3a9956","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return rule_type_object.QosRuleType.get_objects(**filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":147,"context_line":"    def create_policy_rule(self, context, rule_obj, rule_data, policy_id):"},{"line_number":148,"context_line":"        \"\"\"Create a QoS policy rule."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_2eae6a85","line":147,"in_reply_to":"3aaa91ec_afed7590","updated":"2016-06-22 14:29:03.000000000","message":"This is to facilitate something like this:\nhttps://review.openstack.org/#/c/319626/10/neutron/pecan_wsgi/controllers/resource.py@49\nI think we need a way to consistently passing in parent id to the extension methods.  The idea get children resource method parameters list first, then append parent_id at the end of it. This way all subresource method call that needs parent information info can be passed in the same fashion: \nSee: https://review.openstack.org/#/c/319626/10/neutron/pecan_wsgi/controllers/resource.py@42","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a6489795799cc02d1b146547387b0d72d42da096","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":174,"context_line":"    def update_policy_rule(self, context, rule_obj, rule_id, rule_data,"},{"line_number":175,"context_line":"                           policy_id):"},{"line_number":176,"context_line":"        \"\"\"Update a QoS policy rule."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_8ff2396e","line":175,"updated":"2016-06-21 16:32:29.000000000","message":"ditto","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"acae81a23c20c8a17a08ff99f2cf9c79ad3a9956","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":174,"context_line":"    def update_policy_rule(self, context, rule_obj, rule_id, rule_data,"},{"line_number":175,"context_line":"                           policy_id):"},{"line_number":176,"context_line":"        \"\"\"Update a QoS policy rule."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_2ec5ca3b","line":175,"in_reply_to":"3aaa91ec_8ff2396e","updated":"2016-06-22 14:29:03.000000000","message":"ditto\nAnd see:\nhttps://review.openstack.org/#/c/319626/10/neutron/pecan_wsgi/controllers/resource.py@162","commit_id":"df731e89e4d2da1d429672ef968e9a8e29e02d1f"}],"neutron/tests/functional/pecan_wsgi/utils.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a732deb72fbbe18953ce47c87c756dbfe6034459","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        \u0027fake_subresources\u0027: {"},{"line_number":115,"context_line":"            \u0027parent\u0027: {"},{"line_number":116,"context_line":"                \u0027collection_name\u0027: ("},{"line_number":117,"context_line":"                    HYPHENATED_COLLECTION.replace(\u0027_\u0027, \u0027-\u0027)),"},{"line_number":118,"context_line":"                \u0027member_name\u0027: HYPHENATED_RESOURCE},"},{"line_number":119,"context_line":"            \u0027parameters\u0027: {\u0027foo\u0027: {\u0027is_visible\u0027: True},"},{"line_number":120,"context_line":"                           \u0027bar\u0027: {\u0027is_visible\u0027: True}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_a2947536","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":59},"updated":"2016-06-02 06:08:18.000000000","message":"I don\u0027t think you should have to do this here, the startup code should handle this instead.","commit_id":"a8aac1b14bb1845b73422df0cc49df63c906cb41"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"dd2e7b08264bcf2e46f538bcfea3c8dfe09c64fb","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        \u0027fake_subresources\u0027: {"},{"line_number":115,"context_line":"            \u0027parent\u0027: {"},{"line_number":116,"context_line":"                \u0027collection_name\u0027: ("},{"line_number":117,"context_line":"                    HYPHENATED_COLLECTION.replace(\u0027_\u0027, \u0027-\u0027)),"},{"line_number":118,"context_line":"                \u0027member_name\u0027: HYPHENATED_RESOURCE},"},{"line_number":119,"context_line":"            \u0027parameters\u0027: {\u0027foo\u0027: {\u0027is_visible\u0027: True},"},{"line_number":120,"context_line":"                           \u0027bar\u0027: {\u0027is_visible\u0027: True}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_91b94b7c","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":59},"in_reply_to":"9abb7d3a_a2947536","updated":"2016-06-03 19:59:30.000000000","message":"Done","commit_id":"a8aac1b14bb1845b73422df0cc49df63c906cb41"}]}
