)]}'
{"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0867d7662ed45ef691a3f3244a439dce1a2889f7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    return ports"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_unused_port(used, start\u003d1024, end\u003dNone):"},{"line_number":163,"context_line":"    if end is None:"},{"line_number":164,"context_line":"        port_range \u003d utils.execute("},{"line_number":165,"context_line":"            [\u0027sysctl\u0027, \u0027-n\u0027, \u0027net.ipv4.ip_local_port_range\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8b78b0c5","line":162,"updated":"2016-06-14 04:58:54.000000000","message":"what if someone defines this to be above 65535?","commit_id":"dc12f5e2b28a4852cab27b3498dc558f83510754"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"781aa165daec148e20679f4efbc64fb16904df30","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    return ports"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_unused_port(used, start\u003d1024, end\u003dNone):"},{"line_number":163,"context_line":"    if end is None:"},{"line_number":164,"context_line":"        port_range \u003d utils.execute("},{"line_number":165,"context_line":"            [\u0027sysctl\u0027, \u0027-n\u0027, \u0027net.ipv4.ip_local_port_range\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_7e16a749","line":162,"in_reply_to":"7aa08908_8127ef10","updated":"2016-07-13 15:02:08.000000000","message":"I agree with Iwamoto.","commit_id":"dc12f5e2b28a4852cab27b3498dc558f83510754"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"f139791046124ed47894bac7dcb213c7661d098e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    return ports"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_unused_port(used, start\u003d1024, end\u003dNone):"},{"line_number":163,"context_line":"    if end is None:"},{"line_number":164,"context_line":"        port_range \u003d utils.execute("},{"line_number":165,"context_line":"            [\u0027sysctl\u0027, \u0027-n\u0027, \u0027net.ipv4.ip_local_port_range\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8127ef10","line":162,"in_reply_to":"7aa08908_8b78b0c5","updated":"2016-06-14 06:14:59.000000000","message":"If end \u003e 65535 is passed as an arg, it\u0027s a user error.\nThis function is only used by test codes, so I don\u0027t think extra validation is necessary.","commit_id":"dc12f5e2b28a4852cab27b3498dc558f83510754"}],"neutron/tests/unit/tests/common/test_net_helpers.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d28467a933ae98491780a8289fb8343e6a06ac29","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            ex.return_value \u003d \"2048\\t61000\""},{"line_number":70,"context_line":"            result \u003d net_helpers.get_unused_port(set(range(1025, 2048)))"},{"line_number":71,"context_line":"            self.assertEqual(1024, result)"},{"line_number":72,"context_line":"            ex.assert_called_once_with("},{"line_number":73,"context_line":"                [\u0027sysctl\u0027, \u0027-n\u0027, \u0027net.ipv4.ip_local_port_range\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5c316da1","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":65},"updated":"2016-06-14 08:02:02.000000000","message":"Nit: I would remove that, we\u0027re interested in testing state here and not interaction.","commit_id":"dc12f5e2b28a4852cab27b3498dc558f83510754"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"b835a98667d6ba58f0167b6e93c517748e652850","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            ex.return_value \u003d \"2048\\t61000\""},{"line_number":70,"context_line":"            result \u003d net_helpers.get_unused_port(set(range(1025, 2048)))"},{"line_number":71,"context_line":"            self.assertEqual(1024, result)"},{"line_number":72,"context_line":"            ex.assert_called_once_with("},{"line_number":73,"context_line":"                [\u0027sysctl\u0027, \u0027-n\u0027, \u0027net.ipv4.ip_local_port_range\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_eb65921d","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":65},"in_reply_to":"1aa78d24_be2acf7b","updated":"2016-07-14 08:21:31.000000000","message":"Done","commit_id":"dc12f5e2b28a4852cab27b3498dc558f83510754"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"781aa165daec148e20679f4efbc64fb16904df30","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            ex.return_value \u003d \"2048\\t61000\""},{"line_number":70,"context_line":"            result \u003d net_helpers.get_unused_port(set(range(1025, 2048)))"},{"line_number":71,"context_line":"            self.assertEqual(1024, result)"},{"line_number":72,"context_line":"            ex.assert_called_once_with("},{"line_number":73,"context_line":"                [\u0027sysctl\u0027, \u0027-n\u0027, \u0027net.ipv4.ip_local_port_range\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_be2acf7b","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":65},"in_reply_to":"7aa08908_5c316da1","updated":"2016-07-13 15:02:08.000000000","message":"Agreed.","commit_id":"dc12f5e2b28a4852cab27b3498dc558f83510754"}]}
