)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"07d40481d5b2855627336fc6801011a848a69562","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"L3 DB: only read dns \u0027dns-integration\u0027 once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check that the extension is loaded only once and not every"},{"line_number":10,"context_line":"time a floating ip is created or updated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_d5017806","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":44},"updated":"2016-05-23 15:51:27.000000000","message":"Nit: I found this mis-leading. At first, I thought you were saying that currently the extensions was being loaded every time a fip is created or updated. I would just change the order of words:\n\n\"Check only once that the extension is loaded...\"\n\nor maybe even better:\n\n\"Check only once that the extension is supported...\"","commit_id":"45d4da27db39b1a3acea7007e2d93b87386df4be"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"696ad5f65ee46efbf41e15254d0945fae871cd91","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"L3 DB: only read dns \u0027dns-integration\u0027 once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check that the extension is loaded only once and not every"},{"line_number":10,"context_line":"time a floating ip is created or updated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_480e75e6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":44},"in_reply_to":"bab6814e_d5017806","updated":"2016-05-24 06:10:44.000000000","message":"Done","commit_id":"45d4da27db39b1a3acea7007e2d93b87386df4be"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"499b1b77c980df941bb3fdd3e5ae69b144feaef2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"L3 DB: only read dns \u0027dns-integration\u0027 once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check only once that the extension is supported. This does not"},{"line_number":10,"context_line":"need to be done every time a floating ip is created or updated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_154e32c1","line":10,"updated":"2016-05-24 11:45:18.000000000","message":"can you explain why we need this at all?\nis there any performance problem?","commit_id":"a392f762c0b04c6b53fc446bfc879d4d4273a10c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e23c632602447990b9f3e3d25869ee4260deebaa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"L3 DB: only read dns \u0027dns-integration\u0027 once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check only once that the extension is supported. This does not"},{"line_number":10,"context_line":"need to be done every time a floating ip is created or updated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_db6cdb38","line":10,"in_reply_to":"bab6814e_154e32c1","updated":"2016-05-24 12:13:52.000000000","message":"I think that it is a nice tweak. Can you justify why each time we create/update a floating IP we need to read a lite of features to see if one should be used?","commit_id":"a392f762c0b04c6b53fc446bfc879d4d4273a10c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"173967941a00d78f68a5470feadb77c437210fd4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"L3 DB: only read dns \u0027dns-integration\u0027 once"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check only once that the extension is supported. This does not"},{"line_number":10,"context_line":"need to be done every time a floating ip is created or updated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_47bbe20e","line":10,"in_reply_to":"bab6814e_db6cdb38","updated":"2016-05-24 15:20:41.000000000","message":"to me it looks like unnecessary complexity.\n\nit makes sense if is_extension_supported is expensive.\nbut i guess it isn\u0027t.","commit_id":"a392f762c0b04c6b53fc446bfc879d4d4273a10c"}],"neutron/db/l3_db.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0634445b6b58eaa14d8bb5d3fb5469430dbe3170","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    _dns_integration \u003d None"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @property"},{"line_number":152,"context_line":"    def _dns_supported(self):"},{"line_number":153,"context_line":"        if self._dns_integration is None:"},{"line_number":154,"context_line":"            self._dns_integration \u003d utils.is_extension_supported("},{"line_number":155,"context_line":"                self._core_plugin, \u0027dns-integration\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_540d0736","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":22},"updated":"2016-05-31 07:27:58.000000000","message":"the method name seems vague to me.\nit should indicate dns-integration clearly.","commit_id":"11b706ae2837eb9afefbce16895a8e151d16ca98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e6f6fb5e3358647b9d3c31b00672d2d97e8a5fd3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    _dns_integration \u003d None"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @property"},{"line_number":152,"context_line":"    def _dns_supported(self):"},{"line_number":153,"context_line":"        if self._dns_integration is None:"},{"line_number":154,"context_line":"            self._dns_integration \u003d utils.is_extension_supported("},{"line_number":155,"context_line":"                self._core_plugin, \u0027dns-integration\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_62f6f0d8","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":22},"in_reply_to":"9abb7d3a_540d0736","updated":"2016-06-05 11:39:55.000000000","message":"Done","commit_id":"11b706ae2837eb9afefbce16895a8e151d16ca98"}]}