)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e084dbcd83352e3521f3481d72cc3411edf3746f","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"                    self.context,"},{"line_number":1499,"context_line":"                    device_subset,"},{"line_number":1500,"context_line":"                    self.agent_id,"},{"line_number":1501,"context_line":"                    cfg.CONF.host))"},{"line_number":1502,"context_line":"            device_details[\u0027devices\u0027].extend(_device_details.get(\u0027devices\u0027))"},{"line_number":1503,"context_line":"            device_details[\u0027failed_devices\u0027].extend("},{"line_number":1504,"context_line":"                _device_details.get(\u0027failed_devices\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5ed44446","line":1501,"range":{"start_line":1501,"start_character":20,"end_line":1501,"end_character":33},"updated":"2016-05-24 18:30:17.000000000","message":"This should be self.conf.host otherwise the consumers conf passed to the constructor will be ignored.","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"c9b9fbd87fdecc02c05393f3314d8f6332cf34c4","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"                    self.context,"},{"line_number":1499,"context_line":"                    device_subset,"},{"line_number":1500,"context_line":"                    self.agent_id,"},{"line_number":1501,"context_line":"                    cfg.CONF.host))"},{"line_number":1502,"context_line":"            device_details[\u0027devices\u0027].extend(_device_details.get(\u0027devices\u0027))"},{"line_number":1503,"context_line":"            device_details[\u0027failed_devices\u0027].extend("},{"line_number":1504,"context_line":"                _device_details.get(\u0027failed_devices\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_37e22502","line":1501,"range":{"start_line":1501,"start_character":20,"end_line":1501,"end_character":33},"in_reply_to":"bab6814e_5ed44446","updated":"2016-05-25 09:18:15.000000000","message":"Done","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e084dbcd83352e3521f3481d72cc3411edf3746f","unresolved":false,"context_lines":[{"line_number":1515,"context_line":"            except oslo_messaging.RemoteError as e:"},{"line_number":1516,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1517,"context_line":"                    ctx.reraise \u003d True"},{"line_number":1518,"context_line":"                    LOG.warning(_LW(\u0027Agent cannot get devices details list. \u0027"},{"line_number":1519,"context_line":"                                    \u0027Detail message: %s\u0027), e)"},{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5999fe1e","line":1518,"range":{"start_line":1518,"start_character":24,"end_line":1518,"end_character":31},"updated":"2016-05-24 18:30:17.000000000","message":"Maybe we should use error in this case; what do you think?","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e084dbcd83352e3521f3481d72cc3411edf3746f","unresolved":false,"context_lines":[{"line_number":1515,"context_line":"            except oslo_messaging.RemoteError as e:"},{"line_number":1516,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1517,"context_line":"                    ctx.reraise \u003d True"},{"line_number":1518,"context_line":"                    LOG.warning(_LW(\u0027Agent cannot get devices details list. \u0027"},{"line_number":1519,"context_line":"                                    \u0027Detail message: %s\u0027), e)"},{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_19e2d69f","line":1518,"range":{"start_line":1518,"start_character":54,"end_line":1518,"end_character":61},"updated":"2016-05-24 18:30:17.000000000","message":"Nit: device","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"c9b9fbd87fdecc02c05393f3314d8f6332cf34c4","unresolved":false,"context_lines":[{"line_number":1515,"context_line":"            except oslo_messaging.RemoteError as e:"},{"line_number":1516,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1517,"context_line":"                    ctx.reraise \u003d True"},{"line_number":1518,"context_line":"                    LOG.warning(_LW(\u0027Agent cannot get devices details list. \u0027"},{"line_number":1519,"context_line":"                                    \u0027Detail message: %s\u0027), e)"},{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_77ecadf3","line":1518,"range":{"start_line":1518,"start_character":54,"end_line":1518,"end_character":61},"in_reply_to":"bab6814e_19e2d69f","updated":"2016-05-25 09:18:15.000000000","message":"Done","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"c9b9fbd87fdecc02c05393f3314d8f6332cf34c4","unresolved":false,"context_lines":[{"line_number":1515,"context_line":"            except oslo_messaging.RemoteError as e:"},{"line_number":1516,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1517,"context_line":"                    ctx.reraise \u003d True"},{"line_number":1518,"context_line":"                    LOG.warning(_LW(\u0027Agent cannot get devices details list. \u0027"},{"line_number":1519,"context_line":"                                    \u0027Detail message: %s\u0027), e)"},{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_57cec983","line":1518,"range":{"start_line":1518,"start_character":24,"end_line":1518,"end_character":31},"in_reply_to":"bab6814e_5999fe1e","updated":"2016-05-25 09:18:15.000000000","message":"Done. That\u0027s better.","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e084dbcd83352e3521f3481d72cc3411edf3746f","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1517,"context_line":"                    ctx.reraise \u003d True"},{"line_number":1518,"context_line":"                    LOG.warning(_LW(\u0027Agent cannot get devices details list. \u0027"},{"line_number":1519,"context_line":"                                    \u0027Detail message: %s\u0027), e)"},{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1522,"context_line":"                    retry_count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_3e4ea0c1","line":1519,"range":{"start_line":1519,"start_character":37,"end_line":1519,"end_character":43},"updated":"2016-05-24 18:30:17.000000000","message":"Nit: Detailed","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"c9b9fbd87fdecc02c05393f3314d8f6332cf34c4","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1517,"context_line":"                    ctx.reraise \u003d True"},{"line_number":1518,"context_line":"                    LOG.warning(_LW(\u0027Agent cannot get devices details list. \u0027"},{"line_number":1519,"context_line":"                                    \u0027Detail message: %s\u0027), e)"},{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1522,"context_line":"                    retry_count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b7b8d5c8","line":1519,"range":{"start_line":1519,"start_character":37,"end_line":1519,"end_character":43},"in_reply_to":"bab6814e_3e4ea0c1","updated":"2016-05-25 09:18:15.000000000","message":"Done","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e084dbcd83352e3521f3481d72cc3411edf3746f","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"                    retry_count +\u003d 1"},{"line_number":1523,"context_line":"                    if retry_count \u003c 5:"},{"line_number":1524,"context_line":"                        ctx.reraise \u003d False"},{"line_number":1525,"context_line":"                        LOG.warning(_LW(\u0027Agent cannot get devices details \u0027"},{"line_number":1526,"context_line":"                                        \u0027list. Retrying. Detail message: %s\u0027),"},{"line_number":1527,"context_line":"                                    e)"},{"line_number":1528,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_59f29e70","line":1525,"range":{"start_line":1525,"start_character":58,"end_line":1525,"end_character":65},"updated":"2016-05-24 18:30:17.000000000","message":"Nit: device","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"c9b9fbd87fdecc02c05393f3314d8f6332cf34c4","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"                    retry_count +\u003d 1"},{"line_number":1523,"context_line":"                    if retry_count \u003c 5:"},{"line_number":1524,"context_line":"                        ctx.reraise \u003d False"},{"line_number":1525,"context_line":"                        LOG.warning(_LW(\u0027Agent cannot get devices details \u0027"},{"line_number":1526,"context_line":"                                        \u0027list. Retrying. Detail message: %s\u0027),"},{"line_number":1527,"context_line":"                                    e)"},{"line_number":1528,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f7b25de4","line":1525,"range":{"start_line":1525,"start_character":58,"end_line":1525,"end_character":65},"in_reply_to":"bab6814e_59f29e70","updated":"2016-05-25 09:18:15.000000000","message":"Done","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e084dbcd83352e3521f3481d72cc3411edf3746f","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"                    if retry_count \u003c 5:"},{"line_number":1524,"context_line":"                        ctx.reraise \u003d False"},{"line_number":1525,"context_line":"                        LOG.warning(_LW(\u0027Agent cannot get devices details \u0027"},{"line_number":1526,"context_line":"                                        \u0027list. Retrying. Detail message: %s\u0027),"},{"line_number":1527,"context_line":"                                    e)"},{"line_number":1528,"context_line":"                        continue"},{"line_number":1529,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_be59f090","line":1526,"range":{"start_line":1526,"start_character":57,"end_line":1526,"end_character":63},"updated":"2016-05-24 18:30:17.000000000","message":"Nit: Detailed","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"c9b9fbd87fdecc02c05393f3314d8f6332cf34c4","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"                    if retry_count \u003c 5:"},{"line_number":1524,"context_line":"                        ctx.reraise \u003d False"},{"line_number":1525,"context_line":"                        LOG.warning(_LW(\u0027Agent cannot get devices details \u0027"},{"line_number":1526,"context_line":"                                        \u0027list. Retrying. Detail message: %s\u0027),"},{"line_number":1527,"context_line":"                                    e)"},{"line_number":1528,"context_line":"                        continue"},{"line_number":1529,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_97c4b140","line":1526,"range":{"start_line":1526,"start_character":57,"end_line":1526,"end_character":63},"in_reply_to":"bab6814e_be59f090","updated":"2016-05-25 09:18:15.000000000","message":"Done","commit_id":"8b07f5625256db501ba01132c13958d89d2a334c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"cb379e6ba021db0ffc001e1d926619f880988c01","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"            yield device_list[i:i + subset_size]"},{"line_number":1490,"context_line":""},{"line_number":1491,"context_line":"    def _get_devices_details_list_and_failed_devices(self, devices, retry):"},{"line_number":1492,"context_line":"        subset_size \u003d max(len(devices) // (2 ** retry), 1000)"},{"line_number":1493,"context_line":"        device_details \u003d {\u0027devices\u0027: [], \u0027failed_devices\u0027: []}"},{"line_number":1494,"context_line":"        for device_subset in self._get_device_list_chunks(devices,"},{"line_number":1495,"context_line":"                                                          subset_size):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_01909642","line":1492,"updated":"2016-05-30 05:36:19.000000000","message":"I don\u0027t think it is worth risking an RPC timeout, thus the subset_size of 1000 is a bit too large.","commit_id":"a5344e3709d8c994d795a16718bff39366d6d7fe"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"dd74a059c78cc86f835699aca2f299f22e8cc06f","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"            yield device_list[i:i + subset_size]"},{"line_number":1490,"context_line":""},{"line_number":1491,"context_line":"    def _get_devices_details_list_and_failed_devices(self, devices, retry):"},{"line_number":1492,"context_line":"        subset_size \u003d max(len(devices) // (2 ** retry), 1000)"},{"line_number":1493,"context_line":"        device_details \u003d {\u0027devices\u0027: [], \u0027failed_devices\u0027: []}"},{"line_number":1494,"context_line":"        for device_subset in self._get_device_list_chunks(devices,"},{"line_number":1495,"context_line":"                                                          subset_size):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_7c5f8541","line":1492,"in_reply_to":"9abb7d3a_01909642","updated":"2016-05-30 06:30:06.000000000","message":"I humbly disagree with you there. RPC timeout happens due to environment conditions + input size. So there is no way to know in advance or adjust chunk size based a static predetermined value.\n\nHere we are not assuming anything, if a timeout happens there is a timing based backoff for RPC clients for that call already implemented. On top of that we also try with a lesser input size. So we decrease the chances for a timeout with the next retry.\n\nThe size 1000 is just a way of saying... if the system cannot respond to an input size of 1000 devices even with 5 retries, by which time there is a big timeout value and delay added before each retry (with RPC backoff patch); then it\u0027s not worth retrying. Better bailout and fix the issue that\u0027s preventing the call to work. Also the value 1000 only actually applies when we are coming down exponentially from a large device list.","commit_id":"a5344e3709d8c994d795a16718bff39366d6d7fe"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"cb379e6ba021db0ffc001e1d926619f880988c01","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1522,"context_line":"                    retry_count +\u003d 1"},{"line_number":1523,"context_line":"                    if retry_count \u003c 5:"},{"line_number":1524,"context_line":"                        ctx.reraise \u003d False"},{"line_number":1525,"context_line":"                        LOG.warning(_LW(\u0027Agent cannot get device details. \u0027"},{"line_number":1526,"context_line":"                                        \u0027Retrying. Detailed message: %s\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_c1ae8e84","line":1523,"updated":"2016-05-30 05:36:19.000000000","message":"With commit 3e668b6 in place, this retry logic sounds redundant.","commit_id":"a5344e3709d8c994d795a16718bff39366d6d7fe"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"dd74a059c78cc86f835699aca2f299f22e8cc06f","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            except oslo_messaging.MessagingTimeout as e:"},{"line_number":1521,"context_line":"                with excutils.save_and_reraise_exception() as ctx:"},{"line_number":1522,"context_line":"                    retry_count +\u003d 1"},{"line_number":1523,"context_line":"                    if retry_count \u003c 5:"},{"line_number":1524,"context_line":"                        ctx.reraise \u003d False"},{"line_number":1525,"context_line":"                        LOG.warning(_LW(\u0027Agent cannot get device details. \u0027"},{"line_number":1526,"context_line":"                                        \u0027Retrying. Detailed message: %s\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_109c5dbf","line":1523,"in_reply_to":"9abb7d3a_c1ae8e84","updated":"2016-05-30 06:30:06.000000000","message":"Actually, this commit encourages clients to retry without any timing logic on their part! So it\u0027s not redundant but is actually needed.\n\nHere we don\u0027t retry forever. We adjust the input size (halving it) to aid the backoff, and increase the probability of the call to go through.","commit_id":"a5344e3709d8c994d795a16718bff39366d6d7fe"}]}
