)]}'
{"neutron/services/trunk/plugin.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a1f154b9e2ecc9e52d17455efb40bfd2b30b557b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def _extend_port_trunk_details(core_plugin, port_res, port_db):"},{"line_number":23,"context_line":"    \"\"\"Add trunk details to a port.\"\"\""},{"line_number":24,"context_line":"    if manager.NeutronManager.get_service_plugins().get(\u0027trunk\u0027):"},{"line_number":25,"context_line":"        port_res[\u0027trunk_details\u0027] \u003d \u0027foobar\u0027"},{"line_number":26,"context_line":"        return port_res"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_bd2bc12f","line":25,"updated":"2016-05-28 04:28:54.000000000","message":"Is \u0027foobar\u0027 is intentional? Sorry, I didn\u0027t get the importance doing this..","commit_id":"ed565db3d793f8f10b2e63e3d3c81a5a5769f023"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ac15eee04a489ee51c44cbe02fb20cebd32ee2e2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def _extend_port_trunk_details(core_plugin, port_res, port_db):"},{"line_number":23,"context_line":"    \"\"\"Add trunk details to a port.\"\"\""},{"line_number":24,"context_line":"    if manager.NeutronManager.get_service_plugins().get(\u0027trunk\u0027):"},{"line_number":25,"context_line":"        port_res[\u0027trunk_details\u0027] \u003d \u0027foobar\u0027"},{"line_number":26,"context_line":"        return port_res"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_d00a7689","line":25,"in_reply_to":"9abb7d3a_2a56f3cd","updated":"2016-05-31 19:13:51.000000000","message":"I tend to like small patches focused on adding a minimal but meaningful change to the code base that can stand on its own and not break any existing use cases.  At a minimum, that minimal change should be testable by adding a new unit test.\n\nThis patch does not add or change any unit tests in a meaningful way.  I think my vote would be to squash this in to a patch that does because I think even API changes are better when there is a test that uses them in some way, even a simple way.","commit_id":"ed565db3d793f8f10b2e63e3d3c81a5a5769f023"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dad972ccf75faaef7bb07979099c550288385928","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def _extend_port_trunk_details(core_plugin, port_res, port_db):"},{"line_number":23,"context_line":"    \"\"\"Add trunk details to a port.\"\"\""},{"line_number":24,"context_line":"    if manager.NeutronManager.get_service_plugins().get(\u0027trunk\u0027):"},{"line_number":25,"context_line":"        port_res[\u0027trunk_details\u0027] \u003d \u0027foobar\u0027"},{"line_number":26,"context_line":"        return port_res"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_2a56f3cd","line":25,"in_reply_to":"9abb7d3a_bd2bc12f","updated":"2016-05-31 18:28:45.000000000","message":"It is intentional, but the aim of this patch is not so much having something complete and fully functional but rather laying down the foundation for other folks who are gonna pick the pieces and tie them together. For instance, Ryan is working on making this operational. For what it\u0027s worth, we may even consider squashing these into his patch [1] \n\n[1] https://review.openstack.org/#/c/320092/","commit_id":"ed565db3d793f8f10b2e63e3d3c81a5a5769f023"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2ebd37252fe0d0de970e8bd059961b3af9e30653","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def _extend_port_trunk_details(core_plugin, port_res, port_db):"},{"line_number":23,"context_line":"    \"\"\"Add trunk details to a port.\"\"\""},{"line_number":24,"context_line":"    if manager.NeutronManager.get_service_plugins().get(\u0027trunk\u0027):"},{"line_number":25,"context_line":"        port_res[\u0027trunk_details\u0027] \u003d \u0027foobar\u0027"},{"line_number":26,"context_line":"        return port_res"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_a40a1788","line":25,"in_reply_to":"9abb7d3a_d00a7689","updated":"2016-05-31 19:36:24.000000000","message":"I think your suggestion is reasonable and this means squashing change [1] into [2] too. It is worth nothing that we never figured out a lightweight process of testing API proposals, we could only do so once at least DB and plugin layers were in place. It\u0027s probably time we understand how we can simply test the contract without bringing in the layers underneath. I may end up needing this for the stadium efforts anyway.\n\n[1] https://review.openstack.org/#/c/281723/\n[2] https://review.openstack.org/#/c/320092/","commit_id":"ed565db3d793f8f10b2e63e3d3c81a5a5769f023"}]}
