)]}'
{"neutron/agent/l3/ha.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"6bc7f1f7074d10b078f2790583831f29942b78f9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if state \u003d\u003d \u0027master\u0027 and ex_gw_port_id:"},{"line_number":138,"context_line":"            interface_name \u003d ri.get_external_device_name(ex_gw_port_id)"},{"line_number":139,"context_line":"            if ri.router.get(\u0027distributed\u0027, False):"},{"line_number":140,"context_line":"                namespace \u003d ri.ha_namespace"},{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                namespace \u003d ri.ns_name"},{"line_number":143,"context_line":"            ri._enable_ra_on_gw(ri.ex_gw_port, namespace, interface_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_874691bd","line":140,"range":{"start_line":140,"start_character":31,"end_line":140,"end_character":43},"updated":"2016-05-27 13:24:31.000000000","message":"what is the difference between ri.ha_namespace and ri.ns_name?","commit_id":"c91c10f311f587591aed34f69152f48413792fc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3d56d500c0a3f07e3462c36f9acc85ddd317187d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if state \u003d\u003d \u0027master\u0027 and ex_gw_port_id:"},{"line_number":138,"context_line":"            interface_name \u003d ri.get_external_device_name(ex_gw_port_id)"},{"line_number":139,"context_line":"            if ri.router.get(\u0027distributed\u0027, False):"},{"line_number":140,"context_line":"                namespace \u003d ri.ha_namespace"},{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                namespace \u003d ri.ns_name"},{"line_number":143,"context_line":"            ri._enable_ra_on_gw(ri.ex_gw_port, namespace, interface_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_eb5a5e4f","line":140,"range":{"start_line":140,"start_character":31,"end_line":140,"end_character":43},"in_reply_to":"7aa08908_525a9b84","updated":"2016-08-16 16:02:55.000000000","message":"+1 If we want to simplify this, another patch set would be appropriate.","commit_id":"c91c10f311f587591aed34f69152f48413792fc5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e35a2df6ae77b618c457ab25d47ab884a8ed915f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if state \u003d\u003d \u0027master\u0027 and ex_gw_port_id:"},{"line_number":138,"context_line":"            interface_name \u003d ri.get_external_device_name(ex_gw_port_id)"},{"line_number":139,"context_line":"            if ri.router.get(\u0027distributed\u0027, False):"},{"line_number":140,"context_line":"                namespace \u003d ri.ha_namespace"},{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                namespace \u003d ri.ns_name"},{"line_number":143,"context_line":"            ri._enable_ra_on_gw(ri.ex_gw_port, namespace, interface_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_525a9b84","line":140,"range":{"start_line":140,"start_character":31,"end_line":140,"end_character":43},"in_reply_to":"9abb7d3a_874691bd","updated":"2016-06-06 06:32:24.000000000","message":"For dvr_ha router, ha_namespace is the snat namespace, ns_name will be the qrouter namespace. I think we can use just ha_namespace here in this method, but it is out of the scope of this patch.","commit_id":"c91c10f311f587591aed34f69152f48413792fc5"}],"neutron/tests/functional/agent/l3/test_ha_router.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9467cdee9c34be8eb9730aa09fa3b1ae27470fe7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.agent.l3 import agent as neutron_l3_agent"},{"line_number":24,"context_line":"from neutron.agent.l3 import namespaces"},{"line_number":25,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":26,"context_line":"from neutron.agent.linux import utils"},{"line_number":27,"context_line":"from neutron.common import constants"},{"line_number":28,"context_line":"from neutron.common import ipv6_utils"},{"line_number":29,"context_line":"from neutron.common import utils as common_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_614dbfc3","line":26,"updated":"2016-08-17 11:53:27.000000000","message":"This went away so when it merged with master, this caused an error.","commit_id":"c91c10f311f587591aed34f69152f48413792fc5"}]}
