)]}'
{"neutron/tests/common/machine_fixtures.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0b043653706ef7d59e23f19804a8501bc2b8acd0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    @ipv6_cidr.setter"},{"line_number":126,"context_line":"    def ipv6_cidr(self, ipv6_cidr):"},{"line_number":127,"context_line":"        self.port.addr.add(ipv6_cidr)"},{"line_number":128,"context_line":"        if self._ipv6_cidr:"},{"line_number":129,"context_line":"            self.port.addr.delete(self._ipv6_cidr)"},{"line_number":130,"context_line":"        self._ipv6_cidr \u003d ipv6_cidr"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_8d77979e","line":128,"updated":"2016-08-16 09:27:08.000000000","message":"probably want to delete the old one before adding the new one in case they conflict in any way.","commit_id":"a2676bd887bad018cc7fd00d89b6f59133de3a93"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"fa2e2ce7535479b7b43c2f01c6f2f7e3ec185c21","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    @ipv6_cidr.setter"},{"line_number":126,"context_line":"    def ipv6_cidr(self, ipv6_cidr):"},{"line_number":127,"context_line":"        self.port.addr.add(ipv6_cidr)"},{"line_number":128,"context_line":"        if self._ipv6_cidr:"},{"line_number":129,"context_line":"            self.port.addr.delete(self._ipv6_cidr)"},{"line_number":130,"context_line":"        self._ipv6_cidr \u003d ipv6_cidr"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_f19f0601","line":128,"in_reply_to":"3ac371cc_8d77979e","updated":"2016-08-22 06:41:12.000000000","message":"Done","commit_id":"a2676bd887bad018cc7fd00d89b6f59133de3a93"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1bec6f4ceac105dbb1ba4a6ec3b28a95533c6ceb","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def ipv6(self):"},{"line_number":119,"context_line":"        return self._ipv6_cidr.partition(\u0027/\u0027)[0]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @property"},{"line_number":122,"context_line":"    def ipv6_cidr(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_66b8fe75","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":48},"updated":"2016-11-03 14:56:25.000000000","message":"I know we do it this way on L105 - but I think it\u0027s better to use netaddr for this to not rely on format:\n\nreturn str(netaddr.IPNetwork(self._ipv6_cidr).ip)","commit_id":"989aba6a2bba0992f0406fc6555ea9a590f71965"}],"neutron/tests/fullstack/test_l3_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1bec6f4ceac105dbb1ba4a6ec3b28a95533c6ceb","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        for fixed_ip in router[\u0027external_gateway_info\u0027][\u0027external_fixed_ips\u0027]:"},{"line_number":157,"context_line":"            if netaddr.IPNetwork(fixed_ip[\u0027ip_address\u0027]).version \u003d\u003d 6:"},{"line_number":158,"context_line":"                external_vm.set_default_gateway(fixed_ip[\u0027ip_address\u0027])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        vm \u003d self._create_net_subnet_and_vm("},{"line_number":161,"context_line":"            tenant_id, [\u002720.0.0.0/24\u0027, \u00272001:db8:aaaa::/64\u0027],"},{"line_number":162,"context_line":"            self.environment.hosts[1], router)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_665abef3","line":159,"updated":"2016-11-03 14:56:25.000000000","message":"Should we \u0027break\u0027 here?","commit_id":"989aba6a2bba0992f0406fc6555ea9a590f71965"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"78a2afef9e42ba36fc2e05b8cf817eeb434cf29b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        for fixed_ip in router[\u0027external_gateway_info\u0027][\u0027external_fixed_ips\u0027]:"},{"line_number":157,"context_line":"            if netaddr.IPNetwork(fixed_ip[\u0027ip_address\u0027]).version \u003d\u003d 6:"},{"line_number":158,"context_line":"                external_vm.set_default_gateway(fixed_ip[\u0027ip_address\u0027])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        vm \u003d self._create_net_subnet_and_vm("},{"line_number":161,"context_line":"            tenant_id, [\u002720.0.0.0/24\u0027, \u00272001:db8:aaaa::/64\u0027],"},{"line_number":162,"context_line":"            self.environment.hosts[1], router)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_00462c23","line":159,"in_reply_to":"9a629dbe_7d314fec","updated":"2016-11-07 09:58:37.000000000","message":"Ok, I didn\u0027t know there will be always only one IPv6 address in external_fixed_ips.","commit_id":"989aba6a2bba0992f0406fc6555ea9a590f71965"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"03fc36ccf5445b54338b4f5baa911506d81d4661","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        for fixed_ip in router[\u0027external_gateway_info\u0027][\u0027external_fixed_ips\u0027]:"},{"line_number":157,"context_line":"            if netaddr.IPNetwork(fixed_ip[\u0027ip_address\u0027]).version \u003d\u003d 6:"},{"line_number":158,"context_line":"                external_vm.set_default_gateway(fixed_ip[\u0027ip_address\u0027])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        vm \u003d self._create_net_subnet_and_vm("},{"line_number":161,"context_line":"            tenant_id, [\u002720.0.0.0/24\u0027, \u00272001:db8:aaaa::/64\u0027],"},{"line_number":162,"context_line":"            self.environment.hosts[1], router)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_7d314fec","line":159,"in_reply_to":"ba5da102_665abef3","updated":"2016-11-07 09:43:50.000000000","message":"The router would have two external_fixed_ips (a V4 and a V6 address). If required, we can add a break here. But honestly this is not a major performance issue. \n\nPlease let me know your thoughts on this. If you think a \u0027break\u0027 is really needed, I\u0027ll update the patch accordingly.","commit_id":"989aba6a2bba0992f0406fc6555ea9a590f71965"}]}