)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay S. Bryant \u003cjsbryant@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-27 09:54:55 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix handling check against non-root ip in subnet CIDR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a subnet is created using an IP that isn\u0027t a root IP"},{"line_number":10,"context_line":"(doesn\u0027t end with .0) the code that handles IP checking"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPn%2F%2Fecs%3D","line":7,"updated":"2013-07-01 05:35:39.000000000","message":"Since this commit changes the behavior to accept non-root IP in subnet CIDR, it is better the commit message explains it:\n\"Allow non-root ip in subnet CIDR\"","commit_id":"a71b00d0a2c5b21117ba099456b8086f7e41bae0"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"701a7542343d610155365b6d82ea5386ee5726ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay S. Bryant \u003cjsbryant@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-27 09:54:55 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix handling check against non-root ip in subnet CIDR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a subnet is created using an IP that isn\u0027t a root IP"},{"line_number":10,"context_line":"(doesn\u0027t end with .0) the code that handles IP checking"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPn%2F%2Fcco%3D","line":7,"in_reply_to":"AAAAPn%2F%2Fecs%3D","updated":"2013-07-01 20:19:29.000000000","message":"Good thought.  Thanks!\nDone","commit_id":"a71b00d0a2c5b21117ba099456b8086f7e41bae0"}],"quantum/db/db_base_plugin_v2.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"47651906d3528d8c4a286aa34e355ffa992a8b42","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        # network or the broadcast address"},{"line_number":554,"context_line":"        if (ip !\u003d net.network and"},{"line_number":555,"context_line":"                ip !\u003d net.broadcast and"},{"line_number":556,"context_line":"                net.netmask \u0026 ip \u003d\u003d net.netmask \u0026 net.ip):"},{"line_number":557,"context_line":"            return True"},{"line_number":558,"context_line":"        return False"},{"line_number":559,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fsmc%3D","line":556,"updated":"2013-06-25 01:06:55.000000000","message":"net.netmask \u0026 ip \u003d\u003d net.network","commit_id":"49e62f04037df40af4257dc0d98bb1e15bce6f15"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"701a7542343d610155365b6d82ea5386ee5726ec","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        # network or the broadcast address"},{"line_number":554,"context_line":"        if (ip !\u003d net.network and"},{"line_number":555,"context_line":"                ip !\u003d net.broadcast and"},{"line_number":556,"context_line":"                net.netmask \u0026 ip \u003d\u003d net.netmask \u0026 net.ip):"},{"line_number":557,"context_line":"            return True"},{"line_number":558,"context_line":"        return False"},{"line_number":559,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FkvA%3D","line":556,"in_reply_to":"AAAAPn%2F%2Fsmc%3D","updated":"2013-06-27 14:54:47.000000000","message":"Done\n\nThanks Mark.  Good idea.  I hadn\u0027t noticed that net.network was getting the IP I was looking for properly set","commit_id":"49e62f04037df40af4257dc0d98bb1e15bce6f15"}],"quantum/tests/unit/test_db_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":1550,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.2\u0027}]}"},{"line_number":1551,"context_line":"            net_id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":1552,"context_line":"            res \u003d self._create_port(self.fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":1553,"context_line":"            try:"},{"line_number":1554,"context_line":"                self.assertEqual(res.status_int, 201)"},{"line_number":1555,"context_line":"            finally:"},{"line_number":1556,"context_line":"                if res.status_int \u003d\u003d 201:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FkKM%3D","line":1553,"updated":"2013-06-27 17:36:48.000000000","message":"why the try? the test should be deterministic","commit_id":"a71b00d0a2c5b21117ba099456b8086f7e41bae0"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"701a7542343d610155365b6d82ea5386ee5726ec","unresolved":false,"context_lines":[{"line_number":1550,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.2\u0027}]}"},{"line_number":1551,"context_line":"            net_id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":1552,"context_line":"            res \u003d self._create_port(self.fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":1553,"context_line":"            try:"},{"line_number":1554,"context_line":"                self.assertEqual(res.status_int, 201)"},{"line_number":1555,"context_line":"            finally:"},{"line_number":1556,"context_line":"                if res.status_int \u003d\u003d 201:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Fcc4%3D","line":1553,"in_reply_to":"AAAAPn%2F%2FefU%3D","updated":"2013-07-01 20:19:29.000000000","message":"Done","commit_id":"a71b00d0a2c5b21117ba099456b8086f7e41bae0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":1550,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.2\u0027}]}"},{"line_number":1551,"context_line":"            net_id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":1552,"context_line":"            res \u003d self._create_port(self.fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":1553,"context_line":"            try:"},{"line_number":1554,"context_line":"                self.assertEqual(res.status_int, 201)"},{"line_number":1555,"context_line":"            finally:"},{"line_number":1556,"context_line":"                if res.status_int \u003d\u003d 201:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FefU%3D","line":1553,"in_reply_to":"AAAAPn%2F%2FkCc%3D","updated":"2013-07-01 05:35:39.000000000","message":"I don\u0027t think try/finally is needed in this case. if status_int is not 201, assertEqual raises an error and the rest is not executed. Otherwise the port created will be deleted successfully.","commit_id":"a71b00d0a2c5b21117ba099456b8086f7e41bae0"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"701a7542343d610155365b6d82ea5386ee5726ec","unresolved":false,"context_lines":[{"line_number":1550,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.2\u0027}]}"},{"line_number":1551,"context_line":"            net_id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":1552,"context_line":"            res \u003d self._create_port(self.fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":1553,"context_line":"            try:"},{"line_number":1554,"context_line":"                self.assertEqual(res.status_int, 201)"},{"line_number":1555,"context_line":"            finally:"},{"line_number":1556,"context_line":"                if res.status_int \u003d\u003d 201:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FkCc%3D","line":1553,"in_reply_to":"AAAAPn%2F%2FkKM%3D","updated":"2013-06-28 12:13:44.000000000","message":"I had run into issues with other test cases in this file where a try isn\u0027t used.  It then goes and tries to release a port that wasn\u0027t actually created and so the error that is raised up is for the failure to delete the port rather than the failure the test case was written to uncover.  I suppose that wouldn\u0027t happen here since I am checking res.status_int before deleting the port, but it doesn\u0027t hurt anything.  In fact I should probably go through and fix up the other test cases when time allows.","commit_id":"a71b00d0a2c5b21117ba099456b8086f7e41bae0"}]}
