)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4d0a2fd0e191e9c933f4a0e2e1132b49fd5cad38","unresolved":false,"context_lines":[{"line_number":10,"context_line":"physical_interface_mappings is does not make sense. As it only"},{"line_number":11,"context_line":"supports layer2 networks (flat, vlan) an interface mapping is"},{"line_number":12,"context_line":"mandatory. This patch terminates the agent when no mapping is"},{"line_number":13,"context_line":"provided."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I647cf4da55fda54e32b7047b84e0d7f671629fa7"},{"line_number":16,"context_line":"Closes-Bug: #1587444"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_af2e14f8","line":13,"updated":"2016-08-24 13:57:43.000000000","message":"I think that this require a UpgradeImpact flag","commit_id":"1e4edfc92b9424477a8f7c86a45d32b8c4ad4c20"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ef7c92c92df31ec44b8df8f9e0af12785d353ffb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Terminate macvtap agent when physical_interface_mapping config not present"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting the macvtap agent without specifiying at least one"},{"line_number":10,"context_line":"physical_interface_mappings is does not make sense. As it only"},{"line_number":11,"context_line":"supports layer2 networks (flat, vlan) an interface mapping is"},{"line_number":12,"context_line":"mandatory. An existing agent deployment witout an interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a3c09a3_7f164656","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":46},"updated":"2017-01-16 16:44:57.000000000","message":"specifying","commit_id":"a2d42eac9a1a3f178ccce692dd948f0f0399f900"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ef7c92c92df31ec44b8df8f9e0af12785d353ffb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Terminate macvtap agent when physical_interface_mapping config not present"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting the macvtap agent without specifiying at least one"},{"line_number":10,"context_line":"physical_interface_mappings is does not make sense. As it only"},{"line_number":11,"context_line":"supports layer2 networks (flat, vlan) an interface mapping is"},{"line_number":12,"context_line":"mandatory. An existing agent deployment witout an interface"},{"line_number":13,"context_line":"mapping can not serve any networks to instances!"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a3c09a3_42036d0d","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":31},"updated":"2017-01-16 16:44:57.000000000","message":"remove","commit_id":"a2d42eac9a1a3f178ccce692dd948f0f0399f900"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ef7c92c92df31ec44b8df8f9e0af12785d353ffb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Starting the macvtap agent without specifiying at least one"},{"line_number":10,"context_line":"physical_interface_mappings is does not make sense. As it only"},{"line_number":11,"context_line":"supports layer2 networks (flat, vlan) an interface mapping is"},{"line_number":12,"context_line":"mandatory. An existing agent deployment witout an interface"},{"line_number":13,"context_line":"mapping can not serve any networks to instances!"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch terminates the agent when no mapping is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a3c09a3_822475af","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":46},"updated":"2017-01-16 16:44:57.000000000","message":"without","commit_id":"a2d42eac9a1a3f178ccce692dd948f0f0399f900"}],"neutron/tests/unit/plugins/ml2/drivers/macvtap/agent/test_macvtap_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8a939a889d47890e5e2a738240dfb1ffc8e174ba","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_parse_interface_mappings_bad(self):"},{"line_number":186,"context_line":"        cfg.CONF.set_override(\u0027physical_interface_mappings\u0027, \u0027bad_mapping\u0027,"},{"line_number":187,"context_line":"                              \u0027macvtap\u0027)"},{"line_number":188,"context_line":"        with mock.patch.object(n_utils, \u0027parse_mappings\u0027,"},{"line_number":189,"context_line":"                               side_effect\u003dValueError(\u0027bad mapping\u0027)),\\"},{"line_number":190,"context_line":"            mock.patch.object(sys, \u0027exit\u0027) as mock_exit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_6d633bdd","side":"PARENT","line":187,"updated":"2016-08-16 09:27:10.000000000","message":"I don\u0027t think we want to get rid of this test over here. It was testing a different branch L186 of the interface parsing. They are two distinct exception paths so we should keep the old test in addition to the new one.","commit_id":"01a9d41ceb02ac43f8a4de1c719d2932dade4df2"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"28a754da9194631b31d99873519034134c6a89c9","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_parse_interface_mappings_bad(self):"},{"line_number":186,"context_line":"        cfg.CONF.set_override(\u0027physical_interface_mappings\u0027, \u0027bad_mapping\u0027,"},{"line_number":187,"context_line":"                              \u0027macvtap\u0027)"},{"line_number":188,"context_line":"        with mock.patch.object(n_utils, \u0027parse_mappings\u0027,"},{"line_number":189,"context_line":"                               side_effect\u003dValueError(\u0027bad mapping\u0027)),\\"},{"line_number":190,"context_line":"            mock.patch.object(sys, \u0027exit\u0027) as mock_exit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_d215fa49","side":"PARENT","line":187,"in_reply_to":"3ac371cc_6d633bdd","updated":"2016-08-24 13:10:14.000000000","message":"you\u0027re right, I\u0027ll fix it","commit_id":"01a9d41ceb02ac43f8a4de1c719d2932dade4df2"}],"releasenotes/notes/terminate-macvtap-agt-when-interface_mapping-not-present-3109faf3b44d366a.yaml":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4a1f920e88478d5203cf4f8543ae7e69dce5536d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    to start and use the macvtap agent."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - Bug #1587444"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_e35aa0f1","line":9,"updated":"2016-08-25 12:00:56.000000000","message":"you can delete the last line here","commit_id":"5b1e5539f956d158a9e409a85d787eb294b091b0"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"845b726a202b2123f8886da5559768623e813cb7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    to start and use the macvtap agent."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - Bug #1587444"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_51e09a96","line":9,"in_reply_to":"1ac06dbe_11c5823c","updated":"2016-08-25 12:36:02.000000000","message":"now it\u0027s working again ?! I\u0027ll upload it again","commit_id":"5b1e5539f956d158a9e409a85d787eb294b091b0"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9e7304c0c65de0f885a2371cecb2631a63d98545","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    to start and use the macvtap agent."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - Bug #1587444"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_11c5823c","line":9,"in_reply_to":"1ac06dbe_e35aa0f1","updated":"2016-08-25 12:33:22.000000000","message":"hhmm..if I do so, the docs verification fails","commit_id":"5b1e5539f956d158a9e409a85d787eb294b091b0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ef7c92c92df31ec44b8df8f9e0af12785d353ffb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - After upgrade, a macvtap agent without"},{"line_number":4,"context_line":"    a physical_interface_mapping configured can not"},{"line_number":5,"context_line":"    be started. Specify a valid mapping to be able"},{"line_number":6,"context_line":"    to start and use the macvtap agent."},{"line_number":7,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a3c09a3_626f89c5","line":4,"range":{"start_line":4,"start_character":6,"end_line":4,"end_character":32},"updated":"2017-01-16 16:44:57.000000000","message":"-\u003e ..._mappings","commit_id":"a2d42eac9a1a3f178ccce692dd948f0f0399f900"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6a88fc946d0797ffa01a2c86dfaf3f7368b8244b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    physical_interface_mappings configured can not"},{"line_number":5,"context_line":"    be started. Specify a valid mapping to be able"},{"line_number":6,"context_line":"    to start and use the macvtap agent."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - Bug #1587444"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a461143_0a43c96c","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":16},"updated":"2017-02-01 01:49:47.000000000","message":"no need for this section for \u0027simple bugs\u0027, it doesn\u0027t look good on the release notes.\n\nhttp://docs-draft.openstack.org/98/323398/6/check/gate-neutron-releasenotes/4849b9a//releasenotes/build/html/unreleased.html#bug-fixes","commit_id":"ae95556d29e4408eb2673c080d5cef21cd51fd7d"}]}
