)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"bf9686d1f81b5de58adf09993a0ecea1233a9bc1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"methd, and retrieve the schema helper in a different manner, or provide"},{"line_number":12,"context_line":"it to the Connection subclass in advance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This use-case came up in Dragonflow, where we wanted to retrieve"},{"line_number":15,"context_line":"specific columns within specific tables, and not the whole tables."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I634841a2402e5d9bcbf1983a17eee2bb1a6299fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_60664052","line":14,"updated":"2016-06-01 10:05:17.000000000","message":"If you will make use of the _get_schema_helper, may be you should declare it as a public function (without the _)","commit_id":"0fc355a7ce3f6c9ea326e5625284be4c154d2622"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"828e06315c8f0d482ff0026c28a8f5b57a4c3db5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"methd, and retrieve the schema helper in a different manner, or provide"},{"line_number":12,"context_line":"it to the Connection subclass in advance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This use-case came up in Dragonflow, where we wanted to retrieve"},{"line_number":15,"context_line":"specific columns within specific tables, and not the whole tables."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I634841a2402e5d9bcbf1983a17eee2bb1a6299fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_b1b87876","line":14,"in_reply_to":"9abb7d3a_60664052","updated":"2016-06-01 11:03:58.000000000","message":"Done","commit_id":"0fc355a7ce3f6c9ea326e5625284be4c154d2622"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"6bfbaa7993636e65b7c151453b5f8ec9c2fc0c7d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-05 08:13:40 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move the generation of the schema helper in OVSDB connection to a different method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the OVSDB connection class, move the code retrieving the schema"},{"line_number":10,"context_line":"helper to a separate method. This will allow subclasses to override this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_c98d79d4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":82},"updated":"2016-06-08 20:48:56.000000000","message":"This line is limited to 50 characters [1].\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"16536f81eab6994bb7cb55c21d1cfd3ec152ab74"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"89a9e05566db29e16f928322875b96ecd67c7259","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the OVSDB connection class, move the code retrieving the schema"},{"line_number":13,"context_line":"helper to a separate method. This will allow subclasses to override this"},{"line_number":14,"context_line":"methd, and retrieve the schema helper in a different manner, or provide"},{"line_number":15,"context_line":"it to the Connection subclass in advance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This use-case came up in Dragonflow, where we wanted to retrieve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa6399be_529e3f63","line":14,"updated":"2016-10-17 13:20:39.000000000","message":"nit: method","commit_id":"2bbe0f0a7c3ed5bb4a78ce24e973a7612ed27638"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3c76bc199f6fb2401f18b61da707b711b61552f3","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the OVSDB connection class, move the code retrieving the schema"},{"line_number":13,"context_line":"helper to a separate method. This will allow subclasses to override this"},{"line_number":14,"context_line":"methd, and retrieve the schema helper in a different manner, or provide"},{"line_number":15,"context_line":"it to the Connection subclass in advance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This use-case came up in Dragonflow, where we wanted to retrieve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa6399be_7a1f8eb7","line":14,"in_reply_to":"fa6399be_529e3f63","updated":"2016-10-17 17:41:29.000000000","message":"Done","commit_id":"2bbe0f0a7c3ed5bb4a78ce24e973a7612ed27638"}],"neutron/agent/ovsdb/native/connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ee21fe73e14668fe641d6d229183f69439bf890e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.thread.setDaemon(True)"},{"line_number":83,"context_line":"            self.thread.start()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_schema_helper(self, table_name_list):"},{"line_number":86,"context_line":"        \"\"\"Retrieve the schema helper object from OVSDB\"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_a8563803","line":85,"updated":"2016-06-01 15:30:28.000000000","message":"I think it would be better to leave most of this code in start() and just isolate the table/column registration in a separate method like:\n\n def update_schema_helper(self, helper):\n     ...\n\nand call it after the try/except block in the original code. Otherwise, you end up having to reimplement the retry logic etc when you override the get_schema_helper method.","commit_id":"10060158456a8996eb66834edfabe1733f954d02"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"209878649759bf018ac5f14c6eac9c28f0bd05f2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.thread.setDaemon(True)"},{"line_number":83,"context_line":"            self.thread.start()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_schema_helper(self, table_name_list):"},{"line_number":86,"context_line":"        \"\"\"Retrieve the schema helper object from OVSDB\"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_7c5c0e7d","line":85,"in_reply_to":"9abb7d3a_a8563803","updated":"2016-06-01 16:46:53.000000000","message":"Yes - it might be better to move the table registration code to another method (I\u0027ll do that). But isolating get_schema_helper in this way allows subclasses to e.g. provide the schema helper externally.","commit_id":"10060158456a8996eb66834edfabe1733f954d02"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"457d214bb48469cb1cdbda68f128057eee2a8135","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.thread.setDaemon(True)"},{"line_number":83,"context_line":"            self.thread.start()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_schema_helper(self, table_name_list):"},{"line_number":86,"context_line":"        \"\"\"Retrieve the schema helper object from OVSDB\"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_63552a4f","line":85,"updated":"2016-07-04 18:16:23.000000000","message":"is this meant to be a public method? if so please have specific unit tests for this new method. that was my original point.\n\nif you want to piggyback on existing code then change this to a private method with the prefix _","commit_id":"b7d935e793b63eb8feac1c891928e6f210552367"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"de780e0b3fcf9a01d1609bba0dc07532cc1d8a93","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.thread.setDaemon(True)"},{"line_number":83,"context_line":"            self.thread.start()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_schema_helper(self, table_name_list):"},{"line_number":86,"context_line":"        \"\"\"Retrieve the schema helper object from OVSDB\"\"\""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_e6ff68ff","line":85,"in_reply_to":"1aa78d24_63552a4f","updated":"2016-07-04 19:04:21.000000000","message":"Sorry, I misunderstood that the first time round. Will do.","commit_id":"b7d935e793b63eb8feac1c891928e6f210552367"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"457d214bb48469cb1cdbda68f128057eee2a8135","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            helpers.enable_connection_uri(self.connection)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            # There is a small window for a race, so retry up to a second"},{"line_number":95,"context_line":"            @retrying.retry(wait_exponential_multiplier\u003d10,"},{"line_number":96,"context_line":"                            stop_max_delay\u003d1000)"},{"line_number":97,"context_line":"            def do_get_schema_helper():"},{"line_number":98,"context_line":"                return idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_e3c75a10","line":95,"updated":"2016-07-04 18:16:23.000000000","message":"do you at least want to log what failed.","commit_id":"b7d935e793b63eb8feac1c891928e6f210552367"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"de780e0b3fcf9a01d1609bba0dc07532cc1d8a93","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            helpers.enable_connection_uri(self.connection)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            # There is a small window for a race, so retry up to a second"},{"line_number":95,"context_line":"            @retrying.retry(wait_exponential_multiplier\u003d10,"},{"line_number":96,"context_line":"                            stop_max_delay\u003d1000)"},{"line_number":97,"context_line":"            def do_get_schema_helper():"},{"line_number":98,"context_line":"                return idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_060d5437","line":95,"in_reply_to":"1aa78d24_e3c75a10","updated":"2016-07-04 19:04:21.000000000","message":"This code is the same as the original code - it is only moved. I will add the log in a separate patch.","commit_id":"b7d935e793b63eb8feac1c891928e6f210552367"},{"author":{"_account_id":18347,"name":"Itamar Ofek","email":"itamofek@netscape.net","username":"itamaro"},"change_message_id":"828215bb263092448561a2901e56855afe075a01","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            # There is a small window for a race, so retry up to a second"},{"line_number":95,"context_line":"            @retrying.retry(wait_exponential_multiplier\u003d10,"},{"line_number":96,"context_line":"                            stop_max_delay\u003d1000)"},{"line_number":97,"context_line":"            def do_get_schema_helper():"},{"line_number":98,"context_line":"                return idlutils.get_schema_helper(self.connection,"},{"line_number":99,"context_line":"                                                  self.schema_name)"},{"line_number":100,"context_line":"            helper \u003d do_get_schema_helper()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_89070317","line":97,"updated":"2016-07-27 12:44:04.000000000","message":"Please consider un-nesting this function (in additional patch)","commit_id":"31c275beb9e8b23609c6e837f56f01ad768af06c"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c7315190e8bb62bb009e039833c3dc334dcf6beb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            # There is a small window for a race, so retry up to a second"},{"line_number":95,"context_line":"            @retrying.retry(wait_exponential_multiplier\u003d10,"},{"line_number":96,"context_line":"                            stop_max_delay\u003d1000)"},{"line_number":97,"context_line":"            def do_get_schema_helper():"},{"line_number":98,"context_line":"                return idlutils.get_schema_helper(self.connection,"},{"line_number":99,"context_line":"                                                  self.schema_name)"},{"line_number":100,"context_line":"            helper \u003d do_get_schema_helper()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_172c5b01","line":97,"in_reply_to":"dada55a8_89070317","updated":"2016-07-28 16:24:05.000000000","message":"There is zero benefit to un-nesting this function. It exists solely to let one repeat this call using the retying library\u0027s decorator.","commit_id":"31c275beb9e8b23609c6e837f56f01ad768af06c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b59e3f9d5f2e8eb23a3bb78b6be0d65aaa817c42","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return helper"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def update_schema_helper(self, helper):"},{"line_number":108,"context_line":"        if self._schema_filter is None:"},{"line_number":109,"context_line":"            helper.register_all()"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            for table_name in self._schema_filter:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_aa697427","line":108,"range":{"start_line":108,"start_character":30,"end_line":108,"end_character":38},"updated":"2016-08-22 16:18:32.000000000","message":"Nit: Not needed.","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"89a9e05566db29e16f928322875b96ecd67c7259","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        return helper"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_schema_helper(self, helper):"},{"line_number":109,"context_line":"        if self._schema_filter is None:"},{"line_number":110,"context_line":"            helper.register_all()"},{"line_number":111,"context_line":"        else:"},{"line_number":112,"context_line":"            for table_name in self._schema_filter:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_f76e65fe","line":109,"updated":"2016-10-17 13:20:39.000000000","message":"Nit: Not needed (if you invert the if branch):\n\n    if self._schema_filter:\n        for table_name...\n    else: \n        helper.register_all()","commit_id":"2bbe0f0a7c3ed5bb4a78ce24e973a7612ed27638"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3c76bc199f6fb2401f18b61da707b711b61552f3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        return helper"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_schema_helper(self, helper):"},{"line_number":109,"context_line":"        if self._schema_filter is None:"},{"line_number":110,"context_line":"            helper.register_all()"},{"line_number":111,"context_line":"        else:"},{"line_number":112,"context_line":"            for table_name in self._schema_filter:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_1a8772d8","line":109,"in_reply_to":"fa6399be_f76e65fe","updated":"2016-10-17 17:41:29.000000000","message":"Done","commit_id":"2bbe0f0a7c3ed5bb4a78ce24e973a7612ed27638"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e237e166609c3cc1d013c782a4cb0d46d1a4b836","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                schema_helper will register all tables for given schema_name as"},{"line_number":72,"context_line":"                default."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        self._schema_filter \u003d table_name_list"},{"line_number":75,"context_line":"        with self.lock:"},{"line_number":76,"context_line":"            if self.idl is not None:"},{"line_number":77,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_e5d764bd","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":27},"updated":"2016-10-18 09:51:01.000000000","message":"why do you want to store it, rather than just passing it as another argument of update_schema_helper?","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"5f2f2ae6d7385c0ebe5bccac0add26d73a3a188d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                schema_helper will register all tables for given schema_name as"},{"line_number":72,"context_line":"                default."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        self._schema_filter \u003d table_name_list"},{"line_number":75,"context_line":"        with self.lock:"},{"line_number":76,"context_line":"            if self.idl is not None:"},{"line_number":77,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_cacdc4b8","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":27},"in_reply_to":"fa6399be_19d720c0","updated":"2016-10-19 17:04:16.000000000","message":"I am trying to think of an elegant way it can be done. I still want to come up with an API that makes sense both here, in review https://review.openstack.org/#/c/329031/ , and in the general case of class extension.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"dd53ee4a4891a045a06eb6a623fbe69e8f17849a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                schema_helper will register all tables for given schema_name as"},{"line_number":72,"context_line":"                default."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        self._schema_filter \u003d table_name_list"},{"line_number":75,"context_line":"        with self.lock:"},{"line_number":76,"context_line":"            if self.idl is not None:"},{"line_number":77,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_ca85c407","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":27},"in_reply_to":"fa6399be_19d720c0","updated":"2016-10-19 17:06:59.000000000","message":"If I remember correctly, he changed this because I told him that it should be stored on the connection way back in patch set 6. Omer has been very patient.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c956b22764590cfa726d32358b454d17aa25e6f1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                schema_helper will register all tables for given schema_name as"},{"line_number":72,"context_line":"                default."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        self._schema_filter \u003d table_name_list"},{"line_number":75,"context_line":"        with self.lock:"},{"line_number":76,"context_line":"            if self.idl is not None:"},{"line_number":77,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_19d720c0","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":27},"in_reply_to":"fa6399be_5077c63a","updated":"2016-10-19 16:15:46.000000000","message":"I second Yamamoto here. schema_filter should be an arg passed to update_schema_helper.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0998150a40e0938224a4559ff27909bc01983f72","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                schema_helper will register all tables for given schema_name as"},{"line_number":72,"context_line":"                default."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        self._schema_filter \u003d table_name_list"},{"line_number":75,"context_line":"        with self.lock:"},{"line_number":76,"context_line":"            if self.idl is not None:"},{"line_number":77,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_5077c63a","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":27},"in_reply_to":"fa6399be_c0224b01","updated":"2016-10-19 06:46:22.000000000","message":"i don\u0027t condider passing a value implicitly via self\u0027s attribute is simpler than having an explicit argument.\n\nalso, if you want to make it simple, why don\u0027t you hardcode table_name_list in update_schema_helper?","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"198dcda5927115ba8c18a5896f0cacb6ddf26bcd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                schema_helper will register all tables for given schema_name as"},{"line_number":72,"context_line":"                default."},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        self._schema_filter \u003d table_name_list"},{"line_number":75,"context_line":"        with self.lock:"},{"line_number":76,"context_line":"            if self.idl is not None:"},{"line_number":77,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_c0224b01","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":27},"in_reply_to":"fa6399be_e5d764bd","updated":"2016-10-18 11:13:21.000000000","message":"I wanted to keep update_schema_helper\u0027s API as simple as possible. Therefore, it gets only the helper.\n\nThis API also changes a lot on review https://review.openstack.org/#/c/329031/ , and I wanted to have something that is easily adaptable, and that allows me to easily keep the API the same.\n\nIn any case, I want to make sure that once these methods are merged, the API doesn\u0027t change. If _schema_list is a list now, and later we\u0027ll want it an filter-object instance (as you suggested in 329031), that would be an API change.\n\nThis is also one of the reasons _schema_filter is private. It is planned to change, and I don\u0027t want anyone using it.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c956b22764590cfa726d32358b454d17aa25e6f1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.thread.setDaemon(True)"},{"line_number":87,"context_line":"            self.thread.start()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_schema_helper(self):"},{"line_number":90,"context_line":"        \"\"\"Retrieve the schema helper object from OVSDB\"\"\""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_b4a55905","line":89,"updated":"2016-10-19 16:15:46.000000000","message":"should this method be private or you think it can be called by other classes? It doesn\u0027t seem so.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"5f2f2ae6d7385c0ebe5bccac0add26d73a3a188d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.thread.setDaemon(True)"},{"line_number":87,"context_line":"            self.thread.start()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_schema_helper(self):"},{"line_number":90,"context_line":"        \"\"\"Retrieve the schema helper object from OVSDB\"\"\""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_0a641ce3","line":89,"in_reply_to":"fa6399be_b4a55905","updated":"2016-10-19 17:04:16.000000000","message":"This method is planned to be overriden by other classes. That is why it is public.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c956b22764590cfa726d32358b454d17aa25e6f1","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        return helper"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_schema_helper(self, helper):"},{"line_number":109,"context_line":"        if self._schema_filter:"},{"line_number":110,"context_line":"            for table_name in self._schema_filter:"},{"line_number":111,"context_line":"                helper.register_table(table_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_7482e153","line":108,"updated":"2016-10-19 16:15:46.000000000","message":"ditto, maybe it should be private.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"5f2f2ae6d7385c0ebe5bccac0add26d73a3a188d","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        return helper"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_schema_helper(self, helper):"},{"line_number":109,"context_line":"        if self._schema_filter:"},{"line_number":110,"context_line":"            for table_name in self._schema_filter:"},{"line_number":111,"context_line":"                helper.register_table(table_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_2a63a0dd","line":108,"in_reply_to":"fa6399be_7482e153","updated":"2016-10-19 17:04:16.000000000","message":"This method is planned to be overriden by other classes. That is why it is public.","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"}],"neutron/tests/unit/agent/ovsdb/native/test_connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e113efedc3812eb55edeacf590552c83115d9ad3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestOVSNativeConnection, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _assert_by_table_name_list(self, table_name_list):"},{"line_number":32,"context_line":"        reg_all_called \u003d table_name_list is None"},{"line_number":33,"context_line":"        reg_table_called \u003d table_name_list is not None"},{"line_number":34,"context_line":"        self.assertEqual(reg_all_called, self.helper.register_all.called)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_6cfed839","line":31,"updated":"2016-08-12 16:37:07.000000000","message":"I commented here https://review.openstack.org/#/c/329031/3/neutron/tests/unit/agent/ovsdb/native/test_connection.py how I\u0027d prefer these tests be moved to functional tests. They could go in a new file named neutron/tests/functional/agent/ovsdb/native/test_connection.py","commit_id":"16be8cc817e336f80a304b296b40352b4af04ed9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"9fc529491cfd73d8d230f4c5d9a0d083b926de31","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestOVSNativeConnection, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _assert_by_table_name_list(self, table_name_list):"},{"line_number":32,"context_line":"        reg_all_called \u003d table_name_list is None"},{"line_number":33,"context_line":"        reg_table_called \u003d table_name_list is not None"},{"line_number":34,"context_line":"        self.assertEqual(reg_all_called, self.helper.register_all.called)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_fe5721c8","line":31,"in_reply_to":"9ad45d7e_6cfed839","updated":"2016-08-14 07:42:54.000000000","message":"@Terry, I agree that functional tests would be better, and I will add them as part of https://review.openstack.org/#/c/329031/ . I don\u0027t think they should be a part of this patch.","commit_id":"16be8cc817e336f80a304b296b40352b4af04ed9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b59e3f9d5f2e8eb23a3bb78b6be0d65aaa817c42","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(connection, \u0027TransactionQueue\u0027)"},{"line_number":58,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":59,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":60,"context_line":"    def test_start_call_graph(self, wait_for_change, idl, transaction_queue):"},{"line_number":61,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_6d5cb6ed","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":29},"updated":"2016-08-22 16:18:32.000000000","message":"I don\u0027t get the aim of this test. We mock a lots of things out just to test interaction between connections.start() calling to get_schema_helper() and passing whatever was returned from it into update_schema_helper().\n\nWhat does it add to the existing tests above?","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a1fb323134183546a2792a626af6d7ec9eb4e8c9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(connection, \u0027TransactionQueue\u0027)"},{"line_number":58,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":59,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":60,"context_line":"    def test_start_call_graph(self, wait_for_change, idl, transaction_queue):"},{"line_number":61,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_f9dce413","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":29},"in_reply_to":"1ac06dbe_4d61fa38","updated":"2016-08-22 17:05:23.000000000","message":"@Terry took the words out of my mouth. This test verifies that the API doesn\u0027t get broken - that both get_schema_helper and update_schema_helper are called.","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"27756b2c19ad34e633edc830bf893d484228d53c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(connection, \u0027TransactionQueue\u0027)"},{"line_number":58,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":59,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":60,"context_line":"    def test_start_call_graph(self, wait_for_change, idl, transaction_queue):"},{"line_number":61,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_8d8125c6","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":29},"in_reply_to":"1ac06dbe_4d91ed46","updated":"2016-08-22 20:00:31.000000000","message":"They test different things. L42 verifies the expected behaviour of registering tables and columns on the helper.\n\nThis test verifies the API works correctly, i.e. the two (overridable) methods get_schema_helper and update_schema_helper are being called.","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a1f48c3c086a070ae23955122490568d12bbcdb8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(connection, \u0027TransactionQueue\u0027)"},{"line_number":58,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":59,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":60,"context_line":"    def test_start_call_graph(self, wait_for_change, idl, transaction_queue):"},{"line_number":61,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_4d61fa38","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":29},"in_reply_to":"1ac06dbe_6d5cb6ed","updated":"2016-08-22 16:23:08.000000000","message":"I think the idea is to just ensure that the API doesn\u0027t get broken. Basically, that if someone subclasses Connection and provides their own update_schema_helper(), that start does actually call it.","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"25d28068a6091933fafe88b8d118dd0778c20000","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(connection, \u0027TransactionQueue\u0027)"},{"line_number":58,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":59,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":60,"context_line":"    def test_start_call_graph(self, wait_for_change, idl, transaction_queue):"},{"line_number":61,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_eb96a5ee","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":29},"in_reply_to":"1ac06dbe_8d8125c6","updated":"2016-08-23 09:05:32.000000000","message":"Omer explained me on IRC that they want to override update_schema_helper in dragonflow so they don\u0027t need to re-impement start() instead. I\u0027m still not sure why this interaction is needed instead of just aiming test on the result, but I don\u0027t want to block :)","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"39817963f9325f4ba7f450f420a2b5ce37a999f3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(connection, \u0027TransactionQueue\u0027)"},{"line_number":58,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":59,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":60,"context_line":"    def test_start_call_graph(self, wait_for_change, idl, transaction_queue):"},{"line_number":61,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_4d91ed46","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":29},"in_reply_to":"1ac06dbe_f9dce413","updated":"2016-08-22 19:56:12.000000000","message":"I still don\u0027t get it. How is it different from L42 ?","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"25d28068a6091933fafe88b8d118dd0778c20000","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":60,"context_line":"    def test_start_call_graph(self, wait_for_change, idl, transaction_queue):"},{"line_number":61,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"},{"line_number":64,"context_line":"        self.connection.get_schema_helper \u003d mock.Mock()"},{"line_number":65,"context_line":"        self.connection.get_schema_helper.return_value \u003d helper"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_0b86a1da","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":49},"updated":"2016-08-23 09:05:32.000000000","message":"Given that Idl is mocked out, all of these Mock() objects can be sentinels instead: e.g. mock.sentinel.connection or just object()","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"25d28068a6091933fafe88b8d118dd0778c20000","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            mock.Mock(), mock.Mock(), mock.Mock())"},{"line_number":63,"context_line":"        helper \u003d mock.Mock()"},{"line_number":64,"context_line":"        self.connection.get_schema_helper \u003d mock.Mock()"},{"line_number":65,"context_line":"        self.connection.get_schema_helper.return_value \u003d helper"},{"line_number":66,"context_line":"        self.connection.update_schema_helper \u003d mock.Mock()"},{"line_number":67,"context_line":"        with mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":68,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_cb0ac989","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":63},"updated":"2016-08-23 09:05:32.000000000","message":"Nit: If you\u0027d swap this, you can get rid of line 63:\n\n helper \u003d self.connection.get_schema_helper.return_value","commit_id":"6877a2291894b8b895a81aed9ec0e33025a771a7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c956b22764590cfa726d32358b454d17aa25e6f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":64,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":65,"context_line":"            self.connection.start()"},{"line_number":66,"context_line":"        self.connection.get_schema_helper.assert_called_once_with()"},{"line_number":67,"context_line":"        self.connection.update_schema_helper.assert_called_once_with(helper)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_transaction_queue_init(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_b4f39909","line":66,"updated":"2016-10-19 16:15:46.000000000","message":"this test basically tests that get_schema_helper and update_schema_helper are called, right? Or am I missing something? What\u0027s the value of it? Maybe you can add a test that checks that update_schema_helper works as expected when having table_name_list\u003dNone and when having table_name_list !\u003d None","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"5f2f2ae6d7385c0ebe5bccac0add26d73a3a188d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":64,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":65,"context_line":"            self.connection.start()"},{"line_number":66,"context_line":"        self.connection.get_schema_helper.assert_called_once_with()"},{"line_number":67,"context_line":"        self.connection.update_schema_helper.assert_called_once_with(helper)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_transaction_queue_init(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_0af5fcc9","line":66,"in_reply_to":"fa6399be_b4f39909","updated":"2016-10-19 17:04:16.000000000","message":"You are not missing anything, this is the goal of the test. Since these methods were written with subclasses overriding them in mind, I wanted a test that verifies this methods are called, i.e. changes to start won\u0027t break subclasses expecting create_schema_helper and update_schema_helper to be called.\n\nA test for different calling conventions (with table_name_list, without table_name_list) can be found in line 47 and 50. Additionally, I have added functional tests in this review: https://review.openstack.org/#/c/355943/","commit_id":"426408359951eadcbbcfe483622e0e95db8ea8da"}]}
