)]}'
{"quantum/plugins/nicira/nvplib.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"891ac3dadfe0382d37442c4eee5e375067066cbd","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"                                 http_uri,"},{"line_number":1409,"context_line":"                                 cluster\u003dcluster)"},{"line_number":1410,"context_line":"    except Exception as e:"},{"line_number":1411,"context_line":"        msg \u003d (\"Error \u0027%s\u0027 when connecting to controller(s): %s.\""},{"line_number":1412,"context_line":"               % (str(e), \u0027, \u0027.join(cluster.nvp_controllers)))"},{"line_number":1413,"context_line":"        raise Exception(msg)"},{"line_number":1414,"context_line":"    return json.loads(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fsrc%3D","line":1411,"updated":"2013-06-12 15:36:54.000000000","message":"do you need the i18n format here:\nmsg \u003d _(...)\nIf so then there should also be dictionary values for the parameters.","commit_id":"7920bd9f882d99d12379a47d6c5569fdf15f7074"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":1408,"context_line":"                                 http_uri,"},{"line_number":1409,"context_line":"                                 cluster\u003dcluster)"},{"line_number":1410,"context_line":"    except Exception as e:"},{"line_number":1411,"context_line":"        msg \u003d (\"Error \u0027%s\u0027 when connecting to controller(s): %s.\""},{"line_number":1412,"context_line":"               % (str(e), \u0027, \u0027.join(cluster.nvp_controllers)))"},{"line_number":1413,"context_line":"        raise Exception(msg)"},{"line_number":1414,"context_line":"    return json.loads(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F%2BxQ%3D","line":1411,"in_reply_to":"AAAAPX%2F%2FsCg%3D","updated":"2013-06-15 22:39:12.000000000","message":"I reckon the approach of fixing the string when a patch alters it (or the code nearby) works well.\n\nThen, at some point, all the remaining i18n fixes can be pushed separately. This kind of patch is super easy altough a bit boring; the real downsides is that it usually causes a conflict-storm in all related patches.","commit_id":"7920bd9f882d99d12379a47d6c5569fdf15f7074"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"656d3877bfd4547f1e0753c89be0447120c30546","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"                                 http_uri,"},{"line_number":1409,"context_line":"                                 cluster\u003dcluster)"},{"line_number":1410,"context_line":"    except Exception as e:"},{"line_number":1411,"context_line":"        msg \u003d (\"Error \u0027%s\u0027 when connecting to controller(s): %s.\""},{"line_number":1412,"context_line":"               % (str(e), \u0027, \u0027.join(cluster.nvp_controllers)))"},{"line_number":1413,"context_line":"        raise Exception(msg)"},{"line_number":1414,"context_line":"    return json.loads(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FsCg%3D","line":1411,"in_reply_to":"AAAAPX%2F%2Fsnc%3D","updated":"2013-06-12 19:09:04.000000000","message":"I think it makes sense for new code to have proper i18n support.  We can have a follow on patch to clean up the few places that are not properly internationalized.","commit_id":"7920bd9f882d99d12379a47d6c5569fdf15f7074"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1408,"context_line":"                                 http_uri,"},{"line_number":1409,"context_line":"                                 cluster\u003dcluster)"},{"line_number":1410,"context_line":"    except Exception as e:"},{"line_number":1411,"context_line":"        msg \u003d (\"Error \u0027%s\u0027 when connecting to controller(s): %s.\""},{"line_number":1412,"context_line":"               % (str(e), \u0027, \u0027.join(cluster.nvp_controllers)))"},{"line_number":1413,"context_line":"        raise Exception(msg)"},{"line_number":1414,"context_line":"    return json.loads(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fsnc%3D","line":1411,"in_reply_to":"AAAAPX%2F%2Fsrc%3D","updated":"2013-06-12 16:00:10.000000000","message":"Can do, even though there are so many places in this library that are not i18n-ized that I wonder whether this would need a different patch altogether.","commit_id":"7920bd9f882d99d12379a47d6c5569fdf15f7074"}]}
