)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"6ffc54f49c24515e79378d4e6efe8acd97f1b16f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update of shared QoS policy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_afc42a92","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":44},"updated":"2016-06-06 10:58:20.000000000","message":"globally shared","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"6ffc54f49c24515e79378d4e6efe8acd97f1b16f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update of shared QoS policy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_8f932ea3","line":9,"range":{"start_line":9,"start_character":71,"end_line":9,"end_character":77},"updated":"2016-06-06 10:58:20.000000000","message":"linebreak","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"6ffc54f49c24515e79378d4e6efe8acd97f1b16f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update of shared QoS policy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_0f873e62","line":9,"range":{"start_line":9,"start_character":67,"end_line":9,"end_character":68},"updated":"2016-06-06 10:58:20.000000000","message":"s/mark/marked","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"30c63102b646389772bc0dfe0dcb2e33b2107343","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update of shared QoS policy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_63ab5dd7","line":9,"range":{"start_line":9,"start_character":67,"end_line":9,"end_character":68},"in_reply_to":"7aa08908_0f873e62","updated":"2016-06-06 21:08:46.000000000","message":"Done","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"30c63102b646389772bc0dfe0dcb2e33b2107343","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update of shared QoS policy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_c3ba1123","line":9,"range":{"start_line":9,"start_character":71,"end_line":9,"end_character":77},"in_reply_to":"7aa08908_8f932ea3","updated":"2016-06-06 21:08:46.000000000","message":"Done","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"30c63102b646389772bc0dfe0dcb2e33b2107343","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update of shared QoS policy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_a3b54532","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":44},"in_reply_to":"7aa08908_afc42a92","updated":"2016-06-06 21:08:46.000000000","message":"Done","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"6ffc54f49c24515e79378d4e6efe8acd97f1b16f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c59e71eae0bf2e73475bba321afc4aaa514b317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_0fee1e22","line":11,"range":{"start_line":11,"start_character":73,"end_line":11,"end_character":75},"updated":"2016-06-06 10:58:20.000000000","message":"linebreak","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"30c63102b646389772bc0dfe0dcb2e33b2107343","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user updates QoS policy which is shared, it will be still mark as shared"},{"line_number":10,"context_line":"even if this flag will not be set explicitly in update request."},{"line_number":11,"context_line":"For example update description of QoS policy will not change shared flag to"},{"line_number":12,"context_line":"default value which is \"False\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c59e71eae0bf2e73475bba321afc4aaa514b317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_8397698f","line":11,"range":{"start_line":11,"start_character":73,"end_line":11,"end_character":75},"in_reply_to":"7aa08908_0fee1e22","updated":"2016-06-06 21:08:46.000000000","message":"Done","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"}],"neutron/objects/rbac_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5670533306c380cbeb3225f3f6c10df2e3075634","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def _update_post(self):"},{"line_number":208,"context_line":"    self.update_shared(self.shared, self.id)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"def update_pre(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_6ebd4f02","line":208,"updated":"2016-06-09 09:52:33.000000000","message":"Why do we even trigger update_shared() here in case self.shared is not set?","commit_id":"8e72d4c526c8db32558920313f87951bf40a416c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7569528ccec718d9cf47470bb237366764699c21","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def _update_post(self):"},{"line_number":208,"context_line":"    self.update_shared(self.shared, self.id)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"def update_pre(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_ae029770","line":208,"in_reply_to":"7aa08908_0e912b53","updated":"2016-06-09 09:57:14.000000000","message":"self.obj_get_changes()?","commit_id":"8e72d4c526c8db32558920313f87951bf40a416c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a73f39095a56de30ccd6ed38227d78d4e7b4fc7e","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def _update_post(self):"},{"line_number":208,"context_line":"    self.update_shared(self.shared, self.id)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"def update_pre(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0e912b53","line":208,"in_reply_to":"7aa08908_6ebd4f02","updated":"2016-06-09 09:55:01.000000000","message":"Problem is that if shared has got \"default\u003dFalse\" then self.shared is always defined here.\nHow You want to check if it was set (updated) by user or set default value? :/","commit_id":"8e72d4c526c8db32558920313f87951bf40a416c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8b2ce104653db39c0fc6f9fcc7514e7cfb60a84a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    self.update_shared(self.shared, self.id)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"def update_pre(self):"},{"line_number":212,"context_line":"    if hasattr(self, \u0027shared\u0027):"},{"line_number":213,"context_line":"        return"},{"line_number":214,"context_line":"    ctx \u003d self._context"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_67e17efe","line":211,"updated":"2016-06-07 12:47:19.000000000","message":"is there a unit test for this new method?","commit_id":"8e72d4c526c8db32558920313f87951bf40a416c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f9a989ee162100b1426679a85047af5a0e9ea287","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    self.update_shared(self.shared, self.id)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"def update_pre(self):"},{"line_number":212,"context_line":"    if hasattr(self, \u0027shared\u0027):"},{"line_number":213,"context_line":"        return"},{"line_number":214,"context_line":"    ctx \u003d self._context"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_63b3c40a","line":211,"in_reply_to":"7aa08908_67e17efe","updated":"2016-06-08 20:10:16.000000000","message":"Not yet. I will try to add such ASAP","commit_id":"8e72d4c526c8db32558920313f87951bf40a416c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f9a989ee162100b1426679a85047af5a0e9ea287","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def _update_hook(self, update_orig):"},{"line_number":219,"context_line":"    with db_api.autonested_transaction(self._context.session):"},{"line_number":220,"context_line":"        update_pre(self)"},{"line_number":221,"context_line":"        update_orig(self)"},{"line_number":222,"context_line":"        _update_post(self)"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_030ac089","line":220,"updated":"2016-06-08 20:10:16.000000000","message":"Haim Daniel: I\u0027m not sure if it is good solution. It can works only if object\u0027s shared attribute don\u0027t have default value. But then we required from all users of rbac_db class to set shared attribute always.\nEven in rbac_db unit tests fake object has got shared(default\u003dFalse) and without that some tests are failing.","commit_id":"8e72d4c526c8db32558920313f87951bf40a416c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c86df24d9f8e568c0bba1d45c8f88da6ab4a925c","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def _update_hook(self, update_orig):"},{"line_number":213,"context_line":"    with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":214,"context_line":"        shared_was_changed \u003d (\"shared\" in self.obj_get_changes())"},{"line_number":215,"context_line":"        update_orig(self)"},{"line_number":216,"context_line":"        _update_post(self, shared_was_changed)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_d7b7b6f3","line":214,"updated":"2016-06-09 10:49:06.000000000","message":"Why not detecting it where it is actually used, in _update_post?","commit_id":"d86302a3920fcab6f4e390a08508ff6555c61e95"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c2587910aff82b4e594e8e8a2c864328510c9eca","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def _update_hook(self, update_orig):"},{"line_number":213,"context_line":"    with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":214,"context_line":"        shared_was_changed \u003d (\"shared\" in self.obj_get_changes())"},{"line_number":215,"context_line":"        update_orig(self)"},{"line_number":216,"context_line":"        _update_post(self, shared_was_changed)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_17fe5e38","line":214,"in_reply_to":"7aa08908_17501e5e","updated":"2016-06-09 10:55:28.000000000","message":"Ah right. that\u0027s because update() will reset all changes on the object. Still, there is no much reason to pass it as an argument and not applying it right away here to decide if to execute _update_post.","commit_id":"d86302a3920fcab6f4e390a08508ff6555c61e95"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c5feb772ff7283c33baff07fcfb09a76db932cab","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def _update_hook(self, update_orig):"},{"line_number":213,"context_line":"    with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":214,"context_line":"        shared_was_changed \u003d (\"shared\" in self.obj_get_changes())"},{"line_number":215,"context_line":"        update_orig(self)"},{"line_number":216,"context_line":"        _update_post(self, shared_was_changed)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_2278762b","line":214,"in_reply_to":"7aa08908_17fe5e38","updated":"2016-06-09 11:07:46.000000000","message":"Yes, I can do this but I thougt that \"_update_post\" is lets say \"more generic\" function and maybe some other things might be done there. Those changes could be independent from shared attribute so I\u0027m not sure if it is best idea to call \"update_post\" only if there is change of shared attribute.\n\nMaybe it could be done but with calling \"self.update_shared() directly in _update_hook function. What You think?","commit_id":"d86302a3920fcab6f4e390a08508ff6555c61e95"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a8375392dd28aa78c8aa6222876b5d883523b958","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def _update_hook(self, update_orig):"},{"line_number":213,"context_line":"    with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":214,"context_line":"        shared_was_changed \u003d (\"shared\" in self.obj_get_changes())"},{"line_number":215,"context_line":"        update_orig(self)"},{"line_number":216,"context_line":"        _update_post(self, shared_was_changed)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_7d1ce36a","line":214,"in_reply_to":"7aa08908_2278762b","updated":"2016-06-09 11:14:34.000000000","message":"I think if you want to keep that method agnostic to shared handling, then you should pass all changes as an argument, not just shared.","commit_id":"d86302a3920fcab6f4e390a08508ff6555c61e95"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5878db4c1fd03686f0218a07773625c8414ed1a6","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def _update_hook(self, update_orig):"},{"line_number":213,"context_line":"    with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":214,"context_line":"        shared_was_changed \u003d (\"shared\" in self.obj_get_changes())"},{"line_number":215,"context_line":"        update_orig(self)"},{"line_number":216,"context_line":"        _update_post(self, shared_was_changed)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_5d45a7b1","line":214,"in_reply_to":"7aa08908_7d1ce36a","updated":"2016-06-09 11:26:07.000000000","message":"Ok. I changed it. I hope now it\u0027s better for You.","commit_id":"d86302a3920fcab6f4e390a08508ff6555c61e95"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c29c9237894ddce13d327101c9f934cf7b677c73","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def _update_hook(self, update_orig):"},{"line_number":213,"context_line":"    with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":214,"context_line":"        shared_was_changed \u003d (\"shared\" in self.obj_get_changes())"},{"line_number":215,"context_line":"        update_orig(self)"},{"line_number":216,"context_line":"        _update_post(self, shared_was_changed)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_17501e5e","line":214,"in_reply_to":"7aa08908_d7b7b6f3","updated":"2016-06-09 10:52:51.000000000","message":"I wanted but there was some problem with this and one of API tests was failing\nFor example if I updated policy only with changing \"shared\" attribute then it was fine (neutron qos-policy-update \u003cpolicy_id\u003e --shared\") but if I do the same but also with change of descriotion (neutron qos-policy-update \u003cpolicy_id\u003e --shared\" --description \"new desc\") then after \"update_orig\" was called method \"self.obj_get_changes()\" returns me empty dict always.","commit_id":"d86302a3920fcab6f4e390a08508ff6555c61e95"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"6ffc54f49c24515e79378d4e6efe8acd97f1b16f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        policy_data \u003d policy[\u0027policy\u0027]"},{"line_number":70,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, id\u003dpolicy_id)"},{"line_number":71,"context_line":"        if \"shared\" not in policy_data.keys():"},{"line_number":72,"context_line":"            policy_data[\u0027shared\u0027] \u003d policy_obj.to_dict().get(\u0027shared\u0027)"},{"line_number":73,"context_line":"        policy_obj.update_nonidentifying_fields(policy_data,"},{"line_number":74,"context_line":"                                                reset_changes\u003dTrue)"},{"line_number":75,"context_line":"        policy_obj.update()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cf48965e","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":70},"updated":"2016-06-06 10:58:20.000000000","message":"IMO that\u0027s not the spot for fixing it. The business logic for shared property is located under neutron.objects.rbac_db.py, and is supposed to serve neutron objects switching to shared logic all together.","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"30c63102b646389772bc0dfe0dcb2e33b2107343","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        policy_data \u003d policy[\u0027policy\u0027]"},{"line_number":70,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, id\u003dpolicy_id)"},{"line_number":71,"context_line":"        if \"shared\" not in policy_data.keys():"},{"line_number":72,"context_line":"            policy_data[\u0027shared\u0027] \u003d policy_obj.to_dict().get(\u0027shared\u0027)"},{"line_number":73,"context_line":"        policy_obj.update_nonidentifying_fields(policy_data,"},{"line_number":74,"context_line":"                                                reset_changes\u003dTrue)"},{"line_number":75,"context_line":"        policy_obj.update()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_26d5e3b8","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":70},"in_reply_to":"7aa08908_cf48965e","updated":"2016-06-06 21:08:46.000000000","message":"I\u0027m not an expert in RBAC but from what I checked this rbac_db library is changing shared attribut if it is given in \"update_fields\" dictionary. In this case it isn\u0027t and then QoSPolicy object is setting it as False because it is default value. IMHO it is not possible to change it there. Maybe we can remove default value from field definitiin in QoSPolicy object but I still think that this solution is better.\n\nMaybe You know where I could change it in rbac_db.py lib? I would be grateful for any help on that :)","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a2c77c3bd4cd9d50477ec16ade5b09c77e6f9e95","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        retrieved_policy \u003d self.admin_client.show_qos_policy(policy[\u0027id\u0027])"},{"line_number":87,"context_line":"        retrieved_policy \u003d retrieved_policy[\u0027policy\u0027]"},{"line_number":88,"context_line":"        self.assertTrue(retrieved_policy[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.idempotent_id(\u00271cb42653-54bd-4a9a-b888-c55e18199201\u0027)"},{"line_number":91,"context_line":"    def test_delete_policy(self):"},{"line_number":92,"context_line":"        policy \u003d self.admin_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_bc20ea4a","line":89,"updated":"2016-06-06 10:47:22.000000000","message":"I think it makes sense to add a couple of extra lines here to run update_qos_policy with an explicit shared\u003dFalse, and then assertFalse(retrieved_policy[\u0027shared\u0027]).  That way we have ensured that the explicit setting of False still works.  That way we can ensure that if this gets updated in the future we are properly testing all three possible values for \u0027shared\u0027: setting True, setting False, and not setting.","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"30c63102b646389772bc0dfe0dcb2e33b2107343","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        retrieved_policy \u003d self.admin_client.show_qos_policy(policy[\u0027id\u0027])"},{"line_number":87,"context_line":"        retrieved_policy \u003d retrieved_policy[\u0027policy\u0027]"},{"line_number":88,"context_line":"        self.assertTrue(retrieved_policy[\u0027shared\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @test.idempotent_id(\u00271cb42653-54bd-4a9a-b888-c55e18199201\u0027)"},{"line_number":91,"context_line":"    def test_delete_policy(self):"},{"line_number":92,"context_line":"        policy \u003d self.admin_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_034ed96e","line":89,"in_reply_to":"7aa08908_bc20ea4a","updated":"2016-06-06 21:08:46.000000000","message":"Done","commit_id":"bcdaf747de9959f2f60e5373c317ceef9f1781df"}]}
