)]}'
{"neutron/db/migration/__init__.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4063c393556f1fae3d7b3bd2a9b385e756960525","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    NEWTON,"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CREATION_OPERATIONS \u003d (sa.sql.ddl.CreateIndex,"},{"line_number":39,"context_line":"                       sa.sql.ddl.CreateTable,"},{"line_number":40,"context_line":"                       sa.sql.ddl.CreateColumn,"},{"line_number":41,"context_line":"                       )"},{"line_number":42,"context_line":"DROP_OPERATIONS \u003d (sa.sql.ddl.DropConstraint,"},{"line_number":43,"context_line":"                   sa.sql.ddl.DropIndex,"},{"line_number":44,"context_line":"                   sa.sql.ddl.DropTable,"},{"line_number":45,"context_line":"                   alembic.ddl.base.DropColumn)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def skip_if_offline(func):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_713fdc25","side":"PARENT","line":45,"range":{"start_line":38,"start_character":0,"end_line":45,"end_character":47},"updated":"2016-06-06 02:16:58.000000000","message":"I moved these out of here to the test module because I don\u0027t want external projects depending on them.","commit_id":"578e41216ceba596903a55e7675b9ec20be1349e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f6e4ecaa5a2c9cf79d01dd9880c230514e9208a9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    NEWTON,"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CREATION_OPERATIONS \u003d (sa.sql.ddl.CreateIndex,"},{"line_number":39,"context_line":"                       sa.sql.ddl.CreateTable,"},{"line_number":40,"context_line":"                       sa.sql.ddl.CreateColumn,"},{"line_number":41,"context_line":"                       )"},{"line_number":42,"context_line":"DROP_OPERATIONS \u003d (sa.sql.ddl.DropConstraint,"},{"line_number":43,"context_line":"                   sa.sql.ddl.DropIndex,"},{"line_number":44,"context_line":"                   sa.sql.ddl.DropTable,"},{"line_number":45,"context_line":"                   alembic.ddl.base.DropColumn)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def skip_if_offline(func):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2c8c617e","side":"PARENT","line":45,"range":{"start_line":38,"start_character":0,"end_line":45,"end_character":47},"in_reply_to":"7aa08908_713fdc25","updated":"2016-06-07 18:58:29.000000000","message":"Another reason is that it isn\u0027t needed anywhere outside of test code.","commit_id":"578e41216ceba596903a55e7675b9ec20be1349e"}],"neutron/db/migration/alembic_migrations/versions/newton/contract/c879c5e1ee90_add_segment_id_to_subnet.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a63be2ad6b49be2e83dfa3936779cc36cddd247d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def contract_creation_exceptions():"},{"line_number":34,"context_line":"    \"\"\"The networksegments table was renamed in the contract branch.\"\"\""},{"line_number":35,"context_line":"    return {"},{"line_number":36,"context_line":"        sa.Column: [\u0027subnets.segment_id\u0027]"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_58909543","line":34,"updated":"2016-06-13 01:29:09.000000000","message":"A rename is a contract operation. There is no way old code can deal with a column disappearing so running a rename in the expand phase would break everything. Am I missing something?","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"596372124da325e03315fa1f607482a27b3278ba","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def contract_creation_exceptions():"},{"line_number":34,"context_line":"    \"\"\"The networksegments table was renamed in the contract branch.\"\"\""},{"line_number":35,"context_line":"    return {"},{"line_number":36,"context_line":"        sa.Column: [\u0027subnets.segment_id\u0027]"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_73df723a","line":34,"in_reply_to":"7aa08908_58909543","updated":"2016-06-13 02:34:36.000000000","message":"Ideally a column would be added in an expand migration. This docstring is explaining why this particular column is being added in a contract migration. The reason is because the column is being added to a table that was renamed in a contract migration, and an expand expand migration cannot depend on a contract migration.\n\nShould I clarify the docstring some more?","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"387f33d901e567855c4e226af7050301236bebeb","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def contract_creation_exceptions():"},{"line_number":34,"context_line":"    \"\"\"The networksegments table was renamed in the contract branch.\"\"\""},{"line_number":35,"context_line":"    return {"},{"line_number":36,"context_line":"        sa.Column: [\u0027subnets.segment_id\u0027]"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_ccf480f2","line":34,"in_reply_to":"7aa08908_73df723a","updated":"2016-06-14 12:23:57.000000000","message":"I think yes, this should be clarified","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"63f5c7ae0a2cd67fff1f797681b0a76c6409c0c7","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def contract_creation_exceptions():"},{"line_number":34,"context_line":"    \"\"\"The networksegments table was renamed in the contract branch.\"\"\""},{"line_number":35,"context_line":"    return {"},{"line_number":36,"context_line":"        sa.Column: [\u0027subnets.segment_id\u0027]"},{"line_number":37,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0ebb07c5","line":34,"in_reply_to":"7aa08908_ccf480f2","updated":"2016-06-14 16:54:34.000000000","message":"Done","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"}],"neutron/tests/functional/db/test_migrations.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f6e4ecaa5a2c9cf79d01dd9880c230514e9208a9","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            script \u003d alembic_script.ScriptDirectory.from_config("},{"line_number":193,"context_line":"                self.alembic_config)"},{"line_number":194,"context_line":"            for m in list(script.walk_revisions(base\u003d\u0027base\u0027, head\u003d\u0027heads\u0027)):"},{"line_number":195,"context_line":"                branches \u003d m.branch_labels or [None]"},{"line_number":196,"context_line":"                if migration.CONTRACT_BRANCH in branches:"},{"line_number":197,"context_line":"                    method_name \u003d \u0027contract_creation_exceptions\u0027"},{"line_number":198,"context_line":"                    exceptions_dict \u003d creation_exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4c19ed21","side":"PARENT","line":195,"range":{"start_line":195,"start_character":47,"end_line":195,"end_character":51},"updated":"2016-06-07 18:58:29.000000000","message":"I always wondered about that None.  :)","commit_id":"578e41216ceba596903a55e7675b9ec20be1349e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4063c393556f1fae3d7b3bd2a9b385e756960525","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        def is_allowed(clauseelement, exceptions, disallowed_ops):"},{"line_number":257,"context_line":"            if (isinstance(clauseelement, disallowed_ops[\u0027sqla\u0027]) and"},{"line_number":258,"context_line":"                    hasattr(clauseelement, \u0027element\u0027)):"},{"line_number":259,"context_line":"                return is_excepted_sqla(clauseelement, exceptions)"},{"line_number":260,"context_line":"            if isinstance(clauseelement, disallowed_ops[\u0027alembic\u0027]):"},{"line_number":261,"context_line":"                return is_excepted_alembic(clauseelement, exceptions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_318394ce","line":258,"range":{"start_line":258,"start_character":20,"end_line":258,"end_character":53},"updated":"2016-06-06 02:16:58.000000000","message":"Perhaps this check is no longer needed?","commit_id":"b637ed6581a2eeefaef353e324f7c006932c57c7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a63be2ad6b49be2e83dfa3936779cc36cddd247d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"CREATION_OPERATIONS \u003d {"},{"line_number":49,"context_line":"    \u0027sqla\u0027: (sqla_ddl.CreateIndex,"},{"line_number":50,"context_line":"             sqla_ddl.CreateTable,"},{"line_number":51,"context_line":"             sqla_ddl.CreateColumn,"},{"line_number":52,"context_line":"             ),"},{"line_number":53,"context_line":"    \u0027alembic\u0027: (alembic_ddl.AddColumn,"},{"line_number":54,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_58b7f5d7","line":51,"updated":"2016-06-13 01:29:09.000000000","message":"CreateColumn is is a contract operation if it is non-nullable. Old code will cease to function if it\u0027s not populating non-nullable fields.","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"596372124da325e03315fa1f607482a27b3278ba","unresolved":false,"context_lines":[{"line_number":48,"context_line":"CREATION_OPERATIONS \u003d {"},{"line_number":49,"context_line":"    \u0027sqla\u0027: (sqla_ddl.CreateIndex,"},{"line_number":50,"context_line":"             sqla_ddl.CreateTable,"},{"line_number":51,"context_line":"             sqla_ddl.CreateColumn,"},{"line_number":52,"context_line":"             ),"},{"line_number":53,"context_line":"    \u0027alembic\u0027: (alembic_ddl.AddColumn,"},{"line_number":54,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f3eb62da","line":51,"in_reply_to":"7aa08908_58b7f5d7","updated":"2016-06-13 02:34:36.000000000","message":"OK, this will have to be addressed in a follow-up patch, since this patch is only about Add/DropColumn.","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a63be2ad6b49be2e83dfa3936779cc36cddd247d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"DROP_OPERATIONS \u003d {"},{"line_number":58,"context_line":"    \u0027sqla\u0027: (sqla_ddl.DropConstraint,"},{"line_number":59,"context_line":"             sqla_ddl.DropIndex,"},{"line_number":60,"context_line":"             sqla_ddl.DropTable,"},{"line_number":61,"context_line":"             ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_380ae98a","line":58,"updated":"2016-06-13 01:29:09.000000000","message":"I\u0027m not sure dropping a constraint should be restricted to a contract operation. Old code will still continue to function if a constraint is not present unless it was explicitly depending on it for duplicate detection or something. It seems like these would need to be evaluated on a case-by-case basis.","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"596372124da325e03315fa1f607482a27b3278ba","unresolved":false,"context_lines":[{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"DROP_OPERATIONS \u003d {"},{"line_number":58,"context_line":"    \u0027sqla\u0027: (sqla_ddl.DropConstraint,"},{"line_number":59,"context_line":"             sqla_ddl.DropIndex,"},{"line_number":60,"context_line":"             sqla_ddl.DropTable,"},{"line_number":61,"context_line":"             ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_73b652fa","line":58,"in_reply_to":"7aa08908_380ae98a","updated":"2016-06-13 02:34:36.000000000","message":"OK. But I am leaning towards keeping the restriction and using the \"is_allowed()\" mechanism below to tag drop constraints in expand operations when we know they are safe.","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a63be2ad6b49be2e83dfa3936779cc36cddd247d","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"DROP_OPERATIONS \u003d {"},{"line_number":58,"context_line":"    \u0027sqla\u0027: (sqla_ddl.DropConstraint,"},{"line_number":59,"context_line":"             sqla_ddl.DropIndex,"},{"line_number":60,"context_line":"             sqla_ddl.DropTable,"},{"line_number":61,"context_line":"             ),"},{"line_number":62,"context_line":"    \u0027alembic\u0027: (alembic_ddl.DropColumn,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f8bea1ac","line":59,"updated":"2016-06-13 01:29:09.000000000","message":"dropping indexes should not be restricted to the CONTRACT branch. you can easily drop an index with old server code running and not impact anything (except for maybe performance).","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"596372124da325e03315fa1f607482a27b3278ba","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"DROP_OPERATIONS \u003d {"},{"line_number":58,"context_line":"    \u0027sqla\u0027: (sqla_ddl.DropConstraint,"},{"line_number":59,"context_line":"             sqla_ddl.DropIndex,"},{"line_number":60,"context_line":"             sqla_ddl.DropTable,"},{"line_number":61,"context_line":"             ),"},{"line_number":62,"context_line":"    \u0027alembic\u0027: (alembic_ddl.DropColumn,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_53899625","line":59,"in_reply_to":"7aa08908_f8bea1ac","updated":"2016-06-13 02:34:36.000000000","message":"Ditto","commit_id":"5207a0c5ea7bc7fdea435fe1f2dc4719a4be93e7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9ee868763723227023c22156827e8fe1dce8ba82","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            for sa_type_, excepted_names in exceptions.items():"},{"line_number":267,"context_line":"                if isinstance(element, sa_type_):"},{"line_number":268,"context_line":"                    if element_name in excepted_names:"},{"line_number":269,"context_line":"                        return True"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        def is_excepted_alembic(clauseelement, exceptions):"},{"line_number":272,"context_line":"            \"\"\"Identify excepted operations that are allowed for the branch.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_79c5023c","line":269,"updated":"2016-06-15 15:12:54.000000000","message":"For the sake of better typing, should we return False as the last statement?","commit_id":"28bc1d79361ddbe53b67058a6c995e2d9ac19e3a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9ee868763723227023c22156827e8fe1dce8ba82","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            for alembic_type, excepted_names in exceptions.items():"},{"line_number":278,"context_line":"                if alembic_type \u003d\u003d sqlalchemy.Column:"},{"line_number":279,"context_line":"                    if element_name in excepted_names:"},{"line_number":280,"context_line":"                        return True"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        def is_allowed(clauseelement, exceptions, disallowed_ops):"},{"line_number":283,"context_line":"            if (isinstance(clauseelement, disallowed_ops[\u0027sqla\u0027]) and"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_b9bf6aa9","line":280,"updated":"2016-06-15 15:12:54.000000000","message":"ditto","commit_id":"28bc1d79361ddbe53b67058a6c995e2d9ac19e3a"}]}
