)]}'
{"neutron/tests/tempest/exceptions.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class QoSLimitReached(TempestException):"},{"line_number":36,"context_line":"    message \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1f56135c","line":36,"range":{"start_line":36,"start_character":44,"end_line":36,"end_character":73},"updated":"2016-06-07 09:35:13.000000000","message":"Shouldn\u0027t it be configurable?","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"6efdc0df323948197536e43a20398a6c153ff854","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class QoSLimitReached(TempestException):"},{"line_number":36,"context_line":"    message \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_217926f7","line":36,"range":{"start_line":36,"start_character":39,"end_line":36,"end_character":40},"updated":"2016-06-07 12:25:35.000000000","message":"this is supposed to be %d.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class QoSLimitReached(TempestException):"},{"line_number":36,"context_line":"    message \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0c5a614f","line":36,"range":{"start_line":36,"start_character":44,"end_line":36,"end_character":73},"in_reply_to":"7aa08908_1f56135c","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class QoSLimitReached(TempestException):"},{"line_number":36,"context_line":"    message \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4c32a911","line":36,"range":{"start_line":36,"start_character":39,"end_line":36,"end_character":40},"in_reply_to":"7aa08908_217926f7","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"}],"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def create_secgroup_rules(cls, rulesets, secgroup_id\u003dNone):"},{"line_number":72,"context_line":"        client \u003d cls.manager.network_client"},{"line_number":73,"context_line":"        if not secgroup_id:"},{"line_number":74,"context_line":"            sgs \u003d client.list_security_groups()[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b473d6b0","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":29},"updated":"2016-06-06 13:51:09.000000000","message":"This is basically a copy of create_loginable_secgroup_rule(). You should change its behavior to:\n\n def create_loginable_secgroup_rule(cls, ...)\n    ruleset \u003d {...}\n    cls.create_secgroup_rules(ruleset)","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def create_secgroup_rules(cls, rulesets, secgroup_id\u003dNone):"},{"line_number":72,"context_line":"        client \u003d cls.manager.network_client"},{"line_number":73,"context_line":"        if not secgroup_id:"},{"line_number":74,"context_line":"            sgs \u003d client.list_security_groups()[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2f692826","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":29},"in_reply_to":"7aa08908_b473d6b0","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ssh_client.test_connection_auth()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def setup_network_and_server(cls):"},{"line_number":133,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":134,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_94d05a55","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":32},"updated":"2016-06-06 13:51:09.000000000","message":"This is copy\u0026paste of https://review.openstack.org/#/c/320808/16/neutron/tests/tempest/scenario/test_basic.py@33\n\nYou can re-use it there.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"36d238d875782b1d8e02015190bb57bf728110ba","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ssh_client.test_connection_auth()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def setup_network_and_server(cls):"},{"line_number":133,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":134,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2f75cff8","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":32},"in_reply_to":"7aa08908_94d05a55","updated":"2016-06-06 13:56:42.000000000","message":"+1 for the \"@\u003cline number\u003e\" syntax. I\u0027ve been looking for this!","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ssh_client.test_connection_auth()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def setup_network_and_server(cls):"},{"line_number":133,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":134,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4f78f4c4","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":32},"in_reply_to":"7aa08908_94d05a55","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def create_secgroup_rules(cls, rulesets, direction, secgroup_id\u003dNone):"},{"line_number":72,"context_line":"        client \u003d cls.manager.network_client"},{"line_number":73,"context_line":"        if not secgroup_id:"},{"line_number":74,"context_line":"            sgs \u003d client.list_security_groups()[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_dfe92b82","line":71,"range":{"start_line":71,"start_character":45,"end_line":71,"end_character":56},"updated":"2016-06-07 09:35:13.000000000","message":"Why do you want to always create a group of the same direction? I think it should be part of rules in the ruleset.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def create_secgroup_rules(cls, rulesets, direction, secgroup_id\u003dNone):"},{"line_number":72,"context_line":"        client \u003d cls.manager.network_client"},{"line_number":73,"context_line":"        if not secgroup_id:"},{"line_number":74,"context_line":"            sgs \u003d client.list_security_groups()[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5b2f08f6","line":71,"range":{"start_line":71,"start_character":45,"end_line":71,"end_character":56},"in_reply_to":"7aa08908_dfe92b82","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        belonging to the same security group."},{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":97,"context_line":"                   \u0027port_range_min\u0027: 22,"},{"line_number":98,"context_line":"                   \u0027port_range_max\u0027: 22,"},{"line_number":99,"context_line":"                   \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1f79f3c8","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":16},"updated":"2016-06-07 09:35:13.000000000","message":"Nit: I think singular ruleset is better, or to match the strucutre, rule_list.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        belonging to the same security group."},{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":97,"context_line":"                   \u0027port_range_min\u0027: 22,"},{"line_number":98,"context_line":"                   \u0027port_range_max\u0027: 22,"},{"line_number":99,"context_line":"                   \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a0ceb7b1","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":16},"in_reply_to":"7aa08908_1f79f3c8","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                     device_id\u003dcls.server["},{"line_number":143,"context_line":"                                          \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":144,"context_line":"        cls.fip \u003d cls.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":145,"context_line":"        cls.check_connectivity(cls.fip[\u0027floating_ip_address\u0027],"},{"line_number":146,"context_line":"                               CONF.validation.image_ssh_user,"},{"line_number":147,"context_line":"                               cls.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_915b172e","line":147,"range":{"start_line":145,"start_character":1,"end_line":147,"end_character":58},"updated":"2016-06-07 09:35:13.000000000","message":"I don\u0027t think checking connectivity belongs to the setup, should be part of particular test.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                     device_id\u003dcls.server["},{"line_number":143,"context_line":"                                          \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":144,"context_line":"        cls.fip \u003d cls.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":145,"context_line":"        cls.check_connectivity(cls.fip[\u0027floating_ip_address\u0027],"},{"line_number":146,"context_line":"                               CONF.validation.image_ssh_user,"},{"line_number":147,"context_line":"                               cls.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_80057b7b","line":147,"range":{"start_line":145,"start_character":1,"end_line":147,"end_character":58},"in_reply_to":"7aa08908_915b172e","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"709ee848ae291b8635fe4297958b8cb65820db95","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def create_secgroup_rules(cls, rulesets, secgroup_id\u003dNone):"},{"line_number":72,"context_line":"        client \u003d cls.manager.network_client"},{"line_number":73,"context_line":"        if not secgroup_id:"},{"line_number":74,"context_line":"            sgs \u003d client.list_security_groups()[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_cdf97382","line":71,"range":{"start_line":71,"start_character":35,"end_line":71,"end_character":43},"updated":"2016-06-07 13:15:19.000000000","message":"Nit: rule_list","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9b40a56e085e73457761fcbaba9385a36e9bb7db","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def create_secgroup_rules(cls, rulesets, secgroup_id\u003dNone):"},{"line_number":72,"context_line":"        client \u003d cls.manager.network_client"},{"line_number":73,"context_line":"        if not secgroup_id:"},{"line_number":74,"context_line":"            sgs \u003d client.list_security_groups()[\u0027security_groups\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_51da12e9","line":71,"range":{"start_line":71,"start_character":35,"end_line":71,"end_character":43},"in_reply_to":"7aa08908_cdf97382","updated":"2016-06-08 05:55:53.000000000","message":"Done","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"709ee848ae291b8635fe4297958b8cb65820db95","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rulesets:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_8d9acb61","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":48},"updated":"2016-06-07 13:15:19.000000000","message":"This line is not needed","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e02a2505d68f12463538a1402db1c26efb88b021","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rulesets:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_62181776","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":48},"in_reply_to":"7aa08908_2cda88e8","updated":"2016-06-08 07:59:30.000000000","message":"Your suggestion is more elegant but I want to emphasize  that the direction is mandatory.","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3a6d817d20e57674c236146120371dd8440a8e06","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rulesets:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_2cda88e8","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":48},"in_reply_to":"7aa08908_313946f3","updated":"2016-06-08 07:36:50.000000000","message":"yes, so you can leave direction at ruleset, there is no need for any special handling.","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9b40a56e085e73457761fcbaba9385a36e9bb7db","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rulesets:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_313946f3","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":48},"in_reply_to":"7aa08908_8d9acb61","updated":"2016-06-08 05:55:53.000000000","message":"The definition of create_security_group_rule \n\ndef create_security_group_rule(self, direction, security_group_id, **kwargs)","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"709ee848ae291b8635fe4297958b8cb65820db95","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        for ruleset in rulesets:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"},{"line_number":85,"context_line":"                **ruleset)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_cda4d3a7","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":36},"updated":"2016-06-07 13:15:19.000000000","message":"this line is not needed","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9b40a56e085e73457761fcbaba9385a36e9bb7db","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        for ruleset in rulesets:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"},{"line_number":85,"context_line":"                **ruleset)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_71274eca","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":36},"in_reply_to":"7aa08908_cda4d3a7","updated":"2016-06-08 05:55:53.000000000","message":"See above.","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"709ee848ae291b8635fe4297958b8cb65820db95","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                     device_id\u003dcls.server["},{"line_number":144,"context_line":"                                          \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":145,"context_line":"        cls.fip \u003d cls.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":146,"context_line":"        cls.check_connectivity(cls.fip[\u0027floating_ip_address\u0027],"},{"line_number":147,"context_line":"                               CONF.validation.image_ssh_user,"},{"line_number":148,"context_line":"                               cls.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_4d2c6302","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":58},"updated":"2016-06-07 13:15:19.000000000","message":"Unaddressed comment from previous PS","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9b40a56e085e73457761fcbaba9385a36e9bb7db","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                     device_id\u003dcls.server["},{"line_number":144,"context_line":"                                          \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":145,"context_line":"        cls.fip \u003d cls.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":146,"context_line":"        cls.check_connectivity(cls.fip[\u0027floating_ip_address\u0027],"},{"line_number":147,"context_line":"                               CONF.validation.image_ssh_user,"},{"line_number":148,"context_line":"                               cls.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_3c075d19","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":58},"in_reply_to":"7aa08908_4d2c6302","updated":"2016-06-08 05:55:53.000000000","message":"Oops. Sorry for that.","commit_id":"1570f09392e2e12f2803ccccf00d37a0f7230eef"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9a2c209b85f206dd499a35d06708aac09afff808","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    secgroup_id \u003d sg[\u0027id\u0027]"},{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rule_list:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_ec46c079","line":80,"range":{"start_line":80,"start_character":12,"end_line":80,"end_character":19},"updated":"2016-06-08 07:38:22.000000000","message":"Nit: Now it becomes just rule :)","commit_id":"1ef2fb21d6fa95810f1a65c0faf6d590fcf4ad89"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b43f36d8ee7cd3fada1cd277bb7b09e1909f397d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    secgroup_id \u003d sg[\u0027id\u0027]"},{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rule_list:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_226c4f34","line":80,"range":{"start_line":80,"start_character":12,"end_line":80,"end_character":19},"in_reply_to":"7aa08908_ec46c079","updated":"2016-06-08 08:04:30.000000000","message":"Done","commit_id":"1ef2fb21d6fa95810f1a65c0faf6d590fcf4ad89"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9a2c209b85f206dd499a35d06708aac09afff808","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rule_list:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8c91fcf3","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":48},"updated":"2016-06-08 07:38:22.000000000","message":"This is still not needed.","commit_id":"1ef2fb21d6fa95810f1a65c0faf6d590fcf4ad89"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b43f36d8ee7cd3fada1cd277bb7b09e1909f397d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for ruleset in rule_list:"},{"line_number":81,"context_line":"            direction \u003d ruleset.pop(\u0027direction\u0027)"},{"line_number":82,"context_line":"            client.create_security_group_rule("},{"line_number":83,"context_line":"                direction\u003ddirection,"},{"line_number":84,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_c27aabf0","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":48},"in_reply_to":"7aa08908_8c91fcf3","updated":"2016-06-08 08:04:30.000000000","message":"I answered on PS3","commit_id":"1ef2fb21d6fa95810f1a65c0faf6d590fcf4ad89"}],"neutron/tests/tempest/scenario/constants.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5bf82366aab52e301c881059a83d8f6ad999f76d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"SERVER_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":16,"context_line":"DEFAULT_SECURITY_GROUP \u003d \u0027default\u0027"},{"line_number":17,"context_line":"LIMIT_KILO_BITS_SEC \u003d 1000"},{"line_number":18,"context_line":"SOCKET_CONNECT_TIMEOUT \u003d 60"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_db3dd1de","line":17,"updated":"2016-07-10 07:31:52.000000000","message":"nit: shouldn\u0027t be LIMIT_KILO_BITS_PER_SECOND maybe?","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e97d7293e777d42402d6934ffcd434b4658b26b9","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"SERVER_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":16,"context_line":"DEFAULT_SECURITY_GROUP \u003d \u0027default\u0027"},{"line_number":17,"context_line":"LIMIT_KILO_BITS_SEC \u003d 1000"},{"line_number":18,"context_line":"SOCKET_CONNECT_TIMEOUT \u003d 60"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_6f4b375a","line":17,"in_reply_to":"1aa78d24_db3dd1de","updated":"2016-07-10 14:44:53.000000000","message":"Done","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"}],"neutron/tests/tempest/scenario/exceptions.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":19,"context_line":"TempestException \u003d exceptions.TempestException"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class QoSLimitReached(TempestException):"},{"line_number":23,"context_line":"    message \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_115f270f","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":73},"updated":"2016-06-07 09:35:13.000000000","message":"The same is in neutron.tests.tempest.exceptions","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"TempestException \u003d exceptions.TempestException"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class QoSLimitReached(TempestException):"},{"line_number":23,"context_line":"    message \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c0366351","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":73},"in_reply_to":"7aa08908_115f270f","updated":"2016-06-08 08:01:40.000000000","message":"I\u0027m removing the one in neutron.tests.tempest.exceptions","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"49d7079ca8ed74f14c35d4f7063c347b6d45a78d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    message \u003d \"Unable to connect to %(host)s port %(port)s:Connection Refused\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TimeoutException(TempestException):"},{"line_number":29,"context_line":"    message \u003d \"Timeout connecting to %(host)s port %(port)s\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_9c72b80f","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":22},"updated":"2016-06-08 11:43:59.000000000","message":"Nit: ConnectionTimeoutException","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"052821f81e884795532be400282c8dcc99f29ce1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    message \u003d \"Unable to connect to %(host)s port %(port)s:Connection Refused\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TimeoutException(TempestException):"},{"line_number":29,"context_line":"    message \u003d \"Timeout connecting to %(host)s port %(port)s\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_456cec9b","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":22},"in_reply_to":"7aa08908_9c72b80f","updated":"2016-06-08 12:49:54.000000000","message":"Done","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class SocketConnectionRefused(TempestException):"},{"line_number":25,"context_line":"    message \u003d \"Unable to connect to %(host)s port %(port)s:Connection Refused\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ConnectionTimeoutException(TempestException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_c1dbffeb","line":25,"range":{"start_line":25,"start_character":57,"end_line":25,"end_character":58},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class SocketConnectionRefused(TempestException):"},{"line_number":25,"context_line":"    message \u003d \"Unable to connect to %(host)s port %(port)s:Connection Refused\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ConnectionTimeoutException(TempestException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_c4db0dec","line":25,"range":{"start_line":25,"start_character":57,"end_line":25,"end_character":58},"in_reply_to":"3aaa91ec_c1dbffeb","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ConnectionTimeoutException(TempestException):"},{"line_number":29,"context_line":"    message \u003d \"Timeout connecting to %(host)s port %(port)s\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_e149dbb8","line":29,"range":{"start_line":29,"start_character":58,"end_line":29,"end_character":59},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ConnectionTimeoutException(TempestException):"},{"line_number":29,"context_line":"    message \u003d \"Timeout connecting to %(host)s port %(port)s\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_a4d6c1c0","line":29,"range":{"start_line":29,"start_character":58,"end_line":29,"end_character":59},"in_reply_to":"3aaa91ec_e149dbb8","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"}],"neutron/tests/tempest/scenario/test_basic.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#                                      device_id\u003dserver["},{"line_number":49,"context_line":"#                                          \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":50,"context_line":"#        fip \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":51,"context_line":"#        self.check_connectivity(fip[\u0027floating_ip_address\u0027],"},{"line_number":52,"context_line":"#                                CONF.validation.image_ssh_user,"},{"line_number":53,"context_line":"#                                keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f1b09b45","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":56},"updated":"2016-06-07 09:35:13.000000000","message":"The check should stay here.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#                                      device_id\u003dserver["},{"line_number":49,"context_line":"#                                          \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":50,"context_line":"#        fip \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":51,"context_line":"#        self.check_connectivity(fip[\u0027floating_ip_address\u0027],"},{"line_number":52,"context_line":"#                                CONF.validation.image_ssh_user,"},{"line_number":53,"context_line":"#                                keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_00a50ba1","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":56},"in_reply_to":"7aa08908_f1b09b45","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"03c33e62c526d368b0fafd436c2dfd89d28194fe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from tempest import test"},{"line_number":17,"context_line":"from neutron.tests.tempest import config"},{"line_number":18,"context_line":"from neutron.tests.tempest.scenario import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_2e3987d9","line":17,"updated":"2016-06-09 09:50:32.000000000","message":"Missing empty line","commit_id":"1b8b15b9fa1b55390412da0f296da168a834d3db"}],"neutron/tests/tempest/scenario/test_qos.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.tests.tempest.scenario import base"},{"line_number":24,"context_line":"from neutron.tests.tempest.scenario import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.lib.common import ssh"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_9437baaf","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":34},"updated":"2016-06-06 13:51:09.000000000","message":"This should be at L20","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.tests.tempest.scenario import base"},{"line_number":24,"context_line":"from neutron.tests.tempest.scenario import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.lib.common import ssh"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6f197079","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":34},"in_reply_to":"7aa08908_9437baaf","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    # Default to ipv4."},{"line_number":36,"context_line":"    _ip_version \u003d 4"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _connect_socket(self, host, port):"},{"line_number":39,"context_line":"        \"\"\"Try to initiate a connection to a host using an ip address and a port."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        Trying couple of times until a timeout is reached in case the listening"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_74304e57","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":42},"updated":"2016-06-06 13:51:09.000000000","message":"Can it be moved outside of this class?","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    # Default to ipv4."},{"line_number":36,"context_line":"    _ip_version \u003d 4"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _connect_socket(self, host, port):"},{"line_number":39,"context_line":"        \"\"\"Try to initiate a connection to a host using an ip address and a port."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        Trying couple of times until a timeout is reached in case the listening"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f047fc1a","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":42},"in_reply_to":"7aa08908_74304e57","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    _ip_version \u003d 4"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _connect_socket(self, host, port):"},{"line_number":39,"context_line":"        \"\"\"Try to initiate a connection to a host using an ip address and a port."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        Trying couple of times until a timeout is reached in case the listening"},{"line_number":42,"context_line":"        host is not ready yet."}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_345366e3","line":39,"range":{"start_line":39,"start_character":80,"end_line":39,"end_character":81},"updated":"2016-06-06 13:51:09.000000000","message":"Is it longer than 80 chars?","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    _ip_version \u003d 4"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _connect_socket(self, host, port):"},{"line_number":39,"context_line":"        \"\"\"Try to initiate a connection to a host using an ip address and a port."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        Trying couple of times until a timeout is reached in case the listening"},{"line_number":42,"context_line":"        host is not ready yet."}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ef71e0a9","line":39,"range":{"start_line":39,"start_character":80,"end_line":39,"end_character":81},"in_reply_to":"7aa08908_345366e3","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        host is not ready yet."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        def try_connect(host_ip, port):"},{"line_number":46,"context_line":"            try:"},{"line_number":47,"context_line":"                client_socket \u003d socket.socket(socket.AF_INET,"},{"line_number":48,"context_line":"                                              socket.SOCK_STREAM)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_948fba22","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":39},"updated":"2016-06-06 13:51:09.000000000","message":"Is there a reason to create a closure?","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        host is not ready yet."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        def try_connect(host_ip, port):"},{"line_number":46,"context_line":"            try:"},{"line_number":47,"context_line":"                client_socket \u003d socket.socket(socket.AF_INET,"},{"line_number":48,"context_line":"                                              socket.SOCK_STREAM)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_104d683e","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":39},"in_reply_to":"7aa08908_948fba22","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                client_socket.connect((host_ip, port))"},{"line_number":50,"context_line":"                client_socket.setblocking(0)"},{"line_number":51,"context_line":"                return client_socket"},{"line_number":52,"context_line":"            except socket.error:"},{"line_number":53,"context_line":"                return False"},{"line_number":54,"context_line":"        start \u003d time.time()"},{"line_number":55,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_14cbca54","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":32},"updated":"2016-06-06 13:51:09.000000000","message":"You basically wrap 3 socket functions catching a single error. It will help debugging if this is logged including traceback","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                client_socket.connect((host_ip, port))"},{"line_number":50,"context_line":"                client_socket.setblocking(0)"},{"line_number":51,"context_line":"                return client_socket"},{"line_number":52,"context_line":"            except socket.error:"},{"line_number":53,"context_line":"                return False"},{"line_number":54,"context_line":"        start \u003d time.time()"},{"line_number":55,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ef44401c","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":32},"in_reply_to":"7aa08908_14cbca54","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                client_socket.setblocking(0)"},{"line_number":51,"context_line":"                return client_socket"},{"line_number":52,"context_line":"            except socket.error:"},{"line_number":53,"context_line":"                return False"},{"line_number":54,"context_line":"        start \u003d time.time()"},{"line_number":55,"context_line":"        while True:"},{"line_number":56,"context_line":"            client_socket \u003d try_connect(host, port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f486feb7","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":28},"updated":"2016-06-06 13:51:09.000000000","message":"What does it mean, if client_socket is set to False? We should rather raise an exception here.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                client_socket.setblocking(0)"},{"line_number":51,"context_line":"                return client_socket"},{"line_number":52,"context_line":"            except socket.error:"},{"line_number":53,"context_line":"                return False"},{"line_number":54,"context_line":"        start \u003d time.time()"},{"line_number":55,"context_line":"        while True:"},{"line_number":56,"context_line":"            client_socket \u003d try_connect(host, port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8f565cd0","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":28},"in_reply_to":"7aa08908_f486feb7","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    \u0027host\u0027: host, \u0027port\u0027: port}"},{"line_number":62,"context_line":"                raise exceptions.TimeoutException(msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":65,"context_line":"        BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":66,"context_line":"        TOLERANCE_FACTOR \u003d 1.1"},{"line_number":67,"context_line":"        LIMIT_BYTES_SEC \u003d (limit_kbps * 1024 * TOLERANCE_FACTOR) / 8.0"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0f21f34d","line":64,"range":{"start_line":64,"start_character":59,"end_line":64,"end_character":69},"updated":"2016-06-06 13:51:09.000000000","message":"Is it used?","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    \u0027host\u0027: host, \u0027port\u0027: port}"},{"line_number":62,"context_line":"                raise exceptions.TimeoutException(msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":65,"context_line":"        BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":66,"context_line":"        TOLERANCE_FACTOR \u003d 1.1"},{"line_number":67,"context_line":"        LIMIT_BYTES_SEC \u003d (limit_kbps * 1024 * TOLERANCE_FACTOR) / 8.0"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2f3da8bb","line":64,"range":{"start_line":64,"start_character":59,"end_line":64,"end_character":69},"in_reply_to":"7aa08908_0f21f34d","updated":"2016-06-07 08:30:29.000000000","message":"Yes. In #147","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7145863d0d706595bc570a67d1b5488f00b8e2d4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    \u0027host\u0027: host, \u0027port\u0027: port}"},{"line_number":62,"context_line":"                raise exceptions.TimeoutException(msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":65,"context_line":"        BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":66,"context_line":"        TOLERANCE_FACTOR \u003d 1.1"},{"line_number":67,"context_line":"        LIMIT_BYTES_SEC \u003d (limit_kbps * 1024 * TOLERANCE_FACTOR) / 8.0"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_31a183a4","line":64,"range":{"start_line":64,"start_character":59,"end_line":64,"end_character":69},"in_reply_to":"7aa08908_2f3da8bb","updated":"2016-06-07 09:35:21.000000000","message":"No, that is variable from L144.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                raise exceptions.TimeoutException(msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":65,"context_line":"        BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":66,"context_line":"        TOLERANCE_FACTOR \u003d 1.1"},{"line_number":67,"context_line":"        LIMIT_BYTES_SEC \u003d (limit_kbps * 1024 * TOLERANCE_FACTOR) / 8.0"},{"line_number":68,"context_line":"        client_socket \u003d self._connect_socket(host, port)"},{"line_number":69,"context_line":"        total_bytes_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_146e2a2f","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":30},"updated":"2016-06-06 13:51:09.000000000","message":"Don\u0027t count the constants per every call of this method.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":65,"context_line":"        BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":66,"context_line":"        TOLERANCE_FACTOR \u003d 1.1"},{"line_number":67,"context_line":"        LIMIT_BYTES_SEC \u003d (limit_kbps * 1024 * TOLERANCE_FACTOR) / 8.0"},{"line_number":68,"context_line":"        client_socket \u003d self._connect_socket(host, port)"},{"line_number":69,"context_line":"        total_bytes_read \u003d 0"},{"line_number":70,"context_line":"        cycle_start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f451de63","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":27},"updated":"2016-06-06 13:51:09.000000000","message":"Parenthesis are not needed.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":65,"context_line":"        BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":66,"context_line":"        TOLERANCE_FACTOR \u003d 1.1"},{"line_number":67,"context_line":"        LIMIT_BYTES_SEC \u003d (limit_kbps * 1024 * TOLERANCE_FACTOR) / 8.0"},{"line_number":68,"context_line":"        client_socket \u003d self._connect_socket(host, port)"},{"line_number":69,"context_line":"        total_bytes_read \u003d 0"},{"line_number":70,"context_line":"        cycle_start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cf0504c3","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":27},"in_reply_to":"7aa08908_f451de63","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"24c39cf30691cc7bdd7da54bbab0b2269abb0ee5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                if error \u003d\u003d errno.EAGAIN or error \u003d\u003d errno.EWOULDBLOCK:"},{"line_number":79,"context_line":"                    continue"},{"line_number":80,"context_line":"                else:"},{"line_number":81,"context_line":"                    raise"},{"line_number":82,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":83,"context_line":"            cycle_data_read +\u003d len(data)"},{"line_number":84,"context_line":"            time_elapsed \u003d time.time() - cycle_start_time"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8dd1415a","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":25},"updated":"2016-06-07 12:25:40.000000000","message":"Don\u0027t \u0027raise\u0027 without an explicit exception instance.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"21b08806eaaea06054997c47de3fbebb62f3024b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                if error \u003d\u003d errno.EAGAIN or error \u003d\u003d errno.EWOULDBLOCK:"},{"line_number":79,"context_line":"                    continue"},{"line_number":80,"context_line":"                else:"},{"line_number":81,"context_line":"                    raise"},{"line_number":82,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":83,"context_line":"            cycle_data_read +\u003d len(data)"},{"line_number":84,"context_line":"            time_elapsed \u003d time.time() - cycle_start_time"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4cbbc9e5","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":25},"in_reply_to":"7aa08908_8dd1415a","updated":"2016-06-07 12:34:05.000000000","message":"This is actually correct, it raises exception from L76","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":83,"context_line":"            cycle_data_read +\u003d len(data)"},{"line_number":84,"context_line":"            time_elapsed \u003d time.time() - cycle_start_time"},{"line_number":85,"context_line":"            should_check \u003d (time_elapsed \u003e\u003d 5 or total_bytes_read \u003d\u003d file_size)"},{"line_number":86,"context_line":"            if should_check:"},{"line_number":87,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":88,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f409de32","line":85,"range":{"start_line":85,"start_character":27,"end_line":85,"end_character":28},"updated":"2016-06-06 13:51:09.000000000","message":"Parenthesis are not needed.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            total_bytes_read +\u003d len(data)"},{"line_number":83,"context_line":"            cycle_data_read +\u003d len(data)"},{"line_number":84,"context_line":"            time_elapsed \u003d time.time() - cycle_start_time"},{"line_number":85,"context_line":"            should_check \u003d (time_elapsed \u003e\u003d 5 or total_bytes_read \u003d\u003d file_size)"},{"line_number":86,"context_line":"            if should_check:"},{"line_number":87,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":88,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2f912853","line":85,"range":{"start_line":85,"start_character":27,"end_line":85,"end_character":28},"in_reply_to":"7aa08908_f409de32","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                           \"bytes_read\": total_bytes_read,"},{"line_number":92,"context_line":"                           \"cycle_data\": cycle_data_read})"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"                if (cycle_data_read / time_elapsed) \u003e LIMIT_BYTES_SEC:"},{"line_number":95,"context_line":"                    # Limit reached"},{"line_number":96,"context_line":"                    return False"},{"line_number":97,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0f145342","line":94,"range":{"start_line":94,"start_character":19,"end_line":94,"end_character":20},"updated":"2016-06-06 13:51:09.000000000","message":"Parenthesis are not needed.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                           \"bytes_read\": total_bytes_read,"},{"line_number":92,"context_line":"                           \"cycle_data\": cycle_data_read})"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"                if (cycle_data_read / time_elapsed) \u003e LIMIT_BYTES_SEC:"},{"line_number":95,"context_line":"                    # Limit reached"},{"line_number":96,"context_line":"                    return False"},{"line_number":97,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ef29e038","line":94,"range":{"start_line":94,"start_character":19,"end_line":94,"end_character":20},"in_reply_to":"7aa08908_0f145342","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                else:"},{"line_number":98,"context_line":"                    cycle_start_time \u003d time.time()"},{"line_number":99,"context_line":"                    cycle_data_read \u003d 0"},{"line_number":100,"context_line":"        return True"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_qos(self):"},{"line_number":103,"context_line":"        \"\"\"This is a basic test that check that a QoS policy with"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4f35bbd8","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":19},"updated":"2016-06-06 13:51:09.000000000","message":"Why do we return True or False here? We later assert on true only, can we just raise an exception in case it failed?","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                else:"},{"line_number":98,"context_line":"                    cycle_start_time \u003d time.time()"},{"line_number":99,"context_line":"                    cycle_data_read \u003d 0"},{"line_number":100,"context_line":"        return True"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_qos(self):"},{"line_number":103,"context_line":"        \"\"\"This is a basic test that check that a QoS policy with"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_33e4ee39","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":19},"in_reply_to":"7aa08908_4f35bbd8","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                      \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":140,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":141,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":142,"context_line":"        msg \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"},{"line_number":143,"context_line":"        time.sleep(30)"},{"line_number":144,"context_line":"        test_start \u003d time.time()"},{"line_number":145,"context_line":"        self.assertTrue(self._check_bw(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0f4c5341","line":142,"range":{"start_line":142,"start_character":39,"end_line":142,"end_character":40},"updated":"2016-06-06 13:51:09.000000000","message":"LIMIT_KILO_BITS_SEC is an integer","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                      \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":140,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":141,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":142,"context_line":"        msg \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"},{"line_number":143,"context_line":"        time.sleep(30)"},{"line_number":144,"context_line":"        test_start \u003d time.time()"},{"line_number":145,"context_line":"        self.assertTrue(self._check_bw(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_efae0097","line":142,"range":{"start_line":142,"start_character":39,"end_line":142,"end_character":40},"in_reply_to":"7aa08908_0f4c5341","updated":"2016-06-07 08:30:29.000000000","message":"Done","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3453e80298cc45226854ae5f34d4804057ab748","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":141,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":142,"context_line":"        msg \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"},{"line_number":143,"context_line":"        time.sleep(30)"},{"line_number":144,"context_line":"        test_start \u003d time.time()"},{"line_number":145,"context_line":"        self.assertTrue(self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":146,"context_line":"                                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cf824b00","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":22},"updated":"2016-06-06 13:51:09.000000000","message":"Why do we need to wait 30 seconds? Can we instead get_port with given id and check the qos_policy_id?","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9078e4a84db63cddc768c1ccb8d5f479161f6aef","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":141,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":142,"context_line":"        msg \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"},{"line_number":143,"context_line":"        time.sleep(30)"},{"line_number":144,"context_line":"        test_start \u003d time.time()"},{"line_number":145,"context_line":"        self.assertTrue(self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":146,"context_line":"                                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_53c09a7b","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":22},"in_reply_to":"7aa08908_35fa4043","updated":"2016-06-07 08:30:29.000000000","message":"The problem is with the agent - it may not be applied fast enough.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b43dab165831c480dc57e1a57d124480f1e73d43","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":141,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":142,"context_line":"        msg \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"},{"line_number":143,"context_line":"        time.sleep(30)"},{"line_number":144,"context_line":"        test_start \u003d time.time()"},{"line_number":145,"context_line":"        self.assertTrue(self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":146,"context_line":"                                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5a6d7b97","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":22},"in_reply_to":"7aa08908_4ffdbb39","updated":"2016-06-06 14:01:12.000000000","message":"I think the problem here is that API doesn\u0027t expose time when policy is on the port. On the other hand api should reflect the actual state, so once we have policy on port in db, it must be on the agent.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"ee1698e158d5189a920e13baa674d739a15e64d1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":141,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":142,"context_line":"        msg \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"},{"line_number":143,"context_line":"        time.sleep(30)"},{"line_number":144,"context_line":"        test_start \u003d time.time()"},{"line_number":145,"context_line":"        self.assertTrue(self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":146,"context_line":"                                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_35fa4043","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":22},"in_reply_to":"7aa08908_5a6d7b97","updated":"2016-06-06 14:20:32.000000000","message":"Good point. Itzik, can you please make sure this is the case (that the DB state is only changed after the policy is applied to the port)?\nIf not, lets see what we do instead of wait_until_true, until we fix the bug.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"36d238d875782b1d8e02015190bb57bf728110ba","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":141,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":142,"context_line":"        msg \u003d \"Limit reached, limit \u003d %s\" % constants.LIMIT_KILO_BITS_SEC"},{"line_number":143,"context_line":"        time.sleep(30)"},{"line_number":144,"context_line":"        test_start \u003d time.time()"},{"line_number":145,"context_line":"        self.assertTrue(self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":146,"context_line":"                                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4ffdbb39","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":22},"in_reply_to":"7aa08908_cf824b00","updated":"2016-06-06 13:56:42.000000000","message":"I\u0027d very much prefer to use some kind of \u0027wait_until_true\u0027 variant instead.","commit_id":"72b594f1230fdcd70b7727a80061756668360b7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        client_socket.setblocking(0)"},{"line_number":40,"context_line":"        return client_socket"},{"line_number":41,"context_line":"    except socket.error:"},{"line_number":42,"context_line":"        LOG.exception(\"Failed connecting to server\")"},{"line_number":43,"context_line":"        traceback.print_exc()"},{"line_number":44,"context_line":"        raise"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d1c0ff7e","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":50},"updated":"2016-06-07 09:35:13.000000000","message":"You should also log host_ip and port here.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        client_socket.setblocking(0)"},{"line_number":40,"context_line":"        return client_socket"},{"line_number":41,"context_line":"    except socket.error:"},{"line_number":42,"context_line":"        LOG.exception(\"Failed connecting to server\")"},{"line_number":43,"context_line":"        traceback.print_exc()"},{"line_number":44,"context_line":"        raise"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0056ab5b","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":50},"in_reply_to":"7aa08908_d1c0ff7e","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return client_socket"},{"line_number":41,"context_line":"    except socket.error:"},{"line_number":42,"context_line":"        LOG.exception(\"Failed connecting to server\")"},{"line_number":43,"context_line":"        traceback.print_exc()"},{"line_number":44,"context_line":"        raise"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_71eaeb10","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":29},"updated":"2016-06-07 09:35:13.000000000","message":"LOG.exception() does that for you.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return client_socket"},{"line_number":41,"context_line":"    except socket.error:"},{"line_number":42,"context_line":"        LOG.exception(\"Failed connecting to server\")"},{"line_number":43,"context_line":"        traceback.print_exc()"},{"line_number":44,"context_line":"        raise"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e050bf60","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":29},"in_reply_to":"7aa08908_71eaeb10","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    start \u003d time.time()"},{"line_number":56,"context_line":"    while True:"},{"line_number":57,"context_line":"        client_socket \u003d _try_connect(host, port)"},{"line_number":58,"context_line":"        if client_socket:"},{"line_number":59,"context_line":"            return client_socket"},{"line_number":60,"context_line":"        if time.time() - start \u003e constants.SOCKET_CONNECT_TIMEOUT:"},{"line_number":61,"context_line":"            msg \u003d \"Timeout connecting to %(host)s port %(port)s\" % {"},{"line_number":62,"context_line":"                \u0027host\u0027: host, \u0027port\u0027: port}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_311ce311","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":32},"updated":"2016-06-07 09:35:13.000000000","message":"if is not needed, just return client_socket","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9f421c1151f4b76b97cf91cfdedf59c243d7bb9e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    start \u003d time.time()"},{"line_number":56,"context_line":"    while True:"},{"line_number":57,"context_line":"        client_socket \u003d _try_connect(host, port)"},{"line_number":58,"context_line":"        if client_socket:"},{"line_number":59,"context_line":"            return client_socket"},{"line_number":60,"context_line":"        if time.time() - start \u003e constants.SOCKET_CONNECT_TIMEOUT:"},{"line_number":61,"context_line":"            msg \u003d \"Timeout connecting to %(host)s port %(port)s\" % {"},{"line_number":62,"context_line":"                \u0027host\u0027: host, \u0027port\u0027: port}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f01e8eb9","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":32},"in_reply_to":"7aa08908_1d0d38e8","updated":"2016-06-08 08:23:28.000000000","message":"If the connection fails it returns None.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    start \u003d time.time()"},{"line_number":56,"context_line":"    while True:"},{"line_number":57,"context_line":"        client_socket \u003d _try_connect(host, port)"},{"line_number":58,"context_line":"        if client_socket:"},{"line_number":59,"context_line":"            return client_socket"},{"line_number":60,"context_line":"        if time.time() - start \u003e constants.SOCKET_CONNECT_TIMEOUT:"},{"line_number":61,"context_line":"            msg \u003d \"Timeout connecting to %(host)s port %(port)s\" % {"},{"line_number":62,"context_line":"                \u0027host\u0027: host, \u0027port\u0027: port}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3ec027e0","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":32},"in_reply_to":"7aa08908_311ce311","updated":"2016-06-08 08:01:40.000000000","message":"I want it to return only if there is a connection or if the timeout has passed (Exception in this case).","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3405c7668e8d3399c49dc7a0ad166f25945e6088","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    start \u003d time.time()"},{"line_number":56,"context_line":"    while True:"},{"line_number":57,"context_line":"        client_socket \u003d _try_connect(host, port)"},{"line_number":58,"context_line":"        if client_socket:"},{"line_number":59,"context_line":"            return client_socket"},{"line_number":60,"context_line":"        if time.time() - start \u003e constants.SOCKET_CONNECT_TIMEOUT:"},{"line_number":61,"context_line":"            msg \u003d \"Timeout connecting to %(host)s port %(port)s\" % {"},{"line_number":62,"context_line":"                \u0027host\u0027: host, \u0027port\u0027: port}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1d0d38e8","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":32},"in_reply_to":"7aa08908_3ec027e0","updated":"2016-06-08 08:06:46.000000000","message":"What is the case when client_socket is evaluated as False? In _try_connect() you create a socket by calling socket library. The function always returns this object so I don\u0027t see a case when this can happen.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f0fed32bce5423895b6978c5b13dc4c81112c344","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    start \u003d time.time()"},{"line_number":56,"context_line":"    while True:"},{"line_number":57,"context_line":"        client_socket \u003d _try_connect(host, port)"},{"line_number":58,"context_line":"        if client_socket:"},{"line_number":59,"context_line":"            return client_socket"},{"line_number":60,"context_line":"        if time.time() - start \u003e constants.SOCKET_CONNECT_TIMEOUT:"},{"line_number":61,"context_line":"            msg \u003d \"Timeout connecting to %(host)s port %(port)s\" % {"},{"line_number":62,"context_line":"                \u0027host\u0027: host, \u0027port\u0027: port}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_10387aee","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":32},"in_reply_to":"7aa08908_f01e8eb9","updated":"2016-06-08 08:24:30.000000000","message":"Which line?","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":72,"context_line":"    TOLERANCE_FACTOR \u003d 1.1"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":75,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":76,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":77,"context_line":"        total_bytes_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_31afc382","line":74,"range":{"start_line":74,"start_character":59,"end_line":74,"end_character":69},"updated":"2016-06-07 09:35:13.000000000","message":"I still see this is not used anywhere.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":72,"context_line":"    TOLERANCE_FACTOR \u003d 1.1"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size, test_start):"},{"line_number":75,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":76,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":77,"context_line":"        total_bytes_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3bc03c7b","line":74,"range":{"start_line":74,"start_character":59,"end_line":74,"end_character":69},"in_reply_to":"7aa08908_31afc382","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":125,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":126,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":127,"context_line":"        self.create_secgroup_rules(rulesets, direction\u003d\u0027ingress\u0027)"},{"line_number":128,"context_line":"        ssh_client \u003d ssh.Client(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":129,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":130,"context_line":"                                pkey\u003dself.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_31c6a348","line":127,"range":{"start_line":127,"start_character":44,"end_line":127,"end_character":64},"updated":"2016-06-07 09:35:13.000000000","message":"Defining it on L124 was better.","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":125,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":126,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":127,"context_line":"        self.create_secgroup_rules(rulesets, direction\u003d\u0027ingress\u0027)"},{"line_number":128,"context_line":"        ssh_client \u003d ssh.Client(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":129,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":130,"context_line":"                                pkey\u003dself.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_db22d800","line":127,"range":{"start_line":127,"start_character":44,"end_line":127,"end_character":64},"in_reply_to":"7aa08908_31c6a348","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d70db3ab3000a5f527ccbf75fb3a178094d81187","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                                      \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":146,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":147,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":148,"context_line":"        time.sleep(10)"},{"line_number":149,"context_line":"        test_start \u003d time.time()"},{"line_number":150,"context_line":"        self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":151,"context_line":"                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_71130bb9","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":22},"updated":"2016-06-07 09:35:13.000000000","message":"Can you add a note here that this is not optimal and we should find a way how to validate the policy was applied?","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cede6d90eba60208d97988f6e3519df2c1181b1d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                                      \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":146,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":147,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":148,"context_line":"        time.sleep(10)"},{"line_number":149,"context_line":"        test_start \u003d time.time()"},{"line_number":150,"context_line":"        self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":151,"context_line":"                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_bb6f0cc4","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":22},"in_reply_to":"7aa08908_71130bb9","updated":"2016-06-08 08:01:40.000000000","message":"Done","commit_id":"67c284d8b0eab51f3d61b5e69bfcbbe3db147cde"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"49d7079ca8ed74f14c35d4f7063c347b6d45a78d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.tests.tempest.scenario import constants"},{"line_number":25,"context_line":"from neutron.tests.tempest.scenario import exceptions as sc_exceptions"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_3ce624b0","line":27,"updated":"2016-06-08 11:43:59.000000000","message":"Nit: unnecessary empty line","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"052821f81e884795532be400282c8dcc99f29ce1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.tests.tempest.scenario import constants"},{"line_number":25,"context_line":"from neutron.tests.tempest.scenario import exceptions as sc_exceptions"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_7929db89","line":27,"in_reply_to":"7aa08908_3ce624b0","updated":"2016-06-08 12:49:54.000000000","message":"Done","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"49d7079ca8ed74f14c35d4f7063c347b6d45a78d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    start \u003d time.time()"},{"line_number":56,"context_line":"    while True:"},{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            client_socket \u003d _try_connect(host, port)"},{"line_number":59,"context_line":"            break"},{"line_number":60,"context_line":"        except sc_exceptions.SocketConnectionRefused:"},{"line_number":61,"context_line":"            if time.time() - start \u003e constants.SOCKET_CONNECT_TIMEOUT:"},{"line_number":62,"context_line":"                raise sc_exceptions.TimeoutException(host\u003dhost, port\u003dport)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_3c0aa479","line":59,"range":{"start_line":58,"start_character":12,"end_line":59,"end_character":17},"updated":"2016-06-08 11:43:59.000000000","message":"Nit:\n return _try_connect(host, port)","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"052821f81e884795532be400282c8dcc99f29ce1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    start \u003d time.time()"},{"line_number":56,"context_line":"    while True:"},{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            client_socket \u003d _try_connect(host, port)"},{"line_number":59,"context_line":"            break"},{"line_number":60,"context_line":"        except sc_exceptions.SocketConnectionRefused:"},{"line_number":61,"context_line":"            if time.time() - start \u003e constants.SOCKET_CONNECT_TIMEOUT:"},{"line_number":62,"context_line":"                raise sc_exceptions.TimeoutException(host\u003dhost, port\u003dport)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_b956a303","line":59,"range":{"start_line":58,"start_character":12,"end_line":59,"end_character":17},"in_reply_to":"7aa08908_3c0aa479","updated":"2016-06-08 12:49:54.000000000","message":"Done","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"49d7079ca8ed74f14c35d4f7063c347b6d45a78d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":72,"context_line":"    TOLERANCE_FACTOR \u003d 1.1"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size):"},{"line_number":75,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":76,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":77,"context_line":"        total_bytes_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_fc32dc0e","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":17},"updated":"2016-06-08 11:43:59.000000000","message":"Nit: This can be moved outside of the class","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"052821f81e884795532be400282c8dcc99f29ce1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":72,"context_line":"    TOLERANCE_FACTOR \u003d 1.1"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size):"},{"line_number":75,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":76,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":77,"context_line":"        total_bytes_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_b97b437a","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":17},"in_reply_to":"7aa08908_fc32dc0e","updated":"2016-06-08 12:49:54.000000000","message":"This shouldn\u0027t be used outside of the class so I think we can keep it.","commit_id":"fddd70bd49f89886ae753de2048facd7e23a92dd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"03e536c1320a612669adaf9361146c10483dd5fc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.tests.tempest.scenario import base"},{"line_number":24,"context_line":"from neutron.tests.tempest.scenario import constants"},{"line_number":25,"context_line":"from neutron.tests.tempest.scenario import exceptions as sc_exceptions"},{"line_number":26,"context_line":"from tempest import test"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_5452a735","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":24},"updated":"2016-06-09 09:49:31.000000000","message":"Belongs to L21","commit_id":"1b8b15b9fa1b55390412da0f296da168a834d3db"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7911d0f5a48a0dddfece275c50051c402e938282","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # Default to ipv4."},{"line_number":69,"context_line":"    _ip_version \u003d 4"},{"line_number":70,"context_line":"    BUFFER_SIZE \u003d 10 * 1024 * 1024"},{"line_number":71,"context_line":"    TOLERANCE_FACTOR \u003d 1.1"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _check_bw(self, host, port, limit_kbps, file_size):"},{"line_number":74,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_3432edf2","line":71,"updated":"2016-06-13 07:28:06.000000000","message":"I\u0027d increase the tolerance factor to 1.5 or something like that (that\u0027s a broad range), but we have found that the initial burst of traffic tends to spike over that very easily.\n\nSo, between 1Mbps and several Gbps (uncapped -on same node-) the factor will always tell us if the policy is being applied.\n\nWe could increase the factor for higher throughputs if necessary, but I believe keeping a low tolerance is going to bring us lots of random failures.","commit_id":"3491c06b284a8eb6a59489db442eb3a72e9c41e2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7911d0f5a48a0dddfece275c50051c402e938282","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        policy_id \u003d policy[\u0027policy\u0027][\u0027id\u0027]"},{"line_number":145,"context_line":"        self.admin_manager.network_client.create_bandwidth_limit_rule("},{"line_number":146,"context_line":"            policy_id, max_kbps\u003dconstants.LIMIT_KILO_BITS_SEC,"},{"line_number":147,"context_line":"            max_burst_kbps\u003dconstants.LIMIT_KILO_BITS_SEC / 10)"},{"line_number":148,"context_line":"        port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":149,"context_line":"                                      device_id\u003dself.server["},{"line_number":150,"context_line":"                                      \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_b941b865","line":147,"updated":"2016-06-13 07:28:06.000000000","message":"Actually this was wrong, and will eventually change, it should not be /10, there was a bug in OVS, but OVS now internally is multiplying it by *8, which, makes it work.\n\nTo be safe I\u0027d try burst \u003d constants.LIMIT_KILO_BITS_SEC","commit_id":"3491c06b284a8eb6a59489db442eb3a72e9c41e2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"9f9b7bc1088df25772e90f19b4ddde838e452399","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        #TODO(itzikb) - This is a temporary until we have a better"},{"line_number":154,"context_line":"        #               way to make sure the policy is applied by the"},{"line_number":155,"context_line":"        #                backend"},{"line_number":156,"context_line":"        time.sleep(10)"},{"line_number":157,"context_line":"        test_start \u003d time.time()"},{"line_number":158,"context_line":"        self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":159,"context_line":"                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_9c47074b","line":156,"updated":"2016-06-09 14:10:41.000000000","message":"This isn\u0027t going to fly... The test should pass reliably on loaded clouds. Can QoS folks come up with an alternative solution? Does the API not let you know if the policy was applied by the agent?","commit_id":"3491c06b284a8eb6a59489db442eb3a72e9c41e2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7911d0f5a48a0dddfece275c50051c402e938282","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        #TODO(itzikb) - This is a temporary until we have a better"},{"line_number":154,"context_line":"        #               way to make sure the policy is applied by the"},{"line_number":155,"context_line":"        #                backend"},{"line_number":156,"context_line":"        time.sleep(10)"},{"line_number":157,"context_line":"        test_start \u003d time.time()"},{"line_number":158,"context_line":"        self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":159,"context_line":"                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_744e3570","line":156,"in_reply_to":"7aa08908_19b5decf","updated":"2016-06-13 07:28:06.000000000","message":"\u003c1Mbit is not possible with SR-IOV.\n\nI agree the sleep is unpredictable at all, so, we may need to wait_until a function that checks_bw works.\n\n\nIncreasing the tolerance probably would allow us to lower the buffer size of the check_bw, and hence the test time, making it more suitable for a wait_until loop.","commit_id":"3491c06b284a8eb6a59489db442eb3a72e9c41e2"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"68a08c78a2d483376fc2791a1c299e65f3ca23f0","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        #TODO(itzikb) - This is a temporary until we have a better"},{"line_number":154,"context_line":"        #               way to make sure the policy is applied by the"},{"line_number":155,"context_line":"        #                backend"},{"line_number":156,"context_line":"        time.sleep(10)"},{"line_number":157,"context_line":"        test_start \u003d time.time()"},{"line_number":158,"context_line":"        self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":159,"context_line":"                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_dcbfcf5e","line":156,"in_reply_to":"7aa08908_9c47074b","updated":"2016-06-09 14:22:26.000000000","message":"First discussion is here: https://review.openstack.org/#/c/325889/1/neutron/tests/tempest/scenario/test_qos.py@143","commit_id":"3491c06b284a8eb6a59489db442eb3a72e9c41e2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"59716533ceba5ccc908d8c2c78cea2b84a4e6fbb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        #TODO(itzikb) - This is a temporary until we have a better"},{"line_number":154,"context_line":"        #               way to make sure the policy is applied by the"},{"line_number":155,"context_line":"        #                backend"},{"line_number":156,"context_line":"        time.sleep(10)"},{"line_number":157,"context_line":"        test_start \u003d time.time()"},{"line_number":158,"context_line":"        self._check_bw(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":159,"context_line":"                       NC_PORT, constants.LIMIT_KILO_BITS_SEC,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_19b5decf","line":156,"in_reply_to":"7aa08908_dcbfcf5e","updated":"2016-06-09 16:42:24.000000000","message":"I think the way forward is to try to find an implementation of _check_bw that is fast enough to be put in a retry loop (wait_until). Then you can either keep the sleep or you don\u0027t, but the test becomes reliable enough to pass on arbitrary systems. One thing we could do is to lower the value of LIMIT_KILO_BITS_SEC, it\u0027s currently set to 1 Mbit, perhaps lowering it would make things faster.","commit_id":"3491c06b284a8eb6a59489db442eb3a72e9c41e2"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"313f2bd56ea0adc24052b3414927dd17bffbca48","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":70,"context_line":"    # Default to ipv4."},{"line_number":71,"context_line":"    _ip_version \u003d 4"},{"line_number":72,"context_line":"    BUFFER_SIZE \u003d 1 * 1024 * 1024"},{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _check_bw(self, ssh_client, host):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_19525735","line":72,"range":{"start_line":72,"start_character":18,"end_line":72,"end_character":22},"updated":"2016-06-14 07:53:39.000000000","message":"You don\u0027t need this","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":70,"context_line":"    # Default to ipv4."},{"line_number":71,"context_line":"    _ip_version \u003d 4"},{"line_number":72,"context_line":"    BUFFER_SIZE \u003d 1 * 1024 * 1024"},{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _check_bw(self, ssh_client, host):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_7cd2695d","line":72,"range":{"start_line":72,"start_character":18,"end_line":72,"end_character":22},"in_reply_to":"7aa08908_19525735","updated":"2016-06-14 08:48:10.000000000","message":"Done","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"dfd7394bf86652afebe9b0c383c0c7c4651e234d","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _check_bw(self, ssh_client, host):"},{"line_number":76,"context_line":"        BS \u003d 1024"},{"line_number":77,"context_line":"        COUNT \u003d 2 * 1024"},{"line_number":78,"context_line":"        NC_PORT \u003d 1234"},{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_1c5c087c","line":77,"updated":"2016-06-14 06:50:18.000000000","message":"Could you autocalculate COUNT from BUFFER_SIZE \u0026 BS ?  That\u0027d make the maintenance of the test easier.","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _check_bw(self, ssh_client, host):"},{"line_number":76,"context_line":"        BS \u003d 1024"},{"line_number":77,"context_line":"        COUNT \u003d 2 * 1024"},{"line_number":78,"context_line":"        NC_PORT \u003d 1234"},{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_5cd5ed40","line":77,"in_reply_to":"7aa08908_1c5c087c","updated":"2016-06-14 08:48:10.000000000","message":"Done","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e1d452892bec96fa4e2425f9578e46651f86c31f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        BS \u003d 1024"},{"line_number":77,"context_line":"        COUNT \u003d 2 * 1024"},{"line_number":78,"context_line":"        NC_PORT \u003d 1234"},{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_d6ac1cef","line":79,"updated":"2016-06-14 06:55:54.000000000","message":"why do you need another \"port\", can\u0027t you use NC_PORT down at L94 \u0026 L96","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        BS \u003d 1024"},{"line_number":77,"context_line":"        COUNT \u003d 2 * 1024"},{"line_number":78,"context_line":"        NC_PORT \u003d 1234"},{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_19453742","line":79,"in_reply_to":"7aa08908_d6ac1cef","updated":"2016-06-14 08:48:10.000000000","message":"Done","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e1d452892bec96fa4e2425f9578e46651f86c31f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        NC_PORT \u003d 1234"},{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":83,"context_line":"        total_bytes_read \u003d 0"},{"line_number":84,"context_line":"        cycle_start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_d637fce0","line":81,"updated":"2016-06-14 06:55:54.000000000","message":"more than file_size it\u0027s total_expected_bytes or something like that, but that\u0027s ok.","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e1d452892bec96fa4e2425f9578e46651f86c31f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":83,"context_line":"        total_bytes_read \u003d 0"},{"line_number":84,"context_line":"        cycle_start_time \u003d time.time()"},{"line_number":85,"context_line":"        cycle_data_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_366120d4","line":82,"updated":"2016-06-14 06:55:54.000000000","message":"maniac nit: I\u0027d put the constants all together up around L79","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":83,"context_line":"        total_bytes_read \u003d 0"},{"line_number":84,"context_line":"        cycle_start_time \u003d time.time()"},{"line_number":85,"context_line":"        cycle_data_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_7976fba4","line":82,"in_reply_to":"7aa08908_366120d4","updated":"2016-06-14 08:48:10.000000000","message":"Done","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"313f2bd56ea0adc24052b3414927dd17bffbca48","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":90,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":91,"context_line":"            pass"},{"line_number":92,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":93,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":94,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":95,"context_line":"        ssh_client.exec_command(cmd)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_7c28a986","line":92,"range":{"start_line":92,"start_character":16,"end_line":92,"end_character":17},"updated":"2016-06-14 07:53:39.000000000","message":"Just out of curiosity, why do we need a subshell here?","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":90,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":91,"context_line":"            pass"},{"line_number":92,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":93,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":94,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":95,"context_line":"        ssh_client.exec_command(cmd)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_4a4a3b56","line":92,"range":{"start_line":92,"start_character":16,"end_line":92,"end_character":17},"in_reply_to":"7aa08908_7c28a986","updated":"2016-06-14 08:48:10.000000000","message":"I tried without but it didn\u0027t work","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e1d452892bec96fa4e2425f9578e46651f86c31f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":142,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":143,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":144,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":145,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":146,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":147,"context_line":"        self.create_secgroup_rules(rulesets)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_36e64044","line":144,"updated":"2016-06-14 06:55:54.000000000","message":"1234 should be a global constant NC_PORT, or local constant, and make it become a parameter of check_bw too.","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":142,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":143,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":144,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":145,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":146,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":147,"context_line":"        self.create_secgroup_rules(rulesets)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_f9ccab6b","line":144,"in_reply_to":"7aa08908_36e64044","updated":"2016-06-14 08:48:10.000000000","message":"Done","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e1d452892bec96fa4e2425f9578e46651f86c31f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":143,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":144,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":145,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":146,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":147,"context_line":"        self.create_secgroup_rules(rulesets)"},{"line_number":148,"context_line":"        ssh_client \u003d ssh.Client(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_16e1842a","line":145,"range":{"start_line":145,"start_character":39,"end_line":145,"end_character":43},"updated":"2016-06-14 06:55:54.000000000","message":"ditto","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":143,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":144,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":145,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":146,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":147,"context_line":"        self.create_secgroup_rules(rulesets)"},{"line_number":148,"context_line":"        ssh_client \u003d ssh.Client(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_d9cbaf70","line":145,"range":{"start_line":145,"start_character":39,"end_line":145,"end_character":43},"in_reply_to":"7aa08908_16e1842a","updated":"2016-06-14 08:48:10.000000000","message":"Done","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"dfd7394bf86652afebe9b0c383c0c7c4651e234d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        utils.wait_until_true(lambda:"},{"line_number":165,"context_line":"                              self._check_bw(ssh_client,"},{"line_number":166,"context_line":"                                             self.fip[\u0027floating_ip_address\u0027]),"},{"line_number":167,"context_line":"                                             timeout\u003d120, sleep\u003d1)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_9c00f803","line":167,"updated":"2016-06-14 06:50:18.000000000","message":"To make this code easier to understand to any new reader, without the need to look into _check_bw, I\u0027d move limit_kbps as a parameter of check_bw, and use it here, then you can see all in a few lines L158-L165 that you set some bandwidth, and then wait until such bandwidth applied correctly.","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        utils.wait_until_true(lambda:"},{"line_number":165,"context_line":"                              self._check_bw(ssh_client,"},{"line_number":166,"context_line":"                                             self.fip[\u0027floating_ip_address\u0027]),"},{"line_number":167,"context_line":"                                             timeout\u003d120, sleep\u003d1)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_39c3d339","line":167,"in_reply_to":"7aa08908_9c00f803","updated":"2016-06-14 08:48:10.000000000","message":"Done","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a78ba308a234052e5244478e611b1853032e4ac","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        BS \u003d 512"},{"line_number":77,"context_line":"        COUNT \u003d QoSTest.BUFFER_SIZE / BS"},{"line_number":78,"context_line":"        NC_PORT \u003d 1234"},{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_c5dbbc4d","line":79,"updated":"2016-06-14 09:02:48.000000000","message":"\"port\" is still here :) you can just use NC_PORT","commit_id":"685bd5f40b81e30b145a8bb6622fac96bbf27512"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a78ba308a234052e5244478e611b1853032e4ac","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        NC_PORT \u003d 1234"},{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":83,"context_line":"        total_bytes_read \u003d 0"},{"line_number":84,"context_line":"        cycle_start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_25eba0dd","line":81,"updated":"2016-06-14 09:02:48.000000000","message":"total_expected_bytes would be more reasonable, this is not a file :)","commit_id":"685bd5f40b81e30b145a8bb6622fac96bbf27512"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a78ba308a234052e5244478e611b1853032e4ac","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        port \u003d NC_PORT"},{"line_number":80,"context_line":"        limit_kbps \u003d constants.LIMIT_KILO_BITS_SEC"},{"line_number":81,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":82,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":83,"context_line":"        total_bytes_read \u003d 0"},{"line_number":84,"context_line":"        cycle_start_time \u003d time.time()"},{"line_number":85,"context_line":"        cycle_data_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_05d14423","line":82,"updated":"2016-06-14 09:02:48.000000000","message":"see maniac comments in previous patchset","commit_id":"685bd5f40b81e30b145a8bb6622fac96bbf27512"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a78ba308a234052e5244478e611b1853032e4ac","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            pass"},{"line_number":92,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":93,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":94,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":95,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":96,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_858a5419","line":94,"range":{"start_line":94,"start_character":27,"end_line":94,"end_character":31},"updated":"2016-06-14 09:02:48.000000000","message":"NC_PORT","commit_id":"685bd5f40b81e30b145a8bb6622fac96bbf27512"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a78ba308a234052e5244478e611b1853032e4ac","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":142,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":143,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":144,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":145,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":146,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":147,"context_line":"        self.create_secgroup_rules(rulesets)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_45750c30","line":144,"updated":"2016-06-14 09:02:48.000000000","message":"NC_PORT","commit_id":"685bd5f40b81e30b145a8bb6622fac96bbf27512"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a78ba308a234052e5244478e611b1853032e4ac","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        rulesets \u003d [{\u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":143,"context_line":"                     \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":144,"context_line":"                     \u0027port_range_min\u0027: 1234,"},{"line_number":145,"context_line":"                     \u0027port_range_max\u0027: 1234,"},{"line_number":146,"context_line":"                     \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":147,"context_line":"        self.create_secgroup_rules(rulesets)"},{"line_number":148,"context_line":"        ssh_client \u003d ssh.Client(self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_2570c03f","line":145,"range":{"start_line":145,"start_character":39,"end_line":145,"end_character":43},"updated":"2016-06-14 09:02:48.000000000","message":"NC_PORT","commit_id":"685bd5f40b81e30b145a8bb6622fac96bbf27512"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6a78ba308a234052e5244478e611b1853032e4ac","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        utils.wait_until_true(lambda:"},{"line_number":165,"context_line":"                              self._check_bw(ssh_client,"},{"line_number":166,"context_line":"                                             self.fip[\u0027floating_ip_address\u0027]),"},{"line_number":167,"context_line":"                                             timeout\u003d120, sleep\u003d1)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_45acec8b","line":167,"updated":"2016-06-14 09:02:48.000000000","message":"see commnets in PS10","commit_id":"685bd5f40b81e30b145a8bb6622fac96bbf27512"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":87,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":88,"context_line":"            pass"},{"line_number":89,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":90,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":91,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":92,"context_line":"        ssh_client.exec_command(cmd)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_0194e7df","line":89,"range":{"start_line":89,"start_character":41,"end_line":89,"end_character":42},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":87,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":88,"context_line":"            pass"},{"line_number":89,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":90,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":91,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":92,"context_line":"        ssh_client.exec_command(cmd)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_41bc2f6c","line":89,"range":{"start_line":89,"start_character":57,"end_line":89,"end_character":58},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":87,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":88,"context_line":"            pass"},{"line_number":89,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":90,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":91,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":92,"context_line":"        ssh_client.exec_command(cmd)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_a4fd213d","line":89,"range":{"start_line":89,"start_character":41,"end_line":89,"end_character":42},"in_reply_to":"3aaa91ec_0194e7df","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":87,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":88,"context_line":"            pass"},{"line_number":89,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":90,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":91,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":92,"context_line":"        ssh_client.exec_command(cmd)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_44955de2","line":89,"range":{"start_line":89,"start_character":57,"end_line":89,"end_character":58},"in_reply_to":"3aaa91ec_41bc2f6c","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":88,"context_line":"            pass"},{"line_number":89,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":90,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":91,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":92,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":93,"context_line":"        client_socket \u003d _connect_socket(host, port)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_61b96b79","line":90,"range":{"start_line":90,"start_character":37,"end_line":90,"end_character":38},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        except exceptions.SSHExecCommandFailed:"},{"line_number":88,"context_line":"            pass"},{"line_number":89,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)s count\u003d%(count)s of\u003d/tmp/img) \""},{"line_number":90,"context_line":"               \"\u0026\u0026 (nc -ll -p %(port)s \u003c /tmp/img \u003e /dev/null \u0026)\" % {"},{"line_number":91,"context_line":"                   \u0027port\u0027: port, \u0027bs\u0027: BS, \u0027count\u0027: COUNT})"},{"line_number":92,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":93,"context_line":"        client_socket \u003d _connect_socket(host, port)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_c4894dcc","line":90,"range":{"start_line":90,"start_character":37,"end_line":90,"end_character":38},"in_reply_to":"3aaa91ec_61b96b79","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                data \u003d client_socket.recv(QoSTest.BUFFER_SIZE)"},{"line_number":98,"context_line":"            except socket.error as e:"},{"line_number":99,"context_line":"                error \u003d e.args[0]"},{"line_number":100,"context_line":"                if error \u003d\u003d errno.EAGAIN or error \u003d\u003d errno.EWOULDBLOCK:"},{"line_number":101,"context_line":"                    continue"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_44e9dd19","line":100,"range":{"start_line":100,"start_character":44,"end_line":100,"end_character":70},"updated":"2016-06-29 10:05:22.000000000","message":"Is it possible to get this error on non-blocking socket?","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                data \u003d client_socket.recv(QoSTest.BUFFER_SIZE)"},{"line_number":98,"context_line":"            except socket.error as e:"},{"line_number":99,"context_line":"                error \u003d e.args[0]"},{"line_number":100,"context_line":"                if error \u003d\u003d errno.EAGAIN or error \u003d\u003d errno.EWOULDBLOCK:"},{"line_number":101,"context_line":"                    continue"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_17854558","line":100,"range":{"start_line":100,"start_character":44,"end_line":100,"end_character":70},"in_reply_to":"3aaa91ec_44e9dd19","updated":"2016-06-29 10:20:01.000000000","message":"AFAIK yes","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            time_elapsed \u003d time.time() - cycle_start_time"},{"line_number":107,"context_line":"            should_check \u003d time_elapsed \u003e\u003d 5 or total_bytes_read \u003d\u003d file_size"},{"line_number":108,"context_line":"            if should_check:"},{"line_number":109,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":110,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""},{"line_number":111,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)s\","},{"line_number":112,"context_line":"                          {\"time_elapsed\": time_elapsed,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_84f3c509","line":109,"range":{"start_line":109,"start_character":58,"end_line":109,"end_character":59},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            time_elapsed \u003d time.time() - cycle_start_time"},{"line_number":107,"context_line":"            should_check \u003d time_elapsed \u003e\u003d 5 or total_bytes_read \u003d\u003d file_size"},{"line_number":108,"context_line":"            if should_check:"},{"line_number":109,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":110,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""},{"line_number":111,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)s\","},{"line_number":112,"context_line":"                          {\"time_elapsed\": time_elapsed,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_e47c49b7","line":109,"range":{"start_line":109,"start_character":58,"end_line":109,"end_character":59},"in_reply_to":"3aaa91ec_84f3c509","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            should_check \u003d time_elapsed \u003e\u003d 5 or total_bytes_read \u003d\u003d file_size"},{"line_number":108,"context_line":"            if should_check:"},{"line_number":109,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":110,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""},{"line_number":111,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)s\","},{"line_number":112,"context_line":"                          {\"time_elapsed\": time_elapsed,"},{"line_number":113,"context_line":"                           \"bytes_read\": total_bytes_read,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_64f699fa","line":110,"range":{"start_line":110,"start_character":59,"end_line":110,"end_character":60},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            should_check \u003d time_elapsed \u003e\u003d 5 or total_bytes_read \u003d\u003d file_size"},{"line_number":108,"context_line":"            if should_check:"},{"line_number":109,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":110,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""},{"line_number":111,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)s\","},{"line_number":112,"context_line":"                          {\"time_elapsed\": time_elapsed,"},{"line_number":113,"context_line":"                           \"bytes_read\": total_bytes_read,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_444a7d84","line":110,"range":{"start_line":110,"start_character":59,"end_line":110,"end_character":60},"in_reply_to":"3aaa91ec_64f699fa","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fe57727b7236a7fc9d605db858fdea357eb9d30b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            if should_check:"},{"line_number":109,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":110,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""},{"line_number":111,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)s\","},{"line_number":112,"context_line":"                          {\"time_elapsed\": time_elapsed,"},{"line_number":113,"context_line":"                           \"bytes_read\": total_bytes_read,"},{"line_number":114,"context_line":"                           \"cycle_data\": cycle_data_read})"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_e4e2892e","line":111,"range":{"start_line":111,"start_character":58,"end_line":111,"end_character":59},"updated":"2016-06-29 10:05:22.000000000","message":"d","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a3d63e0784c975a556b344708426b48e09e573b4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            if should_check:"},{"line_number":109,"context_line":"                LOG.debug(\"time_elapsed \u003d  %(time_elapsed)s,\""},{"line_number":110,"context_line":"                          \"total_bytes_read \u003d %(bytes_read)s,\""},{"line_number":111,"context_line":"                          \"cycle_data_read \u003d %(cycle_data)s\","},{"line_number":112,"context_line":"                          {\"time_elapsed\": time_elapsed,"},{"line_number":113,"context_line":"                           \"bytes_read\": total_bytes_read,"},{"line_number":114,"context_line":"                           \"cycle_data\": cycle_data_read})"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_84446574","line":111,"range":{"start_line":111,"start_character":58,"end_line":111,"end_character":59},"in_reply_to":"3aaa91ec_e4e2892e","updated":"2016-06-29 10:20:01.000000000","message":"Done","commit_id":"d60ddb9a40e91ab08bda1cc1a6da4d37e5f4c288"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"848777ff32774fc04eedbc714ecac165f221b821","unresolved":false,"context_lines":[{"line_number":67,"context_line":"class QoSTest(base.BaseTempestTestCase):"},{"line_number":68,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":69,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":70,"context_line":"    # Default to ipv4."},{"line_number":71,"context_line":"    _ip_version \u003d 4"},{"line_number":72,"context_line":"    BUFFER_SIZE \u003d 1024 * 1024"},{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_57788dc4","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":22},"updated":"2016-07-05 10:57:01.000000000","message":"The \u0027_ip_version \u003d 4\u0027 is self-explainatory so this comment can be removed.","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"677a1285ca2696f257e984592d7b0500a4c5f0bc","unresolved":false,"context_lines":[{"line_number":67,"context_line":"class QoSTest(base.BaseTempestTestCase):"},{"line_number":68,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":69,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":70,"context_line":"    # Default to ipv4."},{"line_number":71,"context_line":"    _ip_version \u003d 4"},{"line_number":72,"context_line":"    BUFFER_SIZE \u003d 1024 * 1024"},{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_a07ac4ba","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":22},"in_reply_to":"1aa78d24_57788dc4","updated":"2016-07-10 09:41:59.000000000","message":"Done","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"848777ff32774fc04eedbc714ecac165f221b821","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _check_bw(self, ssh_client, host, port, limit_kbps):"},{"line_number":76,"context_line":"        BS \u003d 512"},{"line_number":77,"context_line":"        COUNT \u003d QoSTest.BUFFER_SIZE / BS"},{"line_number":78,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":79,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":80,"context_line":"        total_bytes_read \u003d 0"},{"line_number":81,"context_line":"        cycle_start_time \u003d time.time()"},{"line_number":82,"context_line":"        cycle_data_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_f73ed9d8","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":30},"updated":"2016-07-05 10:57:01.000000000","message":"All of these (including LIMIT_BYTES_SEC, which depends on limit_kbps which in itself always get some constant value) are constants and depends only on known values pre-run, so they shouldn\u0027t be defined in this function.","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"677a1285ca2696f257e984592d7b0500a4c5f0bc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _check_bw(self, ssh_client, host, port, limit_kbps):"},{"line_number":76,"context_line":"        BS \u003d 512"},{"line_number":77,"context_line":"        COUNT \u003d QoSTest.BUFFER_SIZE / BS"},{"line_number":78,"context_line":"        LIMIT_BYTES_SEC \u003d limit_kbps * 1024 * QoSTest.TOLERANCE_FACTOR / 8.0"},{"line_number":79,"context_line":"        file_size \u003d BS * COUNT"},{"line_number":80,"context_line":"        total_bytes_read \u003d 0"},{"line_number":81,"context_line":"        cycle_start_time \u003d time.time()"},{"line_number":82,"context_line":"        cycle_data_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_0b95b931","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":30},"in_reply_to":"1aa78d24_f73ed9d8","updated":"2016-07-10 09:41:59.000000000","message":"Done","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"848777ff32774fc04eedbc714ecac165f221b821","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                data \u003d client_socket.recv(QoSTest.BUFFER_SIZE)"},{"line_number":98,"context_line":"            except socket.error as e:"},{"line_number":99,"context_line":"                error \u003d e.args[0]"},{"line_number":100,"context_line":"                if error \u003d\u003d errno.EAGAIN or error \u003d\u003d errno.EWOULDBLOCK:"},{"line_number":101,"context_line":"                    continue"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_b250df0b","line":100,"range":{"start_line":100,"start_character":41,"end_line":100,"end_character":43},"updated":"2016-07-05 10:57:01.000000000","message":"nit: might as well check \u0027if e.args[0] in [errno.EAGAIN, errno.EWOULDBLOCK]\u0027. This will save the extra \u0027error\u0027 variable which is only used in this scope.","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"677a1285ca2696f257e984592d7b0500a4c5f0bc","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                data \u003d client_socket.recv(QoSTest.BUFFER_SIZE)"},{"line_number":98,"context_line":"            except socket.error as e:"},{"line_number":99,"context_line":"                error \u003d e.args[0]"},{"line_number":100,"context_line":"                if error \u003d\u003d errno.EAGAIN or error \u003d\u003d errno.EWOULDBLOCK:"},{"line_number":101,"context_line":"                    continue"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_cbec51bd","line":100,"range":{"start_line":100,"start_character":41,"end_line":100,"end_character":43},"in_reply_to":"1aa78d24_b250df0b","updated":"2016-07-10 09:41:59.000000000","message":"Done","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"848777ff32774fc04eedbc714ecac165f221b821","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"                if cycle_data_read / time_elapsed \u003e LIMIT_BYTES_SEC:"},{"line_number":117,"context_line":"                    # Limit reached"},{"line_number":118,"context_line":"                    return False"},{"line_number":119,"context_line":"                else:"},{"line_number":120,"context_line":"                    cycle_start_time \u003d time.time()"},{"line_number":121,"context_line":"                    cycle_data_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_f786d9d9","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":32},"updated":"2016-07-05 10:57:01.000000000","message":"If we reached here, it means that we\u0027ve crossed the bandwidth limit, so we want to stop immediately and fail the test. Returning \u0027False\u0027 here means that _check_bw will simply be run again (because that\u0027s what \u0027wait_until_true\u0027 does), regardless of the fact that we already failed.\n\nPlease change this to some meaningful exception instead.","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"677a1285ca2696f257e984592d7b0500a4c5f0bc","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"                if cycle_data_read / time_elapsed \u003e LIMIT_BYTES_SEC:"},{"line_number":117,"context_line":"                    # Limit reached"},{"line_number":118,"context_line":"                    return False"},{"line_number":119,"context_line":"                else:"},{"line_number":120,"context_line":"                    cycle_start_time \u003d time.time()"},{"line_number":121,"context_line":"                    cycle_data_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_cb8d71d4","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":32},"in_reply_to":"1aa78d24_f786d9d9","updated":"2016-07-10 09:41:59.000000000","message":"@John - This was discussed. If there is a better way - I\u0027ll change it.","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"848777ff32774fc04eedbc714ecac165f221b821","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                      \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":160,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":161,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":162,"context_line":"        utils.wait_until_true(lambda: self._check_bw("},{"line_number":163,"context_line":"            ssh_client,"},{"line_number":164,"context_line":"            self.fip[\u0027floating_ip_address\u0027],"},{"line_number":165,"context_line":"            port\u003dNC_PORT,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_b7bf315f","line":162,"range":{"start_line":162,"start_character":14,"end_line":162,"end_character":29},"updated":"2016-07-05 10:57:01.000000000","message":"I liked the usage of wait_until_true, but I do believe we want to split \u0027check_bw\u0027 into more than one function: one function running netcat, and another for running the actual test. This will have the added benefit of not having to re-create a dummy file each time we run the function.","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"677a1285ca2696f257e984592d7b0500a4c5f0bc","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                      \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":160,"context_line":"        self.admin_manager.network_client.update_port(port[\u0027id\u0027],"},{"line_number":161,"context_line":"                                                      qos_policy_id\u003dpolicy_id)"},{"line_number":162,"context_line":"        utils.wait_until_true(lambda: self._check_bw("},{"line_number":163,"context_line":"            ssh_client,"},{"line_number":164,"context_line":"            self.fip[\u0027floating_ip_address\u0027],"},{"line_number":165,"context_line":"            port\u003dNC_PORT,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_deb81f78","line":162,"range":{"start_line":162,"start_character":14,"end_line":162,"end_character":29},"in_reply_to":"1aa78d24_b7bf315f","updated":"2016-07-10 09:41:59.000000000","message":"@John see above","commit_id":"a8bc3efbcc6d509e2ac77619899c729ca230d21f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"29c41fd028b680066c25ba5897e8a74f3ed02259","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       * TOLERANCE_FACTOR / 8.0)"},{"line_number":78,"context_line":"    FILE_PATH \u003d \"/tmp/img\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _create_file_for_bw_tests(self, ssh_client, file_path):"},{"line_number":81,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)d count\u003d%(count)d of\u003d%(file_path)s) \""},{"line_number":82,"context_line":"               % {\u0027bs\u0027: QoSTest.BS, \u0027count\u0027: QoSTest.COUNT,"},{"line_number":83,"context_line":"               \u0027file_path\u0027: QoSTest.FILE_PATH})"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_64935efb","line":80,"range":{"start_line":80,"start_character":52,"end_line":80,"end_character":61},"updated":"2016-07-10 14:04:01.000000000","message":"file_path is always initialized to FILE_PATH, so this variable can be removed.m Also, it is unused :)","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e97d7293e777d42402d6934ffcd434b4658b26b9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       * TOLERANCE_FACTOR / 8.0)"},{"line_number":78,"context_line":"    FILE_PATH \u003d \"/tmp/img\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _create_file_for_bw_tests(self, ssh_client, file_path):"},{"line_number":81,"context_line":"        cmd \u003d (\"(dd if\u003d/dev/zero bs\u003d%(bs)d count\u003d%(count)d of\u003d%(file_path)s) \""},{"line_number":82,"context_line":"               % {\u0027bs\u0027: QoSTest.BS, \u0027count\u0027: QoSTest.COUNT,"},{"line_number":83,"context_line":"               \u0027file_path\u0027: QoSTest.FILE_PATH})"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_44a58245","line":80,"range":{"start_line":80,"start_character":52,"end_line":80,"end_character":61},"in_reply_to":"1aa78d24_64935efb","updated":"2016-07-10 14:44:53.000000000","message":"Done","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"29c41fd028b680066c25ba5897e8a74f3ed02259","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               \u0027file_path\u0027: QoSTest.FILE_PATH})"},{"line_number":84,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":85,"context_line":"        cmd \u003d \"stat -c %%s %s\" % QoSTest.FILE_PATH"},{"line_number":86,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":87,"context_line":"        filesize \u003d ssh_client.exec_command(cmd)"},{"line_number":88,"context_line":"        if int(filesize.strip()) !\u003d QoSTest.FILE_SIZE:"},{"line_number":89,"context_line":"            raise sc_exceptions.FileCreationFailedException("}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_e49e2e06","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":36},"updated":"2016-07-10 14:04:01.000000000","message":"No need to run the \u0027stat\u0027 command twice.","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e97d7293e777d42402d6934ffcd434b4658b26b9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               \u0027file_path\u0027: QoSTest.FILE_PATH})"},{"line_number":84,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":85,"context_line":"        cmd \u003d \"stat -c %%s %s\" % QoSTest.FILE_PATH"},{"line_number":86,"context_line":"        ssh_client.exec_command(cmd)"},{"line_number":87,"context_line":"        filesize \u003d ssh_client.exec_command(cmd)"},{"line_number":88,"context_line":"        if int(filesize.strip()) !\u003d QoSTest.FILE_SIZE:"},{"line_number":89,"context_line":"            raise sc_exceptions.FileCreationFailedException("}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_c4b85278","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":36},"in_reply_to":"1aa78d24_e49e2e06","updated":"2016-07-10 14:44:53.000000000","message":"Done","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"29c41fd028b680066c25ba5897e8a74f3ed02259","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        cycle_data_read \u003d 0"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        cmd \u003d \"killall -q nc\""},{"line_number":98,"context_line":"        self._create_file_for_bw_tests(ssh_client, QoSTest.FILE_PATH)"},{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":101,"context_line":"        except exceptions.SSHExecCommandFailed:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_84976aea","line":98,"range":{"start_line":98,"start_character":13,"end_line":98,"end_character":38},"updated":"2016-07-10 14:04:01.000000000","message":"This shouldn\u0027t be called every time _check_bw is called (since _check_bw merely checks the bandwidth and shouldn\u0027t handle the actual file\u0027s existance).\n\nI suggest calling this *before* the wait_until_true. You can even call this multiple times until the size is correct (using another wait_until_true for this).","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e97d7293e777d42402d6934ffcd434b4658b26b9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        cycle_data_read \u003d 0"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        cmd \u003d \"killall -q nc\""},{"line_number":98,"context_line":"        self._create_file_for_bw_tests(ssh_client, QoSTest.FILE_PATH)"},{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            ssh_client.exec_command(cmd)"},{"line_number":101,"context_line":"        except exceptions.SSHExecCommandFailed:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_8f014307","line":98,"range":{"start_line":98,"start_character":13,"end_line":98,"end_character":38},"in_reply_to":"1aa78d24_84976aea","updated":"2016-07-10 14:44:53.000000000","message":"Taking the first method.","commit_id":"9ff9d744150f28f938726cc10042e7f7390e70b2"}],"neutron/tests/tempest/scenario/utils.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0ef61095ec18ee43e841c9b7ebedcdaeb8387371","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def wait_until_true(predicate, timeout\u003d60, sleep\u003d1, exception\u003dNone):"},{"line_number":19,"context_line":"    \"\"\""},{"line_number":20,"context_line":"    Wait until callable predicate is evaluated as True"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_1617c445","line":18,"updated":"2016-06-14 06:51:05.000000000","message":"Question, why can\u0027t you use the other wait_until_true defined in neutron test utils?.","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0556b0eef6cea69aedb2e87bd5d765f0c4868e43","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def wait_until_true(predicate, timeout\u003d60, sleep\u003d1, exception\u003dNone):"},{"line_number":19,"context_line":"    \"\"\""},{"line_number":20,"context_line":"    Wait until callable predicate is evaluated as True"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_dcc71d43","line":18,"in_reply_to":"7aa08908_1617c445","updated":"2016-06-14 08:48:10.000000000","message":"I had errors when trying from neutron.agent.linux import utils\nhttp://paste.openstack.org/show/515920/","commit_id":"51475ea0080fe08f82c5af21b98473b94d95dadd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"746e6d5440865a7cfacae4eda7b1f83b3d15e936","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7aa08908_8b28a587","updated":"2016-06-14 09:24:17.000000000","message":"Oh, I missed this file. Copying code is not good at all. We should find a way how to import existing code.","commit_id":"f2b03add1f6c0d000fb9b78c0a47640ff0702aa9"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"ec3fd2aad1013bef675c6c9b7874bdfacc637483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7aa08908_1d1b1f1e","in_reply_to":"7aa08908_17fdbe3b","updated":"2016-06-15 08:53:46.000000000","message":"This sounds like a good approach. neutron.common.utils only imports neutron.db.api for its\u0027 MAX_RETRIES variable (and nothing else). It sounds like a good idea to shuffle some stuff around (i.e. move MAX_RETRIES to some const.py, move wait_until_true to neutron.common.utils).","commit_id":"f2b03add1f6c0d000fb9b78c0a47640ff0702aa9"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5e7dd9ec8a42736691932683ebbf9b2d92d4ef18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7aa08908_17fdbe3b","in_reply_to":"7aa08908_7a21b09d","updated":"2016-06-15 08:22:06.000000000","message":"About this, we should probably move wait_until_true to a module where the configuration is not imported, because wait_until_true doesn\u0027t need it at all and causes havoc when importing all the agent config from here.","commit_id":"f2b03add1f6c0d000fb9b78c0a47640ff0702aa9"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a4271b46438cfdcb4bd73d69349654a2e739ffa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7aa08908_7a21b09d","in_reply_to":"7aa08908_8b28a587","updated":"2016-06-14 15:08:19.000000000","message":"Jakub opened a bug related to the errors I mentioned in PS10\nhttps://bugs.launchpad.net/tempest/+bug/1592345","commit_id":"f2b03add1f6c0d000fb9b78c0a47640ff0702aa9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"746e6d5440865a7cfacae4eda7b1f83b3d15e936","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def wait_until_true(predicate, timeout\u003d60, sleep\u003d1, exception\u003dNone):"},{"line_number":19,"context_line":"    \"\"\""},{"line_number":20,"context_line":"    Wait until callable predicate is evaluated as True"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_6b2bb982","line":17,"updated":"2016-06-14 09:24:17.000000000","message":"Our pep8 job really sucks. Empty line is missing and L15 should be removed.","commit_id":"f2b03add1f6c0d000fb9b78c0a47640ff0702aa9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4039aeac72ae6ec489633ea5a02fd3a00e8ce8c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7aa08908_980e7d3b","updated":"2016-06-17 11:24:48.000000000","message":"Remove this file","commit_id":"b0d24eaa04ebc7fdef50466b01919ff1fffe82c6"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b6a2dfd1bd52ddf94cec58825efe26687c0b4a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7aa08908_99131c65","in_reply_to":"7aa08908_980e7d3b","updated":"2016-06-17 13:11:15.000000000","message":"Done","commit_id":"b0d24eaa04ebc7fdef50466b01919ff1fffe82c6"}]}
