)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d1b6ccd23761e19863a61e44bd3f88b3cb81dfd4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The error appeared because AppManager.close() was"},{"line_number":10,"context_line":"called twice, trying to uninstantiate apps that have"},{"line_number":11,"context_line":"already been uninstantiated."},{"line_number":12,"context_line":"The patch solves the problem by removing duplicate"},{"line_number":13,"context_line":"close() in cleanup."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia823c97559d87e020fa91480e96a3768373064ef"},{"line_number":16,"context_line":"Closes-Bug: #1589746"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_2a8ecfcf","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":19},"updated":"2016-06-08 12:45:28.000000000","message":"this a bit contradicts with the code change :) can you please give more detail on the fix?","commit_id":"7eb2773d7c8f2333aca79cc9c7aae3fa1613a4ac"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"9bb33341c3d27a3c77b814aad81dd4d9d1d571e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The error appeared because AppManager.close() was"},{"line_number":10,"context_line":"called twice, trying to uninstantiate apps that have"},{"line_number":11,"context_line":"already been uninstantiated."},{"line_number":12,"context_line":"The patch solves the problem by removing duplicate"},{"line_number":13,"context_line":"close() in cleanup."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia823c97559d87e020fa91480e96a3768373064ef"},{"line_number":16,"context_line":"Closes-Bug: #1589746"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_ec6dfccc","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":19},"in_reply_to":"7aa08908_2a8ecfcf","updated":"2016-06-08 14:26:12.000000000","message":"The thing is I had to substitute a call to run_apps() with the altered version of the original function from ryu lib (without close() in finally block) because of the cleanup strategy introduced by https://review.openstack.org/#/c/257204/6. I can document all this but there might be a more elegant way to perform the cleanup and I\u0027m looking at it.\n\nI\u0027ll mark the patch as WIP for now.","commit_id":"7eb2773d7c8f2333aca79cc9c7aae3fa1613a4ac"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"0701f7a561ff5a64e3c7917a2517c20b7a6f3bd9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The error appeared because AppManager.close() was"},{"line_number":10,"context_line":"called twice, trying to uninstantiate apps that have"},{"line_number":11,"context_line":"already been uninstantiated."},{"line_number":12,"context_line":"The patch solves the problem by removing duplicate"},{"line_number":13,"context_line":"close() in cleanup."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia823c97559d87e020fa91480e96a3768373064ef"},{"line_number":16,"context_line":"Closes-Bug: #1589746"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_f96aebb1","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":19},"in_reply_to":"7aa08908_d8cf657d","updated":"2016-06-14 07:24:53.000000000","message":"It may be solved by overriding AppManager\u0027s close method and introducing some \"already cleaned up\" flag (if that\u0027s what you mean by putting a conditional). If I come up with no cleaner ideas that these two, I\u0027ll implement the abovementioned approach.","commit_id":"7eb2773d7c8f2333aca79cc9c7aae3fa1613a4ac"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7fd48dc641587404cf6e0878f250954496178fe4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The error appeared because AppManager.close() was"},{"line_number":10,"context_line":"called twice, trying to uninstantiate apps that have"},{"line_number":11,"context_line":"already been uninstantiated."},{"line_number":12,"context_line":"The patch solves the problem by removing duplicate"},{"line_number":13,"context_line":"close() in cleanup."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia823c97559d87e020fa91480e96a3768373064ef"},{"line_number":16,"context_line":"Closes-Bug: #1589746"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_d8cf657d","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":19},"in_reply_to":"7aa08908_ec6dfccc","updated":"2016-06-13 01:18:12.000000000","message":"can you just put a conditional in the other cleanup strategy to detect when close has already been called?","commit_id":"7eb2773d7c8f2333aca79cc9c7aae3fa1613a4ac"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/main.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7fd48dc641587404cf6e0878f250954496178fe4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        for t in services:"},{"line_number":56,"context_line":"            t.kill()"},{"line_number":57,"context_line":"        hub.joinall(services)"},{"line_number":58,"context_line":"        gc.collect()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_58a255af","line":58,"updated":"2016-06-13 01:18:12.000000000","message":"Why calling gc explicitly? It seems something is making an assumption (either us or RYU) that needs to be addressed if we are depending on a GC call to properly exit.","commit_id":"7eb2773d7c8f2333aca79cc9c7aae3fa1613a4ac"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"0701f7a561ff5a64e3c7917a2517c20b7a6f3bd9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        for t in services:"},{"line_number":56,"context_line":"            t.kill()"},{"line_number":57,"context_line":"        hub.joinall(services)"},{"line_number":58,"context_line":"        gc.collect()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_96e9f481","line":58,"in_reply_to":"7aa08908_58a255af","updated":"2016-06-14 07:24:53.000000000","message":"Hm, I\u0027ll try to find out why this call is present in ryu lib\u0027s run_apps.","commit_id":"7eb2773d7c8f2333aca79cc9c7aae3fa1613a4ac"}]}
