)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6e00c74ba52663432b6427a9f9370098ff366e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Artur Korzeniewski \u003cartur.korzeniewski@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-07 15:50:01 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Objects: DNSNameServer OVO usage patch."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icd833eae062b23555d4e53cf2cbd5bcd17cf2108"},{"line_number":10,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_4a7cedeb","line":7,"updated":"2016-06-08 15:24:13.000000000","message":"Let\u0027s be a tad more friendly to readers from outside the upgades group. Let\u0027s add some details about what this patch is about, what it bases on (the patch that added the obiect itself), what\u0027s the goal (eliminating direct access to models).","commit_id":"1a7652e894689728461c6a11e59a27f7cfe94601"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ac37e4d4321a155b44c2d59df0beae54dd566d92","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Artur Korzeniewski \u003cartur.korzeniewski@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-14 15:31:17 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Objects: DNSNameServer object usage in db base common and ipam backend."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added sorting by \u0027order\u0027 field when passing \u0027subnet_id\u0027 as filter field"},{"line_number":10,"context_line":"in DNSNameServer.get_objects()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_14abfc1f","line":7,"updated":"2016-06-15 08:15:04.000000000","message":"nit: it would be more understandable something like:\n\n\"Introduce the DNSNameServer OVO in the code\"","commit_id":"c957ca68ce54474c020af834ee3d80771a3e4e83"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ac37e4d4321a155b44c2d59df0beae54dd566d92","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added sorting by \u0027order\u0027 field when passing \u0027subnet_id\u0027 as filter field"},{"line_number":10,"context_line":"in DNSNameServer.get_objects()."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The DNSNameServer is used in IPAM backend mixin in update subnet"},{"line_number":13,"context_line":"dns nameservers and in save subnet."},{"line_number":14,"context_line":"In db_base_plugin_common, _get_dns_by_subnet is returning the DNS name"},{"line_number":15,"context_line":"servers for subnet_id, sorted by \u0027order\u0027 field."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_7456c02b","line":12,"updated":"2016-06-15 08:15:04.000000000","message":"lines 12-15 can be removed, they don\u0027t add any info that cannot be easily get looking briefly at the code","commit_id":"c957ca68ce54474c020af834ee3d80771a3e4e83"}],"neutron/db/db_base_plugin_common.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6e00c74ba52663432b6427a9f9370098ff366e6","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        return port"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def _get_dns_by_subnet(self, context, subnet_id):"},{"line_number":236,"context_line":"        pager \u003d obj_base.Pager(sorts\u003d[(\u0027order\u0027, False)])"},{"line_number":237,"context_line":"        return subnet_obj.DNSNameServer.get_objects(context,"},{"line_number":238,"context_line":"                                                    _pager\u003dpager,"},{"line_number":239,"context_line":"                                                    subnet_id\u003dsubnet_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cd44774b","line":236,"range":{"start_line":236,"start_character":48,"end_line":236,"end_character":53},"updated":"2016-06-08 15:24:13.000000000","message":"looking at get_sorts in neutron/api/api_common.py, it seems like True is for ASC, and False is for DESC. I guess we want the former?","commit_id":"1a7652e894689728461c6a11e59a27f7cfe94601"}],"neutron/objects/subnet.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ac37e4d4321a155b44c2d59df0beae54dd566d92","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Default sort by \u0027order\u0027 field when subnet_id is passed in kwargs."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        if not _pager:"},{"line_number":45,"context_line":"            _pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_7749a260","line":42,"range":{"start_line":42,"start_character":10,"end_line":42,"end_character":75},"updated":"2016-06-15 08:15:04.000000000","message":"How would the caller know that if the subnet_id is passed the objects get sorted? I see two clearer option:\n\n1) call get_objects in _get_dns_by_subnet and pass the _pager\n2) create a new method get_ordered_objects or something like that.\n\nI lean toward 1","commit_id":"c957ca68ce54474c020af834ee3d80771a3e4e83"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"62dd71c9b479e23994bcd9be0022951d27391901","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Default sort by \u0027order\u0027 field when subnet_id is passed in kwargs."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        if not _pager:"},{"line_number":45,"context_line":"            _pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_1555b3f9","line":42,"range":{"start_line":42,"start_character":10,"end_line":42,"end_character":75},"in_reply_to":"7aa08908_7749a260","updated":"2016-06-15 09:49:00.000000000","message":"In PS1, I had the pager created in _get_dns_by_subnet. I removed it, since when you fetch the subnet object, the DNS nameservers should be by default sorted. \nIt is the requirements when integrating subnet with current code base. In implementation of loading the synthetic fields in base object, we cannot pass the pager dependent on the subnet object and dns_nameservers fields. \n\nSo I have decided to load the dns nameservers sorted by default with order, when the caller specify the subnet_id, which is the case on load_synthetic field.\n\nIf returning to version 1), I would have to modify the load_synthetic fields in general way to sort the DNS nameservers by order when loading the synthetic fields for subnet.\nOption 2) creating the get_ordered_objects should be introduced in all objects and used in load_synthetic_fields like here [1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L403","commit_id":"c957ca68ce54474c020af834ee3d80771a3e4e83"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Default sort by \u0027order\u0027 field."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        if not _pager:"},{"line_number":45,"context_line":"            _pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_9c1fca08","line":42,"updated":"2016-06-16 12:56:41.000000000","message":"That does not seem like a reasonable docstring for the method. It\u0027s just a comment for the code, but it does not describe the method.","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f6fbbc16bf7ea7f3afea01fc9cb991aafbccf4d4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Default sort by \u0027order\u0027 field."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        if not _pager:"},{"line_number":45,"context_line":"            _pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_a90b342a","line":42,"in_reply_to":"7aa08908_9c1fca08","updated":"2016-06-17 08:44:26.000000000","message":"Done","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if not _pager:"},{"line_number":45,"context_line":"            _pager \u003d base.Pager()"},{"line_number":46,"context_line":"        if not _pager.sorts:"},{"line_number":47,"context_line":"            _pager.sorts \u003d [(\u0027order\u0027, True)]"},{"line_number":48,"context_line":"        return  super(DNSNameServer, cls).get_objects(context, _pager,"},{"line_number":49,"context_line":"                                                      **kwargs)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_fcd40e20","line":47,"updated":"2016-06-16 12:56:41.000000000","message":"To be clear for readers, let\u0027s specify here what True means (ASC order).","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f6fbbc16bf7ea7f3afea01fc9cb991aafbccf4d4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if not _pager:"},{"line_number":45,"context_line":"            _pager \u003d base.Pager()"},{"line_number":46,"context_line":"        if not _pager.sorts:"},{"line_number":47,"context_line":"            _pager.sorts \u003d [(\u0027order\u0027, True)]"},{"line_number":48,"context_line":"        return  super(DNSNameServer, cls).get_objects(context, _pager,"},{"line_number":49,"context_line":"                                                      **kwargs)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_8906381f","line":47,"in_reply_to":"7aa08908_fcd40e20","updated":"2016-06-17 08:44:26.000000000","message":"Done","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ac37e4d4321a155b44c2d59df0beae54dd566d92","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        super(BaseObjectIfaceTestCase, self).setUp()"},{"line_number":341,"context_line":"        self.model_map \u003d collections.defaultdict(list)"},{"line_number":342,"context_line":"        self.model_map[self._test_class.db_model] \u003d self.db_objs"},{"line_number":343,"context_line":"        self.pager_map \u003d collections.defaultdict(lambda: None)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def test_get_object(self):"},{"line_number":346,"context_line":"        with mock.patch.object(obj_db_api, \u0027get_object\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_37cc3a8a","line":343,"updated":"2016-06-15 08:15:04.000000000","message":"if you follow my proposal I think all these changes to the unit tests are not needed.","commit_id":"c957ca68ce54474c020af834ee3d80771a3e4e83"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                    mock_calls.append("},{"line_number":380,"context_line":"                        mock.call("},{"line_number":381,"context_line":"                            self.context, obj_class.db_model,"},{"line_number":382,"context_line":"                            _pager\u003dself.pager_map[field],"},{"line_number":383,"context_line":"                            **{k: db_obj[v]"},{"line_number":384,"context_line":"                            for k, v in obj_class.foreign_keys.items()}))"},{"line_number":385,"context_line":"        return mock_calls"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_fc908e44","line":382,"range":{"start_line":382,"start_character":50,"end_line":382,"end_character":55},"updated":"2016-06-16 12:56:41.000000000","message":"field? Not obj_name?","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f6fbbc16bf7ea7f3afea01fc9cb991aafbccf4d4","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                    mock_calls.append("},{"line_number":380,"context_line":"                        mock.call("},{"line_number":381,"context_line":"                            self.context, obj_class.db_model,"},{"line_number":382,"context_line":"                            _pager\u003dself.pager_map[field],"},{"line_number":383,"context_line":"                            **{k: db_obj[v]"},{"line_number":384,"context_line":"                            for k, v in obj_class.foreign_keys.items()}))"},{"line_number":385,"context_line":"        return mock_calls"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_69114c5d","line":382,"range":{"start_line":382,"start_character":50,"end_line":382,"end_character":55},"in_reply_to":"7aa08908_d7612bd5","updated":"2016-06-17 08:44:26.000000000","message":"Done","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a300d2a528cafd5a36128c85f224588ca45e5f65","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                    mock_calls.append("},{"line_number":380,"context_line":"                        mock.call("},{"line_number":381,"context_line":"                            self.context, obj_class.db_model,"},{"line_number":382,"context_line":"                            _pager\u003dself.pager_map[field],"},{"line_number":383,"context_line":"                            **{k: db_obj[v]"},{"line_number":384,"context_line":"                            for k, v in obj_class.foreign_keys.items()}))"},{"line_number":385,"context_line":"        return mock_calls"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_d7612bd5","line":382,"range":{"start_line":382,"start_character":50,"end_line":382,"end_character":55},"in_reply_to":"7aa08908_fc908e44","updated":"2016-06-16 12:57:57.000000000","message":"that is weird: in some places you use field name, in others object names. I think you should stick to the latter uniformly.","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ca8385f10c2e4e7294c933a8da8f8c1cbbceb361","unresolved":false,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":"class PagerTestCase(test_base.BaseTestCase):"},{"line_number":879,"context_line":"    def setUp(self):"},{"line_number":880,"context_line":"        super(PagerTestCase, self).setUp()"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def test_comparison(self):"},{"line_number":883,"context_line":"        pager \u003d base.Pager(sorts\u003d[(\u0027order\u0027, True)])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_9e794d32","line":880,"updated":"2016-06-17 09:22:18.000000000","message":"That setUp is redundant. Please remove.","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"201c75ac483b08a1c052517749c1da0d7650b6d6","unresolved":false,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":"class PagerTestCase(test_base.BaseTestCase):"},{"line_number":879,"context_line":"    def setUp(self):"},{"line_number":880,"context_line":"        super(PagerTestCase, self).setUp()"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def test_comparison(self):"},{"line_number":883,"context_line":"        pager \u003d base.Pager(sorts\u003d[(\u0027order\u0027, True)])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_07c50c5b","line":880,"in_reply_to":"7aa08908_9e794d32","updated":"2016-06-17 10:11:41.000000000","message":"Done","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b854607f2c3e42343274aeaf6cba9836feb876ba","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        super(BaseObjectIfaceTestCase, self).setUp()"},{"line_number":341,"context_line":"        self.model_map \u003d collections.defaultdict(list)"},{"line_number":342,"context_line":"        self.model_map[self._test_class.db_model] \u003d self.db_objs"},{"line_number":343,"context_line":"        self.pager_map \u003d collections.defaultdict(lambda: None)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def test_get_object(self):"},{"line_number":346,"context_line":"        with mock.patch.object(obj_db_api, \u0027get_object\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_30ba59e2","line":343,"updated":"2016-06-22 09:06:24.000000000","message":"mmm this adds complexity to the base class and till now only DNSNameServer needs to specify the pager. Following YAGNI I wouldn\u0027t modify the base class, I\u0027d override the tests in test_subnet.py unless we have in mind some class that might need this and will be added in the near future.","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04db056733a8403f2ccd91d7fd9f46812475bd03","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        super(BaseObjectIfaceTestCase, self).setUp()"},{"line_number":341,"context_line":"        self.model_map \u003d collections.defaultdict(list)"},{"line_number":342,"context_line":"        self.model_map[self._test_class.db_model] \u003d self.db_objs"},{"line_number":343,"context_line":"        self.pager_map \u003d collections.defaultdict(lambda: None)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def test_get_object(self):"},{"line_number":346,"context_line":"        with mock.patch.object(obj_db_api, \u0027get_object\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_e7437d11","line":343,"in_reply_to":"3aaa91ec_30ba59e2","updated":"2016-06-24 07:39:37.000000000","message":"hmm, I do not like the idea of copy-paste the 3 methods just to add a pager. It is used in 2 classes in test_subnet.py, so it means that I would need to copy 3 methods two times... nope, does not sound like a good idea...","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7752623e6223c62dc3b7047095137128e1695a50","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        self.assertIn(filter_name, self.registered_object.extra_filter_names)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"class PagerTestCase(test_base.BaseTestCase):"},{"line_number":896,"context_line":"    def test_comparison(self):"},{"line_number":897,"context_line":"        pager \u003d base.Pager(sorts\u003d[(\u0027order\u0027, True)])"},{"line_number":898,"context_line":"        pager2 \u003d base.Pager(sorts\u003d[(\u0027order\u0027, True)])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_566741ea","line":895,"updated":"2016-06-27 14:13:32.000000000","message":"why do we need this test? What values does it add?","commit_id":"87c00402c3fba28317f01b3359941f9ab553b801"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"e09b4b989e243843d5e83087cabf6b9261720517","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        self.assertIn(filter_name, self.registered_object.extra_filter_names)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"class PagerTestCase(test_base.BaseTestCase):"},{"line_number":896,"context_line":"    def test_comparison(self):"},{"line_number":897,"context_line":"        pager \u003d base.Pager(sorts\u003d[(\u0027order\u0027, True)])"},{"line_number":898,"context_line":"        pager2 \u003d base.Pager(sorts\u003d[(\u0027order\u0027, True)])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_36f43586","line":895,"in_reply_to":"3aaa91ec_566741ea","updated":"2016-06-27 14:41:19.000000000","message":"before this patch pager objects was not comparable and since I have added the functionality to compare the pagers, I have also added the unit test for that.","commit_id":"87c00402c3fba28317f01b3359941f9ab553b801"}],"neutron/tests/unit/objects/test_subnet.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":48,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d mock.ANY"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class DNSNameServerDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_fcdece0e","line":48,"range":{"start_line":48,"start_character":54,"end_line":48,"end_character":62},"updated":"2016-06-16 12:56:41.000000000","message":"Maybe instead actually specifying which pager is expected?","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f6fbbc16bf7ea7f3afea01fc9cb991aafbccf4d4","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":48,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d mock.ANY"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class DNSNameServerDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_493d70dc","line":48,"range":{"start_line":48,"start_character":54,"end_line":48,"end_character":62},"in_reply_to":"7aa08908_77e67445","updated":"2016-06-17 08:44:26.000000000","message":"Done","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4214e4c87bb8e17377beba16a900c698df221c6b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":48,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d mock.ANY"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class DNSNameServerDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_77e67445","line":48,"range":{"start_line":48,"start_character":54,"end_line":48,"end_character":62},"in_reply_to":"7aa08908_b493baff","updated":"2016-06-16 13:42:09.000000000","message":"I mean, you know that it will be Pager(sorts\u003d(\u0027order\u0027, True)), so why not validating that here?","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f3eb07243536efbd72012968687cf76208d809f7","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":48,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d mock.ANY"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class DNSNameServerDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_b493baff","line":48,"range":{"start_line":48,"start_character":54,"end_line":48,"end_character":62},"in_reply_to":"7aa08908_fcdece0e","updated":"2016-06-16 13:35:36.000000000","message":"I don\u0027t get it.","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields):"},{"line_number":61,"context_line":"            obj[\u0027subnet_id\u0027] \u003d self._subnet[\u0027id\u0027]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _create_dnsnameserver(self):"},{"line_number":64,"context_line":"        for obj in self.obj_fields:"},{"line_number":65,"context_line":"            dns \u003d self._make_object(obj)"},{"line_number":66,"context_line":"            dns.create()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_1ced9a8e","line":63,"updated":"2016-06-16 12:56:41.000000000","message":"server*s*?","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f6fbbc16bf7ea7f3afea01fc9cb991aafbccf4d4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields):"},{"line_number":61,"context_line":"            obj[\u0027subnet_id\u0027] \u003d self._subnet[\u0027id\u0027]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _create_dnsnameserver(self):"},{"line_number":64,"context_line":"        for obj in self.obj_fields:"},{"line_number":65,"context_line":"            dns \u003d self._make_object(obj)"},{"line_number":66,"context_line":"            dns.create()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_a924d4c5","line":63,"in_reply_to":"7aa08908_1ced9a8e","updated":"2016-06-17 08:44:26.000000000","message":"Done","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":69,"context_line":"        self._create_dnsnameserver()"},{"line_number":70,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":71,"context_line":"        self.assertTrue(objs[0].order \u003c objs[-1].order)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_get_objects_sort_by_order_desc(self):"},{"line_number":74,"context_line":"        self._create_dnsnameserver()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_dc1f92b5","line":71,"range":{"start_line":71,"start_character":24,"end_line":71,"end_character":54},"updated":"2016-06-16 12:56:41.000000000","message":"Should we validate the order for all entries? (you can compare the result with the explicitly sorted result).","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f6fbbc16bf7ea7f3afea01fc9cb991aafbccf4d4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":69,"context_line":"        self._create_dnsnameserver()"},{"line_number":70,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":71,"context_line":"        self.assertTrue(objs[0].order \u003c objs[-1].order)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_get_objects_sort_by_order_desc(self):"},{"line_number":74,"context_line":"        self._create_dnsnameserver()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_891f586f","line":71,"range":{"start_line":71,"start_character":24,"end_line":71,"end_character":54},"in_reply_to":"7aa08908_dc1f92b5","updated":"2016-06-17 08:44:26.000000000","message":"Done","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        pager \u003d obj_base.Pager(sorts\u003d[(\u0027order\u0027, False)])"},{"line_number":76,"context_line":"        objs \u003d self._test_class.get_objects(self.context, _pager\u003dpager,"},{"line_number":77,"context_line":"                                            subnet_id\u003dself._subnet.id)"},{"line_number":78,"context_line":"        self.assertTrue(objs[0].order \u003e objs[-1].order)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_get_objects_sort_by_address_asc_using_pager(self):"},{"line_number":81,"context_line":"        self._create_dnsnameserver()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_dc4dd2c5","line":78,"updated":"2016-06-16 12:56:41.000000000","message":"ditto","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._create_dnsnameserver()"},{"line_number":82,"context_line":"        pager \u003d obj_base.Pager(sorts\u003d[(\u0027address\u0027, True)])"},{"line_number":83,"context_line":"        objs \u003d self._test_class.get_objects(self.context, _pager\u003dpager)"},{"line_number":84,"context_line":"        self.assertTrue(objs[0].address \u003c objs[-1].address)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class RouteObjectIfaceTestCase(obj_test_base.BaseObjectIfaceTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_5cd0c2c9","line":84,"updated":"2016-06-16 12:56:41.000000000","message":"ditto","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"},{"line_number":127,"context_line":"        obj.create()"},{"line_number":128,"context_line":"        dns_nameservers \u003d [(2, \u00271.2.3.4\u0027), (1, \u00275.6.7.8\u0027), (4, \u00277.7.7.7\u0027)]"},{"line_number":129,"context_line":"        for entry in dns_nameservers:"},{"line_number":130,"context_line":"            dns \u003d subnet.DNSNameServer(self.context, order\u003dentry[0],"},{"line_number":131,"context_line":"                                       address\u003dentry[1],"},{"line_number":132,"context_line":"                                       subnet_id\u003dobj.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_5cb5627c","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":17},"updated":"2016-06-16 12:56:41.000000000","message":"for order, address in...","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f6fbbc16bf7ea7f3afea01fc9cb991aafbccf4d4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"},{"line_number":127,"context_line":"        obj.create()"},{"line_number":128,"context_line":"        dns_nameservers \u003d [(2, \u00271.2.3.4\u0027), (1, \u00275.6.7.8\u0027), (4, \u00277.7.7.7\u0027)]"},{"line_number":129,"context_line":"        for entry in dns_nameservers:"},{"line_number":130,"context_line":"            dns \u003d subnet.DNSNameServer(self.context, order\u003dentry[0],"},{"line_number":131,"context_line":"                                       address\u003dentry[1],"},{"line_number":132,"context_line":"                                       subnet_id\u003dobj.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_e92edca3","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":17},"in_reply_to":"7aa08908_5cb5627c","updated":"2016-06-17 08:44:26.000000000","message":"Done","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eef4aac5d9078034ab47b52ddd37b5404d89d642","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        obj.create()"},{"line_number":128,"context_line":"        dns_nameservers \u003d [(2, \u00271.2.3.4\u0027), (1, \u00275.6.7.8\u0027), (4, \u00277.7.7.7\u0027)]"},{"line_number":129,"context_line":"        for entry in dns_nameservers:"},{"line_number":130,"context_line":"            dns \u003d subnet.DNSNameServer(self.context, order\u003dentry[0],"},{"line_number":131,"context_line":"                                       address\u003dentry[1],"},{"line_number":132,"context_line":"                                       subnet_id\u003dobj.id)"},{"line_number":133,"context_line":"            dns.create()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_bca4464b","line":130,"range":{"start_line":130,"start_character":59,"end_line":130,"end_character":67},"updated":"2016-06-16 12:56:41.000000000","message":"...then use order and address variable here and below.","commit_id":"c93b684d39f557f1b0588f2fc63c16b2858c44f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ca8385f10c2e4e7294c933a8da8f8c1cbbceb361","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":50,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d \\"},{"line_number":51,"context_line":"            obj_base.Pager(sorts \u003d [(\u0027order\u0027, True)])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class DNSNameServerDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_9ea02d92","line":51,"range":{"start_line":51,"start_character":32,"end_line":51,"end_character":35},"updated":"2016-06-17 09:22:18.000000000","message":"I think pep8 requires no spaces around \u003d sign.","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"201c75ac483b08a1c052517749c1da0d7650b6d6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":50,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d \\"},{"line_number":51,"context_line":"            obj_base.Pager(sorts \u003d [(\u0027order\u0027, True)])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class DNSNameServerDbObjectTestCase(obj_test_base.BaseDbObjectTestCase,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_27bf68d1","line":51,"range":{"start_line":51,"start_character":32,"end_line":51,"end_character":35},"in_reply_to":"7aa08908_9ea02d92","updated":"2016-06-17 10:11:41.000000000","message":"Done","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ca8385f10c2e4e7294c933a8da8f8c1cbbceb361","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self._create_dnsnameservers()"},{"line_number":73,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":74,"context_line":"        fields_sorted \u003d sorted([dict(obj) for obj in self.obj_fields],"},{"line_number":75,"context_line":"                                key\u003ditemgetter(\u0027order\u0027))"},{"line_number":76,"context_line":"        self.assertEqual("},{"line_number":77,"context_line":"            fields_sorted,"},{"line_number":78,"context_line":"            [obj_test_base.get_obj_db_fields(obj) for obj in objs])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_fe02110b","line":75,"range":{"start_line":75,"start_character":32,"end_line":75,"end_character":55},"updated":"2016-06-17 09:22:18.000000000","message":"Since you don\u0027t guarantee anywhere that orders are unique, the order here is not strictly set for order duplicates. The test will fail if:\n\n1. two name servers have the same order;\n2. database returns those two name servers in an order that is different from the order of self.obj_fields.","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"201c75ac483b08a1c052517749c1da0d7650b6d6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self._create_dnsnameservers()"},{"line_number":73,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":74,"context_line":"        fields_sorted \u003d sorted([dict(obj) for obj in self.obj_fields],"},{"line_number":75,"context_line":"                                key\u003ditemgetter(\u0027order\u0027))"},{"line_number":76,"context_line":"        self.assertEqual("},{"line_number":77,"context_line":"            fields_sorted,"},{"line_number":78,"context_line":"            [obj_test_base.get_obj_db_fields(obj) for obj in objs])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_c7e78410","line":75,"range":{"start_line":75,"start_character":32,"end_line":75,"end_character":55},"in_reply_to":"7aa08908_fe02110b","updated":"2016-06-17 10:11:41.000000000","message":"Added check if order is not duplicated.","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ca8385f10c2e4e7294c933a8da8f8c1cbbceb361","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        pager \u003d obj_base.Pager(sorts\u003d[(\u0027address\u0027, True)])"},{"line_number":94,"context_line":"        objs \u003d self._test_class.get_objects(self.context, _pager\u003dpager)"},{"line_number":95,"context_line":"        fields_sorted \u003d sorted([dict(obj) for obj in self.obj_fields],"},{"line_number":96,"context_line":"                                key\u003ditemgetter(\u0027address\u0027))"},{"line_number":97,"context_line":"        self.assertEqual("},{"line_number":98,"context_line":"            fields_sorted,"},{"line_number":99,"context_line":"            [obj_test_base.get_obj_db_fields(obj) for obj in objs])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_e116f047","line":96,"updated":"2016-06-17 09:22:18.000000000","message":"Same concern here: while it\u0027s low chance that two name servers will generate duplicate strings, there is still a slight chance.","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"201c75ac483b08a1c052517749c1da0d7650b6d6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        pager \u003d obj_base.Pager(sorts\u003d[(\u0027address\u0027, True)])"},{"line_number":94,"context_line":"        objs \u003d self._test_class.get_objects(self.context, _pager\u003dpager)"},{"line_number":95,"context_line":"        fields_sorted \u003d sorted([dict(obj) for obj in self.obj_fields],"},{"line_number":96,"context_line":"                                key\u003ditemgetter(\u0027address\u0027))"},{"line_number":97,"context_line":"        self.assertEqual("},{"line_number":98,"context_line":"            fields_sorted,"},{"line_number":99,"context_line":"            [obj_test_base.get_obj_db_fields(obj) for obj in objs])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_47ba74e2","line":96,"in_reply_to":"7aa08908_e116f047","updated":"2016-06-17 10:11:41.000000000","message":"Added check if address is not duplicated.","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ca8385f10c2e4e7294c933a8da8f8c1cbbceb361","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"},{"line_number":143,"context_line":"        obj.create()"},{"line_number":144,"context_line":"        dns_nameservers \u003d [(2, \u00271.2.3.4\u0027), (1, \u00275.6.7.8\u0027), (4, \u00277.7.7.7\u0027)]"},{"line_number":145,"context_line":"        for order,address in dns_nameservers:"},{"line_number":146,"context_line":"            dns \u003d subnet.DNSNameServer(self.context, order\u003dorder,"},{"line_number":147,"context_line":"                                       address\u003daddress,"},{"line_number":148,"context_line":"                                       subnet_id\u003dobj.id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_4126e4ba","line":145,"updated":"2016-06-17 09:22:18.000000000","message":"nit: add space after comma","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"921a58d3d4f4183a76b3c8996adb6ed7fbac6ed9","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"},{"line_number":143,"context_line":"        obj.create()"},{"line_number":144,"context_line":"        dns_nameservers \u003d [(2, \u00271.2.3.4\u0027), (1, \u00275.6.7.8\u0027), (4, \u00277.7.7.7\u0027)]"},{"line_number":145,"context_line":"        for order,address in dns_nameservers:"},{"line_number":146,"context_line":"            dns \u003d subnet.DNSNameServer(self.context, order\u003dorder,"},{"line_number":147,"context_line":"                                       address\u003daddress,"},{"line_number":148,"context_line":"                                       subnet_id\u003dobj.id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_e76f205e","line":145,"in_reply_to":"7aa08908_4126e4ba","updated":"2016-06-17 10:12:52.000000000","message":"Done","commit_id":"f3366ceffcd6274e9eb607fbd0ed112aa2d4a1e6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7f7415b91425d95cb33c216bbc07fef6eabb3798","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _create_dnsnameservers(self):"},{"line_number":64,"context_line":"        for obj in self.obj_fields:"},{"line_number":65,"context_line":"            # (NOTE) make sure that order or address would not be duplicated"},{"line_number":66,"context_line":"            if (obj[\u0027order\u0027] in"},{"line_number":67,"context_line":"                    [x[\u0027order\u0027] for x in self.obj_fields if x !\u003d obj]):"},{"line_number":68,"context_line":"                obj[\u0027order\u0027] +\u003d 1"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_65ba05e3","line":65,"updated":"2016-06-17 11:50:28.000000000","message":"That\u0027s a bit weird. I think this code belongs to setUp(), where you already prepare obj_fields for subnet id matching.\n\nI would go as far as just generating new obj_fields dictionaries, since you override all three fields anyway (subnet_id, order, and address). So why bothering trying to make it fit your unique needs?","commit_id":"90c8a927b378d598a3ccf8947f7002d92230a8d4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b854607f2c3e42343274aeaf6cba9836feb876ba","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":47,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d \\"},{"line_number":48,"context_line":"            obj_base.Pager(sorts\u003d[(\u0027order\u0027, True)])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_b0c48992","line":47,"range":{"start_line":47,"start_character":53,"end_line":47,"end_character":55},"updated":"2016-06-22 09:06:24.000000000","message":"meh prefer parenthesis as stated in style guideline [1]\n\n[1] http://docs.openstack.org/developer/hacking/","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04db056733a8403f2ccd91d7fd9f46812475bd03","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(DNSNameServerObjectIfaceTestCase, self).setUp()"},{"line_number":47,"context_line":"        self.pager_map[self._test_class.obj_name()] \u003d \\"},{"line_number":48,"context_line":"            obj_base.Pager(sorts\u003d[(\u0027order\u0027, True)])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_07584989","line":47,"range":{"start_line":47,"start_character":53,"end_line":47,"end_character":55},"in_reply_to":"3aaa91ec_b0c48992","updated":"2016-06-24 07:39:37.000000000","message":"Done","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b854607f2c3e42343274aeaf6cba9836feb876ba","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def setUp(self):"},{"line_number":57,"context_line":"        super(DNSNameServerDbObjectTestCase, self).setUp()"},{"line_number":58,"context_line":"        # (NOTE) make sure that obj data would not consist of the same values"},{"line_number":59,"context_line":"        # for different objects"},{"line_number":60,"context_line":"        while not self._is_objects_unique():"},{"line_number":61,"context_line":"            self.db_objs \u003d list(self.get_random_fields() for _ in range(3))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_30825953","line":58,"updated":"2016-06-22 09:06:24.000000000","message":"why do we need that? can you explain more?","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04db056733a8403f2ccd91d7fd9f46812475bd03","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def setUp(self):"},{"line_number":57,"context_line":"        super(DNSNameServerDbObjectTestCase, self).setUp()"},{"line_number":58,"context_line":"        # (NOTE) make sure that obj data would not consist of the same values"},{"line_number":59,"context_line":"        # for different objects"},{"line_number":60,"context_line":"        while not self._is_objects_unique():"},{"line_number":61,"context_line":"            self.db_objs \u003d list(self.get_random_fields() for _ in range(3))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_07e689af","line":58,"in_reply_to":"3aaa91ec_30825953","updated":"2016-06-24 07:39:37.000000000","message":"Ihar raised his concerns about determinism of unit tests and sorting/comparison the objects [1]\nI\u0027ll add the explanation in comments.\n\n[1] https://review.openstack.org/#/c/326477/7/neutron/tests/unit/objects/test_subnet.py@75","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b854607f2c3e42343274aeaf6cba9836feb876ba","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def setUp(self):"},{"line_number":134,"context_line":"        super(SubnetObjectIfaceTestCase, self).setUp()"},{"line_number":135,"context_line":"        self.pager_map[subnet.DNSNameServer.obj_name()] \u003d \\"},{"line_number":136,"context_line":"            obj_base.Pager(sorts\u003d[(\u0027order\u0027, True)])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_10bbddc5","line":135,"range":{"start_line":135,"start_character":57,"end_line":135,"end_character":59},"updated":"2016-06-22 09:06:24.000000000","message":"ditto","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04db056733a8403f2ccd91d7fd9f46812475bd03","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def setUp(self):"},{"line_number":134,"context_line":"        super(SubnetObjectIfaceTestCase, self).setUp()"},{"line_number":135,"context_line":"        self.pager_map[subnet.DNSNameServer.obj_name()] \u003d \\"},{"line_number":136,"context_line":"            obj_base.Pager(sorts\u003d[(\u0027order\u0027, True)])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_c7ef6185","line":135,"range":{"start_line":135,"start_character":57,"end_line":135,"end_character":59},"in_reply_to":"3aaa91ec_10bbddc5","updated":"2016-06-24 07:39:37.000000000","message":"Done","commit_id":"c90705f042fec73e055822fee7ef87b37a7fc968"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7752623e6223c62dc3b7047095137128e1695a50","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def setUp(self):"},{"line_number":57,"context_line":"        super(DNSNameServerDbObjectTestCase, self).setUp()"},{"line_number":58,"context_line":"        # (NOTE) make sure that obj data would not consist of the same values"},{"line_number":59,"context_line":"        # for different objects, we need it for deterministic behaviour of"},{"line_number":60,"context_line":"        # unit tests sorting and comparison of sorted elements"},{"line_number":61,"context_line":"        while not self._is_objects_unique():"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_d39fc363","line":58,"updated":"2016-06-27 14:13:32.000000000","message":"I\u0027d rephrase \"If two object have the same value for a field and they are sorted using that field, the order is not deterministic. To avoid breaking the tests we ensure unique values for every field\"","commit_id":"87c00402c3fba28317f01b3359941f9ab553b801"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"e09b4b989e243843d5e83087cabf6b9261720517","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def setUp(self):"},{"line_number":57,"context_line":"        super(DNSNameServerDbObjectTestCase, self).setUp()"},{"line_number":58,"context_line":"        # (NOTE) make sure that obj data would not consist of the same values"},{"line_number":59,"context_line":"        # for different objects, we need it for deterministic behaviour of"},{"line_number":60,"context_line":"        # unit tests sorting and comparison of sorted elements"},{"line_number":61,"context_line":"        while not self._is_objects_unique():"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_4c12145a","line":58,"in_reply_to":"3aaa91ec_d39fc363","updated":"2016-06-27 14:41:19.000000000","message":"Done","commit_id":"87c00402c3fba28317f01b3359941f9ab553b801"}]}
