)]}'
{"neutron/extensions/securitygroup.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5e568a75161188f72441f8d6a3fce6f05540cf70","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    except (ValueError, TypeError):"},{"line_number":181,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":184,"context_line":"        return val"},{"line_number":185,"context_line":"    else:"},{"line_number":186,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_a0081bdb","side":"PARENT","line":183,"range":{"start_line":183,"start_character":7,"end_line":183,"end_character":32},"updated":"2016-06-08 13:44:12.000000000","message":"this allows 0 and hence differs from oslo version","commit_id":"82ab972980855a4a07fd3e0ec8cac3023f0c2796"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9181807ded1b632db844af6f8e101163a42eedd2","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    except (ValueError, TypeError):"},{"line_number":181,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":184,"context_line":"        return val"},{"line_number":185,"context_line":"    else:"},{"line_number":186,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f805b313","side":"PARENT","line":183,"range":{"start_line":183,"start_character":7,"end_line":183,"end_character":32},"in_reply_to":"7aa08908_a0081bdb","updated":"2016-06-08 15:47:38.000000000","message":"So, maybe in this case, it\u0027s not a problem with refactor, but with oslo.utils? Submitted a bug [1] to get some eyes on it.\n\n[1] https://bugs.launchpad.net/oslo.utils/+bug/1590485","commit_id":"82ab972980855a4a07fd3e0ec8cac3023f0c2796"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f572fbd6e4c2aa76ba48c8ec143d8f688d9cbfc9","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    except (ValueError, TypeError):"},{"line_number":181,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":184,"context_line":"        return val"},{"line_number":185,"context_line":"    else:"},{"line_number":186,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_1184bc08","side":"PARENT","line":183,"range":{"start_line":183,"start_character":7,"end_line":183,"end_character":32},"in_reply_to":"7aa08908_f805b313","updated":"2016-06-09 04:40:12.000000000","message":"thanks for the patch for oslo.utils","commit_id":"82ab972980855a4a07fd3e0ec8cac3023f0c2796"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"66c3eb2579a8adfcf7504c4967bf63130579845c","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    if netutils.is_valid_port(port):"},{"line_number":181,"context_line":"        return int(port)"},{"line_number":182,"context_line":"    else:"},{"line_number":183,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_317bc67c","line":182,"range":{"start_line":182,"start_character":4,"end_line":182,"end_character":8},"updated":"2016-07-21 21:25:30.000000000","message":"nit: Don\u0027t need the else but it isn\u0027t a big deal. I just like to minimize indentation. :)","commit_id":"8afc65ce3ab2e28897fdefe8af3f544613f84e9e"}]}
