)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d2841a746503c2c83c9c1bdf2f65c18b10e416bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hong Hui Xiao \u003cxiaohhui@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-13 06:06:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Mark dhcp port as ready after enabling dhcp at agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When subnet is created and network is scheduled to dhcp agent, the"},{"line_number":10,"context_line":"dhcp agent will request neutron server to create dhcp port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_93c2b483","line":7,"updated":"2016-06-13 21:02:46.000000000","message":"commit message needs to be updated to show that its being done for all ports on the network.","commit_id":"3468f362168990844bf921907de905415dbea042"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"fed74b8611f7e05cb0fdde63617d02a55e419fe1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hong Hui Xiao \u003cxiaohhui@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-13 06:06:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Mark dhcp port as ready after enabling dhcp at agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When subnet is created and network is scheduled to dhcp agent, the"},{"line_number":10,"context_line":"dhcp agent will request neutron server to create dhcp port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_17006900","line":7,"in_reply_to":"7aa08908_93c2b483","updated":"2016-06-14 01:33:48.000000000","message":"Done","commit_id":"3468f362168990844bf921907de905415dbea042"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"174bc3ee182bb1089dbf141659dfe1867aef7cc1","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                    # After enabling dhcp for network, the dhcp port is"},{"line_number":281,"context_line":"                    # created both in neutron server and dhcp agent. Need"},{"line_number":282,"context_line":"                    # to inform that the dhcp port is ready."},{"line_number":283,"context_line":"                    for port in network.ports:"},{"line_number":284,"context_line":"                        self.dhcp_ready_ports.add(port.id)"},{"line_number":285,"context_line":"                break"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if enable_metadata and dhcp_network_enabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6b50d932","line":284,"range":{"start_line":283,"start_character":20,"end_line":284,"end_character":58},"updated":"2016-06-08 13:23:29.000000000","message":"why adding all ports of the network, shouldn\u0027t only dhcp port be added?","commit_id":"4f61137552453a1f34612c156b8e776b6d68b988"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a09110d8a828b63f9c62de9775db34509cbd271a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                    # After enabling dhcp for network, the dhcp port is"},{"line_number":281,"context_line":"                    # created both in neutron server and dhcp agent. Need"},{"line_number":282,"context_line":"                    # to inform that the dhcp port is ready."},{"line_number":283,"context_line":"                    for port in network.ports:"},{"line_number":284,"context_line":"                        self.dhcp_ready_ports.add(port.id)"},{"line_number":285,"context_line":"                break"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if enable_metadata and dhcp_network_enabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0295af85","line":284,"range":{"start_line":283,"start_character":20,"end_line":284,"end_character":58},"in_reply_to":"7aa08908_6b50d932","updated":"2016-06-08 14:46:09.000000000","message":"yes, you are right. Will update in next patch set.","commit_id":"4f61137552453a1f34612c156b8e776b6d68b988"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"dcc93645384d3cc01c88c14542276296693afdda","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                    # created both in neutron server and dhcp agent. Need"},{"line_number":282,"context_line":"                    # to inform that the dhcp port is ready."},{"line_number":283,"context_line":"                    self.dhcp_ready_ports |\u003d {"},{"line_number":284,"context_line":"                        p.id for p in network.ports"},{"line_number":285,"context_line":"                        if p.device_owner \u003d\u003d constants.DEVICE_OWNER_DHCP}"},{"line_number":286,"context_line":"                break"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c85cb04d","line":284,"updated":"2016-06-13 05:04:08.000000000","message":"I think you actually want to do this will all ports on the network. If a bunch of ports are created immediately after the network/subnet is first created, they may all have this same issue of the port_create_end arriving before the enabling is complete.","commit_id":"e9a27e216c8919455ebe7ea1dd91dac51a83f47f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"532fe51b69db09de162a7b96f381dc6c27bef9b3","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                    # created both in neutron server and dhcp agent. Need"},{"line_number":282,"context_line":"                    # to inform that the dhcp port is ready."},{"line_number":283,"context_line":"                    self.dhcp_ready_ports |\u003d {"},{"line_number":284,"context_line":"                        p.id for p in network.ports"},{"line_number":285,"context_line":"                        if p.device_owner \u003d\u003d constants.DEVICE_OWNER_DHCP}"},{"line_number":286,"context_line":"                break"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5bc88c22","line":284,"in_reply_to":"7aa08908_c85cb04d","updated":"2016-06-13 05:56:02.000000000","message":"For this race, I think it makes sense to add all ports here, because if port_create_end arriving before the enabling is complete, the network cache will be empty, which will bypass marking port as ready. Will update it in next patch.","commit_id":"e9a27e216c8919455ebe7ea1dd91dac51a83f47f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"67d00f40d12215bc14c393ab777ca8271cad2426","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                    # After enabling dhcp for network, mark all existing"},{"line_number":281,"context_line":"                    # ports as ready. So that the status of ports which are"},{"line_number":282,"context_line":"                    # created before enabling dhcp can be updated."},{"line_number":283,"context_line":"                    self.dhcp_ready_ports |\u003d {p.id for p in network.ports}"},{"line_number":284,"context_line":"                break"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if enable_metadata and dhcp_network_enabled:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_262291a3","line":283,"updated":"2016-06-14 05:05:30.000000000","message":"is there a unit test for this?","commit_id":"a8c129c39d90c8f036478578fbc9d8285cfce4fc"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a7cd7093757bec9ec0543b41612b505bee9950f2","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                    # After enabling dhcp for network, mark all existing"},{"line_number":281,"context_line":"                    # ports as ready. So that the status of ports which are"},{"line_number":282,"context_line":"                    # created before enabling dhcp can be updated."},{"line_number":283,"context_line":"                    self.dhcp_ready_ports |\u003d {p.id for p in network.ports}"},{"line_number":284,"context_line":"                break"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if enable_metadata and dhcp_network_enabled:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_26df313b","line":283,"in_reply_to":"7aa08908_262291a3","updated":"2016-06-14 05:19:57.000000000","message":"I think the newly added UT fit for it","commit_id":"a8c129c39d90c8f036478578fbc9d8285cfce4fc"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b816bb684bbc5aad91a31725c5f78d31d598aaf6","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                    # After enabling dhcp for network, mark all existing"},{"line_number":281,"context_line":"                    # ports as ready. So that the status of ports which are"},{"line_number":282,"context_line":"                    # created before enabling dhcp can be updated."},{"line_number":283,"context_line":"                    self.dhcp_ready_ports |\u003d {p.id for p in network.ports}"},{"line_number":284,"context_line":"                break"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if enable_metadata and dhcp_network_enabled:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8abaee6f","line":283,"in_reply_to":"7aa08908_26df313b","updated":"2016-06-16 06:20:13.000000000","message":"Done","commit_id":"a8c129c39d90c8f036478578fbc9d8285cfce4fc"}],"neutron/tests/functional/agent/test_dhcp_agent.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b26b835caafcf97c03420ed7e732c23607be3947","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def test_notify_dhcp_port_ready(self):"},{"line_number":319,"context_line":"        network \u003d self.network_dict_for_dhcp()"},{"line_number":320,"context_line":"        dhcp_port \u003d network.ports[0]"},{"line_number":321,"context_line":"        dhcp_port.device_owner \u003d constants.DEVICE_OWNER_DHCP"},{"line_number":322,"context_line":"        self.agent.start_ready_ports_loop()"},{"line_number":323,"context_line":"        self.configure_dhcp_for_network(network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a2a466b9","line":320,"updated":"2016-06-09 11:06:19.000000000","message":"It would be nice to test with non-DHCP ports on the network.","commit_id":"e9a27e216c8919455ebe7ea1dd91dac51a83f47f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4c044b94c94b1a4d313ab7eac61f479ff2d12252","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def test_notify_dhcp_port_ready(self):"},{"line_number":319,"context_line":"        network \u003d self.network_dict_for_dhcp()"},{"line_number":320,"context_line":"        dhcp_port \u003d network.ports[0]"},{"line_number":321,"context_line":"        dhcp_port.device_owner \u003d constants.DEVICE_OWNER_DHCP"},{"line_number":322,"context_line":"        self.agent.start_ready_ports_loop()"},{"line_number":323,"context_line":"        self.configure_dhcp_for_network(network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6bc4165f","line":320,"in_reply_to":"7aa08908_a2a466b9","updated":"2016-06-09 12:50:59.000000000","message":"Will add if need to re-post.","commit_id":"e9a27e216c8919455ebe7ea1dd91dac51a83f47f"}]}