)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"77f99bf1bc269c2448c909c610459ac8f3da1f3f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"we\u0027ll either search the table for a given port_id *or* search for"},{"line_number":16,"context_line":"subports with a given trunk_id."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch does not add a migration.  Changing the primary key in an"},{"line_number":19,"context_line":"alembic migration doesn\u0027t appear to be possible.  The original model"},{"line_number":20,"context_line":"was not released in Mitaka.  Also, this is effectively a cosmetic"},{"line_number":21,"context_line":"change, it doesn\u0027t really effect the operation of the DB.  So,"},{"line_number":22,"context_line":"developers and trunk chasers who have deployed with the previous model"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_6bd42feb","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":48},"updated":"2016-06-09 03:08:05.000000000","message":"Remove.","commit_id":"2c1613261daa9c8dbb1e3831585f73c3679f5062"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"77f99bf1bc269c2448c909c610459ac8f3da1f3f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This patch does not add a migration.  Changing the primary key in an"},{"line_number":19,"context_line":"alembic migration doesn\u0027t appear to be possible.  The original model"},{"line_number":20,"context_line":"was not released in Mitaka.  Also, this is effectively a cosmetic"},{"line_number":21,"context_line":"change, it doesn\u0027t really effect the operation of the DB.  So,"},{"line_number":22,"context_line":"developers and trunk chasers who have deployed with the previous model"},{"line_number":23,"context_line":"will still work."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The only potential gotcha is if a developer tries to run"},{"line_number":26,"context_line":"neutron-db-manage to generate a migration script for new changes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_4bcfb355","line":23,"range":{"start_line":21,"start_character":8,"end_line":23,"end_character":16},"updated":"2016-06-09 03:08:05.000000000","message":"As far as I can tell, yes, this seems to be the case.","commit_id":"2c1613261daa9c8dbb1e3831585f73c3679f5062"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"77f99bf1bc269c2448c909c610459ac8f3da1f3f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"developers and trunk chasers who have deployed with the previous model"},{"line_number":23,"context_line":"will still work."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The only potential gotcha is if a developer tries to run"},{"line_number":26,"context_line":"neutron-db-manage to generate a migration script for new changes"},{"line_number":27,"context_line":"having installed the old model.  That might produce changes that the"},{"line_number":28,"context_line":"surprise the developer but isn\u0027t very likely.  Recommend always using"},{"line_number":29,"context_line":"a fresh testdb to generate migration scripts."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: Ia43a2a772f654e26c3234e153fd8a5501e585c9b"},{"line_number":32,"context_line":"Partially-Implements: blueprint vlan-aware-vms"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_abf1f796","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":45},"updated":"2016-06-09 03:08:05.000000000","message":"Not applicable? Remove I think.","commit_id":"2c1613261daa9c8dbb1e3831585f73c3679f5062"}],"neutron/services/trunk/models.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"038aad5340dc6acdaf8fe75fae922b3d0d34584c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027,"},{"line_number":27,"context_line":"                                      ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":28,"context_line":"                        nullable\u003dFalse,"},{"line_number":29,"context_line":"                        unique\u003dTrue)"},{"line_number":30,"context_line":"    port \u003d sa.orm.relationship("},{"line_number":31,"context_line":"        models_v2.Port,"},{"line_number":32,"context_line":"        backref\u003dsa.orm.backref(\u0027trunk_port\u0027, lazy\u003d\u0027joined\u0027, uselist\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_5e8736d7","line":29,"range":{"start_line":29,"start_character":24,"end_line":29,"end_character":35},"updated":"2016-06-09 23:56:44.000000000","message":"@Rawlin:  This unique attribute essentially creates an index on port_id which can be used to efficiently look up the trunk_Id by port_id.  Unique constraints are implemented using an index with a special unique property.\n\nGiven this, it is a simple matter of joining the subports table on Trunk.id \u003d\u003d SubPort.trunk_id.  This join will benefit from the index I added in the patch before this one.\n\nYour subquery suggestion would do it to but normally I think in terms of joins rather than subqueries.\n\nSo, with my additional index on trunk_id, I think we\u0027ve optimized for this already.","commit_id":"eb0861135b1dafccf8a56811446abf6089d4657b"}]}