)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"db5012518e84f7f696cfba1fd784c8a09ca2cc6f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yatin Kumbhare \u003cyatinkumbhare@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-10 12:35:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv6 raise exception AddrFormatError"},{"line_number":10,"context_line":"if address is specified as empty string. Method is_valid_ipv6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_576edbc9","line":7,"updated":"2016-06-10 13:20:26.000000000","message":"Why did you change this from is_valid_ipv4 ?  Below as well.","commit_id":"985a9e40440844d3041583c68bf4d8e037962225"}],"neutron/common/ipv6_utils.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"604500217155193ae3fefa85eaf069369ba87b22","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":35,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":36,"context_line":"    isIPv4 \u003d netutils.is_valid_ipv4(prefix)"},{"line_number":37,"context_line":"    if isIPv4:"},{"line_number":38,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":39,"context_line":"        raise TypeError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_16dc0b72","line":36,"updated":"2016-06-13 12:19:29.000000000","message":"Why does it make sense to move to a helper in another library that wraps the implementation we currently use? What value does this provide? I personally typically use helpers from libraries when the complexity justifies it and I\u0027d rather the library maintainer maintain it. I don\u0027t see how that applies here.","commit_id":"a53b9bb18ae43d1b6cfbb7303edad4001c2576d2"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9fc7ff352a243b82f6712806a800e64def4c1480","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":35,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":36,"context_line":"    isIPv4 \u003d netutils.is_valid_ipv4(prefix)"},{"line_number":37,"context_line":"    if isIPv4:"},{"line_number":38,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":39,"context_line":"        raise TypeError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_918aba62","line":36,"in_reply_to":"7aa08908_16dc0b72","updated":"2016-06-13 16:14:00.000000000","message":"I believe it\u0027s good to have common pieces of code in single place. Currently we had one implementation in oslo_utils and other in neutron. Neutron uses its own version, so would be good to have one place to fix (like in this case, where netutils validator assumed incorrect values).","commit_id":"a53b9bb18ae43d1b6cfbb7303edad4001c2576d2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"5a7366157dcef9b1177439d5e0e2debdc8429fa8","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":35,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":36,"context_line":"    isIPv4 \u003d netutils.is_valid_ipv4(prefix)"},{"line_number":37,"context_line":"    if isIPv4:"},{"line_number":38,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":39,"context_line":"        raise TypeError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_2cc8c854","line":36,"in_reply_to":"7aa08908_77cf3e7f","updated":"2016-06-13 17:58:20.000000000","message":"I\u0027m not sure I understand the point of that oslo_utils function but I\u0027d rather merge this than waste time arguing about it. We already use oslo_utils so we\u0027re not introducing a new dependency.","commit_id":"a53b9bb18ae43d1b6cfbb7303edad4001c2576d2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d5604a86d1dbe14e74eef21859a1505a6ae5e257","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":35,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":36,"context_line":"    isIPv4 \u003d netutils.is_valid_ipv4(prefix)"},{"line_number":37,"context_line":"    if isIPv4:"},{"line_number":38,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":39,"context_line":"        raise TypeError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_b78d267e","line":36,"in_reply_to":"7aa08908_918aba62","updated":"2016-06-13 16:56:05.000000000","message":"Can you link to the bug you are referring to?","commit_id":"a53b9bb18ae43d1b6cfbb7303edad4001c2576d2"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"1320099f286545f541713e021c1511b1851e2b75","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":35,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":36,"context_line":"    isIPv4 \u003d netutils.is_valid_ipv4(prefix)"},{"line_number":37,"context_line":"    if isIPv4:"},{"line_number":38,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":39,"context_line":"        raise TypeError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_77cf3e7f","line":36,"in_reply_to":"7aa08908_b78d267e","updated":"2016-06-13 17:01:02.000000000","message":"Assaf, I mixed two things. It wasn\u0027t exactly about is_valid_ipv4 but about is_valid_port. Bug: https://bugs.launchpad.net/oslo.utils/+bug/1590485\n\nOther projects are using oslo_utils.","commit_id":"a53b9bb18ae43d1b6cfbb7303edad4001c2576d2"}]}