)]}'
{"neutron/db/db_base_plugin_common.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7c6ab3d1a9794396c875992adff5c4e1d4cd05bd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        context.session.query(models_v2.IPAllocation).filter_by("},{"line_number":93,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":94,"context_line":"            ip_address\u003dip_address,"},{"line_number":95,"context_line":"            subnet_id\u003dsubnet_id).delete()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"},{"line_number":98,"context_line":"    def _store_ip_allocation(context, ip_address, network_id, subnet_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_915b17f6","side":"PARENT","line":95,"range":{"start_line":95,"start_character":33,"end_line":95,"end_character":39},"updated":"2016-06-10 21:40:11.000000000","message":"Would an option like synchronize_session\u003d\u0027fetch\u0027 to delete [1] work too?  The default is synchronize_session\u003d\u0027evaluate\u0027, which I don\u0027t totally understand.  Or, am I off in the weeds?\n\n [1] http://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.delete","commit_id":"a4ae29728938fda76e493add832124a82b55295a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4d1e82eb09cbf14082c3f88ccb69ab4008b347a4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        context.session.query(models_v2.IPAllocation).filter_by("},{"line_number":93,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":94,"context_line":"            ip_address\u003dip_address,"},{"line_number":95,"context_line":"            subnet_id\u003dsubnet_id).delete()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"},{"line_number":98,"context_line":"    def _store_ip_allocation(context, ip_address, network_id, subnet_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_d1abdf1c","side":"PARENT","line":95,"range":{"start_line":95,"start_character":33,"end_line":95,"end_character":39},"in_reply_to":"7aa08908_915b17f6","updated":"2016-06-10 21:53:41.000000000","message":"I\u0027m not sure that will be enough. In the patch that I leverage this I\u0027m looking through deleted objects in the session. (L48 of https://review.openstack.org/#/c/303966/22/neutron/services/revisions/revision_plugin.py)\n\nIt\u0027s not clear to me that using \u0027evaluate\u0027 will actually add the object to the session.deleted set. It makes it sound like it just removes objects already in the session.","commit_id":"a4ae29728938fda76e493add832124a82b55295a"}]}