)]}'
{"neutron/objects/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e6d9fa361e2f009ef645e2485d9a3b007f07c704","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    obj_base.ComparableVersionedObject):"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    synthetic_fields \u003d []"},{"line_number":121,"context_line":"    extra_filter_names \u003d set()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"},{"line_number":124,"context_line":"        super(NeutronObject, self).__init__(context, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_52ab8989","line":121,"updated":"2016-06-10 13:45:38.000000000","message":"YES, SET!","commit_id":"aa05d52efc9461de211d0c1af806a9e18ee5cc57"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a6f4ed4148bc64d3fb03264d229a3f3322c6101d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class NeutronDbObjectNotFoundByModel(exceptions.NotFound):"},{"line_number":51,"context_line":"    message \u003d _(\"NeutronDbObject not found by model %(model)s.\")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class NeutronPrimaryKeyMissing(exceptions.BadRequest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_9295f141","line":51,"range":{"start_line":51,"start_character":18,"end_line":51,"end_character":32},"updated":"2016-06-10 13:42:09.000000000","message":"Maybe this is misleading.","commit_id":"edd4011d68a79de1fb3491cf054512afdf8e09f3"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"df9f0d9f60a225a210f1f7e5c7ab688d276d7d80","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            self.filtered_args \u003d filters"},{"line_number":813,"context_line":"            return query"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        db_base_plugin_v2.NeutronDbPluginV2.register_model_query_hook("},{"line_number":816,"context_line":"            self._test_class.db_model,"},{"line_number":817,"context_line":"            \u0027foo_filter\u0027,"},{"line_number":818,"context_line":"            None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_4f7f22e0","line":815,"updated":"2016-06-13 08:16:58.000000000","message":"Hm. I now wonder whether it won\u0027t leave the hook set on the resource after the test completed.","commit_id":"851fae523aa53b7f970aac0a8c68134b7fbc402a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9a8b3ff27724165ef8883f67735311e83d11bc0f","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            self.filtered_args \u003d filters"},{"line_number":813,"context_line":"            return query"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        db_base_plugin_v2.NeutronDbPluginV2.register_model_query_hook("},{"line_number":816,"context_line":"            self._test_class.db_model,"},{"line_number":817,"context_line":"            \u0027foo_filter\u0027,"},{"line_number":818,"context_line":"            None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8ab298e3","line":815,"in_reply_to":"7aa08908_4f7f22e0","updated":"2016-06-13 08:41:31.000000000","message":"It will. Maybe I should separate this test out from  BaseDbObjectTestCase? I think it doesn\u0027t make sense to test that hook works on every model/object we test.","commit_id":"851fae523aa53b7f970aac0a8c68134b7fbc402a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7850aff8272ce34b52e7c2d9d3a7defbd48887af","unresolved":false,"context_lines":[{"line_number":44,"context_line":"TIMESTAMP_FIELDS \u003d [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NeutronDbPluginV2Fixture(fixtures.Fixture):"},{"line_number":48,"context_line":"    def _setUp(self):"},{"line_number":49,"context_line":"        self.original_plugin \u003d db_base_plugin_v2.NeutronDbPluginV2"},{"line_number":50,"context_line":"        self.addCleanup(self.restore_plugin)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_f6c7bf95","line":47,"updated":"2016-06-13 12:18:27.000000000","message":"I prefer if we keep it isolated, trying to restore just the thing we actually touch.","commit_id":"99026bd239ad23d8e5400ee4567465afd4c8b845"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"87bb925779d57c4bd7e83e422d1e9da6033dab9c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"TIMESTAMP_FIELDS \u003d [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NeutronDbPluginV2Fixture(fixtures.Fixture):"},{"line_number":48,"context_line":"    def _setUp(self):"},{"line_number":49,"context_line":"        self.original_plugin \u003d db_base_plugin_v2.NeutronDbPluginV2"},{"line_number":50,"context_line":"        self.addCleanup(self.restore_plugin)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_c9430412","line":47,"in_reply_to":"7aa08908_96c0fb51","updated":"2016-06-13 12:39:15.000000000","message":"Yes, let\u0027s have a very specific fixture. Also, the hooks are registered on common_db_mixin, so maybe target that one.","commit_id":"99026bd239ad23d8e5400ee4567465afd4c8b845"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3b3ef6c655c2a3a7af94f72e6f0a8835b0b652be","unresolved":false,"context_lines":[{"line_number":44,"context_line":"TIMESTAMP_FIELDS \u003d [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NeutronDbPluginV2Fixture(fixtures.Fixture):"},{"line_number":48,"context_line":"    def _setUp(self):"},{"line_number":49,"context_line":"        self.original_plugin \u003d db_base_plugin_v2.NeutronDbPluginV2"},{"line_number":50,"context_line":"        self.addCleanup(self.restore_plugin)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_a91318b7","line":47,"in_reply_to":"7aa08908_c9430412","updated":"2016-06-13 12:49:20.000000000","message":"Done","commit_id":"99026bd239ad23d8e5400ee4567465afd4c8b845"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3ebf4881a3e643f22385fc1f260d136bd839e3fd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"TIMESTAMP_FIELDS \u003d [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NeutronDbPluginV2Fixture(fixtures.Fixture):"},{"line_number":48,"context_line":"    def _setUp(self):"},{"line_number":49,"context_line":"        self.original_plugin \u003d db_base_plugin_v2.NeutronDbPluginV2"},{"line_number":50,"context_line":"        self.addCleanup(self.restore_plugin)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_96c0fb51","line":47,"in_reply_to":"7aa08908_f6c7bf95","updated":"2016-06-13 12:21:39.000000000","message":"You mean restoring just where the hooks are stored, at model_query_hooks ?","commit_id":"99026bd239ad23d8e5400ee4567465afd4c8b845"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"774089c9e56ac8e23182a709523c76f5551632a5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"TIMESTAMP_FIELDS \u003d [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class CommonDbMixingHooksFixture(fixtures.Fixture):"},{"line_number":49,"context_line":"    def _setUp(self):"},{"line_number":50,"context_line":"        self.original_hooks \u003d common_db_mixin.CommonDbMixin._model_query_hooks"},{"line_number":51,"context_line":"        self.addCleanup(self.restore_hooks)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_07ae93e5","line":48,"range":{"start_line":48,"start_character":19,"end_line":48,"end_character":20},"updated":"2016-06-13 13:28:39.000000000","message":"meh. Also, I would put the class somewhere in neutron/tests/tools.py or smth.","commit_id":"2a2a7e8edfc168581eeaedbebbd57cb3eaf3f637"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"417b6e72beecd935d716ece7a1b6bcbc2f351705","unresolved":false,"context_lines":[{"line_number":45,"context_line":"TIMESTAMP_FIELDS \u003d [\u0027created_at\u0027, \u0027updated_at\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class CommonDbMixingHooksFixture(fixtures.Fixture):"},{"line_number":49,"context_line":"    def _setUp(self):"},{"line_number":50,"context_line":"        self.original_hooks \u003d common_db_mixin.CommonDbMixin._model_query_hooks"},{"line_number":51,"context_line":"        self.addCleanup(self.restore_hooks)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_076cd333","line":48,"range":{"start_line":48,"start_character":19,"end_line":48,"end_character":20},"in_reply_to":"7aa08908_07ae93e5","updated":"2016-06-13 13:36:25.000000000","message":"Done","commit_id":"2a2a7e8edfc168581eeaedbebbd57cb3eaf3f637"}]}
