)]}'
{"neutron/agent/l2/extensions/trunk.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"15e1ebd772e776714298c929a6173655144539b7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":52,"context_line":"        # TODO: determine if port is a trunk port somehow"},{"line_number":53,"context_line":"        #is_trunk \u003d data.get(\u0027is_trunk\u0027, False)"},{"line_number":54,"context_line":"        is_trunk \u003d data[\u0027vif_port\u0027].port_name.startswith(\u0027patch-int-tbr\u0027)"},{"line_number":55,"context_line":"        if is_trunk:"},{"line_number":56,"context_line":"            # TODO: make RPC call to retrieve subport data"},{"line_number":57,"context_line":"            # for testing, these port_ids should be created beforehand"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ca904451","line":54,"updated":"2016-06-10 23:33:33.000000000","message":"Is there another field we should make sure is added to the external_id\u0027s? I\u0027d rather look for the presence of an extra  field rather than rely on naming conventions.","commit_id":"216cae63e8e354432586f1c89f610bb711097f8f"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"b03fa8f91dea8d3273429f2293ee09830d93915f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":52,"context_line":"        # TODO: determine if port is a trunk port somehow"},{"line_number":53,"context_line":"        #is_trunk \u003d data.get(\u0027is_trunk\u0027, False)"},{"line_number":54,"context_line":"        is_trunk \u003d data[\u0027vif_port\u0027].port_name.startswith(\u0027patch-int-tbr\u0027)"},{"line_number":55,"context_line":"        if is_trunk:"},{"line_number":56,"context_line":"            # TODO: make RPC call to retrieve subport data"},{"line_number":57,"context_line":"            # for testing, these port_ids should be created beforehand"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c5792095","line":54,"in_reply_to":"7aa08908_ca904451","updated":"2016-06-13 16:36:09.000000000","message":"Yeah, \"data\" here is actually the port data retrieved from the server. I was thinking that once the \u0027trunk_details\u0027 extension is active, this would just check for a non-empty \u0027trunk_details\u0027 in the port data. Does that sound right?\n\nWe could also have Nova/os-vif add a special field into the external_ids for trunks if need be.","commit_id":"216cae63e8e354432586f1c89f610bb711097f8f"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"15e1ebd772e776714298c929a6173655144539b7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        {\u0027port_id\u0027: \u00279845c11e-6772-438a-a5fd-74a913a3434c\u0027,"},{"line_number":64,"context_line":"                         \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":65,"context_line":"                         \u0027segmentation_id\u0027: 456}]"},{"line_number":66,"context_line":"            trunk_br_name \u003d self._gen_trunk_br_name(data[\u0027port_id\u0027])"},{"line_number":67,"context_line":"            trunk_br \u003d ovs_lib.OVSBridge(trunk_br_name)"},{"line_number":68,"context_line":"            for subport in subports:"},{"line_number":69,"context_line":"                int_patch_port, tbr_patch_port \u003d self._gen_subport_patch_names("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6aa150a9","line":66,"updated":"2016-06-10 23:33:33.000000000","message":"I wonder if we can follow the OVS port to track down the name of the bridge on the other end. A little more work, but less fragile in the long run.","commit_id":"216cae63e8e354432586f1c89f610bb711097f8f"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"b03fa8f91dea8d3273429f2293ee09830d93915f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        {\u0027port_id\u0027: \u00279845c11e-6772-438a-a5fd-74a913a3434c\u0027,"},{"line_number":64,"context_line":"                         \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":65,"context_line":"                         \u0027segmentation_id\u0027: 456}]"},{"line_number":66,"context_line":"            trunk_br_name \u003d self._gen_trunk_br_name(data[\u0027port_id\u0027])"},{"line_number":67,"context_line":"            trunk_br \u003d ovs_lib.OVSBridge(trunk_br_name)"},{"line_number":68,"context_line":"            for subport in subports:"},{"line_number":69,"context_line":"                int_patch_port, tbr_patch_port \u003d self._gen_subport_patch_names("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5c498930","line":66,"in_reply_to":"7aa08908_6aa150a9","updated":"2016-06-13 16:36:09.000000000","message":"That definitely is possible. We could get the peer name of this trunk port, then find what bridge the peer is attached to using bridge.get_bridge_for_iface(peer_name). I will add that in the next PS.","commit_id":"216cae63e8e354432586f1c89f610bb711097f8f"}]}