)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c00e5fe880194f6039894d14cb85873b62649ad7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: move fields and filters logic to hooks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The logic for massaging the fields and filters data was being done in"},{"line_number":10,"context_line":"the controllers.  This change pulls that logic out of the controllers"},{"line_number":11,"context_line":"and puts it in a genric hook so that it\u0027s done for all controllers."},{"line_number":12,"context_line":"This will later be used for pagination, but thats not the main"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_cb2bf180","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":23},"updated":"2016-06-13 15:51:03.000000000","message":"typo: messaging","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8806563daf1b8a11fc9fbf5e6c1890bb636b577c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: move fields and filters logic to hooks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The logic for massaging the fields and filters data was being done in"},{"line_number":10,"context_line":"the controllers.  This change pulls that logic out of the controllers"},{"line_number":11,"context_line":"and puts it in a genric hook so that it\u0027s done for all controllers."},{"line_number":12,"context_line":"This will later be used for pagination, but thats not the main"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_8538a2d4","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":23},"in_reply_to":"7aa08908_64c77c98","updated":"2016-06-14 00:50:05.000000000","message":"Thanks Kevin, didn\u0027t know about this. Makes sense.","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d6fd3a31034b8d3fcf96c823f44bcff78551cd18","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: move fields and filters logic to hooks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The logic for massaging the fields and filters data was being done in"},{"line_number":10,"context_line":"the controllers.  This change pulls that logic out of the controllers"},{"line_number":11,"context_line":"and puts it in a genric hook so that it\u0027s done for all controllers."},{"line_number":12,"context_line":"This will later be used for pagination, but thats not the main"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_4a46c97b","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":23},"in_reply_to":"7aa08908_64c77c98","updated":"2016-06-14 00:43:59.000000000","message":"yeah, i definitely meant massaging","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ef602031eedab0a06bfbd6cc595c0c94722d6d1c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: move fields and filters logic to hooks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The logic for massaging the fields and filters data was being done in"},{"line_number":10,"context_line":"the controllers.  This change pulls that logic out of the controllers"},{"line_number":11,"context_line":"and puts it in a genric hook so that it\u0027s done for all controllers."},{"line_number":12,"context_line":"This will later be used for pagination, but thats not the main"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_64c77c98","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":23},"in_reply_to":"7aa08908_cb2bf180","updated":"2016-06-13 22:34:51.000000000","message":"I think he meant massaging: http://stackoverflow.com/questions/577892/what-does-data-massage-mean","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c00e5fe880194f6039894d14cb85873b62649ad7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The logic for massaging the fields and filters data was being done in"},{"line_number":10,"context_line":"the controllers.  This change pulls that logic out of the controllers"},{"line_number":11,"context_line":"and puts it in a genric hook so that it\u0027s done for all controllers."},{"line_number":12,"context_line":"This will later be used for pagination, but thats not the main"},{"line_number":13,"context_line":"motivation of this patch."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_4b38a1d3","line":11,"range":{"start_line":11,"start_character":17,"end_line":11,"end_character":23},"updated":"2016-06-13 15:51:03.000000000","message":"typo: generic","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d6fd3a31034b8d3fcf96c823f44bcff78551cd18","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The logic for massaging the fields and filters data was being done in"},{"line_number":10,"context_line":"the controllers.  This change pulls that logic out of the controllers"},{"line_number":11,"context_line":"and puts it in a genric hook so that it\u0027s done for all controllers."},{"line_number":12,"context_line":"This will later be used for pagination, but thats not the main"},{"line_number":13,"context_line":"motivation of this patch."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_aa5f6d3f","line":11,"range":{"start_line":11,"start_character":17,"end_line":11,"end_character":23},"in_reply_to":"7aa08908_4b38a1d3","updated":"2016-06-14 00:43:59.000000000","message":"Done","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c00e5fe880194f6039894d14cb85873b62649ad7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Ideally, the filters and fields would passed into the controller"},{"line_number":16,"context_line":"methods themselves as kwargs, but that is not easily done due to pecan"},{"line_number":17,"context_line":"not easily allowing overriding the args and kwargs passed to the"},{"line_number":18,"context_line":"controller methods.  For now, the fields and filters will have to be"},{"line_number":19,"context_line":"pulled out of the request context."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ibea9087c7036faa064b87acb52e09c9a3c74148a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_8b456944","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":20},"updated":"2016-06-13 15:51:03.000000000","message":"nit: extra whitespace","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d6fd3a31034b8d3fcf96c823f44bcff78551cd18","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Ideally, the filters and fields would passed into the controller"},{"line_number":16,"context_line":"methods themselves as kwargs, but that is not easily done due to pecan"},{"line_number":17,"context_line":"not easily allowing overriding the args and kwargs passed to the"},{"line_number":18,"context_line":"controller methods.  For now, the fields and filters will have to be"},{"line_number":19,"context_line":"pulled out of the request context."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ibea9087c7036faa064b87acb52e09c9a3c74148a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_8a5c314c","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":20},"in_reply_to":"7aa08908_8b456944","updated":"2016-06-14 00:43:59.000000000","message":"Done","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"}],"neutron/pecan_wsgi/controllers/resource.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c00e5fe880194f6039894d14cb85873b62649ad7","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get(self, *args, **kwargs):"},{"line_number":102,"context_line":"        # NOTE(blogan): these are set in the FieldsAndFiltersHoook"},{"line_number":103,"context_line":"        fields \u003d request.context.get(\u0027fields\u0027)"},{"line_number":104,"context_line":"        filters \u003d request.context.get(\u0027filters\u0027)"},{"line_number":105,"context_line":"        lister \u003d getattr(self.plugin, \u0027get_%s\u0027 % self.collection)"},{"line_number":106,"context_line":"        neutron_context \u003d request.context[\u0027neutron_context\u0027]"},{"line_number":107,"context_line":"        return {self.collection: lister(neutron_context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0bdfb93a","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":48},"updated":"2016-06-13 15:51:03.000000000","message":"Correct me, if I\u0027m wrong, but you\u0027re using self._listify from hooks to achieve compatibility with previous version?","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d6fd3a31034b8d3fcf96c823f44bcff78551cd18","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get(self, *args, **kwargs):"},{"line_number":102,"context_line":"        # NOTE(blogan): these are set in the FieldsAndFiltersHoook"},{"line_number":103,"context_line":"        fields \u003d request.context.get(\u0027fields\u0027)"},{"line_number":104,"context_line":"        filters \u003d request.context.get(\u0027filters\u0027)"},{"line_number":105,"context_line":"        lister \u003d getattr(self.plugin, \u0027get_%s\u0027 % self.collection)"},{"line_number":106,"context_line":"        neutron_context \u003d request.context[\u0027neutron_context\u0027]"},{"line_number":107,"context_line":"        return {self.collection: lister(neutron_context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3f00e165","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":48},"in_reply_to":"7aa08908_0bdfb93a","updated":"2016-06-14 00:43:59.000000000","message":"no, using it bc there is a need to turn fields into a list if just one field was passed in.  if just one field is passed it, pecan won\u0027t have it as a list.","commit_id":"dcd57a4b88220aa5738c459568c29ed3518eab51"}]}
