)]}'
{"neutron/common/ipv6_utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"746c35b37b1f15064953e08768cca1e1ab67efbf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"_IS_IPV6_ENABLED \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":34,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":35,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":36,"context_line":"    if isIPv4:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e6040916","side":"PARENT","line":33,"updated":"2016-06-14 05:02:54.000000000","message":"i think that due to the fact that this is a public method we need to mark it as deprecated to be removed in the O cycle.","commit_id":"260ce9c161228e35215126e047443ec32b7bf1ef"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a9cbb4bc2984ea0ad987772129a52560e2010f52","unresolved":false,"context_lines":[{"line_number":30,"context_line":"_IS_IPV6_ENABLED \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":34,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":35,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":36,"context_line":"    if isIPv4:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e6a089f6","side":"PARENT","line":33,"in_reply_to":"7aa08908_e6040916","updated":"2016-06-14 05:07:32.000000000","message":"good point. this is in a common file.\n\nplease use debtcollector to mark as deprecated.","commit_id":"260ce9c161228e35215126e047443ec32b7bf1ef"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"06fd1464b59f2fd28189a4b9020f21bb9b265ede","unresolved":false,"context_lines":[{"line_number":31,"context_line":"_IS_IPV6_ENABLED \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@removals.remove("},{"line_number":35,"context_line":"    message\u003d\"use get_ipv6_addr_by_EUI64 from oslo_utils.netutils\","},{"line_number":36,"context_line":"    version\u003d\"Newton\","},{"line_number":37,"context_line":"    removal_version\u003d\"Ocata\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f903ae0b","line":34,"updated":"2016-06-22 02:02:06.000000000","message":"I would use debtcollector.moves.moved_function instead, to redirect the callers of this function.\n\nNote that the oslo version raises slightly different exceptions, but I don\u0027t think this will have a significant impact on any users. The oslo exceptions are better IMO.","commit_id":"9d6a0cea79391ee999b71f163eecf00a7984ab85"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a746bb484214ae8e2898ffd850dbc2777ff125bb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"_IS_IPV6_ENABLED \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@removals.remove("},{"line_number":35,"context_line":"    message\u003d\"use get_ipv6_addr_by_EUI64 from oslo_utils.netutils\","},{"line_number":36,"context_line":"    version\u003d\"Newton\","},{"line_number":37,"context_line":"    removal_version\u003d\"Ocata\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e4cdbe87","line":34,"in_reply_to":"3aaa91ec_5e7f6f14","updated":"2016-06-27 22:46:56.000000000","message":"Sure, I can agree with that too.","commit_id":"9d6a0cea79391ee999b71f163eecf00a7984ab85"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"544ad8edbab0b3edb92ca42bd3392895eb18ac7e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"_IS_IPV6_ENABLED \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@removals.remove("},{"line_number":35,"context_line":"    message\u003d\"use get_ipv6_addr_by_EUI64 from oslo_utils.netutils\","},{"line_number":36,"context_line":"    version\u003d\"Newton\","},{"line_number":37,"context_line":"    removal_version\u003d\"Ocata\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5e7f6f14","line":34,"in_reply_to":"3aaa91ec_f903ae0b","updated":"2016-06-27 08:20:22.000000000","message":"I think the goal here is that remove this method from neutron and use oslo.utils one, not \"Deprecates a function that was moved to another location\" in same project which we have did in other places of Neutron.","commit_id":"9d6a0cea79391ee999b71f163eecf00a7984ab85"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"06fd1464b59f2fd28189a4b9020f21bb9b265ede","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":42,"context_line":"    if isIPv4:"},{"line_number":43,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":44,"context_line":"        raise TypeError(msg)"},{"line_number":45,"context_line":"    try:"},{"line_number":46,"context_line":"        eui64 \u003d int(netaddr.EUI(mac).eui64())"},{"line_number":47,"context_line":"        prefix \u003d netaddr.IPNetwork(prefix)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b91ac66c","line":44,"range":{"start_line":44,"start_character":14,"end_line":44,"end_character":23},"updated":"2016-06-22 02:02:06.000000000","message":"Note: The oslo version returns ValueError here.","commit_id":"9d6a0cea79391ee999b71f163eecf00a7984ab85"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"06fd1464b59f2fd28189a4b9020f21bb9b265ede","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        prefix \u003d netaddr.IPNetwork(prefix)"},{"line_number":48,"context_line":"        return netaddr.IPAddress(prefix.first + eui64 ^ (1 \u003c\u003c 57))"},{"line_number":49,"context_line":"    except (ValueError, netaddr.AddrFormatError):"},{"line_number":50,"context_line":"        raise TypeError(_(\u0027Bad prefix or mac format for generating IPv6 \u0027"},{"line_number":51,"context_line":"                          \u0027address by EUI-64: %(prefix)s, %(mac)s:\u0027)"},{"line_number":52,"context_line":"                        % {\u0027prefix\u0027: prefix, \u0027mac\u0027: mac})"},{"line_number":53,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f92a8e7d","line":50,"range":{"start_line":50,"start_character":14,"end_line":50,"end_character":23},"updated":"2016-06-22 02:02:06.000000000","message":"Note: The oslo version returns ValueError here.","commit_id":"9d6a0cea79391ee999b71f163eecf00a7984ab85"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"53afb72d7ff930f4be58e6d848f82255c986863a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@removals.remove("},{"line_number":35,"context_line":"    message\u003d\"use get_ipv6_addr_by_EUI64 from oslo_utils.netutils\","},{"line_number":36,"context_line":"    version\u003d\"Newton\","},{"line_number":37,"context_line":"    removal_version\u003d\"Ocata\")"},{"line_number":38,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_abe8d517","line":35,"updated":"2016-07-27 14:14:40.000000000","message":"I wonder whether it would make sense to state that our implementation raises TypeError for ipv6 prefixes and bad prefix or mac formats, while oslo raises ValueError for such cases.","commit_id":"7404aafd7eb1a0e960ba9e48bf41b0054c3af0e5"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"03f937d92d3361cd6b7756aab492464a92390754","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@removals.remove("},{"line_number":35,"context_line":"    message\u003d\"use get_ipv6_addr_by_EUI64 from oslo_utils.netutils\","},{"line_number":36,"context_line":"    version\u003d\"Newton\","},{"line_number":37,"context_line":"    removal_version\u003d\"Ocata\")"},{"line_number":38,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_ae2a987c","line":35,"in_reply_to":"bacf61ea_abe8d517","updated":"2016-08-14 13:03:56.000000000","message":"oslo version of this function has docstring \" :raises ValueError, TypeError: For any invalid input.\". That will help developers","commit_id":"7404aafd7eb1a0e960ba9e48bf41b0054c3af0e5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"53afb72d7ff930f4be58e6d848f82255c986863a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    removal_version\u003d\"Ocata\")"},{"line_number":38,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":39,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":40,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":41,"context_line":"    if isIPv4:"},{"line_number":42,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":43,"context_line":"        raise TypeError(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_ebc92dae","line":40,"updated":"2016-07-27 14:14:40.000000000","message":"Do we want to keep this code or rather just call to oslo library?\n\n return netutils.get_ipv6_addr_by_EUI64(prefix)","commit_id":"7404aafd7eb1a0e960ba9e48bf41b0054c3af0e5"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"03f937d92d3361cd6b7756aab492464a92390754","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    removal_version\u003d\"Ocata\")"},{"line_number":38,"context_line":"def get_ipv6_addr_by_EUI64(prefix, mac):"},{"line_number":39,"context_line":"    # Check if the prefix is IPv4 address"},{"line_number":40,"context_line":"    isIPv4 \u003d netaddr.valid_ipv4(prefix)"},{"line_number":41,"context_line":"    if isIPv4:"},{"line_number":42,"context_line":"        msg \u003d _(\"Unable to generate IP address by EUI64 for IPv4 prefix\")"},{"line_number":43,"context_line":"        raise TypeError(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_0e200c9b","line":40,"in_reply_to":"bacf61ea_ebc92dae","updated":"2016-08-14 13:03:56.000000000","message":"This is deprecation patch, so we\u0027d better don\u0027t change this. Jut remove this function at last.","commit_id":"7404aafd7eb1a0e960ba9e48bf41b0054c3af0e5"}]}
