)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a46f1c0b0ee7ce7f27622be8d2aa0d5cee7b4701","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Those features are available only when allow_sorting and"},{"line_number":10,"context_line":"allow_pagination options are enabled (the current default is False)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"They don\u0027t depend on plugin support, because when plugins don\u0027t"},{"line_number":13,"context_line":"implement them natively, emulated mode is applied by API router itself."},{"line_number":14,"context_line":"So to make it plugin agnostic, we introduce a way to register custom"},{"line_number":15,"context_line":"per-extension checks to override support detection for cases like that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1aa78d24_5ed60628","line":12,"updated":"2016-07-14 17:32:08.000000000","message":"thing is, even if the plugin says it supports both via the __native_sorting_support/__native_pagination_support flags, I still don\u0027t think this work unless the config variable are set. Or am I wrong?\n\nIs there a plan to remove the config variables or not?","commit_id":"86d4914ac3f17dad0cb30edc8ebab4eb42921016"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6c66a4b4c770bc9e2426fa4a344436322055b470","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Those features are available only when allow_sorting and"},{"line_number":10,"context_line":"allow_pagination options are enabled (the current default is False)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"They don\u0027t depend on plugin support, because when plugins don\u0027t"},{"line_number":13,"context_line":"implement them natively, emulated mode is applied by API router itself."},{"line_number":14,"context_line":"So to make it plugin agnostic, we introduce a way to register custom"},{"line_number":15,"context_line":"per-extension checks to override support detection for cases like that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1aa78d24_a96d08ce","line":12,"in_reply_to":"1aa78d24_5ed60628","updated":"2016-07-15 14:11:12.000000000","message":"Yes, see the dependency patches, I propose to deprecate and remove those configuration options. Which will result in the extensions to always be present for new installations.","commit_id":"86d4914ac3f17dad0cb30edc8ebab4eb42921016"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6fdd186e3670d3360ad687263995821879a7b021","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Those features are available only when allow_sorting and"},{"line_number":10,"context_line":"allow_pagination options are enabled (the current default is False)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"They don\u0027t depend on plugin support, because when plugins don\u0027t"},{"line_number":13,"context_line":"implement them natively, emulated mode is applied by API router itself."},{"line_number":14,"context_line":"So to make it plugin agnostic, we introduce a way to register custom"},{"line_number":15,"context_line":"per-extension checks to override support detection for cases like that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1aa78d24_2990f894","line":12,"in_reply_to":"1aa78d24_a96d08ce","updated":"2016-07-15 14:11:55.000000000","message":"https://review.openstack.org/#/c/330482/14","commit_id":"86d4914ac3f17dad0cb30edc8ebab4eb42921016"}],"neutron/api/extensions.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5f7f54c83d05e99e42c37aa1b0d3261c60159f4c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        the resource defined in get_pecan_resources will take precedence."},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        return []"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @property"},{"line_number":197,"context_line":"    def supported(self):"},{"line_number":198,"context_line":"        \u0027\u0027\u0027Allows extensions to implement custom support detection logic.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c151db63","line":195,"updated":"2016-06-14 14:37:32.000000000","message":"perhaps a property like\n\ndef is_api_feature(self):\n      return {True|False}\n\nmight be useful to better distinguish features... err extensions, which are supposed to be plugin agnostic","commit_id":"b093bfc6ce60ad306a9fdd0904bdaa4a5bae8fdb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a599639d8a755faeb23005f6a6ef63c15fe27dd7","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        the resource defined in get_pecan_resources will take precedence."},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        return []"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @property"},{"line_number":197,"context_line":"    def supported(self):"},{"line_number":198,"context_line":"        \u0027\u0027\u0027Allows extensions to implement custom support detection logic.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4494d935","line":195,"in_reply_to":"7aa08908_c151db63","updated":"2016-06-14 14:57:23.000000000","message":"Not sure what makes those features not API features.","commit_id":"b093bfc6ce60ad306a9fdd0904bdaa4a5bae8fdb"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5f7f54c83d05e99e42c37aa1b0d3261c60159f4c","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                                   self)._check_extension(extension)"},{"line_number":606,"context_line":"        if not extension_is_valid:"},{"line_number":607,"context_line":"            return False"},{"line_number":608,"context_line":"        if extension.supported:"},{"line_number":609,"context_line":"            return True"},{"line_number":610,"context_line":"        return (self._plugins_support(extension) and"},{"line_number":611,"context_line":"                self._plugins_implement_interface(extension))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6162a73f","line":608,"updated":"2016-06-14 14:37:32.000000000","message":"if the extension is not supported, do you need to check aliases in plugins? I would imagine not...","commit_id":"b093bfc6ce60ad306a9fdd0904bdaa4a5bae8fdb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a599639d8a755faeb23005f6a6ef63c15fe27dd7","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                                   self)._check_extension(extension)"},{"line_number":606,"context_line":"        if not extension_is_valid:"},{"line_number":607,"context_line":"            return False"},{"line_number":608,"context_line":"        if extension.supported:"},{"line_number":609,"context_line":"            return True"},{"line_number":610,"context_line":"        return (self._plugins_support(extension) and"},{"line_number":611,"context_line":"                self._plugins_implement_interface(extension))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c4ce0959","line":608,"in_reply_to":"7aa08908_6162a73f","updated":"2016-06-14 14:57:23.000000000","message":"Done.","commit_id":"b093bfc6ce60ad306a9fdd0904bdaa4a5bae8fdb"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5f7f54c83d05e99e42c37aa1b0d3261c60159f4c","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        if extension.supported:"},{"line_number":609,"context_line":"            return True"},{"line_number":610,"context_line":"        return (self._plugins_support(extension) and"},{"line_number":611,"context_line":"                self._plugins_implement_interface(extension))"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def _plugins_support(self, extension):"},{"line_number":614,"context_line":"        alias \u003d extension.get_alias()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_61df470d","line":611,"updated":"2016-06-14 14:37:32.000000000","message":"this is quite clever as it allows to not have the plugin to declare whether they support or not the feature.\n\nOn the other hand relatively recent changes enabled mixins to add their own aliases to supported_extension_aliases, so I wonder whether it should actually be the  db base class which adds pagination and sorting aliases there if the corresponding conf variables are true.\n\nPersonally I prefer this approach, and I would promote the concept of plugin agnostic feature you are kind of introducing here.","commit_id":"b093bfc6ce60ad306a9fdd0904bdaa4a5bae8fdb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a599639d8a755faeb23005f6a6ef63c15fe27dd7","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        if extension.supported:"},{"line_number":609,"context_line":"            return True"},{"line_number":610,"context_line":"        return (self._plugins_support(extension) and"},{"line_number":611,"context_line":"                self._plugins_implement_interface(extension))"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def _plugins_support(self, extension):"},{"line_number":614,"context_line":"        alias \u003d extension.get_alias()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7f0a4221","line":611,"in_reply_to":"7aa08908_61df470d","updated":"2016-06-14 14:57:23.000000000","message":"I think it\u0027s not ideal to push that logic into plugins because there is really nothing plugin specific here. It\u0027s all the core API router that implements the feature. It does not matter which plugins you have, they all support those features (or better, neutron does).","commit_id":"b093bfc6ce60ad306a9fdd0904bdaa4a5bae8fdb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6e0cec5a96a5576623c837b504f6f9c34ef86a45","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return []"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @property"},{"line_number":197,"context_line":"    def supported(self):"},{"line_number":198,"context_line":"        \u0027\u0027\u0027Allows extensions to implement custom support detection logic.\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_9f6b9184","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":17},"updated":"2016-06-27 09:24:19.000000000","message":"I am just afraid \u0027supported\u0027 is ambiguous and has wider meaning.\nMost API extensions are loaded through plugins, and this property is intended to use for special purpose.\n\nPerhaps I feel a similar feeling as Salavtore felt.\n\nIn my understanding, an extension used by API framework is the only user of this property. How about \u0027supported_by_api_framework\u0027 or something?\n\nAnother solution is to define a new constant like DEFAULT_LOADED_EXTENSIONS. It is similar to DEFAULT_SERVICE_PLUGINS.","commit_id":"2588b2cbc8d2bc5ee2c64d7e3818404f067bb58a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6c76c7b28cb5138ae244edff4d506b4966e7dad2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        return []"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @property"},{"line_number":197,"context_line":"    def supported(self):"},{"line_number":198,"context_line":"        \u0027\u0027\u0027Allows extensions to implement custom support detection logic.\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_e0b5d1ec","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":17},"in_reply_to":"3aaa91ec_9f6b9184","updated":"2016-06-27 11:14:06.000000000","message":"I simplified it a bit, allowing extensions to register custom checks in a map that is then used by the validation logic.","commit_id":"2588b2cbc8d2bc5ee2c64d7e3818404f067bb58a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6e0cec5a96a5576623c837b504f6f9c34ef86a45","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @property"},{"line_number":197,"context_line":"    def supported(self):"},{"line_number":198,"context_line":"        \u0027\u0027\u0027Allows extensions to implement custom support detection logic.\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class ActionExtensionController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_e4b84cca","line":198,"updated":"2016-06-27 09:24:19.000000000","message":"I think \"\"\" is better than \u0027\u0027\u0027 as we usually use \"\"\".","commit_id":"2588b2cbc8d2bc5ee2c64d7e3818404f067bb58a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6c76c7b28cb5138ae244edff4d506b4966e7dad2","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @property"},{"line_number":197,"context_line":"    def supported(self):"},{"line_number":198,"context_line":"        \u0027\u0027\u0027Allows extensions to implement custom support detection logic.\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class ActionExtensionController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_2a117a52","line":198,"in_reply_to":"3aaa91ec_e4b84cca","updated":"2016-06-27 11:14:06.000000000","message":"Done","commit_id":"2588b2cbc8d2bc5ee2c64d7e3818404f067bb58a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"78fcbd6a5cfa45b65c6e61fca626dfc683278fd9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"_PLUGIN_AGNOSTIC_EXTENSIONS \u003d set()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def register_custom_supported_check(alias, f, plugin_agnostic\u003dFalse):"},{"line_number":46,"context_line":"    EXTENSION_SUPPORTED_CHECK_MAP[alias] \u003d f"},{"line_number":47,"context_line":"    if plugin_agnostic:"},{"line_number":48,"context_line":"        _PLUGIN_AGNOSTIC_EXTENSIONS.add(alias)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_3c226002","line":45,"range":{"start_line":45,"start_character":43,"end_line":45,"end_character":44},"updated":"2016-07-22 11:32:41.000000000","message":"Nit: Maybe a docstring explaining that f is a function that decides whether \u0027alias\u0027 extension is supported would be helpful for developers.","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6492db5ee5fe84009995a821dc0ff4d15ee3b97","unresolved":false,"context_lines":[{"line_number":42,"context_line":"_PLUGIN_AGNOSTIC_EXTENSIONS \u003d set()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def register_custom_supported_check(alias, f, plugin_agnostic\u003dFalse):"},{"line_number":46,"context_line":"    EXTENSION_SUPPORTED_CHECK_MAP[alias] \u003d f"},{"line_number":47,"context_line":"    if plugin_agnostic:"},{"line_number":48,"context_line":"        _PLUGIN_AGNOSTIC_EXTENSIONS.add(alias)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_6c4a0a85","line":45,"range":{"start_line":45,"start_character":43,"end_line":45,"end_character":44},"in_reply_to":"dada55a8_3c226002","updated":"2016-07-25 17:06:36.000000000","message":"Done.","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a4664343266ad8298b497f58a5cd71ce87f61f54","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \u0027\u0027\u0027Register a custom function to determine if extension is supported."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    :param alias: API extension alias name"},{"line_number":49,"context_line":"    :param f: custom check function"},{"line_number":50,"context_line":"    :param plugin_agnostic: if False, don\u0027t require a plugin to claim support"},{"line_number":51,"context_line":"    with supported_extension_aliases. If True, a plugin must claim the"},{"line_number":52,"context_line":"    extension is supported."}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_84158e4a","line":49,"range":{"start_line":49,"start_character":14,"end_line":49,"end_character":35},"updated":"2016-07-25 20:50:07.000000000","message":"It is better to mention this function should return a boolean value.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"90c0350f5408808eaebb7324b9a41913e24c0958","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \u0027\u0027\u0027Register a custom function to determine if extension is supported."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    :param alias: API extension alias name"},{"line_number":49,"context_line":"    :param f: custom check function"},{"line_number":50,"context_line":"    :param plugin_agnostic: if False, don\u0027t require a plugin to claim support"},{"line_number":51,"context_line":"    with supported_extension_aliases. If True, a plugin must claim the"},{"line_number":52,"context_line":"    extension is supported."}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_ca5491ff","line":49,"range":{"start_line":49,"start_character":14,"end_line":49,"end_character":35},"in_reply_to":"dada55a8_84158e4a","updated":"2016-07-26 09:59:03.000000000","message":"Done","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e4a8f58edf355c6ed1c0a01c55e51e5b63e6ffe6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    extension is supported."},{"line_number":53,"context_line":"    \u0027\u0027\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    EXTENSION_SUPPORTED_CHECK_MAP[alias] \u003d f"},{"line_number":56,"context_line":"    if plugin_agnostic:"},{"line_number":57,"context_line":"        _PLUGIN_AGNOSTIC_EXTENSIONS.add(alias)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_755ac62b","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":44},"updated":"2016-07-25 21:09:53.000000000","message":"What if there\u0027s a collision? Shall we just assume consumers use the API properly?","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"90c0350f5408808eaebb7324b9a41913e24c0958","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    extension is supported."},{"line_number":53,"context_line":"    \u0027\u0027\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    EXTENSION_SUPPORTED_CHECK_MAP[alias] \u003d f"},{"line_number":56,"context_line":"    if plugin_agnostic:"},{"line_number":57,"context_line":"        _PLUGIN_AGNOSTIC_EXTENSIONS.add(alias)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_ea94f58b","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":44},"in_reply_to":"dada55a8_755ac62b","updated":"2016-07-26 09:59:03.000000000","message":"I will document that.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a4664343266ad8298b497f58a5cd71ce87f61f54","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        \"\"\"Check if an extension supported by a plugin has been loaded.\"\"\""},{"line_number":691,"context_line":"        plugin_extensions \u003d self.get_supported_extension_aliases()"},{"line_number":692,"context_line":"        missing_aliases \u003d plugin_extensions - set(self.extensions)"},{"line_number":693,"context_line":"        missing_aliases -\u003d set(_PLUGIN_AGNOSTIC_EXTENSIONS)"},{"line_number":694,"context_line":"        if missing_aliases:"},{"line_number":695,"context_line":"            raise exceptions.ExtensionsNotFound("},{"line_number":696,"context_line":"                extensions\u003dlist(missing_aliases))"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_4466f629","line":693,"range":{"start_line":693,"start_character":27,"end_line":693,"end_character":59},"updated":"2016-07-25 20:50:07.000000000","message":"The type of _PLUGIN_AGNOSTIC_EXTENSIONS is \u0027set\u0027, so set() is unnecessary.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1f6386b4fa0eb3dee2dfe5447bc85a4bf1717b86","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        \"\"\"Check if an extension supported by a plugin has been loaded.\"\"\""},{"line_number":693,"context_line":"        plugin_extensions \u003d self.get_supported_extension_aliases()"},{"line_number":694,"context_line":"        missing_aliases \u003d plugin_extensions - set(self.extensions)"},{"line_number":695,"context_line":"        missing_aliases -\u003d set(_PLUGIN_AGNOSTIC_EXTENSIONS)"},{"line_number":696,"context_line":"        if missing_aliases:"},{"line_number":697,"context_line":"            raise exceptions.ExtensionsNotFound("},{"line_number":698,"context_line":"                extensions\u003dlist(missing_aliases))"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_3405cb45","line":695,"range":{"start_line":695,"start_character":27,"end_line":695,"end_character":30},"updated":"2016-07-31 23:28:58.000000000","message":"Redundant.","commit_id":"5eb4c778598d7dfdf8a4d3955b06035c5bb33c7e"}],"neutron/common/config.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a46f1c0b0ee7ce7f27622be8d2aa0d5cee7b4701","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                      \"removed in the Ocata release.\")),"},{"line_number":69,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"},{"line_number":70,"context_line":"                help\u003d_(\"Allow the usage of the bulk API\")),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027allow_pagination\u0027, default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d_(\"Allow the usage of the pagination\")),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027allow_sorting\u0027, default\u003dFalse,"},{"line_number":74,"context_line":"                help\u003d_(\"Allow the usage of the sorting\")),"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_7e5ca2f0","line":71,"updated":"2016-07-14 17:32:08.000000000","message":"can we deprecate these in favor of using the plugin/s  __native_pagination_support and __native_sorting_support? Perhaps you discussed about this but I am too lazy to fish through the history of the patch :)","commit_id":"86d4914ac3f17dad0cb30edc8ebab4eb42921016"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6c66a4b4c770bc9e2426fa4a344436322055b470","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                      \"removed in the Ocata release.\")),"},{"line_number":69,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"},{"line_number":70,"context_line":"                help\u003d_(\"Allow the usage of the bulk API\")),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027allow_pagination\u0027, default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d_(\"Allow the usage of the pagination\")),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027allow_sorting\u0027, default\u003dFalse,"},{"line_number":74,"context_line":"                help\u003d_(\"Allow the usage of the sorting\")),"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_699a00c7","line":71,"in_reply_to":"1aa78d24_7e5ca2f0","updated":"2016-07-15 14:11:12.000000000","message":"Even if there is no native support, API layer \"emulates\" sorting/pagination, so from user perspective, the fact plugin does it natively is irrelevant implementation detail.","commit_id":"86d4914ac3f17dad0cb30edc8ebab4eb42921016"}],"neutron/extensions/pagination.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"78fcbd6a5cfa45b65c6e61fca626dfc683278fd9","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.api import extensions"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_ALIAS \u003d \u0027pagination\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_9c2eeca3","line":18,"updated":"2016-07-22 11:32:41.000000000","message":"Nit: Empty line not needed.","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"78fcbd6a5cfa45b65c6e61fca626dfc683278fd9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Fake extension that indicates that pagination is enabled.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    extensions.register_custom_supported_check("},{"line_number":26,"context_line":"        _ALIAS, lambda: cfg.CONF.allow_pagination, plugin_agnostic\u003dTrue"},{"line_number":27,"context_line":"    )"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_bc3490fb","line":26,"range":{"start_line":26,"start_character":24,"end_line":26,"end_character":49},"updated":"2016-07-22 11:32:41.000000000","message":"Assuming all patches are merged in this patches chain, is the plan to change it to True in Ocata? If so, would it make sense to add TODO comment here? Same applies for sorting.","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"63e8ad642be761bd63450524042199b2fdf9fbf3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Fake extension that indicates that pagination is enabled.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    extensions.register_custom_supported_check("},{"line_number":26,"context_line":"        _ALIAS, lambda: cfg.CONF.allow_pagination, plugin_agnostic\u003dTrue"},{"line_number":27,"context_line":"    )"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_4c9e26b9","line":26,"range":{"start_line":26,"start_character":24,"end_line":26,"end_character":49},"in_reply_to":"dada55a8_bc3490fb","updated":"2016-07-25 16:53:50.000000000","message":"One of the patches mark options as deprecated. That, I think, is enough to track the remaining Ocata work.","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e4a8f58edf355c6ed1c0a01c55e51e5b63e6ffe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"dada55a8_7512c60a","updated":"2016-07-25 21:09:53.000000000","message":"IIUC these are \"dummy\" extensions/plugins; they don\u0027t get registered as entry points + don\u0027t show up with API (e.g. \u0027neutron ext-list\u0027 CLI). With that in mind does it still make sense to keep them in the extensions package or should we make a new subpackage to separate them (e.g. neutron.extensions.internal or whatever)?","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"567d8908963255d4a2fc209b6cdcabcdea136c93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"dada55a8_44dd5113","in_reply_to":"dada55a8_041b591c","updated":"2016-07-25 21:50:59.000000000","message":"You should also set allow_pagination and allow_sorting to True in neutron.conf to see those extensions enabled.\n\nAs for the last sentence, no, they are automatically loaded from the sub-directory.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"60a728560f8b4b870a04b06ccb9c3658696b3a6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"dada55a8_041b591c","in_reply_to":"dada55a8_15770a3b","updated":"2016-07-25 21:45:54.000000000","message":"Perhaps I\u0027m missing something... \n\n\nWhen I run with your patch in devstack, the pagination and sorting extensions don\u0027t show up using \u0027neutron ext-list\u0027.\n\n\nIIRC they would have to be added as entry points and also added to neutron.plugins.common.constants.DEFAULT_SERVICE_PLUGINS to be auto-loaded if that\u0027s the intention.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd4c15d543ccaccfe5482ee4a563e6aa82ecd808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"dada55a8_15770a3b","in_reply_to":"dada55a8_7512c60a","updated":"2016-07-25 21:13:17.000000000","message":"They do show in /extensions. See api tests added.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"}],"neutron/tests/contrib/hooks/pagination":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5f7f54c83d05e99e42c37aa1b0d3261c60159f4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-extra|$TEMPEST_CONFIG]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"validate_pagination \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aa08908_2e052e13","side":"PARENT","line":4,"updated":"2016-06-14 14:37:32.000000000","message":"forgive my ignorance, what does this do?","commit_id":"16a00e2b067af38e22e2cf2204015e1ae9c07cb4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a599639d8a755faeb23005f6a6ef63c15fe27dd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-extra|$TEMPEST_CONFIG]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"validate_pagination \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aa08908_df9896c2","side":"PARENT","line":4,"in_reply_to":"7aa08908_2e052e13","updated":"2016-06-14 14:57:23.000000000","message":"This is a hook that is applied to local.conf for devstack. This section I remove was used to configure tempest to run pagination tests (the option was checked for every pagination-related test).\n\nNow that we detect the feature by inspecting api extensions list configured for tempest, the option becomes unneeded.","commit_id":"16a00e2b067af38e22e2cf2204015e1ae9c07cb4"}],"neutron/tests/unit/api/test_extensions.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1ab4303f7f65a86549de53171529c45cbb0721a5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.map_contents_backup \u003d copy.deepcopy("},{"line_number":61,"context_line":"            extensions.EXTENSION_SUPPORTED_CHECK_MAP"},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        self._plugin_agnostic_extensions_backup \u003d ("},{"line_number":64,"context_line":"            extensions._PLUGIN_AGNOSTIC_EXTENSIONS"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        self.addCleanup(self.restore)"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_ac081029","line":63,"range":{"start_line":63,"start_character":49,"end_line":63,"end_character":50},"updated":"2016-07-21 15:18:35.000000000","message":"Missing \u0027set\u0027 ?","commit_id":"86d4914ac3f17dad0cb30edc8ebab4eb42921016"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf47ba125ea3fc52c9d116d17023a2dc2f4cf24d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.map_contents_backup \u003d copy.deepcopy("},{"line_number":61,"context_line":"            extensions.EXTENSION_SUPPORTED_CHECK_MAP"},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        self._plugin_agnostic_extensions_backup \u003d ("},{"line_number":64,"context_line":"            extensions._PLUGIN_AGNOSTIC_EXTENSIONS"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        self.addCleanup(self.restore)"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_1d81888f","line":63,"range":{"start_line":63,"start_character":49,"end_line":63,"end_character":50},"in_reply_to":"dada55a8_ac081029","updated":"2016-07-21 15:28:57.000000000","message":"Yeap.","commit_id":"86d4914ac3f17dad0cb30edc8ebab4eb42921016"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"78fcbd6a5cfa45b65c6e61fca626dfc683278fd9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"extensions_path \u003d \u0027:\u0027.join(neutron.tests.unit.extensions.__path__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CustomExtensionCheckMapMemento(fixtures.Fixture):"},{"line_number":55,"context_line":"    \"\"\"Create a copy of the custom extension support check map so it can be"},{"line_number":56,"context_line":"    restored during test cleanup."},{"line_number":57,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_dc5ea478","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":36},"updated":"2016-07-22 11:32:41.000000000","message":"Nit: Maybe a Fixture instead of Memento would be more consistent with the rest of fixtures.","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d2806360394c997be6011beaa4b89e3c1fb832eb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"extensions_path \u003d \u0027:\u0027.join(neutron.tests.unit.extensions.__path__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CustomExtensionCheckMapMemento(fixtures.Fixture):"},{"line_number":55,"context_line":"    \"\"\"Create a copy of the custom extension support check map so it can be"},{"line_number":56,"context_line":"    restored during test cleanup."},{"line_number":57,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_eabff1a7","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":36},"in_reply_to":"dada55a8_0cba6e0a","updated":"2016-07-25 20:49:00.000000000","message":"I am okay with either. This class has similar logic to AttributeMapMemento. \"Fixture\" may make sense more to me as it inherits Fixture, but it is another topic.","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"63e8ad642be761bd63450524042199b2fdf9fbf3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"extensions_path \u003d \u0027:\u0027.join(neutron.tests.unit.extensions.__path__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CustomExtensionCheckMapMemento(fixtures.Fixture):"},{"line_number":55,"context_line":"    \"\"\"Create a copy of the custom extension support check map so it can be"},{"line_number":56,"context_line":"    restored during test cleanup."},{"line_number":57,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_0cba6e0a","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":36},"in_reply_to":"dada55a8_dc5ea478","updated":"2016-07-25 16:53:50.000000000","message":"We already have a similar memento, AttributeMapMemento. I based this one on its example. If we think it\u0027s worth a change, I am good, but then we need to rename it there too, right?","commit_id":"14965eaa0aaae3e8e4ee060e109617b2c4645f0f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a4664343266ad8298b497f58a5cd71ce87f61f54","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setUp(self):"},{"line_number":60,"context_line":"        self.map_contents_backup \u003d copy.deepcopy("},{"line_number":61,"context_line":"            extensions.EXTENSION_SUPPORTED_CHECK_MAP"},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        self._plugin_agnostic_extensions_backup \u003d set("}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_af6d0b9b","line":60,"range":{"start_line":60,"start_character":13,"end_line":60,"end_character":32},"updated":"2016-07-25 20:50:07.000000000","message":"A variable at L.63 starts with underscore, but this does not. The consistent usage is better.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"90c0350f5408808eaebb7324b9a41913e24c0958","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setUp(self):"},{"line_number":60,"context_line":"        self.map_contents_backup \u003d copy.deepcopy("},{"line_number":61,"context_line":"            extensions.EXTENSION_SUPPORTED_CHECK_MAP"},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        self._plugin_agnostic_extensions_backup \u003d set("}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_cac77196","line":60,"range":{"start_line":60,"start_character":13,"end_line":60,"end_character":32},"in_reply_to":"dada55a8_af6d0b9b","updated":"2016-07-26 09:59:03.000000000","message":"Done","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a4664343266ad8298b497f58a5cd71ce87f61f54","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        self.addCleanup(self.restore)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def restore(self):"},{"line_number":69,"context_line":"        extensions.EXTENSION_SUPPORTED_CHECK_MAP \u003d self.map_contents_backup"},{"line_number":70,"context_line":"        extensions._PLUGIN_AGNOSTIC_EXTENSIONS \u003d ("},{"line_number":71,"context_line":"            self._plugin_agnostic_extensions_backup"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_cfc4bf93","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":15},"updated":"2016-07-25 20:50:07.000000000","message":"nit: It looks better to make it a private method \u0027_restore\u0027.","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"90c0350f5408808eaebb7324b9a41913e24c0958","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        self.addCleanup(self.restore)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def restore(self):"},{"line_number":69,"context_line":"        extensions.EXTENSION_SUPPORTED_CHECK_MAP \u003d self.map_contents_backup"},{"line_number":70,"context_line":"        extensions._PLUGIN_AGNOSTIC_EXTENSIONS \u003d ("},{"line_number":71,"context_line":"            self._plugin_agnostic_extensions_backup"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_eac23584","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":15},"in_reply_to":"dada55a8_cfc4bf93","updated":"2016-07-26 09:59:03.000000000","message":"Done","commit_id":"439361ddaeacbc5beefc96b40b3b862a7cc64e07"}],"releasenotes/notes/sorting-pagination-extensions-e66e99e2a8f5e563.yaml":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"36713fb5637a908b9d7441177ec0dd94a5063137","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - New API extensions, \u0027sorting\u0027 and \u0027pagination\u0027, are added to allow API"},{"line_number":4,"context_line":"    users to detect if sorting and pagination features are enabled. Those"},{"line_number":5,"context_line":"    features are controlled by allow_sorting and allow_pagination options."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_dbdb0e20","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":73},"updated":"2016-06-16 15:35:42.000000000","message":"Nit: These","commit_id":"557612879725c19cc6a29f0c7befd06ec4b92e24"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"36713fb5637a908b9d7441177ec0dd94a5063137","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - New API extensions, \u0027sorting\u0027 and \u0027pagination\u0027, are added to allow API"},{"line_number":4,"context_line":"    users to detect if sorting and pagination features are enabled. Those"},{"line_number":5,"context_line":"    features are controlled by allow_sorting and allow_pagination options."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_bb7a82ee","line":5,"range":{"start_line":5,"start_character":66,"end_line":5,"end_character":73},"updated":"2016-06-16 15:35:42.000000000","message":"config options\n\n\nYou could also enclose the options in ``double backtics`` for prettier html.","commit_id":"557612879725c19cc6a29f0c7befd06ec4b92e24"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1f6386b4fa0eb3dee2dfe5447bc85a4bf1717b86","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - New API extensions, \u0027sorting\u0027 and \u0027pagination\u0027, are added to allow API"},{"line_number":4,"context_line":"    users to detect if sorting and pagination features are enabled. These"},{"line_number":5,"context_line":"    features are controlled by ``allow_sorting`` and ``allow_pagination``"},{"line_number":6,"context_line":"    configuration options."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bacf61ea_2a88b4c4","line":3,"range":{"start_line":3,"start_character":52,"end_line":3,"end_character":55},"updated":"2016-07-31 23:28:58.000000000","message":"Nit: are -\u003e have been","commit_id":"5eb4c778598d7dfdf8a4d3955b06035c5bb33c7e"}]}
