)]}'
{"neutron/plugins/ml2/driver_context.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d6936942d0b09280b2c62cef6ac8a1950b76564b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # This dict is to pass MD-specific data from precommit"},{"line_number":38,"context_line":"        # to postcommit. This allows the vendor-based mechanism"},{"line_number":39,"context_line":"        # drivers to transfer its internal states along the way."},{"line_number":40,"context_line":"        self.driver_data \u003d {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NetworkContext(MechanismDriverContext, api.NetworkContext):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_643efeb9","line":40,"updated":"2016-06-20 08:04:01.000000000","message":"this should be _driver_data\n\nCan you add a unit test for this?","commit_id":"890d88b5bbf856f747a4e293bb4400e27a8593e2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"c357e617ac4e3ad4049d0d62b3e46378aede1029","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # This dict is to pass MD-specific data from precommit"},{"line_number":38,"context_line":"        # to postcommit. This allows the vendor-based mechanism"},{"line_number":39,"context_line":"        # drivers to transfer its internal states along the way."},{"line_number":40,"context_line":"        self._driver_data \u003d {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NetworkContext(MechanismDriverContext, api.NetworkContext):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ea065d84","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":30},"updated":"2016-06-27 06:22:19.000000000","message":"So, this attribute is expected used by MD. But why use a underscore which means it is a private property? I think it would be better to add a getter function(@property) to this attribute.","commit_id":"a3e3d22af35481da50a9a590b0d534f61d9dcdfa"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"52fe0bde6b2935a6cd47506d386b2c4e5fae7674","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @property"},{"line_number":43,"context_line":"    def driver_data(self):"},{"line_number":44,"context_line":"        return self._driver_data"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NetworkContext(MechanismDriverContext, api.NetworkContext):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_94647a22","line":44,"updated":"2016-06-29 16:51:40.000000000","message":"i think it\u0027s better to have dicts for each MDs and only show the one for the MD.\nor, at least define a rule for key names to avoid conflicts among MDs.\nhow do you think?","commit_id":"1e7ba6c662e401e65b9f9dcdad08c3732fd5ba50"}]}