)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a6662ce1122276859746b6376f6a521a04a2a94b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As discussed in this patch [1] this option didn\u0027t come from any actual"},{"line_number":10,"context_line":"user-encountered problem and is now effectively obsolete for its"},{"line_number":11,"context_line":"original purpose anyway.  In the interest of cleaning up options that"},{"line_number":12,"context_line":"aren\u0027t of any real use, this patch obsoletes this one immediately and"},{"line_number":13,"context_line":"marks it deprecated for removal in Ocata."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_e3e646af","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":26},"updated":"2016-06-15 23:59:47.000000000","message":"extra whitespace","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a91ac97d5688d560f754942b686025bc21c0b6f7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As discussed in this patch [1] this option didn\u0027t come from any actual"},{"line_number":10,"context_line":"user-encountered problem and is now effectively obsolete for its"},{"line_number":11,"context_line":"original purpose anyway.  In the interest of cleaning up options that"},{"line_number":12,"context_line":"aren\u0027t of any real use, this patch obsoletes this one immediately and"},{"line_number":13,"context_line":"marks it deprecated for removal in Ocata."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_a7089129","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":26},"in_reply_to":"7aa08908_e3e646af","updated":"2016-06-16 21:10:53.000000000","message":"I have always put two spaces after a period.  That\u0027s the way I was taught.  Do we have a guideline for commit messages that says its wrong?","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"}],"neutron/common/config.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a6662ce1122276859746b6376f6a521a04a2a94b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.IntOpt(\u0027mac_generation_retries\u0027, default\u003d16,"},{"line_number":66,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":67,"context_line":"               help\u003d_(\"How many times Neutron will retry MAC generation. This \""},{"line_number":68,"context_line":"                      \"option is now obsolete and so is depracated to be \""},{"line_number":69,"context_line":"                      \"removed in the Ocata release.\")),"},{"line_number":70,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"},{"line_number":71,"context_line":"                help\u003d_(\"Allow the usage of the bulk API\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c3d4eabe","line":68,"range":{"start_line":68,"start_character":56,"end_line":68,"end_character":66},"updated":"2016-06-15 23:59:47.000000000","message":"typo: deprecated","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a91ac97d5688d560f754942b686025bc21c0b6f7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.IntOpt(\u0027mac_generation_retries\u0027, default\u003d16,"},{"line_number":66,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":67,"context_line":"               help\u003d_(\"How many times Neutron will retry MAC generation. This \""},{"line_number":68,"context_line":"                      \"option is now obsolete and so is depracated to be \""},{"line_number":69,"context_line":"                      \"removed in the Ocata release.\")),"},{"line_number":70,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"},{"line_number":71,"context_line":"                help\u003d_(\"Allow the usage of the bulk API\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_870bd523","line":68,"range":{"start_line":68,"start_character":56,"end_line":68,"end_character":66},"in_reply_to":"7aa08908_c3d4eabe","updated":"2016-06-16 21:10:53.000000000","message":"Good catch, done.","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"}],"neutron/db/dvr_mac_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4f84ce586eddc7f119c957ce0b9b31e1edfe7703","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.callbacks import registry"},{"line_number":29,"context_line":"from neutron.callbacks import resources"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.db import api"},{"line_number":32,"context_line":"from neutron.db import model_base"},{"line_number":33,"context_line":"from neutron.db import models_v2"},{"line_number":34,"context_line":"from neutron.extensions import dvr as ext_dvr"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8f80434b","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":26},"updated":"2016-06-16 02:36:00.000000000","message":"I think you mean db_api here","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a91ac97d5688d560f754942b686025bc21c0b6f7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.callbacks import registry"},{"line_number":29,"context_line":"from neutron.callbacks import resources"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.db import api"},{"line_number":32,"context_line":"from neutron.db import model_base"},{"line_number":33,"context_line":"from neutron.db import models_v2"},{"line_number":34,"context_line":"from neutron.extensions import dvr as ext_dvr"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e739f9d9","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":26},"in_reply_to":"7aa08908_8f80434b","updated":"2016-06-16 21:10:53.000000000","message":"Yikes!  I thought I changed that.  Good catch","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a6662ce1122276859746b6376f6a521a04a2a94b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            raise ext_dvr.DVRMacAddressNotFound(host\u003dhost)"},{"line_number":114,"context_line":"        return dvrma"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _create_dvr_mac_address(self, context, host):"},{"line_number":117,"context_line":"        \"\"\"Create DVR mac address for a given host.\"\"\""},{"line_number":118,"context_line":"        base_mac \u003d cfg.CONF.dvr_base_mac.split(\u0027:\u0027)"},{"line_number":119,"context_line":"        for attempt in reversed(range(db_api.MAX_RETRIES)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_a361de13","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":53},"updated":"2016-06-15 23:59:47.000000000","message":"Shouldn\u0027t we mark this for removal, with decorator?","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a91ac97d5688d560f754942b686025bc21c0b6f7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            raise ext_dvr.DVRMacAddressNotFound(host\u003dhost)"},{"line_number":114,"context_line":"        return dvrma"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _create_dvr_mac_address(self, context, host):"},{"line_number":117,"context_line":"        \"\"\"Create DVR mac address for a given host.\"\"\""},{"line_number":118,"context_line":"        base_mac \u003d cfg.CONF.dvr_base_mac.split(\u0027:\u0027)"},{"line_number":119,"context_line":"        for attempt in reversed(range(db_api.MAX_RETRIES)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4728cd85","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":53},"in_reply_to":"7aa08908_a361de13","updated":"2016-06-16 21:10:53.000000000","message":"No, we don\u0027t want to remove this.","commit_id":"1bc617c675428b07734bb16f90742e7e0d361672"}],"neutron/tests/unit/db/test_dvr_mac_db.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a6662ce1122276859746b6376f6a521a04a2a94b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                self.ctx, entry[\u0027host\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(expected, entry)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test__create_dvr_mac_address_retries_exceeded_retry_logic(self):"},{"line_number":72,"context_line":"        new_retries \u003d 8"},{"line_number":73,"context_line":"        cfg.CONF.set_override(\u0027mac_generation_retries\u0027, new_retries)"},{"line_number":74,"context_line":"        self._create_dvr_mac_entry(\u0027foo_host_1\u0027, \u0027non_unique_mac\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c3b98a7b","side":"PARENT","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":72},"updated":"2016-06-15 23:59:47.000000000","message":"I think, we should keep this test, until full removal of code, even if it\u0027s obsolete.","commit_id":"db9e4048c4d134629d59f11ff004cbb8513e2b18"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a91ac97d5688d560f754942b686025bc21c0b6f7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                self.ctx, entry[\u0027host\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(expected, entry)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test__create_dvr_mac_address_retries_exceeded_retry_logic(self):"},{"line_number":72,"context_line":"        new_retries \u003d 8"},{"line_number":73,"context_line":"        cfg.CONF.set_override(\u0027mac_generation_retries\u0027, new_retries)"},{"line_number":74,"context_line":"        self._create_dvr_mac_entry(\u0027foo_host_1\u0027, \u0027non_unique_mac\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_87591538","side":"PARENT","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":72},"in_reply_to":"7aa08908_c3b98a7b","updated":"2016-06-16 21:10:53.000000000","message":"We\u0027re not removing the code.  Just the configurability of the code.  This tests the configurability and so it should be nuked.","commit_id":"db9e4048c4d134629d59f11ff004cbb8513e2b18"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"16878dd1cc1e71b6b0662c9649fa313ad0b01ec3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                self.ctx, entry[\u0027host\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(expected, entry)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test__create_dvr_mac_address_retries_exceeded_retry_logic(self):"},{"line_number":72,"context_line":"        new_retries \u003d 8"},{"line_number":73,"context_line":"        cfg.CONF.set_override(\u0027mac_generation_retries\u0027, new_retries)"},{"line_number":74,"context_line":"        self._create_dvr_mac_entry(\u0027foo_host_1\u0027, \u0027non_unique_mac\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_05dd1d70","side":"PARENT","line":71,"updated":"2016-06-16 21:48:00.000000000","message":"I think instead of removing this test you should just change the override of \u0027mac_generation_retries\u0027 to the API retry constant. If we remove this test we will lose coverage for the exceptional case, logging the error and raising the exception.","commit_id":"db9e4048c4d134629d59f11ff004cbb8513e2b18"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"de677da2f61bf71d5bdf58ded1da3309be75a6d9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                self.ctx, entry[\u0027host\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(expected, entry)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test__create_dvr_mac_address_retries_exceeded_retry_logic(self):"},{"line_number":72,"context_line":"        new_retries \u003d 8"},{"line_number":73,"context_line":"        cfg.CONF.set_override(\u0027mac_generation_retries\u0027, new_retries)"},{"line_number":74,"context_line":"        self._create_dvr_mac_entry(\u0027foo_host_1\u0027, \u0027non_unique_mac\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_451a8518","side":"PARENT","line":71,"in_reply_to":"7aa08908_05dd1d70","updated":"2016-06-16 21:51:40.000000000","message":"Another option is to not override the API retries constant and remove the assertion at line 80. That\u0027s also good enough in my book, we\u0027ll still get coverage for the exceptional case which is the main point of this test.","commit_id":"db9e4048c4d134629d59f11ff004cbb8513e2b18"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"59ceffad560e746b634076e413f496c6bcac89ec","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                self.ctx, entry[\u0027host\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(expected, entry)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test__create_dvr_mac_address_retries_exceeded_retry_logic(self):"},{"line_number":72,"context_line":"        new_retries \u003d 8"},{"line_number":73,"context_line":"        cfg.CONF.set_override(\u0027mac_generation_retries\u0027, new_retries)"},{"line_number":74,"context_line":"        self._create_dvr_mac_entry(\u0027foo_host_1\u0027, \u0027non_unique_mac\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_e55acc82","side":"PARENT","line":71,"in_reply_to":"7aa08908_451a8518","updated":"2016-06-20 18:29:25.000000000","message":"That makes sense.  I\u0027ll do it.  :)","commit_id":"db9e4048c4d134629d59f11ff004cbb8513e2b18"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d41b94125c955afc9c76531fe76b8608f86b5529","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.assertEqual(expected, entry)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test__create_dvr_mac_address_retries_exceeded_retry_logic(self):"},{"line_number":72,"context_line":"        new_retries \u003d 8"},{"line_number":73,"context_line":"        self._create_dvr_mac_entry(\u0027foo_host_1\u0027, \u0027non_unique_mac\u0027)"},{"line_number":74,"context_line":"        with mock.patch.object(dvr_mac_db.utils, \u0027get_random_mac\u0027) as f:"},{"line_number":75,"context_line":"            f.return_value \u003d \u0027non_unique_mac\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_6559bc5a","line":72,"updated":"2016-06-20 18:33:20.000000000","message":"This variable is now obsolete.","commit_id":"fb2dd7909d1e90de5155e229a56b982154581ba1"}]}
