)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1c819d45dc25007f75a92fff9b5033183802b8ae","unresolved":false,"context_lines":[{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    def _create_db_port_obj(self, context, port_data):"},{"line_number":1146,"context_line":"        if port_data.get(\u0027mac_address\u0027):"},{"line_number":1147,"context_line":"            mac_address \u003d port_data.pop(\u0027mac_address\u0027)"},{"line_number":1148,"context_line":"            if self._is_mac_in_use(context, port_data[\u0027network_id\u0027],"},{"line_number":1149,"context_line":"                                   mac_address):"},{"line_number":1150,"context_line":"                raise exc.MacAddressInUse(net_id\u003dport_data[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_d202246f","side":"PARENT","line":1147,"range":{"start_line":1147,"start_character":36,"end_line":1147,"end_character":39},"updated":"2016-06-21 16:49:15.000000000","message":"Am I missing something that could cause a KeyError in the call to pop here or something?  It looks to me like the \"if port_data.get(...)\" guards it pretty well.","commit_id":"bd7591fb9a3ae2445ef9f2949fe0fcf7f00ed92e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3a44aa3253e89d7308c6bfb095b9ad7aabc3c89a","unresolved":false,"context_lines":[{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    def _create_db_port_obj(self, context, port_data):"},{"line_number":1146,"context_line":"        if port_data.get(\u0027mac_address\u0027):"},{"line_number":1147,"context_line":"            mac_address \u003d port_data.pop(\u0027mac_address\u0027)"},{"line_number":1148,"context_line":"            if self._is_mac_in_use(context, port_data[\u0027network_id\u0027],"},{"line_number":1149,"context_line":"                                   mac_address):"},{"line_number":1150,"context_line":"                raise exc.MacAddressInUse(net_id\u003dport_data[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9bd43748","side":"PARENT","line":1147,"range":{"start_line":1147,"start_character":36,"end_line":1147,"end_character":39},"in_reply_to":"3aaa91ec_d202246f","updated":"2016-06-21 17:39:15.000000000","message":"the mac_address is introduced by the caller so I don\u0027t think we\u0027ll ever hit the KeyError.","commit_id":"bd7591fb9a3ae2445ef9f2949fe0fcf7f00ed92e"}]}