)]}'
{"neutron/common/cache_utils.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d2a3e73923177f2ece886d579021433fa0c60c7a","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":82,"context_line":"        register_oslo_configs(conf)"},{"line_number":83,"context_line":"        for k, v in {"},{"line_number":84,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":85,"context_line":"            \u0027backend\u0027: \u0027oslo_cache.dict\u0027,"},{"line_number":86,"context_line":"            \u0027expiration_time\u0027: int(parameters.get(\u0027default_ttl\u0027, [0])[0]),"},{"line_number":87,"context_line":"        }.items():"},{"line_number":88,"context_line":"            conf.set_override(k, v, group\u003d\u0027cache\u0027)"},{"line_number":89,"context_line":"        return _get_cache_region(conf)"},{"line_number":90,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_2ab91316","line":87,"range":{"start_line":83,"start_character":0,"end_line":87,"end_character":18},"updated":"2016-06-16 17:27:59.000000000","message":"Just from Readability PoV, could you move this dict outside from loop?","commit_id":"e88589388493cb087b83615f776b19fc6405417b"}],"neutron/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d2caf2387fcb86b1e80e95c61622548c18a30fea","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertEqual(expected, ports)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class _TestMetadataProxyHandlerCacheMixin(object):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_call(self):"},{"line_number":112,"context_line":"        req \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8169ecfa","line":109,"range":{"start_line":109,"start_character":36,"end_line":109,"end_character":41},"updated":"2016-06-17 09:36:37.000000000","message":"scenarios are preferable over mixin.","commit_id":"d034532d376b6ca2309d20f59ccc060a762ff12c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e07ab440e59f1cf5d79fe3cbaa13bb87485c2a5f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertEqual(expected, ports)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class _TestMetadataProxyHandlerCacheMixin(object):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_call(self):"},{"line_number":112,"context_line":"        req \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_84057a11","line":109,"range":{"start_line":109,"start_character":36,"end_line":109,"end_character":41},"in_reply_to":"7aa08908_8169ecfa","updated":"2016-06-17 09:39:41.000000000","message":"The moment I am able to execute just one of scenarios, yeah... But I may try to reimplement it if you like.","commit_id":"d034532d376b6ca2309d20f59ccc060a762ff12c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e442d69faee0a71da055c9de40b79a02be99152e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertEqual(expected, ports)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class _TestMetadataProxyHandlerCacheMixin(object):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_call(self):"},{"line_number":112,"context_line":"        req \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_84a1faf9","line":109,"range":{"start_line":109,"start_character":36,"end_line":109,"end_character":41},"in_reply_to":"7aa08908_84057a11","updated":"2016-06-17 09:42:13.000000000","message":"Yes, it brings advantages that you must run only both scenarios :) I don\u0027t insist as I don\u0027t really know the reasoning, I\u0027m just re-selling what I was taught on reviews","commit_id":"d034532d376b6ca2309d20f59ccc060a762ff12c"}]}
