)]}'
{"neutron/agent/l2/extensions/trunk.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"8eb45999b2944f299133f39182bf8429bd856e7b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            (SUBPORT_DEV +\u0027-trunk\u0027 + port_id)[:constants.DEVICE_NAME_MAX_LEN-1])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def update_trunk_port(self, context, port):"},{"line_number":130,"context_line":"        #TODO(rossella_s) implement"},{"line_number":131,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4dda077a","line":130,"updated":"2016-06-21 22:32:37.000000000","message":"I assume a payload will be pushed to the agent and we\u0027ll operate on the payload without calling back on the server here. Is that a correct interpretation?","commit_id":"ab73150b445a97dab6837f56db32f9ee416f3231"}],"neutron/services/trunk/trunk_plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1cee50f281c7a940b59efd0c0e37cb2e9eacd381","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services import service_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TrunkPlugin(service_base.ServicePluginBase):"},{"line_number":22,"context_line":"    \"\"\"Implementation of the Neutron Trunk Service Plugin.\"\"\""},{"line_number":23,"context_line":"    supported_extension_aliases \u003d [\u0027trunk\u0027]"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ed00af04","line":21,"updated":"2016-06-17 05:06:50.000000000","message":"this seems to overlap with [1]. We should also try to make the plugin code decoupled from the RPC/Agent backend because other solutions willing to implement this extension may be agentless.\n\n[1] https://review.openstack.org/#/c/320092/16/neutron/services/trunk/plugin.py","commit_id":"ab73150b445a97dab6837f56db32f9ee416f3231"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"8eb45999b2944f299133f39182bf8429bd856e7b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services import service_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TrunkPlugin(service_base.ServicePluginBase):"},{"line_number":22,"context_line":"    \"\"\"Implementation of the Neutron Trunk Service Plugin.\"\"\""},{"line_number":23,"context_line":"    supported_extension_aliases \u003d [\u0027trunk\u0027]"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_329f1605","line":21,"in_reply_to":"7aa08908_a1de923b","updated":"2016-06-21 22:32:37.000000000","message":"I was planning on creating a follow-on patch to [1] this week that would invoke the RPC notifications.\n\n[1] https://review.openstack.org/#/c/320092/16/neutron/services/trunk/plugin.py","commit_id":"ab73150b445a97dab6837f56db32f9ee416f3231"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e3a7c8b840ca8003384f279f86bac22021daa728","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services import service_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TrunkPlugin(service_base.ServicePluginBase):"},{"line_number":22,"context_line":"    \"\"\"Implementation of the Neutron Trunk Service Plugin.\"\"\""},{"line_number":23,"context_line":"    supported_extension_aliases \u003d [\u0027trunk\u0027]"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_a1de923b","line":21,"in_reply_to":"7aa08908_ceecc6bd","updated":"2016-06-17 16:07:00.000000000","message":"ack","commit_id":"ab73150b445a97dab6837f56db32f9ee416f3231"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"0b054418af6e780cd267ecd1579c7b35c8f30723","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services import service_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TrunkPlugin(service_base.ServicePluginBase):"},{"line_number":22,"context_line":"    \"\"\"Implementation of the Neutron Trunk Service Plugin.\"\"\""},{"line_number":23,"context_line":"    supported_extension_aliases \u003d [\u0027trunk\u0027]"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ceecc6bd","line":21,"in_reply_to":"7aa08908_ed00af04","updated":"2016-06-17 08:13:40.000000000","message":"it does overlap but I wanted to play with the notification driver without creating a dependent patch. I will rework that. Regarding the decoupling we can adopt the same strategy as qos, having several drivers: I will update that.","commit_id":"ab73150b445a97dab6837f56db32f9ee416f3231"}]}