)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e7d67765e5dc1a72133a5e92a9b4729495a9405a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Treinish \u003cmtreinish@kortar.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-17 16:13:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove useless JSON blob from debug logs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit removes logging the entire json blob of routers on a"},{"line_number":10,"context_line":"success request. This is completely unecessary and when lots of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a9d85d2_5474469b","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":14},"updated":"2016-06-20 13:33:13.000000000","message":"I\u0027d not say it\u0027s useless, it was very helpful many times for me while debugging (especially DVR issues).","commit_id":"7d15b03319277748a110d8d7819a1bb084c1d86c"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"79fc4f8cc12cb5cb114b5ffbda795147e0d2b98f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        LOG.debug(\"Routers returned to l3 agent:\\n %s\","},{"line_number":107,"context_line":"                  utils.DelayedStringRenderer(jsonutils.dumps,"},{"line_number":108,"context_line":"                                              routers, indent\u003d5))"},{"line_number":109,"context_line":"        return routers"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_87c90aaf","side":"PARENT","line":107,"updated":"2016-06-17 03:30:44.000000000","message":"This change makes me wonder if there\u0027s some log level more verbose than debug that should exist, since debug is set for all of devstack, and seems to be held to a higher standard than an actual debug spew.","commit_id":"496f1f75e8b97c486ebdcb1e505d71656398026c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"77689461b33a5d7d931e43b446ad4c84cf44ef62","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if utils.is_extension_supported("},{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        LOG.debug(\"Routers returned to l3 agent\")"},{"line_number":107,"context_line":"        return routers"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _ensure_host_set_on_ports(self, context, host, routers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2c075dca","line":106,"updated":"2016-06-17 02:57:43.000000000","message":"I kind of find the message useful for debugging, but can see how it could generate a lot of noise.  Perhaps just printing \u0027router_ids\u0027 here since that at least lets us see what was returned.","commit_id":"a58c116d477b08a00318e6b910466366d9637274"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"5969f1f291b00ebebf828b13b36f2d99bf453402","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if utils.is_extension_supported("},{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        LOG.debug(\"Routers returned to l3 agent\")"},{"line_number":107,"context_line":"        return routers"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _ensure_host_set_on_ports(self, context, host, routers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2240da5e","line":106,"in_reply_to":"7aa08908_2c075dca","updated":"2016-06-17 19:56:31.000000000","message":"+1\n\nI\u0027ve used this before to see if the information retrieved was complete (Are all of the interfaces populated correctly IPs and proper device_owners). The router_ids would be a minimum and the host_ids hosting these routers.","commit_id":"a58c116d477b08a00318e6b910466366d9637274"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"f356d0e5cc203a5c03f6e57f80f51982f0ecb49f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if utils.is_extension_supported("},{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        LOG.debug(\"Routers returned to l3 agent\")"},{"line_number":107,"context_line":"        return routers"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _ensure_host_set_on_ports(self, context, host, routers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_257f44e0","line":106,"in_reply_to":"7aa08908_2c075dca","updated":"2016-06-17 20:15:30.000000000","message":"Done","commit_id":"a58c116d477b08a00318e6b910466366d9637274"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"91be2f87ce4938f0be4bbab8deadc2dabc90b1bc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if utils.is_extension_supported("},{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        router_ids \u003d [x[\u0027id\u0027] for x in jsonutils.dumps(routers)]"},{"line_number":107,"context_line":"        LOG.debug(\"Routers: %s returned to l3 agent\" % \u0027,\u0027.join(router_ids))"},{"line_number":108,"context_line":"        return routers"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0b6fb9c4","line":106,"updated":"2016-06-17 20:47:12.000000000","message":"Did you mean to toss the part where it doesn\u0027t run this code except when debug is enabled?","commit_id":"7d15b03319277748a110d8d7819a1bb084c1d86c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"163debdd8d9077197ba78575b3ba1157b305f7b5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if utils.is_extension_supported("},{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        router_ids \u003d [x[\u0027id\u0027] for x in jsonutils.dumps(routers)]"},{"line_number":107,"context_line":"        LOG.debug(\"Routers: %s returned to l3 agent\" % \u0027,\u0027.join(router_ids))"},{"line_number":108,"context_line":"        return routers"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_58e7ce11","line":106,"in_reply_to":"7aa08908_0b6fb9c4","updated":"2016-06-18 07:50:37.000000000","message":"Do we need a separate variable for this?","commit_id":"7d15b03319277748a110d8d7819a1bb084c1d86c"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"1f595b00b54b464eb0215fc8d1bab5a14b6ba76b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        router_ids \u003d [x[\u0027id\u0027] for x in jsonutils.dumps(routers)]"},{"line_number":107,"context_line":"        LOG.debug(\"Routers: %s returned to l3 agent\" % \u0027,\u0027.join(router_ids))"},{"line_number":108,"context_line":"        return routers"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _ensure_host_set_on_ports(self, context, host, routers):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_10e23ad5","line":107,"updated":"2016-06-18 14:09:48.000000000","message":"Please add the \u0027host\u0027 variable in to this log, so we know which host requested these routers. We could previously deduce that from the binding:host_id value for the router ports.","commit_id":"7d15b03319277748a110d8d7819a1bb084c1d86c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"dbba0b61d890d5dc5ddf2d2baa0c137617c15f3b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"},{"line_number":105,"context_line":"            self._ensure_host_set_on_ports(context, host, routers)"},{"line_number":106,"context_line":"        router_ids \u003d [x[\u0027id\u0027] for x in jsonutils.dumps(routers)]"},{"line_number":107,"context_line":"        LOG.debug(\"Routers: %s returned to l3 agent\" % \u0027,\u0027.join(router_ids))"},{"line_number":108,"context_line":"        return routers"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _ensure_host_set_on_ports(self, context, host, routers):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_8d6157ab","line":107,"updated":"2016-08-16 09:27:48.000000000","message":"This is actually a huge loss of useful debugging info, it\u0027s basically the API response to the main L3 agent call to the server. Maybe it would be better to move it to the L3 agent so it\u0027s not polluting server-side logs.","commit_id":"7d15b03319277748a110d8d7819a1bb084c1d86c"}]}
