)]}'
{"quantum/agent/linux/iptables_firewall.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8f7d429a5fde0b978017a18a47819d6256977035","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        for ip in addresses:"},{"line_number":187,"context_line":"            table.add_rule(chain_name, \u0027-s %s -j RETURN\u0027 % ip)"},{"line_number":188,"context_line":"        table.add_rule(chain_name, \u0027-j DROP\u0027)"},{"line_number":189,"context_line":"        rules.append(\u0027-j $%s\u0027 % chain_name)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _ip_spoofing_rule(self, port, ipv4_rules, ipv6_rules):"},{"line_number":192,"context_line":"        #Note(nati) allow dhcp or RA packet"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F990%3D","line":189,"updated":"2013-06-17 06:09:08.000000000","message":"Though this works fine, when only one IP address is assigned to the port, we don\u0027t need to create a chain. I am not sure how calling another chain increases overhead.","commit_id":"c016ebcb5a3b6117ebab7a6c963e6846141869a7"},{"author":{"_account_id":7706,"name":"Anton Frolov","email":"frolov.anton@gmail.com","username":"anton"},"change_message_id":"cdb0f83575a2417671ef5d1120c628b5028ceb17","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        for ip in addresses:"},{"line_number":187,"context_line":"            table.add_rule(chain_name, \u0027-s %s -j RETURN\u0027 % ip)"},{"line_number":188,"context_line":"        table.add_rule(chain_name, \u0027-j DROP\u0027)"},{"line_number":189,"context_line":"        rules.append(\u0027-j $%s\u0027 % chain_name)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _ip_spoofing_rule(self, port, ipv4_rules, ipv6_rules):"},{"line_number":192,"context_line":"        #Note(nati) allow dhcp or RA packet"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F97Y%3D","line":189,"in_reply_to":"AAAAPn%2F%2F990%3D","updated":"2013-06-17 06:51:24.000000000","message":"Added fallback to \"! -s $IP -j DROP\" for 1 IP address. Much less changes to tests as a bonus. :)","commit_id":"c016ebcb5a3b6117ebab7a6c963e6846141869a7"}]}